118773 2013-07-16 21:27:21 -0700 [EFL][WK2] EWK2FileChooserRequestTest should be defined by inheriting from EWK2UnitTestBase. 2013-07-17 00:18:01 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 118716 0 donggwan.kim webkit-unassigned cdumez commit-queue gyuyoung.kim rakuco oldest_to_newest 909138 0 donggwan.kim 2013-07-16 21:27:21 -0700 Same approach as https://bugs.webkit.org/show_bug.cgi?id=118717 909139 1 206846 donggwan.kim 2013-07-16 21:29:20 -0700 Created attachment 206846 Patch 909179 2 206846 cdumez 2013-07-16 23:49:55 -0700 Comment on attachment 206846 Patch Ok, r=me. 909212 3 206846 commit-queue 2013-07-17 00:17:59 -0700 Comment on attachment 206846 Patch Clearing flags on attachment: 206846 Committed r152767: <http://trac.webkit.org/changeset/152767> 909213 4 commit-queue 2013-07-17 00:18:01 -0700 All reviewed patches have been landed. Closing bug. 206846 2013-07-16 21:29:20 -0700 2013-07-17 00:17:59 -0700 Patch bug-118773-20130716212924.patch text/plain 4522 donggwan.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjJlZDIxY2E1ODYyNzVm MGJiYTI4Zjg2YjFmN2VmOTY3YmY0MWJiMC4uN2VmNmY2NGQ3NTRkOWMyM2YyZTZmZjc1MmU3OTAz ODZhMzI4ZGNhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA3LTE2ICBEb25n LUd3YW4gS2ltICA8ZG9uZ2d3YW4ua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dL Ml0gRVdLMkZpbGVDaG9vc2VyUmVxdWVzdFRlc3Qgc2hvdWxkIGJlIGRlZmluZWQgYnkgaW5oZXJp dGluZyBmcm9tIEVXSzJVbml0VGVzdEJhc2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg3NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJdCBzaG91bGQgYmUgZGVmaW5lZCBhcyByZWxldmFudCB0ZXN0 IGNsYXNzIHNwZWNpZmljIHRvIGVhY2ggdGVzdCBmaWxlIGZvciBtb3JlIHJlYWRhYmlsaXR5Lgor ICAgICAgICBJdCBjb3VsZCBiZSBoZWxwZnVsIHRvIHJlbW92ZSB1bm5lY2Vzc2FyeSBzdGF0aWMg bWV0aG9kcy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9m aWxlX2Nob29zZXJfcmVxdWVzdC5jcHA6CisgICAgICAgIChFV0syRmlsZUNob29zZXJSZXF1ZXN0 VGVzdDo6b25GaWxlQ2hvb3NlclJlcXVlc3QpOgorICAgICAgICAoRVdLMkZpbGVDaG9vc2VyUmVx dWVzdFRlc3Q6OmNvbXBhcmVTdHJpbmdzKToKKyAgICAgICAgKEVXSzJGaWxlQ2hvb3NlclJlcXVl c3RUZXN0OjpmcmVlU3RyaW5nTGlzdCk6CisgICAgICAgIChURVNUX0YpOgorCiAyMDEzLTA3LTE2 ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJ T04gKHIxNTAyOTEpOiBDaGluZXNlIHByZWRpY3RpdmUgaW5wdXQgcG9wLXVwIGRpc2FwcGVhcnMg b24gdHdpdHRlci5jb20KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL3Rlc3RzL3Rlc3RfZXdrMl9maWxlX2Nob29zZXJfcmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfZmlsZV9jaG9vc2VyX3JlcXVl c3QuY3BwCmluZGV4IGE2NjUyMGJhMzJmNWY4NmNhZWVkZThkODk4MTZjM2JiYzI5ZDk0MTAuLjc3 NGY3ZjA4NzA2MTMxZjIwOGEzZTBmMjg3ZjJmMDRjMTAzYWU2NzggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9maWxlX2Nob29zZXJf cmVxdWVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMv dGVzdF9ld2syX2ZpbGVfY2hvb3Nlcl9yZXF1ZXN0LmNwcApAQCAtMzIsMzQgKzMyLDM4IEBAIHVz aW5nIG5hbWVzcGFjZSBFV0syVW5pdFRlc3Q7CiAKIGV4dGVybiBFV0syVW5pdFRlc3RFbnZpcm9u bWVudCogZW52aXJvbm1lbnQ7CiAKLXN0YXRpYyB2b2lkIG9uRmlsZUNob29zZXJSZXF1ZXN0KHZv aWQqIHVzZXJEYXRhLCBFdmFzX09iamVjdCosIHZvaWQqIGV2ZW50SW5mbykKLXsKLSAgICBFd2tf RmlsZV9DaG9vc2VyX1JlcXVlc3QqKiByZXR1cm5SZXF1ZXN0ID0gc3RhdGljX2Nhc3Q8RXdrX0Zp bGVfQ2hvb3Nlcl9SZXF1ZXN0Kio+KHVzZXJEYXRhKTsKLSAgICBBU1NFUlRfVFJVRShyZXR1cm5S ZXF1ZXN0KTsKLSAgICBFd2tfRmlsZV9DaG9vc2VyX1JlcXVlc3QqIHJlcXVlc3QgPSBzdGF0aWNf Y2FzdDxFd2tfRmlsZV9DaG9vc2VyX1JlcXVlc3QqPihldmVudEluZm8pOwotICAgIEFTU0VSVF9U UlVFKHJlcXVlc3QpOwotCi0gICAgLy8gUmVmIHRoZSByZXF1ZXN0IHRvIHByb2Nlc3MgYXN5bmNo cm9ub3VzbHkuCi0gICAgKnJldHVyblJlcXVlc3QgPSBld2tfb2JqZWN0X3JlZihyZXF1ZXN0KTsK LX0KK2NsYXNzIEVXSzJGaWxlQ2hvb3NlclJlcXVlc3RUZXN0IDogcHVibGljIEVXSzJVbml0VGVz dEJhc2UgeworcHVibGljOgorICAgIHN0YXRpYyB2b2lkIG9uRmlsZUNob29zZXJSZXF1ZXN0KHZv aWQqIHVzZXJEYXRhLCBFdmFzX09iamVjdCosIHZvaWQqIGV2ZW50SW5mbykKKyAgICB7CisgICAg ICAgIEV3a19GaWxlX0Nob29zZXJfUmVxdWVzdCoqIHJldHVyblJlcXVlc3QgPSBzdGF0aWNfY2Fz dDxFd2tfRmlsZV9DaG9vc2VyX1JlcXVlc3QqKj4odXNlckRhdGEpOworICAgICAgICBBU1NFUlRf VFJVRShyZXR1cm5SZXF1ZXN0KTsKKyAgICAgICAgRXdrX0ZpbGVfQ2hvb3Nlcl9SZXF1ZXN0KiBy ZXF1ZXN0ID0gc3RhdGljX2Nhc3Q8RXdrX0ZpbGVfQ2hvb3Nlcl9SZXF1ZXN0Kj4oZXZlbnRJbmZv KTsKKyAgICAgICAgQVNTRVJUX1RSVUUocmVxdWVzdCk7CisKKyAgICAgICAgLy8gUmVmIHRoZSBy ZXF1ZXN0IHRvIHByb2Nlc3MgYXN5bmNocm9ub3VzbHkuCisgICAgICAgICpyZXR1cm5SZXF1ZXN0 ID0gZXdrX29iamVjdF9yZWYocmVxdWVzdCk7CisgICAgfQogCi1zdGF0aWMgaW50IGNvbXBhcmVT dHJpbmdzKGNvbnN0IHZvaWQqIHN0cmluZzEsIGNvbnN0IHZvaWQqIHN0cmluZzIpCi17Ci0gICAg QVNTRVJUKHN0cmluZzEpOwotICAgIEFTU0VSVChzdHJpbmcyKTsKKyAgICBzdGF0aWMgaW50IGNv bXBhcmVTdHJpbmdzKGNvbnN0IHZvaWQqIHN0cmluZzEsIGNvbnN0IHZvaWQqIHN0cmluZzIpCisg ICAgeworICAgICAgICBBU1NFUlQoc3RyaW5nMSk7CisgICAgICAgIEFTU0VSVChzdHJpbmcyKTsK IAotICAgIHJldHVybiBzdHJjbXAoc3RhdGljX2Nhc3Q8Y29uc3QgY2hhcio+KHN0cmluZzEpLCBz dGF0aWNfY2FzdDxjb25zdCBjaGFyKj4oc3RyaW5nMikpOwotfQorICAgICAgICByZXR1cm4gc3Ry Y21wKHN0YXRpY19jYXN0PGNvbnN0IGNoYXIqPihzdHJpbmcxKSwgc3RhdGljX2Nhc3Q8Y29uc3Qg Y2hhcio+KHN0cmluZzIpKTsKKyAgICB9CiAKLXN0YXRpYyB2b2lkIGZyZWVTdHJpbmdMaXN0KEVp bmFfTGlzdCoqIGxpc3QpCi17Ci0gICAgdm9pZCogZGF0YTsKLSAgICBFSU5BX0xJU1RfRlJFRSgq bGlzdCwgZGF0YSkgeworcHJvdGVjdGVkOgorICAgIHZvaWQgZnJlZVN0cmluZ0xpc3QoRWluYV9M aXN0KiogbGlzdCkKKyAgICB7CisgICAgICAgIHZvaWQqIGRhdGE7CisgICAgICAgIEVJTkFfTElT VF9GUkVFKCpsaXN0LCBkYXRhKSB7CiAgICAgICAgIGVpbmFfc3RyaW5nc2hhcmVfZGVsKHN0YXRp Y19jYXN0PGNoYXIqPihkYXRhKSk7CisgICAgICAgIH0KICAgICB9Ci19Cit9OwogCi1URVNUX0Yo RVdLMlVuaXRUZXN0QmFzZSwgZXdrX2ZpbGVfY2hvb3Nlcl9yZXF1ZXN0X2ZpbGVzX2Nob29zZSkK K1RFU1RfRihFV0syRmlsZUNob29zZXJSZXF1ZXN0VGVzdCwgZXdrX2ZpbGVfY2hvb3Nlcl9yZXF1 ZXN0X2ZpbGVzX2Nob29zZSkKIHsKICAgICBFd2tfRmlsZV9DaG9vc2VyX1JlcXVlc3QqIHJlcXVl c3QgPSAwOwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZCh3ZWJWaWV3KCksICJm aWxlLGNob29zZXIscmVxdWVzdCIsIG9uRmlsZUNob29zZXJSZXF1ZXN0LCAmcmVxdWVzdCk7CkBA IC05OCw3ICsxMDIsNyBAQCBURVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgZXdrX2ZpbGVfY2hvb3Nl cl9yZXF1ZXN0X2ZpbGVzX2Nob29zZSkKICAgICBFWFBFQ1RfVFJVRSh3YWl0VW50aWxUaXRsZUNo YW5nZWRUbygiZmlsZTEucG5nfGZpbGUyLnBuZyIpKTsKIH0KIAotVEVTVF9GKEVXSzJVbml0VGVz dEJhc2UsIGV3a19maWxlX2Nob29zZXJfcmVxdWVzdF9maWxlX2Nob29zZSkKK1RFU1RfRihFV0sy RmlsZUNob29zZXJSZXF1ZXN0VGVzdCwgZXdrX2ZpbGVfY2hvb3Nlcl9yZXF1ZXN0X2ZpbGVfY2hv b3NlKQogewogICAgIEV3a19GaWxlX0Nob29zZXJfUmVxdWVzdCogcmVxdWVzdCA9IDA7CiAgICAg ZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKHdlYlZpZXcoKSwgImZpbGUsY2hvb3Nlcixy ZXF1ZXN0Iiwgb25GaWxlQ2hvb3NlclJlcXVlc3QsICZyZXF1ZXN0KTsKQEAgLTEyNCw3ICsxMjgs NyBAQCBURVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgZXdrX2ZpbGVfY2hvb3Nlcl9yZXF1ZXN0X2Zp bGVfY2hvb3NlKQogICAgIEVYUEVDVF9UUlVFKHdhaXRVbnRpbFRpdGxlQ2hhbmdlZFRvKCJmaWxl My5wbmciKSk7CiB9CiAKLVRFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfZmlsZV9jaG9vc2Vy X3JlcXVlc3RfZmlsZV9jYW5jZWwpCitURVNUX0YoRVdLMkZpbGVDaG9vc2VyUmVxdWVzdFRlc3Qs IGV3a19maWxlX2Nob29zZXJfcmVxdWVzdF9maWxlX2NhbmNlbCkKIHsKICAgICBFd2tfRmlsZV9D aG9vc2VyX1JlcXVlc3QqIHJlcXVlc3QgPSAwOwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxi YWNrX2FkZCh3ZWJWaWV3KCksICJmaWxlLGNob29zZXIscmVxdWVzdCIsIG9uRmlsZUNob29zZXJS ZXF1ZXN0LCAmcmVxdWVzdCk7Cg==