118771 2013-07-16 21:09:47 -0700 [EFL][WK2] EWK2EinaSharedStringTest should be defined by inheriting from EWK2UnitTestBase. 2013-07-17 00:15:29 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 118716 0 donggwan.kim webkit-unassigned cdumez commit-queue gyuyoung.kim rakuco oldest_to_newest 909133 0 donggwan.kim 2013-07-16 21:09:47 -0700 Same approach as https://bugs.webkit.org/show_bug.cgi?id=118717 909134 1 206843 donggwan.kim 2013-07-16 21:11:24 -0700 Created attachment 206843 Patch 909177 2 206843 cdumez 2013-07-16 23:47:38 -0700 Comment on attachment 206843 Patch Ok, r=me. 909208 3 206843 commit-queue 2013-07-17 00:15:26 -0700 Comment on attachment 206843 Patch Clearing flags on attachment: 206843 Committed r152765: <http://trac.webkit.org/changeset/152765> 909209 4 commit-queue 2013-07-17 00:15:29 -0700 All reviewed patches have been landed. Closing bug. 206843 2013-07-16 21:11:24 -0700 2013-07-17 00:15:26 -0700 Patch bug-118771-20130716211127.patch text/plain 4760 donggwan.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjJlZDIxY2E1ODYyNzVm MGJiYTI4Zjg2YjFmN2VmOTY3YmY0MWJiMC4uZDhjODc1MGJiN2UzOGFkNTJjMGZiMDliMjY2NWY0 YzFjZTU0NTI5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA3LTE2ICBEb25n LUd3YW4gS2ltICA8ZG9uZ2d3YW4ua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dL Ml0gRVdLMkVpbmFTaGFyZWRTdHJpbmdUZXN0IHNob3VsZCBiZSBkZWZpbmVkIGJ5IGluaGVyaXRp bmcgZnJvbSBFV0syVW5pdFRlc3RCYXNlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NzcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgSXQgc2hvdWxkIGJlIGRlZmluZWQgYXMgcmVsZXZhbnQgdGVzdCBj bGFzcyBzcGVjaWZpYyB0byBlYWNoIHRlc3QgZmlsZSBmb3IgbW9yZSByZWFkYWJpbGl0eS4KKyAg ICAgICAgSXQgY291bGQgYmUgaGVscGZ1bCB0byByZW1vdmUgdW5uZWNlc3Nhcnkgc3RhdGljIG1l dGhvZHMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfZWlu YV9zaGFyZWRfc3RyaW5nLmNwcDoKKyAgICAgICAgKEVXSzJFaW5hU2hhcmVkU3RyaW5nVGVzdDo6 Y2hlY2tTdHJpbmcpOgorICAgICAgICAoVEVTVF9GKToKKwogMjAxMy0wNy0xNiAgQWxleGV5IFBy b3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTUwMjkx KTogQ2hpbmVzZSBwcmVkaWN0aXZlIGlucHV0IHBvcC11cCBkaXNhcHBlYXJzIG9uIHR3aXR0ZXIu Y29tCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90 ZXN0X2V3azJfZWluYV9zaGFyZWRfc3RyaW5nLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9laW5hX3NoYXJlZF9zdHJpbmcuY3BwCmluZGV4IDE1 YTA4NGE1MDJiZmZiMjU1YmViODE5NzI3ZDJjMTkxOWExYmM1Y2UuLmJhYmMwN2U2NzVkNTAwNjc3 OTBhMDZkNTY5YjZjNWFlYThhYzdiZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9laW5hX3NoYXJlZF9zdHJpbmcuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9laW5hX3No YXJlZF9zdHJpbmcuY3BwCkBAIC0zOSwzOSArMzksNDIgQEAgZXh0ZXJuIEVXSzJVbml0VGVzdEVu dmlyb25tZW50KiBlbnZpcm9ubWVudDsKICNkZWZpbmUgYW5vdGhlclRlc3RTdHJpbmcgIkknbSBh bm90aGVyIHRlc3Qgc3RyaW5nISIKICNkZWZpbmUgdGVzdFVybCAiZmlsZTovLy9wYXRoL3NvbWV3 aGVyZSIKIAotc3RhdGljIGlubGluZSB2b2lkIGNoZWNrU3RyaW5nKGNvbnN0IFdLRWluYVNoYXJl ZFN0cmluZyYgc3RyaW5nLCBjb25zdCBjaGFyKiBwYXR0ZXJuKQotewotICAgIEFTU0VSVF9FUShz dHJpbmcuaXNOdWxsKCksIHBhdHRlcm4gPyBmYWxzZSA6IHRydWUpOwotICAgIEFTU0VSVF9FUShz dHJpbmcubGVuZ3RoKCksIHBhdHRlcm4gPyBzdHJsZW4ocGF0dGVybikgOiAwKTsgLy8gQ29tcGFy ZSBsZW5ndGguCi0gICAgQVNTRVJUX0VRKHN0cmluZywgcGF0dGVybik7IC8vIENvbXBhcmUgdmFs dWVzLiBDaGVjayAnPT0nIG9wZXJhdG9yIHdpdGggV0tFaW5hU2hhcmVkU3RyaW5nIGFuZCBwbGFp biBzdHJpbmcuCi0gICAgQVNTRVJUX1NUUkVRKHN0cmluZywgcGF0dGVybik7IC8vIENvbXBhcmUg dmFsdWVzLiBDaGVjayAnY29uc3QgY2hhcionIG9wZXJhdG9yLgotfQotCi1URVNUX0YoRVdLMlVu aXRUZXN0QmFzZSwgY29uc3RydWN0RW1wdHkpCitjbGFzcyBFV0syRWluYVNoYXJlZFN0cmluZ1Rl c3QgOiBwdWJsaWMgRVdLMlVuaXRUZXN0QmFzZSB7Citwcm90ZWN0ZWQ6CisgICAgdm9pZCBjaGVj a1N0cmluZyhjb25zdCBXS0VpbmFTaGFyZWRTdHJpbmcmIHN0cmluZywgY29uc3QgY2hhciogcGF0 dGVybikKKyAgICB7CisgICAgICAgIEFTU0VSVF9FUShzdHJpbmcuaXNOdWxsKCksIHBhdHRlcm4g PyBmYWxzZSA6IHRydWUpOworICAgICAgICBBU1NFUlRfRVEoc3RyaW5nLmxlbmd0aCgpLCBwYXR0 ZXJuID8gc3RybGVuKHBhdHRlcm4pIDogMCk7IC8vIENvbXBhcmUgbGVuZ3RoLgorICAgICAgICBB U1NFUlRfRVEoc3RyaW5nLCBwYXR0ZXJuKTsgLy8gQ29tcGFyZSB2YWx1ZXMuIENoZWNrICc9PScg b3BlcmF0b3Igd2l0aCBXS0VpbmFTaGFyZWRTdHJpbmcgYW5kIHBsYWluIHN0cmluZy4KKyAgICAg ICAgQVNTRVJUX1NUUkVRKHN0cmluZywgcGF0dGVybik7IC8vIENvbXBhcmUgdmFsdWVzLiBDaGVj ayAnY29uc3QgY2hhcionIG9wZXJhdG9yLgorICAgIH0KK307CisKK1RFU1RfRihFV0syRWluYVNo YXJlZFN0cmluZ1Rlc3QsIGNvbnN0cnVjdEVtcHR5KQogewogICAgIFdLRWluYVNoYXJlZFN0cmlu ZyBlbXB0eVN0cmluZzsKICAgICBjaGVja1N0cmluZyhlbXB0eVN0cmluZywgMCk7CiB9CiAKLVRF U1RfRihFV0syVW5pdFRlc3RCYXNlLCBjb25zdHJ1Y3RGcm9tUGxhaW5TdHJpbmcpCitURVNUX0Yo RVdLMkVpbmFTaGFyZWRTdHJpbmdUZXN0LCBjb25zdHJ1Y3RGcm9tUGxhaW5TdHJpbmcpCiB7CiAg ICAgV0tFaW5hU2hhcmVkU3RyaW5nIGVtcHR5U3RyaW5nKHRlc3RTdHJpbmcpOwogICAgIGNoZWNr U3RyaW5nKGVtcHR5U3RyaW5nLCB0ZXN0U3RyaW5nKTsKIH0KIAotVEVTVF9GKEVXSzJVbml0VGVz dEJhc2UsIGNvbnN0cnVjdEZyb21XS1N0cmluZykKK1RFU1RfRihFV0syRWluYVNoYXJlZFN0cmlu Z1Rlc3QsIGNvbnN0cnVjdEZyb21XS1N0cmluZykKIHsKICAgICBXS0VpbmFTaGFyZWRTdHJpbmcg c3RyaW5nKEFkb3B0V0ssIFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKHRlc3RTdHJpbmcp KTsKICAgICBjaGVja1N0cmluZyhzdHJpbmcsIHRlc3RTdHJpbmcpOwogfQogCi1URVNUX0YoRVdL MlVuaXRUZXN0QmFzZSwgY29uc3RydWN0RnJvbVdLVVJMKQorVEVTVF9GKEVXSzJFaW5hU2hhcmVk U3RyaW5nVGVzdCwgY29uc3RydWN0RnJvbVdLVVJMKQogewogICAgIFdLRWluYVNoYXJlZFN0cmlu ZyBzdHJpbmcoQWRvcHRXSywgV0tVUkxDcmVhdGVXaXRoVVRGOENTdHJpbmcodGVzdFVybCkpOwog ICAgIGNoZWNrU3RyaW5nKHN0cmluZywgdGVzdFVybCk7CiB9CiAKLVRFU1RfRihFV0syVW5pdFRl c3RCYXNlLCBjb25zdHJ1Y3RGcm9tRWluYVN0cmluZ1NoYXJlKQorVEVTVF9GKEVXSzJFaW5hU2hh cmVkU3RyaW5nVGVzdCwgY29uc3RydWN0RnJvbUVpbmFTdHJpbmdTaGFyZSkKIHsKICAgICBXS0Vp bmFTaGFyZWRTdHJpbmcgc3RyaW5nKFdLRWluYVNoYXJlZFN0cmluZzo6YWRvcHQoZWluYV9zdHJp bmdzaGFyZV9hZGQodGVzdFN0cmluZykpKTsKICAgICBjaGVja1N0cmluZyhzdHJpbmcsIHRlc3RT dHJpbmcpOwpAQCAtODMsNyArODYsNyBAQCBURVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgY29uc3Ry dWN0RnJvbUVpbmFTdHJpbmdTaGFyZSkKICAgICBjaGVja1N0cmluZyhzdHJpbmcsIGFub3RoZXJU ZXN0U3RyaW5nKTsKIH0KIAotVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIGNvc3RydWN0Q29weSkK K1RFU1RfRihFV0syRWluYVNoYXJlZFN0cmluZ1Rlc3QsIGNvc3RydWN0Q29weSkKIHsKICAgICBX S0VpbmFTaGFyZWRTdHJpbmcgc3RyaW5nKHRlc3RTdHJpbmcpOwogICAgIFdLRWluYVNoYXJlZFN0 cmluZyBjb3B5U3RyaW5nKHN0cmluZyk7CkBAIC05Miw3ICs5NSw3IEBAIFRFU1RfRihFV0syVW5p dFRlc3RCYXNlLCBjb3N0cnVjdENvcHkpCiAgICAgQVNTRVJUX0VRKHN0cmluZywgY29weVN0cmlu Zyk7IC8vIENoZWNrICc9PScgb3BlcmF0b3Igd2l0aCB0d28gaW5zdGFuY2VzIG9mIFdLRWluYVNo YXJlZFN0cmluZy4KIH0KIAotVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIGNvbXBhcmlzb25PcGVy YXRvcnMpCitURVNUX0YoRVdLMkVpbmFTaGFyZWRTdHJpbmdUZXN0LCBjb21wYXJpc29uT3BlcmF0 b3JzKQogewogICAgIFdLRWluYVNoYXJlZFN0cmluZyBzdHJpbmcodGVzdFN0cmluZyk7CiAgICAg V0tFaW5hU2hhcmVkU3RyaW5nIHNhbWVTdHJpbmcodGVzdFN0cmluZyk7CkBAIC0xMDksNyArMTEy LDcgQEAgVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIGNvbXBhcmlzb25PcGVyYXRvcnMpCiAgICAg QVNTRVJUX0VRKHN0cmluZywgc3RyaW5nKTsgLy8gU2VsZi1jb21wYXJpc29uLgogfQogCi1URVNU X0YoRVdLMlVuaXRUZXN0QmFzZSwgYXNzaWdubWVudE9wZXJhdG9ycykKK1RFU1RfRihFV0syRWlu YVNoYXJlZFN0cmluZ1Rlc3QsIGFzc2lnbm1lbnRPcGVyYXRvcnMpCiB7CiAgICAgV0tFaW5hU2hh cmVkU3RyaW5nIHN0cmluZzsKIApAQCAtMTI1LDcgKzEyOCw3IEBAIFRFU1RfRihFV0syVW5pdFRl c3RCYXNlLCBhc3NpZ25tZW50T3BlcmF0b3JzKQogICAgIGNoZWNrU3RyaW5nKHN0cmluZywgYW5v dGhlclRlc3RTdHJpbmcpOwogfQogCi1URVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgbGVha1N0cmlu ZykKK1RFU1RfRihFV0syRWluYVNoYXJlZFN0cmluZ1Rlc3QsIGxlYWtTdHJpbmcpCiB7CiAgICAg V0tFaW5hU2hhcmVkU3RyaW5nIHN0cmluZzsKIAo=