118770 2013-07-16 21:03:49 -0700 setPluginUnavailabilityReason can destroy renderObject before obscurity check 2013-07-16 23:02:50 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac (Intel) OS X 10.8 RESOLVED FIXED P2 Major --- 0 gordon_sheridan webkit-unassigned commit-queue oldest_to_newest 909131 0 gordon_sheridan 2013-07-16 21:03:49 -0700 When creating a replacement object for blocked plugins, setPluginUnavailabilityReason can destroy the renderObject, so we need to call renderObject->isReplacementObscured() beforehand. 909135 1 206844 gordon_sheridan 2013-07-16 21:15:38 -0700 Created attachment 206844 Patch to move the obscurity check for blocked plugin replacements before calling setPluginUnavailabilityReason(). 909162 2 206844 commit-queue 2013-07-16 23:02:48 -0700 Comment on attachment 206844 Patch to move the obscurity check for blocked plugin replacements before calling setPluginUnavailabilityReason(). Clearing flags on attachment: 206844 Committed r152756: <http://trac.webkit.org/changeset/152756> 909163 3 commit-queue 2013-07-16 23:02:50 -0700 All reviewed patches have been landed. Closing bug. 206844 2013-07-16 21:15:38 -0700 2013-07-16 23:02:47 -0700 Patch to move the obscurity check for blocked plugin replacements before calling setPluginUnavailabilityReason(). 0001-setPluginUnavailabilityReason-can-destroy-renderObje.patch text/plain 3114 gordon_sheridan RnJvbSBkOWY1Yjg0NTA5OGVmODVjY2Q0NGI4ZTRjNGM3MWE3NDRlYWRiZTc3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHb3Jkb24gU2hlcmlkYW4gPGdvcmRvbl9zaGVyaWRhbkBhcHBs ZS5jb20+CkRhdGU6IFR1ZSwgMTYgSnVsIDIwMTMgMjA6Mjg6NDEgLTA3MDAKU3ViamVjdDogW1BB VENIXSBzZXRQbHVnaW5VbmF2YWlsYWJpbGl0eVJlYXNvbiBjYW4gZGVzdHJveSByZW5kZXJPYmpl Y3QgYmVmb3JlCiBvYnNjdXJpdHkgY2hlY2sgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExODc3MAogPHJkYXI6Ly9wcm9ibGVtLzE0NDYyMzMxPgoKUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCgoqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKFdlYktp dDo6V2ViUGFnZTo6Y3JlYXRlUGx1Z2luKToKTW92ZWQgb2JzY3VyaXR5IGNoZWNrIHRvIGJlZm9y ZSByZW5kZXJPYmplY3QgaXMgcG90ZW50aWFsbHkgZGVzdHJveWVkLgotLS0KIFNvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICB8IDEyICsrKysrKysrKysrKwogU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIHwgMTAgKysrLS0tLS0t LQogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwppbmRleCBmMmVkMjFjLi45ZTBkNTczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTMtMDctMTYgIEdvcmRvbiBTaGVyaWRhbiAgPGdvcmRvbl9zaGVyaWRhbkBhcHBsZS5jb20+ CisKKyAgICAgICAgc2V0UGx1Z2luVW5hdmFpbGFiaWxpdHlSZWFzb24gY2FuIGRlc3Ryb3kgcmVu ZGVyT2JqZWN0IGJlZm9yZSBvYnNjdXJpdHkgY2hlY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODc3MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MTQ0NjIzMzE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YlBhZ2U6OmNyZWF0ZVBsdWdpbik6CisgICAgICAgIE1vdmVkIG9ic2N1cml0eSBjaGVjayB0byBi ZWZvcmUgcmVuZGVyT2JqZWN0IGlzIHBvdGVudGlhbGx5IGRlc3Ryb3llZC4KKwogMjAxMy0wNy0x NiAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNT SU9OIChyMTUwMjkxKTogQ2hpbmVzZSBwcmVkaWN0aXZlIGlucHV0IHBvcC11cCBkaXNhcHBlYXJz IG9uIHR3aXR0ZXIuY29tCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAKaW5kZXggYWUyZDI1ZC4uOTU0NTZjZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTU1NiwxNyArNTU2LDEzIEBAIFBhc3NS ZWZQdHI8UGx1Z2luPiBXZWJQYWdlOjpjcmVhdGVQbHVnaW4oV2ViRnJhbWUqIGZyYW1lLCBIVE1M UGx1Z0luRWxlbWVudCogcGx1CiAgICAgICAgIGJvb2wgcmVwbGFjZW1lbnRPYnNjdXJlZCA9IGZh bHNlOwogICAgICAgICBpZiAocGx1Z2luRWxlbWVudC0+cmVuZGVyZXIoKS0+aXNFbWJlZGRlZE9i amVjdCgpKSB7CiAgICAgICAgICAgICBSZW5kZXJFbWJlZGRlZE9iamVjdCogcmVuZGVyT2JqZWN0 ID0gdG9SZW5kZXJFbWJlZGRlZE9iamVjdChwbHVnaW5FbGVtZW50LT5yZW5kZXJlcigpKTsKKyAg ICAgICAgICAgIHJlcGxhY2VtZW50T2JzY3VyZWQgPSByZW5kZXJPYmplY3QtPmlzUmVwbGFjZW1l bnRPYnNjdXJlZCgpOworICAgICAgICAgICAgCisgICAgICAgICAgICAvLyBzZXRQbHVnaW5VbmF2 YWlsYWJpbGl0eVJlYXNvbiBjYW4gY2F1c2UgYSByZWF0dGFjaCwgd2hpY2ggbWVhbnMgdGhhdCBv dXIgUmVuZGVyRW1iZWRkZWRPYmplY3QgbWlnaHQgZ2V0IGRlc3Ryb3llZCwgc28gaXQgaXMgaW1w b3J0YW50IHRvIGNoZWNrIG9ic2N1cml0eSBmaXJzdAogICAgICAgICAgICAgcmVuZGVyT2JqZWN0 LT5zZXRQbHVnaW5VbmF2YWlsYWJpbGl0eVJlYXNvbkRlc2NyaXB0aW9uKHVuYXZhaWxhYmlsaXR5 RGVzY3JpcHRpb24pOwogICAgICAgICAgICAgcmVuZGVyT2JqZWN0LT5zZXRQbHVnaW5VbmF2YWls YWJpbGl0eVJlYXNvbihSZW5kZXJFbWJlZGRlZE9iamVjdDo6SW5zZWN1cmVQbHVnaW5WZXJzaW9u KTsKICAgICAgICAgfQogCi0gICAgICAgIC8vIHNldFBsdWdpblVuYXZhaWxhYmlsaXR5UmVhc29u IGNhbiBjYXVzZSBhIHJlYXR0YWNoLCB3aGljaCBtZWFucyB0aGF0IG91ciBSZW5kZXJFbWJlZGRl ZE9iamVjdCBoYXMgYmVlbiBkZXN0cm95ZWQsIHNvIHJlLWFjcXVpcmUgaXQuCi0KLSAgICAgICAg aWYgKHBsdWdpbkVsZW1lbnQtPnJlbmRlcmVyKCkgJiYgcGx1Z2luRWxlbWVudC0+cmVuZGVyZXIo KS0+aXNFbWJlZGRlZE9iamVjdCgpKSB7Ci0gICAgICAgICAgICBSZW5kZXJFbWJlZGRlZE9iamVj dCogcmVuZGVyT2JqZWN0ID0gdG9SZW5kZXJFbWJlZGRlZE9iamVjdChwbHVnaW5FbGVtZW50LT5y ZW5kZXJlcigpKTsKLSAgICAgICAgICAgIHJlcGxhY2VtZW50T2JzY3VyZWQgPSByZW5kZXJPYmpl Y3QtPmlzUmVwbGFjZW1lbnRPYnNjdXJlZCgpOwotICAgICAgICB9Ci0KICAgICAgICAgc2VuZChN ZXNzYWdlczo6V2ViUGFnZVByb3h5OjpEaWRCbG9ja0luc2VjdXJlUGx1Z2luVmVyc2lvbihwYXJh bWV0ZXJzLm1pbWVUeXBlLCBwYXJhbWV0ZXJzLnVybC5zdHJpbmcoKSwgZnJhbWVVUkxTdHJpbmcs IHBhZ2VVUkxTdHJpbmcsIHJlcGxhY2VtZW50T2JzY3VyZWQpKTsKICAgICAgICAgcmV0dXJuIDA7 CiAgICAgfQotLSAKMS44LjMuMSAoQXBwbGUgR2l0LTQ2KQoK