118766 2013-07-16 20:22:44 -0700 [EFL][WK2] EWK2AuthRequestTest should be defined by inheriting from EWK2UnitTestBase. 2013-07-17 00:10:06 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 118716 0 donggwan.kim webkit-unassigned cdumez commit-queue gyuyoung.kim rakuco oldest_to_newest 909120 0 donggwan.kim 2013-07-16 20:22:44 -0700 Same approach as https://bugs.webkit.org/show_bug.cgi?id=118717 909121 1 206839 donggwan.kim 2013-07-16 20:24:35 -0700 Created attachment 206839 Patch 909174 2 206839 cdumez 2013-07-16 23:43:29 -0700 Comment on attachment 206839 Patch Ok, r=me. 909197 3 206839 commit-queue 2013-07-17 00:10:03 -0700 Comment on attachment 206839 Patch Clearing flags on attachment: 206839 Committed r152762: <http://trac.webkit.org/changeset/152762> 909198 4 commit-queue 2013-07-17 00:10:06 -0700 All reviewed patches have been landed. Closing bug. 206839 2013-07-16 20:24:35 -0700 2013-07-17 00:10:03 -0700 Patch bug-118766-20130716202438.patch text/plain 6333 donggwan.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjJlZDIxY2E1ODYyNzVm MGJiYTI4Zjg2YjFmN2VmOTY3YmY0MWJiMC4uMGVjYjQ5ZWRiZTBjNGQ1N2UwOTIzNDI0NzNhZTA2 ZjE3OGQ1YWYxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA3LTE2ICBEb25n LUd3YW4gS2ltICA8ZG9uZ2d3YW4ua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dL Ml0gRVdLMkF1dGhSZXF1ZXN0VGVzdCBzaG91bGQgYmUgZGVmaW5lZCBieSBpbmhlcml0aW5nIGZy b20gRVdLMlVuaXRUZXN0QmFzZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExODc2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEl0IHNob3VsZCBiZSBkZWZpbmVkIGFzIHJlbGV2YW50IHRlc3QgY2xhc3Mg c3BlY2lmaWMgdG8gZWFjaCB0ZXN0IGZpbGUgZm9yIG1vcmUgcmVhZGFiaWxpdHkuCisgICAgICAg IEl0IGNvdWxkIGJlIGhlbHBmdWwgdG8gcmVtb3ZlIHVubmVjZXNzYXJ5IHN0YXRpYyBtZXRob2Rz LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2F1dGhfcmVx dWVzdC5jcHA6CisgICAgICAgIChFV0syQXV0aFJlcXVlc3RUZXN0OjpzZXJ2ZXJDYWxsYmFjayk6 CisgICAgICAgIChFV0syQXV0aFJlcXVlc3RUZXN0OjpvbkF1dGhlbnRpY2F0aW9uUmVxdWVzdCk6 CisgICAgICAgIChFV0syQXV0aFJlcXVlc3RUZXN0OjpvbkxvYWRGaW5pc2hlZCk6CisgICAgICAg IChURVNUX0YpOgorCiAyMDEzLTA3LTE2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUu Y29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxNTAyOTEpOiBDaGluZXNlIHByZWRpY3RpdmUg aW5wdXQgcG9wLXVwIGRpc2FwcGVhcnMgb24gdHdpdHRlci5jb20KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9hdXRoX3JlcXVlc3Qu Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2F1 dGhfcmVxdWVzdC5jcHAKaW5kZXggNjBkYTlkYWZkMzFkMWRjNzQ2NmRmYWU5NDM0MWFiMzZjNGI5 NzhlNC4uMGE3MDMyZDBkYzNiOTEwZTIyZDAxMjU2MDlmMDAwNjQwNmEzNGY3MiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2F1dGhf cmVxdWVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMv dGVzdF9ld2syX2F1dGhfcmVxdWVzdC5jcHAKQEAgLTQyLDQzICs0Miw1NCBAQCBzdGF0aWMgY29u c3QgY2hhciBpbmRleEhUTUxTdHJpbmdbXSA9CiAgICAgIjxoZWFkPjx0aXRsZT5FRkxXZWJLaXQy IEF1dGhlbnRpY2F0aW9uIHRlc3Q8L3RpdGxlPjwvaGVhZD4iCiAgICAgIjxib2R5PjwvYm9keT48 L2h0bWw+IjsKIAotc3RhdGljIHZvaWQgc2VydmVyQ2FsbGJhY2soU291cFNlcnZlciosIFNvdXBN ZXNzYWdlKiBtZXNzYWdlLCBjb25zdCBjaGFyKiBwYXRoLCBHSGFzaFRhYmxlKiwgU291cENsaWVu dENvbnRleHQqLCB2b2lkKikKLXsKLSAgICBpZiAobWVzc2FnZS0+bWV0aG9kICE9IFNPVVBfTUVU SE9EX0dFVCkgewotICAgICAgICBzb3VwX21lc3NhZ2Vfc2V0X3N0YXR1cyhtZXNzYWdlLCBTT1VQ X1NUQVRVU19OT1RfSU1QTEVNRU5URUQpOwotICAgICAgICByZXR1cm47CitjbGFzcyBFV0syQXV0 aFJlcXVlc3RUZXN0IDogcHVibGljIEVXSzJVbml0VGVzdEJhc2UgeworcHVibGljOgorICAgIHN0 YXRpYyB2b2lkIHNlcnZlckNhbGxiYWNrKFNvdXBTZXJ2ZXIqLCBTb3VwTWVzc2FnZSogbWVzc2Fn ZSwgY29uc3QgY2hhciogcGF0aCwgR0hhc2hUYWJsZSosIFNvdXBDbGllbnRDb250ZXh0Kiwgdm9p ZCopCisgICAgeworICAgICAgICBpZiAobWVzc2FnZS0+bWV0aG9kICE9IFNPVVBfTUVUSE9EX0dF VCkgeworICAgICAgICAgICAgc291cF9tZXNzYWdlX3NldF9zdGF0dXMobWVzc2FnZSwgU09VUF9T VEFUVVNfTk9UX0lNUExFTUVOVEVEKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQor CisgICAgICAgIGlmICghc3RyY21wKHBhdGgsICIvaW5kZXguaHRtbCIpKSB7CisgICAgICAgICAg ICBjb25zdCBjaGFyKiBhdXRob3JpemF0aW9uID0gc291cF9tZXNzYWdlX2hlYWRlcnNfZ2V0X29u ZShtZXNzYWdlLT5yZXF1ZXN0X2hlYWRlcnMsICJBdXRob3JpemF0aW9uIik7CisgICAgICAgICAg ICAvLyBSZXF1aXJlIGF1dGhlbnRpY2F0aW9uCisgICAgICAgICAgICBpZiAoYXV0aG9yaXphdGlv biAmJiAhc3RyY21wKGF1dGhvcml6YXRpb24sIGV4cGVjdGVkQXV0aG9yaXphdGlvbikpIHsKKyAg ICAgICAgICAgICAgICAvLyBTdWNjZXNzZnVsIGF1dGhlbnRpY2F0aW9uLgorICAgICAgICAgICAg ICAgIHNvdXBfbWVzc2FnZV9zZXRfc3RhdHVzKG1lc3NhZ2UsIFNPVVBfU1RBVFVTX09LKTsKKyAg ICAgICAgICAgICAgICBzb3VwX21lc3NhZ2VfYm9keV9hcHBlbmQobWVzc2FnZS0+cmVzcG9uc2Vf Ym9keSwgU09VUF9NRU1PUllfQ09QWSwgaW5kZXhIVE1MU3RyaW5nLCBzdHJsZW4oaW5kZXhIVE1M U3RyaW5nKSk7CisgICAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgICAgIC8vIE5vICh2 YWxpZCkgYXV0aG9yaXphdGlvbiBoZWFkZXIgcHJvdmlkZWQgYnkgdGhlIGNsaWVudCwgcmVxdWVz dCBhdXRoZW50aWNhdGlvbi4KKyAgICAgICAgICAgICAgICBzb3VwX21lc3NhZ2Vfc2V0X3N0YXR1 cyhtZXNzYWdlLCBTT1VQX1NUQVRVU19VTkFVVEhPUklaRUQpOworICAgICAgICAgICAgICAgIHNv dXBfbWVzc2FnZV9oZWFkZXJzX2FwcGVuZChtZXNzYWdlLT5yZXNwb25zZV9oZWFkZXJzLCAiV1dX LUF1dGhlbnRpY2F0ZSIsICJCYXNpYyByZWFsbT1cIm15IHJlYWxtXCIiKTsKKyAgICAgICAgICAg IH0KKyAgICAgICAgfSBlbHNlCisgICAgICAgICAgICBzb3VwX21lc3NhZ2Vfc2V0X3N0YXR1cyht ZXNzYWdlLCBTT1VQX1NUQVRVU19OT1RfRk9VTkQpOworCisgICAgICAgIHNvdXBfbWVzc2FnZV9i b2R5X2NvbXBsZXRlKG1lc3NhZ2UtPnJlc3BvbnNlX2JvZHkpOwogICAgIH0KIAotICAgIGlmICgh c3RyY21wKHBhdGgsICIvaW5kZXguaHRtbCIpKSB7Ci0gICAgICAgIGNvbnN0IGNoYXIqIGF1dGhv cml6YXRpb24gPSBzb3VwX21lc3NhZ2VfaGVhZGVyc19nZXRfb25lKG1lc3NhZ2UtPnJlcXVlc3Rf aGVhZGVycywgIkF1dGhvcml6YXRpb24iKTsKLSAgICAgICAgLy8gUmVxdWlyZSBhdXRoZW50aWNh dGlvbgotICAgICAgICBpZiAoYXV0aG9yaXphdGlvbiAmJiAhc3RyY21wKGF1dGhvcml6YXRpb24s IGV4cGVjdGVkQXV0aG9yaXphdGlvbikpIHsKLSAgICAgICAgICAgIC8vIFN1Y2Nlc3NmdWwgYXV0 aGVudGljYXRpb24uCi0gICAgICAgICAgICBzb3VwX21lc3NhZ2Vfc2V0X3N0YXR1cyhtZXNzYWdl LCBTT1VQX1NUQVRVU19PSyk7Ci0gICAgICAgICAgICBzb3VwX21lc3NhZ2VfYm9keV9hcHBlbmQo bWVzc2FnZS0+cmVzcG9uc2VfYm9keSwgU09VUF9NRU1PUllfQ09QWSwgaW5kZXhIVE1MU3RyaW5n LCBzdHJsZW4oaW5kZXhIVE1MU3RyaW5nKSk7Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAg ICAvLyBObyAodmFsaWQpIGF1dGhvcml6YXRpb24gaGVhZGVyIHByb3ZpZGVkIGJ5IHRoZSBjbGll bnQsIHJlcXVlc3QgYXV0aGVudGljYXRpb24uCi0gICAgICAgICAgICBzb3VwX21lc3NhZ2Vfc2V0 X3N0YXR1cyhtZXNzYWdlLCBTT1VQX1NUQVRVU19VTkFVVEhPUklaRUQpOwotICAgICAgICAgICAg c291cF9tZXNzYWdlX2hlYWRlcnNfYXBwZW5kKG1lc3NhZ2UtPnJlc3BvbnNlX2hlYWRlcnMsICJX V1ctQXV0aGVudGljYXRlIiwgIkJhc2ljIHJlYWxtPVwibXkgcmVhbG1cIiIpOwotICAgICAgICB9 Ci0gICAgfSBlbHNlCi0gICAgICAgIHNvdXBfbWVzc2FnZV9zZXRfc3RhdHVzKG1lc3NhZ2UsIFNP VVBfU1RBVFVTX05PVF9GT1VORCk7CisgICAgc3RhdGljIHZvaWQgb25BdXRoZW50aWNhdGlvblJl cXVlc3Qodm9pZCogdXNlckRhdGEsIEV2YXNfT2JqZWN0Kiwgdm9pZCogZXZlbnRJbmZvKQorICAg IHsKKyAgICAgICAgRXdrX0F1dGhfUmVxdWVzdCoqIHJldHVyblJlcXVlc3QgPSBzdGF0aWNfY2Fz dDxFd2tfQXV0aF9SZXF1ZXN0Kio+KHVzZXJEYXRhKTsKKyAgICAgICAgQVNTRVJUX1RSVUUocmV0 dXJuUmVxdWVzdCk7CiAKLSAgICBzb3VwX21lc3NhZ2VfYm9keV9jb21wbGV0ZShtZXNzYWdlLT5y ZXNwb25zZV9ib2R5KTsKLX0KKyAgICAgICAgRXdrX0F1dGhfUmVxdWVzdCogcmVxdWVzdCA9IHN0 YXRpY19jYXN0PEV3a19BdXRoX1JlcXVlc3QqPihldmVudEluZm8pOworICAgICAgICBBU1NFUlRf VFJVRShyZXF1ZXN0KTsKIAotc3RhdGljIHZvaWQgb25BdXRoZW50aWNhdGlvblJlcXVlc3Qodm9p ZCogdXNlckRhdGEsIEV2YXNfT2JqZWN0Kiwgdm9pZCogZXZlbnRJbmZvKQotewotICAgIEV3a19B dXRoX1JlcXVlc3QqKiByZXR1cm5SZXF1ZXN0ID0gc3RhdGljX2Nhc3Q8RXdrX0F1dGhfUmVxdWVz dCoqPih1c2VyRGF0YSk7Ci0gICAgQVNTRVJUX1RSVUUocmV0dXJuUmVxdWVzdCk7CisgICAgICAg ICpyZXR1cm5SZXF1ZXN0ID0gZXdrX29iamVjdF9yZWYocmVxdWVzdCk7CisgICAgfQogCi0gICAg RXdrX0F1dGhfUmVxdWVzdCogcmVxdWVzdCA9IHN0YXRpY19jYXN0PEV3a19BdXRoX1JlcXVlc3Qq PihldmVudEluZm8pOwotICAgIEFTU0VSVF9UUlVFKHJlcXVlc3QpOworICAgIHN0YXRpYyB2b2lk IG9uTG9hZEZpbmlzaGVkKHZvaWQqIHVzZXJEYXRhLCBFdmFzX09iamVjdCosIHZvaWQqKQorICAg IHsKKyAgICAgICAgYm9vbCogaXNGaW5pc2hlZCA9IHN0YXRpY19jYXN0PGJvb2wqPih1c2VyRGF0 YSk7CisgICAgICAgIEFTU0VSVF9UUlVFKGlzRmluaXNoZWQpOwogCi0gICAgKnJldHVyblJlcXVl c3QgPSBld2tfb2JqZWN0X3JlZihyZXF1ZXN0KTsKLX0KKyAgICAgICAgKmlzRmluaXNoZWQgPSB0 cnVlOworICAgIH0KK307CiAKLVRFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfYXV0aF9yZXF1 ZXN0X3N1Y2Nlc3MpCitURVNUX0YoRVdLMkF1dGhSZXF1ZXN0VGVzdCwgZXdrX2F1dGhfcmVxdWVz dF9zdWNjZXNzKQogewogICAgIE93blB0cjxFV0syVW5pdFRlc3RTZXJ2ZXI+IGh0dHBTZXJ2ZXIg PSBhZG9wdFB0cihuZXcgRVdLMlVuaXRUZXN0U2VydmVyKTsKICAgICBodHRwU2VydmVyLT5ydW4o c2VydmVyQ2FsbGJhY2spOwpAQCAtMTA1LDcgKzExNiw3IEBAIFRFU1RfRihFV0syVW5pdFRlc3RC YXNlLCBld2tfYXV0aF9yZXF1ZXN0X3N1Y2Nlc3MpCiAgICAgQVNTRVJUX1RSVUUod2FpdFVudGls VGl0bGVDaGFuZ2VkVG8oZXhwZWN0ZWRTdWNjZXNzVGl0bGUpKTsKIH0KIAotVEVTVF9GKEVXSzJV bml0VGVzdEJhc2UsIGV3a19hdXRoX3JlcXVlc3RfZmFpbHVyZV90aGVuX3N1Y2Nlc3MpCitURVNU X0YoRVdLMkF1dGhSZXF1ZXN0VGVzdCwgZXdrX2F1dGhfcmVxdWVzdF9mYWlsdXJlX3RoZW5fc3Vj Y2VzcykKIHsKICAgICBPd25QdHI8RVdLMlVuaXRUZXN0U2VydmVyPiBodHRwU2VydmVyID0gYWRv cHRQdHIobmV3IEVXSzJVbml0VGVzdFNlcnZlcik7CiAgICAgaHR0cFNlcnZlci0+cnVuKHNlcnZl ckNhbGxiYWNrKTsKQEAgLTE0NiwxNSArMTU3LDcgQEAgVEVTVF9GKEVXSzJVbml0VGVzdEJhc2Us IGV3a19hdXRoX3JlcXVlc3RfZmFpbHVyZV90aGVuX3N1Y2Nlc3MpCiAgICAgQVNTRVJUX1RSVUUo d2FpdFVudGlsVGl0bGVDaGFuZ2VkVG8oZXhwZWN0ZWRTdWNjZXNzVGl0bGUpKTsKIH0KIAotc3Rh dGljIHZvaWQgb25Mb2FkRmluaXNoZWQodm9pZCogdXNlckRhdGEsIEV2YXNfT2JqZWN0Kiwgdm9p ZCopCi17Ci0gICAgYm9vbCogaXNGaW5pc2hlZCA9IHN0YXRpY19jYXN0PGJvb2wqPih1c2VyRGF0 YSk7Ci0gICAgQVNTRVJUX1RSVUUoaXNGaW5pc2hlZCk7Ci0KLSAgICAqaXNGaW5pc2hlZCA9IHRy dWU7Ci19Ci0KLVRFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfYXV0aF9yZXF1ZXN0X2NhbmNl bCkKK1RFU1RfRihFV0syQXV0aFJlcXVlc3RUZXN0LCBld2tfYXV0aF9yZXF1ZXN0X2NhbmNlbCkK IHsKICAgICBPd25QdHI8RVdLMlVuaXRUZXN0U2VydmVyPiBodHRwU2VydmVyID0gYWRvcHRQdHIo bmV3IEVXSzJVbml0VGVzdFNlcnZlcik7CiAgICAgaHR0cFNlcnZlci0+cnVuKHNlcnZlckNhbGxi YWNrKTsK