118760 2013-07-16 18:56:20 -0700 Many crashes loading Java applets after r152701 2013-07-16 19:04:01 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca commit-queue esprehn+autocc graouts japhet oldest_to_newest 909106 0 thorton 2013-07-16 18:56:20 -0700 Missed some places where we have to reacquire the renderer (or it can be null) upon reattach. <rdar://problem/14462836> 909108 1 206835 thorton 2013-07-16 18:58:52 -0700 Created attachment 206835 patch 909109 2 thorton 2013-07-16 19:04:01 -0700 http://trac.webkit.org/changeset/152754 206835 2013-07-16 18:58:52 -0700 2013-07-16 18:59:53 -0700 patch crashes.diff text/plain 2763 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZTQxODY4Li43NzI4MTFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMg QEAKIDIwMTMtMDctMTYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK KyAgICAgICAgTWFueSBjcmFzaGVzIGxvYWRpbmcgSmF2YSBhcHBsZXRzIGFmdGVyIHIxNTI3MDEK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODc2MAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTQ0NjI4MzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL0hUTUxBcHBsZXRFbGVtZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkhUTUxBcHBsZXRFbGVtZW50Ojp1cGRhdGVXaWRnZXQpOgorICAg ICAgICBSZS1hY3F1aXJlIHRoZSByZW5kZXJlciBhZnRlciBjYWxsaW5nIGNyZWF0ZUphdmFBcHBs ZXRXaWRnZXQsCisgICAgICAgIGJlY2F1c2UgaXQgY2FuIGNhdXNlIHJlYXR0YWNoLCBsZWF2aW5n IG91ciByZW5kZXJlciBwb2ludGVyIHN0YWxlLgorCisgICAgICAgICogbG9hZGVyL1N1YmZyYW1l TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN1YmZyYW1lTG9hZGVyOjpjcmVhdGVKYXZh QXBwbGV0V2lkZ2V0KToKKyAgICAgICAgTnVsbC1jaGVjayByZW5kZXJlciwgYXMgZWxlbWVudC0+ cmVuZGVyRW1iZWRkZWRPYmplY3QoKSBjYW4gdmVyeSBjbGVhcmx5CisgICAgICAgIHJldHVybiBu dWxsIGluIHNvbWUgY2FzZXMuCisKKzIwMTMtMDctMTYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hv cnRvbkBhcHBsZS5jb20+CisKICAgICAgICAgVXNlIHRoZSBjb3JyZWN0IGN1cnNvciB2YWx1ZSBm b3IgdGhlIHVuYXZhaWxhYmxlIHBsdWdpbiBpbmRpY2F0b3IKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODc0NwogICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMTQ0NTY0OTg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxBcHBsZXRF bGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEFwcGxldEVsZW1lbnQuY3BwCmlu ZGV4IDUwODkzYzYuLjg5NTI4MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TEFwcGxldEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEFwcGxldEVs ZW1lbnQuY3BwCkBAIC0xNTMsNyArMTUzLDEzIEBAIHZvaWQgSFRNTEFwcGxldEVsZW1lbnQ6OnVw ZGF0ZVdpZGdldChQbHVnaW5DcmVhdGlvbk9wdGlvbikKICAgICBGcmFtZSogZnJhbWUgPSBkb2N1 bWVudCgpLT5mcmFtZSgpOwogICAgIEFTU0VSVChmcmFtZSk7CiAKLSAgICByZW5kZXJlci0+c2V0 V2lkZ2V0KGZyYW1lLT5sb2FkZXIoKS0+c3ViZnJhbWVMb2FkZXIoKS0+Y3JlYXRlSmF2YUFwcGxl dFdpZGdldChyb3VuZGVkSW50U2l6ZShMYXlvdXRTaXplKGNvbnRlbnRXaWR0aCwgY29udGVudEhl aWdodCkpLCB0aGlzLCBwYXJhbU5hbWVzLCBwYXJhbVZhbHVlcykpOworICAgIFJlZlB0cjxXaWRn ZXQ+IHdpZGdldCA9IGZyYW1lLT5sb2FkZXIoKS0+c3ViZnJhbWVMb2FkZXIoKS0+Y3JlYXRlSmF2 YUFwcGxldFdpZGdldChyb3VuZGVkSW50U2l6ZShMYXlvdXRTaXplKGNvbnRlbnRXaWR0aCwgY29u dGVudEhlaWdodCkpLCB0aGlzLCBwYXJhbU5hbWVzLCBwYXJhbVZhbHVlcyk7CisKKyAgICAvLyBj cmVhdGVKYXZhQXBwbGV0V2lkZ2V0IGNhbiBjYWxsIHNldFBsdWdpblVuYXZhaWxhYmlsaXR5UmVh c29uLCB3aGljaCBjYW4gY2F1c2UgcmVhdHRhY2ggYW5kIGRlc3Ryb3kgb3VyIHJlbmRlcmVyLgor CisgICAgcmVuZGVyZXIgPSByZW5kZXJFbWJlZGRlZE9iamVjdCgpOworICAgIGlmIChyZW5kZXJl cikKKyAgICAgICAgcmVuZGVyZXItPnNldFdpZGdldCh3aWRnZXQucmVsZWFzZSgpKTsKIH0KIAog Ym9vbCBIVE1MQXBwbGV0RWxlbWVudDo6Y2FuRW1iZWRKYXZhKCkgY29uc3QKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJmcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvU3ViZnJhbWVMb2FkZXIuY3BwCmluZGV4IDI0MjBkZTYuLmFhMmJjMGYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJmcmFtZUxvYWRlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL1N1YmZyYW1lTG9hZGVyLmNwcApAQCAtMzI0LDcgKzMyNCw3IEBA IFBhc3NSZWZQdHI8V2lkZ2V0PiBTdWJmcmFtZUxvYWRlcjo6Y3JlYXRlSmF2YUFwcGxldFdpZGdl dChjb25zdCBJbnRTaXplJiBzaXplLCBICiAgICAgaWYgKCF3aWRnZXQpIHsKICAgICAgICAgUmVu ZGVyRW1iZWRkZWRPYmplY3QqIHJlbmRlcmVyID0gZWxlbWVudC0+cmVuZGVyRW1iZWRkZWRPYmpl Y3QoKTsKIAotICAgICAgICBpZiAoIXJlbmRlcmVyLT5zaG93c1VuYXZhaWxhYmxlUGx1Z2luSW5k aWNhdG9yKCkpCisgICAgICAgIGlmIChyZW5kZXJlciAmJiAhcmVuZGVyZXItPnNob3dzVW5hdmFp bGFibGVQbHVnaW5JbmRpY2F0b3IoKSkKICAgICAgICAgICAgIHJlbmRlcmVyLT5zZXRQbHVnaW5V bmF2YWlsYWJpbGl0eVJlYXNvbihSZW5kZXJFbWJlZGRlZE9iamVjdDo6UGx1Z2luTWlzc2luZyk7 CiAgICAgICAgIHJldHVybiAwOwogICAgIH0K