118756 2013-07-16 16:48:58 -0700 Naming convention on createInvalidParamError is incorrect. 2013-07-17 09:25:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Minor --- 1 chris_curtis chris_curtis commit-queue oldest_to_newest 909071 0 chris_curtis 2013-07-16 16:48:58 -0700 Naming convention on createInvalidParamError is incorrect. 909074 1 206828 chris_curtis 2013-07-16 16:53:36 -0700 Created attachment 206828 Naming convention fix. 909342 2 206828 ggaren 2013-07-17 09:02:45 -0700 Comment on attachment 206828 Naming convention fix. r=me 909345 3 206828 commit-queue 2013-07-17 09:25:36 -0700 Comment on attachment 206828 Naming convention fix. Clearing flags on attachment: 206828 Committed r152784: <http://trac.webkit.org/changeset/152784> 909346 4 commit-queue 2013-07-17 09:25:38 -0700 All reviewed patches have been landed. Closing bug. 206828 2013-07-16 16:53:36 -0700 2013-07-17 09:25:36 -0700 Naming convention fix. ro.diff text/plain 6409 chris_curtis SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUyNzQ3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDEzLTA3LTE2ICBDaHJpcyBDdXJ0aXMgIDxjaHJpc19jdXJ0aXNAYXBwbGUuY29tPgorCisg ICAgICAgIE5hbWluZyBjb252ZW50aW9uIG9uIGNyZWF0ZUludmFsaWRQYXJhbUVycm9yIGlzIGlu Y29ycmVjdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExODc1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAK KyAgICAgICAgQ2hhbmdlZCB0aGUgbmFtaW5nIG9mIGNyZWF0ZUludmFsaWRQYXJhbUVycm9yIHRv IGNyZWF0ZUludmFsaWRQYXJhbWV0ZXJFcnJvci4KKyAgICAgICAgVGhpcyBjb3JyZWN0cyB0aGUg bmFtaW5nIGNvbnZlbnRpb24gZm9yIHRoZSBmdW5jdGlvbiBsaXN0ZWQgaW4gdGhlIFdlYktpdCBj b2RlIHN0eWxpbmcuCisKKyAgICAgICAgKiBpbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHA6Cisg ICAgICAgIChKU0M6OmxvYWRWYXJhcmdzKToKKyAgICAgICAgKiBqaXQvSklUU3R1YnMuY3BwOgor ICAgICAgICAoSlNDOjpERUZJTkVfU1RVQl9GVU5DVElPTik6CisgICAgICAgICogbGxpbnQvTExJ bnRTbG93UGF0aHMuY3BwOgorICAgICAgICAoSlNDOjpMTEludDo6TExJTlRfU0xPV19QQVRIX0RF Q0wpOgorICAgICAgICAqIHJ1bnRpbWUvQ29tbW9uU2xvd1BhdGhzLmg6CisgICAgICAgIChKU0M6 OkNvbW1vblNsb3dQYXRoczo6b3BJbik6CisgICAgICAgICogcnVudGltZS9FeGNlcHRpb25IZWxw ZXJzLmNwcDoKKyAgICAgICAgKEpTQzo6Y3JlYXRlSW52YWxpZFBhcmFtZXRlckVycm9yKToKKyAg ICAgICAgKiBydW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuaDoKKyAgICAgICAgKiBydW50aW1lL0pT T2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6SlNPYmplY3Q6Omhhc0luc3RhbmNlKToKKwogMjAx My0wNy0xNiAgRGF2aWQgRmFybGVyICA8ZGZhcmxlckBhcHBsZS5jb20+CiAKICAgICAgICAgVHlw byBpbiBERkdJbnNlcnRpb25TZXQuaCBoZWFkZXIgZ3VhcmQ6ICJERkdJbnNlY3Rpb25TZXRfaCIg LT4gIkRGR0luc2VydGlvblNldF9oIgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVy cHJldGVyL0ludGVycHJldGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCShyZXZpc2lvbiAxNTI2MzEpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xODksNyArMTg5LDcgQEAgQ2FsbEZyYW1lKiBsb2FkVmFyYXJncyhDYWxsRnJhbWUq IGNhbGxGcgogICAgIH0KIAogICAgIGlmICghYXJndW1lbnRzLmlzT2JqZWN0KCkpIHsKLSAgICAg ICAgY2FsbEZyYW1lLT52bSgpLmV4Y2VwdGlvbiA9IGNyZWF0ZUludmFsaWRQYXJhbUVycm9yKGNh bGxGcmFtZSwgIkZ1bmN0aW9uLnByb3RvdHlwZS5hcHBseSIsIGFyZ3VtZW50cyk7CisgICAgICAg IGNhbGxGcmFtZS0+dm0oKS5leGNlcHRpb24gPSBjcmVhdGVJbnZhbGlkUGFyYW1ldGVyRXJyb3Io Y2FsbEZyYW1lLCAiRnVuY3Rpb24ucHJvdG90eXBlLmFwcGx5IiwgYXJndW1lbnRzKTsKICAgICAg ICAgcmV0dXJuIDA7CiAgICAgfQogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJ VFN0dWJzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0 dWJzLmNwcAkocmV2aXNpb24gMTUyNjMxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9K SVRTdHVicy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4ODksNyArMTg4OSw3IEBAIERFRklORV9T VFVCX0ZVTkNUSU9OKEVuY29kZWRKU1ZhbHVlLCBvcF8KICAgICAgICAgfQogICAgIH0KIAotICAg IHN0YWNrRnJhbWUudm0tPmV4Y2VwdGlvbiA9IGNyZWF0ZUludmFsaWRQYXJhbUVycm9yKGNhbGxG cmFtZSwgImluc3RhbmNlb2YiLCBiYXNlVmFsKTsKKyAgICBzdGFja0ZyYW1lLnZtLT5leGNlcHRp b24gPSBjcmVhdGVJbnZhbGlkUGFyYW1ldGVyRXJyb3IoY2FsbEZyYW1lLCAiaW5zdGFuY2VvZiIs IGJhc2VWYWwpOwogICAgIFZNX1RIUk9XX0VYQ0VQVElPTl9BVF9FTkQoKTsKICAgICByZXR1cm4g SlNWYWx1ZTo6ZW5jb2RlKEpTVmFsdWUoKSk7CiB9CkBAIC0zMzAxLDcgKzMzMDEsNyBAQCBERUZJ TkVfU1RVQl9GVU5DVElPTihFbmNvZGVkSlNWYWx1ZSwgb3BfCiAgICAgSlNWYWx1ZSBiYXNlVmFs ID0gc3RhY2tGcmFtZS5hcmdzWzFdLmpzVmFsdWUoKTsKIAogICAgIGlmICghYmFzZVZhbC5pc09i amVjdCgpKSB7Ci0gICAgICAgIHN0YWNrRnJhbWUudm0tPmV4Y2VwdGlvbiA9IGNyZWF0ZUludmFs aWRQYXJhbUVycm9yKHN0YWNrRnJhbWUuY2FsbEZyYW1lLCAiaW4iLCBiYXNlVmFsKTsKKyAgICAg ICAgc3RhY2tGcmFtZS52bS0+ZXhjZXB0aW9uID0gY3JlYXRlSW52YWxpZFBhcmFtZXRlckVycm9y KHN0YWNrRnJhbWUuY2FsbEZyYW1lLCAiaW4iLCBiYXNlVmFsKTsKICAgICAgICAgVk1fVEhST1df RVhDRVBUSU9OKCk7CiAgICAgfQogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQv TExJbnRTbG93UGF0aHMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9s bGludC9MTEludFNsb3dQYXRocy5jcHAJKHJldmlzaW9uIDE1MjYzMSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9sbGludC9MTEludFNsb3dQYXRocy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcz MSw3ICs3MzEsNyBAQCBMTElOVF9TTE9XX1BBVEhfREVDTChzbG93X3BhdGhfY2hlY2tfaGFzCiAg ICAgICAgICAgICBMTElOVF9SRVRVUk4oanNCb29sZWFuKGJhc2VPYmplY3QtPm1ldGhvZFRhYmxl KCktPmN1c3RvbUhhc0luc3RhbmNlKGJhc2VPYmplY3QsIGV4ZWMsIHZhbHVlKSkpOwogICAgICAg ICB9CiAgICAgfQotICAgIExMSU5UX1RIUk9XKGNyZWF0ZUludmFsaWRQYXJhbUVycm9yKGV4ZWMs ICJpbnN0YW5jZW9mIiwgYmFzZVZhbCkpOworICAgIExMSU5UX1RIUk9XKGNyZWF0ZUludmFsaWRQ YXJhbWV0ZXJFcnJvcihleGVjLCAiaW5zdGFuY2VvZiIsIGJhc2VWYWwpKTsKIH0KIAogTExJTlRf U0xPV19QQVRIX0RFQ0woc2xvd19wYXRoX2luc3RhbmNlb2YpCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9Db21tb25TbG93UGF0aHMuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9Db21tb25TbG93UGF0aHMuaAkocmV2aXNpb24gMTUyNjMx KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29tbW9uU2xvd1BhdGhzLmgJKHdv cmtpbmcgY29weSkKQEAgLTc4LDcgKzc4LDcgQEAgQUxXQVlTX0lOTElORSBFeGVjU3RhdGUqIGFy aXR5Q2hlY2tGb3IoRQogaW5saW5lIGJvb2wgb3BJbihFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUg cHJvcE5hbWUsIEpTVmFsdWUgYmFzZVZhbCkKIHsKICAgICBpZiAoIWJhc2VWYWwuaXNPYmplY3Qo KSkgewotICAgICAgICBleGVjLT52bSgpLmV4Y2VwdGlvbiA9IGNyZWF0ZUludmFsaWRQYXJhbUVy cm9yKGV4ZWMsICJpbiIsIGJhc2VWYWwpOworICAgICAgICBleGVjLT52bSgpLmV4Y2VwdGlvbiA9 IGNyZWF0ZUludmFsaWRQYXJhbWV0ZXJFcnJvcihleGVjLCAiaW4iLCBiYXNlVmFsKTsKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvRXhjZXB0aW9uSGVscGVycy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvRXhjZXB0aW9uSGVscGVycy5jcHAJKHJldmlzaW9uIDE1MjYzMSkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC04NCw3ICs4NCw3IEBAIEpTT2JqZWN0KiBjcmVhdGVVbmRlZmluZWRWYXJp YWJsZUVycm9yKEUKICAgICByZXR1cm4gY3JlYXRlUmVmZXJlbmNlRXJyb3IoZXhlYywgbWVzc2Fn ZSk7CiB9CiAgICAgCi1KU09iamVjdCogY3JlYXRlSW52YWxpZFBhcmFtRXJyb3IoRXhlY1N0YXRl KiBleGVjLCBjb25zdCBjaGFyKiBvcCwgSlNWYWx1ZSB2YWx1ZSkKK0pTT2JqZWN0KiBjcmVhdGVJ bnZhbGlkUGFyYW1ldGVyRXJyb3IoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBjaGFyKiBvcCwgSlNW YWx1ZSB2YWx1ZSkKIHsKICAgICBTdHJpbmcgZXJyb3JNZXNzYWdlID0gbWFrZVN0cmluZygiJyIs IHZhbHVlLnRvU3RyaW5nKGV4ZWMpLT52YWx1ZShleGVjKSwgIicgaXMgbm90IGEgdmFsaWQgYXJn dW1lbnQgZm9yICciLCBvcCwgIiciKTsKICAgICBKU09iamVjdCogZXhjZXB0aW9uID0gY3JlYXRl VHlwZUVycm9yKGV4ZWMsIGVycm9yTWVzc2FnZSk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvRXhjZXB0aW9uSGVscGVycy5oCShyZXZpc2lvbiAxNTI2MzEpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmgJKHdvcmtp bmcgY29weSkKQEAgLTQyLDcgKzQyLDcgQEAgSlNPYmplY3QqIGNyZWF0ZVN0YWNrT3ZlcmZsb3dF cnJvcihKU0dsbwogSlNPYmplY3QqIGNyZWF0ZU91dE9mTWVtb3J5RXJyb3IoSlNHbG9iYWxPYmpl Y3QqKTsKIEpTT2JqZWN0KiBjcmVhdGVVbmRlZmluZWRWYXJpYWJsZUVycm9yKEV4ZWNTdGF0ZSos IGNvbnN0IElkZW50aWZpZXImKTsKIEpTT2JqZWN0KiBjcmVhdGVOb3RBbk9iamVjdEVycm9yKEV4 ZWNTdGF0ZSosIEpTVmFsdWUpOwotSlNPYmplY3QqIGNyZWF0ZUludmFsaWRQYXJhbUVycm9yKEV4 ZWNTdGF0ZSosIGNvbnN0IGNoYXIqIG9wLCBKU1ZhbHVlKTsKK0pTT2JqZWN0KiBjcmVhdGVJbnZh bGlkUGFyYW1ldGVyRXJyb3IoRXhlY1N0YXRlKiwgY29uc3QgY2hhciogb3AsIEpTVmFsdWUpOwog SlNPYmplY3QqIGNyZWF0ZU5vdEFDb25zdHJ1Y3RvckVycm9yKEV4ZWNTdGF0ZSosIEpTVmFsdWUp OwogSlNPYmplY3QqIGNyZWF0ZU5vdEFGdW5jdGlvbkVycm9yKEV4ZWNTdGF0ZSosIEpTVmFsdWUp OwogSlNPYmplY3QqIGNyZWF0ZUVycm9yRm9ySW52YWxpZEdsb2JhbEFzc2lnbm1lbnQoRXhlY1N0 YXRlKiwgY29uc3QgU3RyaW5nJik7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU09iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNPYmplY3QuY3BwCShyZXZpc2lvbiAxNTI2MzEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU09iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0MDAsNyArMTQwMCw3 IEBAIGJvb2wgSlNPYmplY3Q6Omhhc0luc3RhbmNlKEV4ZWNTdGF0ZSogZXgKICAgICAgICAgcmV0 dXJuIGRlZmF1bHRIYXNJbnN0YW5jZShleGVjLCB2YWx1ZSwgZ2V0KGV4ZWMsIGV4ZWMtPnByb3Bl cnR5TmFtZXMoKS5wcm90b3R5cGUpKTsKICAgICBpZiAoaW5mby5pbXBsZW1lbnRzSGFzSW5zdGFu Y2UoKSkKICAgICAgICAgcmV0dXJuIG1ldGhvZFRhYmxlKCktPmN1c3RvbUhhc0luc3RhbmNlKHRo aXMsIGV4ZWMsIHZhbHVlKTsKLSAgICB0aHJvd0Vycm9yKGV4ZWMsIGNyZWF0ZUludmFsaWRQYXJh bUVycm9yKGV4ZWMsICJpbnN0YW5jZW9mIiAsIHRoaXMpKTsKKyAgICB0aHJvd0Vycm9yKGV4ZWMs IGNyZWF0ZUludmFsaWRQYXJhbWV0ZXJFcnJvcihleGVjLCAiaW5zdGFuY2VvZiIgLCB0aGlzKSk7 CiAgICAgcmV0dXJuIGZhbHNlOwogfQogCg==