118755 2013-07-16 16:44:27 -0700 check-webkit-style: "using namespace foo;" should be flagged as an error only in headers 2013-07-17 02:10:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 skyul skyul brian.holt commit-queue dpranke glenn rniwa oldest_to_newest 909070 0 skyul 2013-07-16 16:44:27 -0700 The patch in Bug 57241 is buggy because it flags "using namespace foo;" in source files too. 909072 1 206827 skyul 2013-07-16 16:51:03 -0700 Created attachment 206827 Patch 909076 2 206827 skyul 2013-07-16 17:11:05 -0700 Comment on attachment 206827 Patch Clearing flags on attachment: 206827 Committed r152748: <http://trac.webkit.org/changeset/152748> 909077 3 skyul 2013-07-16 17:11:09 -0700 All reviewed patches have been landed. Closing bug. 909256 4 brian.holt 2013-07-17 02:10:54 -0700 Good catch! I didn't realise from the original bug that it was only meant to apply to headers. 206827 2013-07-16 16:51:03 -0700 2013-07-16 17:11:05 -0700 Patch bug-118755-20130717085059.patch text/plain 3629 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNzQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTUwZTEzNzI2OWNkNGQ5MDllODQ0YjVhZjI4NGMyOTkz NDRlMTU5OC4uZmZjMmJiYjc2MGVkYmMxYzc2YWY4YzQzZmExMThmNmI3YzcwYjlmMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEzLTA3LTE2ICBLd2FuZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisK KyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlOiAidXNpbmcgbmFtZXNwYWNlIGZvbzsiIHNob3Vs ZCBiZSBmbGFnZ2VkIGFzIGFuIGVycm9yIG9ubHkgaW4gaGVhZGVycworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NzU1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHIxNTI3MTkgdG8gY2hlY2sgInVz aW5nIG5hbWVzcGFjZSBmb287IiBvbmx5IGluIGhlYWRlcnMuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKGNoZWNrX3VzaW5nX25h bWVzcGFjZSk6CisgICAgICAgIChjaGVja19zdHlsZSk6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHk6CisgICAgICAgIChXZWJLaXRTdHls ZVRlc3QudGVzdF91c2luZ19uYW1lc3BhY2UpOgorCiAyMDEzLTA3LTE2ICBDaHJpc3RvcGhlIER1 bWV6ICA8Y2guZHVtZXpAc2lzYS5zYW1zdW5nLmNvbT4KIAogICAgICAgICBHZXQgcmlkIG9mIG11 bHRpcGxlIGluaGVyaXRhbmNlIHN1cHBvcnQgZnJvbSB0aGUgYmluZGluZ3MgZ2VuZXJhdG9ycwpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCA4YmUz YmViYmQyMDE5YWQ0MDQ5MWI5Njg4NWU5NmY5OTNjN2RmYjdlLi5kNjdlNjlhZDg0NjExMmJlMmU4 MDExZTIyOTc4NjUzYjNkYTA3ZDRkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcC5weQpAQCAtMjE2MSwxOSArMjE2MSwxOCBAQCBkZWYgY2hlY2tfdXNpbmdf c3RkKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9zdGF0ZSwgZXJyb3IpOgogICAgICAg ICAgICJVc2UgJ3VzaW5nIG5hbWVzcGFjZSBzdGQ7JyBpbnN0ZWFkIG9mICd1c2luZyBzdGQ6OiVz OycuIiAlIG1ldGhvZF9uYW1lKQogCiAKLWRlZiBjaGVja191c2luZ19uYW1lc3BhY2UoY2xlYW5f bGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJvcik6CitkZWYgY2hlY2tfdXNpbmdf bmFtZXNwYWNlKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9leHRlbnNpb24sIGVycm9y KToKICAgICAiIiJMb29rcyBmb3IgJ3VzaW5nIG5hbWVzcGFjZSBmb287JyB3aGljaCBzaG91bGQg YmUgcmVtb3ZlZC4KIAogICAgIEFyZ3M6CiAgICAgICBjbGVhbl9saW5lczogQSBDbGVhbnNlZExp bmVzIGluc3RhbmNlIGNvbnRhaW5pbmcgdGhlIGZpbGUuCiAgICAgICBsaW5lX251bWJlcjogVGhl IG51bWJlciBvZiB0aGUgbGluZSB0byBjaGVjay4KLSAgICAgIGZpbGVfc3RhdGU6IEEgX0ZpbGVT dGF0ZSBpbnN0YW5jZSB3aGljaCBtYWludGFpbnMgaW5mb3JtYXRpb24gYWJvdXQKLSAgICAgICAg ICAgICAgICAgIHRoZSBzdGF0ZSBvZiB0aGluZ3MgaW4gdGhlIGZpbGUuCisgICAgICBmaWxlX2V4 dGVuc2lvbjogVGhlIGV4dGVuc2lvbiAoZG90IG5vdCBpbmNsdWRlZCkgb2YgdGhlIGZpbGUuCiAg ICAgICBlcnJvcjogVGhlIGZ1bmN0aW9uIHRvIGNhbGwgd2l0aCBhbnkgZXJyb3JzIGZvdW5kLgog ICAgICIiIgogCi0gICAgIyBUaGlzIGNoZWNrIGRvZXNuJ3QgYXBwbHkgdG8gQyBvciBPYmplY3Rp dmUtQyBpbXBsZW1lbnRhdGlvbiBmaWxlcy4KLSAgICBpZiBmaWxlX3N0YXRlLmlzX2Nfb3Jfb2Jq ZWN0aXZlX2MoKToKKyAgICAjIFRoaXMgY2hlY2sgYXBwbGllcyBvbmx5IHRvIGhlYWRlcnMuCisg ICAgaWYgZmlsZV9leHRlbnNpb24gIT0gJ2gnOgogICAgICAgICByZXR1cm4KIAogICAgIGxpbmUg PSBjbGVhbl9saW5lcy5lbGlkZWRbbGluZV9udW1iZXJdICAjIEdldCByaWQgb2YgY29tbWVudHMg YW5kIHN0cmluZ3MuCkBAIC0yNjcwLDcgKzI2NjksNyBAQCBkZWYgY2hlY2tfc3R5bGUoY2xlYW5f bGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX2V4dGVuc2lvbiwgY2xhc3Nfc3RhdGUsIGZpbGVfc3Rh dAogICAgIGNoZWNrX25hbWVzcGFjZV9pbmRlbnRhdGlvbihjbGVhbl9saW5lcywgbGluZV9udW1i ZXIsIGZpbGVfZXh0ZW5zaW9uLCBmaWxlX3N0YXRlLCBlcnJvcikKICAgICBjaGVja19kaXJlY3Rp dmVfaW5kZW50YXRpb24oY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJv cikKICAgICBjaGVja191c2luZ19zdGQoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0 YXRlLCBlcnJvcikKLSAgICBjaGVja191c2luZ19uYW1lc3BhY2UoY2xlYW5fbGluZXMsIGxpbmVf bnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJvcikKKyAgICBjaGVja191c2luZ19uYW1lc3BhY2UoY2xl YW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX2V4dGVuc2lvbiwgZXJyb3IpCiAgICAgY2hlY2tf bWF4X21pbl9tYWNyb3MoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJv cikKICAgICBjaGVja19jdHlwZV9mdW5jdGlvbnMoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBm aWxlX3N0YXRlLCBlcnJvcikKICAgICBjaGVja19zd2l0Y2hfaW5kZW50YXRpb24oY2xlYW5fbGlu ZXMsIGxpbmVfbnVtYmVyLCBlcnJvcikKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggZTEwYmJmZWZiNmE5ZWU3ZmI0 N2I3YzZkMTZkNDMxY2Y3ZmVkMDQ5YS4uNmVmODU3YzQxZTM4NjA0OWFhMTEzZTI5MGQ5NTViMDdh ZTIxNDczMCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHBfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTQ0OTUsNyArNDQ5NSw3IEBAIGNsYXNzIFdlYktpdFN0 eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICd1c2luZyBuYW1lc3BhY2Ug Zm9vOycsCiAgICAgICAgICAgICAiRG8gbm90IHVzZSAndXNpbmcgbmFtZXNwYWNlIGZvbzsnLiIK ICAgICAgICAgICAgICIgIFtidWlsZC91c2luZ19uYW1lc3BhY2VdIFs0XSIsCi0gICAgICAgICAg ICAnZm9vLmNwcCcpCisgICAgICAgICAgICAnZm9vLmgnKQogCiAgICAgZGVmIHRlc3RfbWF4X21h Y3JvKHNlbGYpOgogICAgICAgICBzZWxmLmFzc2VydF9saW50KAo=