118753 2013-07-16 16:18:02 -0700 Typo in DFGInsertionSet.h header guard: "DFGInsectionSet_h" -> "DFGInsertionSet_h" 2013-07-16 16:23:10 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 1 dfarler dfarler oldest_to_newest 909057 0 dfarler 2013-07-16 16:18:02 -0700 DFGInsertionSet.h: 26 #ifndef DFGInsertionSet_h 27 #define DFGInsectionSet_h Found this with trunk clang [-Wheader-guard] In file included from /webkit/OpenSource/Source/JavaScriptCore/dfg/DFGDCEPhase.cpp:33: /webkit/OpenSource/Source/JavaScriptCore/dfg/DFGInsertionSet.h:26:9: error: 'DFGInsertionSet_h' is used as a header guard here, followed by #define of a different macro [-Werror,-Wheader-guard] #ifndef DFGInsertionSet_h ^~~~~~~~~~~~~~~~~ /webkit/OpenSource/Source/JavaScriptCore/dfg/DFGInsertionSet.h:27:9: note: 'DFGInsectionSet_h' is defined here; did you mean 'DFGInsertionSet_h'? #define DFGInsectionSet_h ^~~~~~~~~~~~~~~~~ DFGInsertionSet_h 1 error generated. 909058 1 206824 dfarler 2013-07-16 16:20:21 -0700 Created attachment 206824 Patch 909059 2 206824 ggaren 2013-07-16 16:22:22 -0700 Comment on attachment 206824 Patch r=me 909061 3 dfarler 2013-07-16 16:23:10 -0700 Committed r152747: <http://trac.webkit.org/changeset/152747> 206824 2013-07-16 16:20:21 -0700 2013-07-16 16:22:22 -0700 Patch bug-118753-20130716162021.patch text/plain 1172 dfarler U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 NGRjZGUyNzRhNzJhN2I0NzkzNTFjYjM5NDE0OGVkMzEzZTAyZmEzLi5iZmJlMjAxNmIwZGZiZTlk NzJjZWQ1NjBmMmYzOTQyNDg0NjNlZDg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0wNy0xNiAgRGF2aWQgRmFybGVyICA8ZGZhcmxlckBhcHBsZS5jb20+ CisKKyAgICAgICAgVHlwbyBpbiBERkdJbnNlcnRpb25TZXQuaCBoZWFkZXIgZ3VhcmQ6ICJERkdJ bnNlY3Rpb25TZXRfaCIgLT4gIkRGR0luc2VydGlvblNldF9oIgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NzUzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHSW5zZXJ0aW9uU2V0Lmg6Cisg ICAgICAgICJERkdJbnNlY3Rpb25TZXRfaCIgLT4gIkRGR0luc2VydGlvblNldF9oIgorCiAyMDEz LTA3LTE2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZVJv cGUgZml4dXAgc2hvdWxkbid0IGxlYWQgdG8gYW4gSWRlbnRpdHkgd2l0aG91dCBraWRzCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0luc2VydGlvblNldC5oIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdJbnNlcnRpb25TZXQuaAppbmRleCA3MGQzMDk4OGQ2 ZDhiYmZlM2QxNzNiYzlkYTgyZjViNGJiMjZkMTg4Li4xOWMxZGE0YTY2YzZlNWYyYjRhNWI1M2I2 NzFhMGQ4MjE1ODhjNzQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0luc2VydGlvblNldC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSW5zZXJ0 aW9uU2V0LmgKQEAgLTI0LDcgKzI0LDcgQEAKICAqLwogCiAjaWZuZGVmIERGR0luc2VydGlvblNl dF9oCi0jZGVmaW5lIERGR0luc2VjdGlvblNldF9oCisjZGVmaW5lIERGR0luc2VydGlvblNldF9o CiAKICNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4KIAo=