118739 2013-07-16 11:07:54 -0700 REGRESSION (r150291): Chinese predictive input pop-up disappears on twitter.com 2013-07-16 14:16:00 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 ap ap dbates rniwa oldest_to_newest 908959 0 ap 2013-07-16 11:07:54 -0700 Steps to reproduce: 1. Enable Cangjie (Traditional Chinese) input in System Preferences > Keyboard > Input Sources. 2. In the settings for Cangjie, make sure "Show prediction candidates" is turned on. 3. Switch to the Cangjie input source. 4. Click Reply on a tweet at twitter.com. 5. Type "hqi<space>. Results: a predictive input pop-up momentarily appears, but does not stay on screen. <rdar://problem/14300350> 908988 1 206808 ap 2013-07-16 12:41:49 -0700 Created attachment 206808 proposed fix I couldn't make a test for this issue. WebKitTestRunner tests from WebProcess side, and there were too many timing issues trying to detect an effect of this patch from there. 908998 2 206808 dbates 2013-07-16 13:31:01 -0700 Comment on attachment 206808 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=206808&action=review r=me > Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:224 > + m_temporarilyClosedComposition = false; I'm unclear if you're unhappy about this addition given your ChangeLog remark on it being a "targeted fix just for this specific [bug]". If you're unhappy about this change then I suggest we add a FIXME comment and/or file a bug (and reference it in the FIXME comment) so that we may revisit this fix should we come up with a better approach at a later date. On another note, I noticed that WebPageProxy::m_temporarilyClosedComposition is only used in the Apple Mac WebKit port (as of the time of writing). We should consider guarding it with an #idef so as to make it clear at the call site that it's specific to the Apple Mac WebKit port. Obviously we should look to better encapsulate such Mac-specific implementation details so as to minimize the use of platform-specific #ifdefs in platform-independent files. 909012 3 ap 2013-07-16 14:16:00 -0700 Committed <http://trac.webkit.org/r152740>. > If you're unhappy about this change then I suggest we add a FIXME comment and/or file a bug This specific change should be perfectly good. What is not good is that other similar places don't reset m_temporarilyClosedComposition, and that if I change them to do that, then things break. EditorState tracking is quite unreliable in general. 206808 2013-07-16 12:41:49 -0700 2013-07-16 13:31:01 -0700 proposed fix TwitterIM.txt text/plain 2132 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjczNCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDEzLTA3LTE2ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxNTAy OTEpOiBDaGluZXNlIHByZWRpY3RpdmUgaW5wdXQgcG9wLXVwIGRpc2FwcGVhcnMgb24gdHdpdHRl ci5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx ODczOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTQzMDAzNTA+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRWRpdG9yU3RhdGUgdHJhY2tpbmcgb24g VUkgc2lkZSBpcyB2ZXJ5IGZyYWdpbGUuIFRoaXMgaXMgYSB0YXJnZXRlZCBmaXgganVzdCBmb3IK KyAgICAgICAgdGhpcyBzcGVjaWZpYyBzY2VuYXJpby4KKworICAgICAgICBUaGUgaXNzdWUgd2Fz IHRoYXQgd2UgaGFkIGEgc3RhbGUgbV90ZW1wb3JhcmlseUNsb3NlZENvbXBvc2l0aW9uIGZsYWcs IHdoaWNoIHdhcworICAgICAgICBtYWtpbmcgVUkgcHJvY2VzcyBiZWxpZXZlIHRoYXQgYSBjb21w b3NpdGlvbiB3YXMgY2xvc2VkIGZyb20gV2ViUHJvY2VzcyBzaWRlLAorICAgICAgICBhbmQgbm90 aWZ5IGlucHV0IG1ldGhvZCBhYm91dCB0aGF0LiBJdCBzaG91bGRuJ3QgaGF2ZSBiZWVuIGEgcHJv YmxlbSwgYmVjYXVzZSB0aGVyZQorICAgICAgICBpcyBubyBjb21wb3NpdGlvbiBhdCB0aGlzIHBv aW50IGluZGVlZCwgYnV0IHRoaXMgZXh0cmEgY2FsbCBpcyBhIHByb2JsZW0gZm9yCisgICAgICAg IHByZWRpY3RpdmUgaW5wdXQsIHdoaWNoIHdvcmtzIGluIGEgc29tZXdoYXQgdW5jb252ZW50aW9u YWwgd2F5ICg8cmRhcjovL3Byb2JsZW0vMTQ0NTgyOTc+KS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9tYWMvV2ViUGFnZVByb3h5TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6 Omluc2VydFRleHQpOiBSZXNldCBtX3RlbXBvcmFyaWx5Q2xvc2VkQ29tcG9zaXRpb24gZmxhZyB3 aGVuCisgICAgICAgIGdldHRpbmcgbmV3IEVkaXRvclN0YXRlIGluIHJlc3BvbnNlIHRvIHBlcmZv cm1pbmcgdGhpcyBhY3Rpb24uIFRoZXJlIGlzIGNlcnRhaW5seQorICAgICAgICBubyBjb21wb3Np dGlvbiBhZnRlciBpbnNlcnRUZXh0LCBhbmQgYWxsIGludGVyZXN0ZWQgcGFydGllcyBhcmUgb24g dGhlIHNhbWUgcGFnZQorICAgICAgICBhbHJlYWR5LgorCiAyMDEzLTA3LTE2ICBKZXNzaWUgQmVy bGluICA8amJlcmxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHNvbWUgTlNEaWN0aW9uYXJ5 IG1pc3VzZSBwb2ludGVkIG91dCBieSB0aGUgY2xhbmcgc3RhdGljIGFuYWx5emVyCkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYlBhZ2VQcm94eU1hYy5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYlBhZ2VQcm94eU1hYy5tbQkocmV2 aXNpb24gMTUyNjM4KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJQYWdlUHJv eHlNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTIyMSw2ICsyMjEsOCBAQCBib29sIFdlYlBhZ2VQ cm94eTo6aW5zZXJ0VGV4dChjb25zdCBTdHJpCiAKICAgICBib29sIGhhbmRsZWQgPSB0cnVlOwog ICAgIHByb2Nlc3MoKS0+c2VuZFN5bmMoTWVzc2FnZXM6OldlYlBhZ2U6Okluc2VydFRleHQodGV4 dCwgcmVwbGFjZW1lbnRSYW5nZVN0YXJ0LCByZXBsYWNlbWVudFJhbmdlRW5kKSwgTWVzc2FnZXM6 OldlYlBhZ2U6Okluc2VydFRleHQ6OlJlcGx5KGhhbmRsZWQsIG1fZWRpdG9yU3RhdGUpLCBtX3Bh Z2VJRCk7CisgICAgbV90ZW1wb3JhcmlseUNsb3NlZENvbXBvc2l0aW9uID0gZmFsc2U7CisKICAg ICByZXR1cm4gaGFuZGxlZDsKIH0KIAo=