118725 2013-07-16 02:35:58 -0700 [Qt] syncqt doesn't generate the forwarding headers in SVN repositories. 2013-07-30 06:33:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 114171 1 kadam kadam abecsi abrhm allan.jensen jturcotte ossy vestbo zarvai oldest_to_newest 908768 0 kadam 2013-07-16 02:35:58 -0700 The problem is that after this change impossible to build WebKit trunk with Qt 5.1. The problem is the svn. If we use svn repository then the syncqt won't generate the forwarding headers and the build will be wrong because of missing header files. Oswald Buddenhagen suggested this change. https://bugreports.qt-project.org/browse/QTBUG-29465 908829 1 206764 kadam 2013-07-16 04:52:14 -0700 Created attachment 206764 proposed patch 908831 2 206764 ossy 2013-07-16 04:55:55 -0700 Comment on attachment 206764 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=206764&action=review LGTM, but it would be great if Tor Arne can do the final review. > .qmake.conf:6 > +#The syncqt can generate the forwarding headers in SVN repositories. > +CONFIG+=git_build It would be great to have a more descriptive comment here, for example same as in the changelog: # Workaround to make syncqt run and generate forwarding headers in SVN repositories too # https://bugs.webkit.org/show_bug.cgi?id=118725 908833 3 206767 kadam 2013-07-16 05:02:52 -0700 Created attachment 206767 proposed patch Ossy, thanks for the informal review. I corrected the comment. 908877 4 206764 vestbo 2013-07-16 07:15:55 -0700 Comment on attachment 206764 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=206764&action=review >> .qmake.conf:6 >> +CONFIG+=git_build > > It would be great to have a more descriptive comment here, for example same as in the changelog: > # Workaround to make syncqt run and generate forwarding headers in SVN repositories too > # https://bugs.webkit.org/show_bug.cgi?id=118725 I agree with Ossy about the comment. This should also be guarded by a check for an actual .svn directory. 909320 5 206886 kadam 2013-07-17 05:53:50 -0700 Created attachment 206886 proposed patch I updated the patch. What do you think? Is it good? 912425 6 206886 vestbo 2013-07-29 03:45:24 -0700 Comment on attachment 206886 proposed patch Style issues aside (no spaces around arguments), lgtm 912815 7 kadam 2013-07-30 06:33:06 -0700 Committed r153467: <http://trac.webkit.org/changeset/153467> 206764 2013-07-16 04:52:14 -0700 2013-07-16 07:15:55 -0700 proposed patch git_build.patch text/plain 955 kadam ZGlmZiAtLWdpdCBhLy5xbWFrZS5jb25mIGIvLnFtYWtlLmNvbmYKaW5kZXggMjc2M2NiYi4uNGRl OGU3ZSAxMDA2NDQKLS0tIGEvLnFtYWtlLmNvbmYKKysrIGIvLnFtYWtlLmNvbmYKQEAgLTEsNiAr MSw5IEBACiAjIFRoZSBxbWFrZSBnZW5lcmF0ZWQgbW9kdWxlIGZpbGVzIGJlbG9uZyBpbnRvIG91 ciBUb29scy9xbWFrZSBkaXIKIE1PRFVMRV9RTUFLRV9PVVRESVIgPSAkJHNoYWRvd2VkKCQkUFdE L1Rvb2xzL3FtYWtlKQogUU1BS0VQQVRIICs9ICQkUFdEL1Rvb2xzL3FtYWtlICQkTU9EVUxFX1FN QUtFX09VVERJUgorCisjVGhlIHN5bmNxdCBjYW4gZ2VuZXJhdGUgdGhlIGZvcndhcmRpbmcgaGVh ZGVycyBpbiBTVk4gcmVwb3NpdG9yaWVzLgorQ09ORklHKz1naXRfYnVpbGQKIGxvYWQocXRfYnVp bGRfY29uZmlnKQogCiBNT0RVTEVfVkVSU0lPTiA9IDUuMi4wCmRpZmYgLS1naXQgYS9DaGFuZ2VM b2cgYi9DaGFuZ2VMb2cKaW5kZXggNTQyMjJmYi4uZTNhNzQ0MSAxMDA2NDQKLS0tIGEvQ2hhbmdl TG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA3LTE2ICDDgWTDoW0g S2FsbGFpICA8a2FkYW1AaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtRdF0gV29ya2Fyb3Vu ZCB0byBtYWtlIHN5bmNxdCBydW4gYW5kIGdlbmVyYXRlIGZvcndhcmRpbmcgaGVhZGVycyBpbiBT Vk4gcmVwb3NpdG9yaWVzIHRvby4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExODcyNS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIC5xbWFrZS5jb25mOgorCiAyMDEzLTA3LTA5ICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBVcGRh dGUgTkVXUyBhbmQgVmVyc2lvbnMubTQgZm9yIDIuMS4zIHJlbGVhc2UuCg== 206767 2013-07-16 05:02:52 -0700 2013-07-17 05:53:50 -0700 proposed patch git_build.patch text/plain 1025 kadam ZGlmZiAtLWdpdCBhLy5xbWFrZS5jb25mIGIvLnFtYWtlLmNvbmYKaW5kZXggMjc2M2NiYi4uZDQ2 MTY0ZCAxMDA2NDQKLS0tIGEvLnFtYWtlLmNvbmYKKysrIGIvLnFtYWtlLmNvbmYKQEAgLTEsNiAr MSwxMCBAQAogIyBUaGUgcW1ha2UgZ2VuZXJhdGVkIG1vZHVsZSBmaWxlcyBiZWxvbmcgaW50byBv dXIgVG9vbHMvcW1ha2UgZGlyCiBNT0RVTEVfUU1BS0VfT1VURElSID0gJCRzaGFkb3dlZCgkJFBX RC9Ub29scy9xbWFrZSkKIFFNQUtFUEFUSCArPSAkJFBXRC9Ub29scy9xbWFrZSAkJE1PRFVMRV9R TUFLRV9PVVRESVIKKworIyBXb3JrYXJvdW5kIHRvIG1ha2Ugc3luY3F0IHJ1biBhbmQgZ2VuZXJh dGUgZm9yd2FyZGluZyBoZWFkZXJzIGluIFNWTiByZXBvc2l0b3JpZXMgdG9vCisjIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg3MjUKK0NPTkZJRys9Z2l0X2J1aWxk CiBsb2FkKHF0X2J1aWxkX2NvbmZpZykKIAogTU9EVUxFX1ZFUlNJT04gPSA1LjIuMApkaWZmIC0t Z2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDU0MjIyZmIuLmUzYTc0NDEgMTAwNjQ0 Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMy0w Ny0xNiAgw4Fkw6FtIEthbGxhaSAgPGthZGFtQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBb UXRdIFdvcmthcm91bmQgdG8gbWFrZSBzeW5jcXQgcnVuIGFuZCBnZW5lcmF0ZSBmb3J3YXJkaW5n IGhlYWRlcnMgaW4gU1ZOIHJlcG9zaXRvcmllcyB0b28uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg3MjUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiAucW1ha2UuY29uZjoKKwogMjAxMy0wNy0wOSAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZC4gVXBkYXRlIE5FV1MgYW5kIFZlcnNpb25zLm00IGZvciAyLjEuMyByZWxlYXNlLgo= 206886 2013-07-17 05:53:50 -0700 2013-07-29 03:45:24 -0700 proposed patch git_build.patch text/plain 1067 kadam ZGlmZiAtLWdpdCBhLy5xbWFrZS5jb25mIGIvLnFtYWtlLmNvbmYKaW5kZXggMjc2M2NiYi4uMDgy ZTQyYiAxMDA2NDQKLS0tIGEvLnFtYWtlLmNvbmYKKysrIGIvLnFtYWtlLmNvbmYKQEAgLTEsNiAr MSwxMyBAQAogIyBUaGUgcW1ha2UgZ2VuZXJhdGVkIG1vZHVsZSBmaWxlcyBiZWxvbmcgaW50byBv dXIgVG9vbHMvcW1ha2UgZGlyCiBNT0RVTEVfUU1BS0VfT1VURElSID0gJCRzaGFkb3dlZCgkJFBX RC9Ub29scy9xbWFrZSkKIFFNQUtFUEFUSCArPSAkJFBXRC9Ub29scy9xbWFrZSAkJE1PRFVMRV9R TUFLRV9PVVRESVIKKworIyBXb3JrYXJvdW5kIHRvIG1ha2Ugc3luY3F0IHJ1biBhbmQgZ2VuZXJh dGUgZm9yd2FyZGluZyBoZWFkZXJzIGluIFNWTiByZXBvc2l0b3JpZXMgdG9vCisjIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg3MjUKK2V4aXN0cyggJCRQV0QvLnN2 biApIHsKKyAgICBDT05GSUcgKz0gZ2l0X2J1aWxkCit9CisKIGxvYWQocXRfYnVpbGRfY29uZmln KQogCiBNT0RVTEVfVkVSU0lPTiA9IDUuMi4wCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFu Z2VMb2cKaW5kZXggMTQ2ZjkxOS4uN2VmMjU5OSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBi L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA3LTE3ICDDgWTDoW0gS2FsbGFpICA8 a2FkYW1AaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtRdF0gV29ya2Fyb3VuZCB0byBtYWtl IHN5bmNxdCBydW4gYW5kIGdlbmVyYXRlIGZvcndhcmRpbmcgaGVhZGVycyBpbiBTVk4gcmVwb3Np dG9yaWVzIHRvby4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExODcyNS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIC5xbWFrZS5jb25mOgorCiAyMDEzLTA3LTE2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBSZW1vdmUgY29tcGlsZSB3YXJu aW5ncyBhYm91dCBHVEsrIEFQSSBkZXByZWNhdGVkIGFmdGVyIDMuNgo=