<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>118718</bug_id>
          
          <creation_ts>2013-07-16 00:38:43 -0700</creation_ts>
          <short_desc>Don&apos;t warn about NULL usage in GTK functions even when a functional call spans multiple lines</short_desc>
          <delta_ts>2013-07-16 00:40:56 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kwang Yul Seo">skyul</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>pnormand</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>908726</commentid>
    <comment_count>0</comment_count>
    <who name="Kwang Yul Seo">skyul</who>
    <bug_when>2013-07-16 00:38:43 -0700</bug_when>
    <thetext>Bug 32858, 39372, 70498, 43090, 51758 and 77890 add exceptions to the null check rule of check-webkit-style so that check-webkit-style won&apos;t warn about NULL usage in some GTK functions such as g_*() and gst_().

However, the implementation of the null check in check-webkit-style only matches one line at a time so that it fails to match if a function spans multiple lines. For example, check-webkit-style emits a style error if g_object_set spans multiple lines as in https://bugs.webkit.org/show_bug.cgi?id=118657#c20</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>