<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>118716</bug_id>
          
          <creation_ts>2013-07-16 00:25:12 -0700</creation_ts>
          <short_desc>[EFL][WK2] Relevant test classes should be redefined by inheriting from EWK2UnitTestBase as per each test file</short_desc>
          <delta_ts>2013-07-17 03:50:56 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>118717</dependson>
    
    <dependson>118721</dependson>
    
    <dependson>118726</dependson>
    
    <dependson>118762</dependson>
    
    <dependson>118763</dependson>
    
    <dependson>118766</dependson>
    
    <dependson>118767</dependson>
    
    <dependson>118769</dependson>
    
    <dependson>118771</dependson>
    
    <dependson>118772</dependson>
    
    <dependson>118773</dependson>
    
    <dependson>118775</dependson>
    
    <dependson>118777</dependson>
    
    <dependson>118779</dependson>
    
    <dependson>118780</dependson>
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Donggwan Kim">donggwan.kim</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>gyuyoung.kim</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>908722</commentid>
    <comment_count>0</comment_count>
    <who name="Donggwan Kim">donggwan.kim</who>
    <bug_when>2013-07-16 00:25:12 -0700</bug_when>
    <thetext>All the test files use EWK2UnitTestBase only.
There are many methods and variables defined in each test file as static.
It should be defined as relevant test class specific to each test file for more readability like below.

class EWK2FooTest : public EWK2UnitTestBase {
public:
    void foo();
};</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>908733</commentid>
    <comment_count>1</comment_count>
    <who name="Donggwan Kim">donggwan.kim</who>
    <bug_when>2013-07-16 01:01:17 -0700</bug_when>
    <thetext>I uploaded the patch as sample. (https://bugs.webkit.org/show_bug.cgi?id=118717)
If this approach is accepted by a reviewer, i will modify all other test cases as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>909291</commentid>
    <comment_count>2</comment_count>
    <who name="Donggwan Kim">donggwan.kim</who>
    <bug_when>2013-07-17 03:50:56 -0700</bug_when>
    <thetext>All the dependent patches was fixed and closed.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>