11870 2006-12-18 16:36:01 -0800 Bug 11866 caused layout test regression in fast/forms/input-value.html 2006-12-18 18:40:39 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED LayoutTestFailure P2 Normal --- 1 ddkilzer webkit-unassigned ddkilzer KwhiteRight mrowe oldest_to_newest 41241 0 ddkilzer 2006-12-18 16:36:01 -0800 The patch for Bug 11866 caused a layout test regression in fast/forms/input-value.html. http://build.webkit.org/results/post-commit-powerpc-mac-os-x/4737/ 41243 1 ddkilzer 2006-12-18 16:37:23 -0800 Looks like the expected results just need to be updated. 41244 2 KwhiteRight 2006-12-18 16:50:16 -0800 If the goal is to match IE or Gecko, then it should have "after" in the second column for "hidden with value property changed", and this is a regression. If the goal is to make sense, then I'd argue for "before", to match text and password fields. I suppose trying to make sense is a bit quixotic here. 41247 3 KwhiteRight 2006-12-18 17:30:38 -0800 The two problems (the layout test failing now, and all three of those input types' attributes not doing what IE does) seem like separate issues to me. What if I change the expected results to show "before" in the second column for hidden fields, just as they do for text and password fields, and then file a new bug to change the behavior of all three types to match what IE does? 41215 4 mrowe 2006-12-18 17:43:36 -0800 That sounds fine to me. 41216 5 11912 mrowe 2006-12-18 18:05:30 -0800 Created attachment 11912 Patch with updated results. 41217 6 11912 beidson 2006-12-18 18:16:14 -0800 Comment on attachment 11912 Patch with updated results. Okay! 41218 7 mrowe 2006-12-18 18:18:29 -0800 Landed in r18292. Kirby, can you please file the followup bug? 41220 8 KwhiteRight 2006-12-18 18:40:39 -0800 Filed as bug 11871. 11912 2006-12-18 18:05:30 -0800 2006-12-18 18:16:14 -0800 Patch with updated results. webkit-bug-11870-v1.patch text/plain 1452 mrowe SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE4MjkxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDYtMTItMTggIE1hcmsgUm93ZSAgPGJkYXNo QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQnVnIDExODcwOiBCdWcgMTE4NjYgY2F1c2VkIGxheW91dCB0ZXN0IHJlZ3Jlc3Npb24g aW4gZmFzdC9mb3Jtcy9pbnB1dC12YWx1ZS5odG1sCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExODcwCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2lucHV0 LXZhbHVlLWV4cGVjdGVkLnR4dDogVXBkYXRlZCByZXN1bHRzLgorCiAyMDA2LTEyLTE4ICBCZXRo IERha2luICA8YmRha2luQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGVsZS4K SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtdmFsdWUtZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtdmFsdWUtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAxODI5MCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtdmFs dWUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC03Myw4ICs3Myw4IEBACiAgICAgICAg ICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgxLDEpIHNpemUgMjh4MTgKICAgICAgICAg ICAgICAgICAgIHRleHQgcnVuIGF0ICgxLDEpIHdpZHRoIDI4OiAiYWZ0ZXIiCiAgICAgICAgICAg ICAgIFJlbmRlclRhYmxlQ2VsbCB7VER9IGF0ICg2OTgsNzgpIHNpemUgNjF4MjAgW3I9MyBjPTMg cnM9MSBjcz0xXQotICAgICAgICAgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMSwxKSBz aXplIDI4eDE4Ci0gICAgICAgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMSwxKSB3aWR0aCAyODog ImFmdGVyIgorICAgICAgICAgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMSwxKSBzaXpl IDQweDE4CisgICAgICAgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMSwxKSB3aWR0aCA0MDogImJl Zm9yZSIKICAgICAgICAgICAgIFJlbmRlclRhYmxlUm93IHtUUn0gYXQgKDAsMTAwKSBzaXplIDc2 MXgyNAogICAgICAgICAgICAgICBSZW5kZXJUYWJsZUNlbGwge1REfSBhdCAoMiwxMDIpIHNpemUg Mzg1eDIwIFtyPTQgYz0wIHJzPTEgY3M9MV0KICAgICAgICAgICAgICAgICBSZW5kZXJUZXh0IHsj dGV4dH0gYXQgKDEsMSkgc2l6ZSAyMjR4MTgK