118679 2013-07-15 10:36:08 -0700 NetworkStorageSession::createDefaultSession is only implemented by Soup 2013-07-15 16:40:51 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap skyul cdumez commit-queue danw gustavo gyuyoung.kim kbalazs mrobinson rakuco skyul oldest_to_newest 908457 0 ap 2013-07-15 10:36:08 -0700 NetworkStorageSession::createDefaultSession() is declared a cross-platform function, but it is only implemented or used by Soup. Can you please fix this? I suspect that it is just incorrect, as there is only one default session, which is returned by defaultStorageSession(). 908537 1 skyul 2013-07-15 15:30:17 -0700 (In reply to comment #0) > NetworkStorageSession::createDefaultSession() is declared a cross-platform function, but it is only implemented or used by Soup. > > Can you please fix this? I suspect that it is just incorrect, as there is only one default session, which is returned by defaultStorageSession(). Currently, only _ewk_view_priv_new in WebKit/efl/ewk/ewk_view.cpp uses this method. This is incorrect because we already have defaultStorageSession(). I will fix it. 908561 2 206699 skyul 2013-07-15 16:19:56 -0700 Created attachment 206699 Patch 908574 3 206699 skyul 2013-07-15 16:40:45 -0700 Comment on attachment 206699 Patch Clearing flags on attachment: 206699 Committed r152672: <http://trac.webkit.org/changeset/152672> 908576 4 skyul 2013-07-15 16:40:51 -0700 All reviewed patches have been landed. Closing bug. 206699 2013-07-15 16:19:56 -0700 2013-07-15 16:40:45 -0700 Patch bug-118679-20130716081912.patch text/plain 4863 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE2YzYwODFlNDBkZjg0 ZGMxOTk3ZTYxOWMwMjA5Y2UwMmI5MTk4Yi4uMDI0ZjhiZjUxZjFiZTI0NWVmZmU0YWM0ZWFmYzZk NWRjMmFjYzg5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA3LTE1ICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgTmV0d29ya1N0b3Jh Z2VTZXNzaW9uOjpjcmVhdGVEZWZhdWx0U2Vzc2lvbiBpcyBvbmx5IGltcGxlbWVudGVkIGJ5IFNv dXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODY3 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92 ZSBOZXR3b3JrU3RvcmFnZVNlc3Npb246OmNyZWF0ZURlZmF1bHRTZXNzaW9uKCkgYmVjYXVzZQor ICAgICAgICBOZXR3b3JrU3RvcmFnZVNlc3Npb246OmRlZmF1bHRTdG9yYWdlU2Vzc2lvbigpIHJl dHVybnMgdGhlIGRlZmF1bHQKKyAgICAgICAgc2Vzc2lvbi4KKworICAgICAgICBObyBuZXcgdGVz dHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvTmV0 d29ya1N0b3JhZ2VTZXNzaW9uLmg6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL05l dHdvcmtTdG9yYWdlU2Vzc2lvblNvdXAuY3BwOgorCiAyMDEzLTA3LTE1ICBSb2dlciBGb25nICA8 cm9nZXJfZm9uZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVwbGFjZSBXS0NBQ0ZUeXBlcyBpbmNs dWRlIHdpdGggZDNkOSBpbmNsdWRlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvQ2hh bmdlTG9nIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCmluZGV4IGFlOWQ2MGZiZDUwNDA5 NGUxYmU5ZGFlYzI3M2JkNzAxODA1MDQ1MjkuLjFjYjVkZWZkMGFiZDAxNmU1YjI4NWEwNDg0ODI0 YWI5YWMyZjY1MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0wNy0x NSAgS3dhbmcgWXVsIFNlbyAgPHNreXVsQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIE5ldHdv cmtTdG9yYWdlU2Vzc2lvbjo6Y3JlYXRlRGVmYXVsdFNlc3Npb24gaXMgb25seSBpbXBsZW1lbnRl ZCBieSBTb3VwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTg2NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZXBsYWNlIE5ldHdvcmtTdG9yYWdlU2Vzc2lvbjo6Y3JlYXRlRGVmYXVsdFNlc3Npb24oKSB3 aXRoCisgICAgICAgIE5ldHdvcmtTdG9yYWdlU2Vzc2lvbjo6ZGVmYXVsdFN0b3JhZ2VTZXNzaW9u KCkuCisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoX2V3a192aWV3X3By aXZfbmV3KToKKyAgICAgICAgKEVXS1ByaXZhdGU6OnN0b3JhZ2VTZXNzaW9uKToKKwogMjAxMy0w Ny0wOSAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VG TF0gQWRkIGV3a192aWV3X2RldmljZV9waXhlbF9yYXRpb19zZXQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvTmV0d29ya1N0b3JhZ2VTZXNzaW9uLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL05ldHdvcmtTdG9yYWdlU2Vzc2lvbi5oCmluZGV4 IDAzMzI0OWEwNjFkODlmOTA4OTgyOTFmMGNkYjE2ZDA3ZGMwNmMwYmIuLjQxMjhjYWE2ZjQwMDMz YzNjZjQwM2E2MDA2ZjVlYzAwNTA5NDZlYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvTmV0d29ya1N0b3JhZ2VTZXNzaW9uLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RvcmFnZVNlc3Npb24uaApAQCAtNDUsNyArNDUs NiBAQCBjbGFzcyBOZXR3b3JrU3RvcmFnZVNlc3Npb24gewogICAgIFdURl9NQUtFX05PTkNPUFlB QkxFKE5ldHdvcmtTdG9yYWdlU2Vzc2lvbik7IFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVi bGljOgogICAgIHN0YXRpYyBOZXR3b3JrU3RvcmFnZVNlc3Npb24mIGRlZmF1bHRTdG9yYWdlU2Vz c2lvbigpOwotICAgIHN0YXRpYyBQYXNzT3duUHRyPE5ldHdvcmtTdG9yYWdlU2Vzc2lvbj4gY3Jl YXRlRGVmYXVsdFNlc3Npb24oY29uc3QgU3RyaW5nJiBpZGVudGlmaWVyQmFzZSA9IFN0cmluZygp KTsKICAgICBzdGF0aWMgUGFzc093blB0cjxOZXR3b3JrU3RvcmFnZVNlc3Npb24+IGNyZWF0ZVBy aXZhdGVCcm93c2luZ1Nlc3Npb24oY29uc3QgU3RyaW5nJiBpZGVudGlmaWVyQmFzZSk7CiAKICAg ICBzdGF0aWMgdm9pZCBzd2l0Y2hUb05ld1Rlc3RpbmdTZXNzaW9uKCk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvTmV0d29ya1N0b3JhZ2VTZXNzaW9u U291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvTmV0d29ya1N0 b3JhZ2VTZXNzaW9uU291cC5jcHAKaW5kZXggZGQ1NmUyYjg5ZjUxY2Q3N2NjYjIwMjczZjdhMmM1 ZDM4ZWJmZWFkMC4uMjZjYWU3NjIwYjAxNjJmMGMyYzcxOGVmZWM1ZjMzMjI5Mjk5ZDhmYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL05ldHdvcmtTdG9y YWdlU2Vzc2lvblNvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv c291cC9OZXR3b3JrU3RvcmFnZVNlc3Npb25Tb3VwLmNwcApAQCAtNTIsMTIgKzUyLDYgQEAgTmV0 d29ya1N0b3JhZ2VTZXNzaW9uJiBOZXR3b3JrU3RvcmFnZVNlc3Npb246OmRlZmF1bHRTdG9yYWdl U2Vzc2lvbigpCiAgICAgcmV0dXJuICpkZWZhdWx0U2Vzc2lvbigpOwogfQogCi1QYXNzT3duUHRy PE5ldHdvcmtTdG9yYWdlU2Vzc2lvbj4gTmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpjcmVhdGVEZWZh dWx0U2Vzc2lvbihjb25zdCBTdHJpbmcmKQotewotICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7 Ci0gICAgcmV0dXJuIGFkb3B0UHRyKG5ldyBOZXR3b3JrU3RvcmFnZVNlc3Npb24oUmVzb3VyY2VI YW5kbGU6OmRlZmF1bHRTZXNzaW9uKCkpKTsKLX0KLQogUGFzc093blB0cjxOZXR3b3JrU3RvcmFn ZVNlc3Npb24+IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbjo6Y3JlYXRlUHJpdmF0ZUJyb3dzaW5nU2Vz c2lvbihjb25zdCBTdHJpbmcmKQogewogICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggNmRjYjY5NGJiYjBhYjBlNzlkYzU0ZDdkZDM0MDI0 NDM3MTJhMGVmYi4uYjVkNjJlZDM5MGYwZDNkOWM2YjM2ZmE1ZmQ3ZGQ4MDE0NGJlN2E2OSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC0yNjksNyArMjY5LDcgQEAgc3RydWN0IF9F d2tfVmlld19Qcml2YXRlX0RhdGEgewogI2lmIEVOQUJMRShOQVZJR0FUT1JfQ09OVEVOVF9VVElM UykgfHwgRU5BQkxFKENVU1RPTV9TQ0hFTUVfSEFORExFUikKICAgICBPd25QdHI8V2ViQ29yZTo6 TmF2aWdhdG9yQ29udGVudFV0aWxzQ2xpZW50RWZsPiBuYXZpZ2F0b3JDb250ZW50VXRpbHNDbGll bnQ7CiAjZW5kaWYKLSAgICBPd25QdHI8V2ViQ29yZTo6TmV0d29ya1N0b3JhZ2VTZXNzaW9uPiBz dG9yYWdlU2Vzc2lvbjsKKyAgICBXZWJDb3JlOjpOZXR3b3JrU3RvcmFnZVNlc3Npb24qIHN0b3Jh Z2VTZXNzaW9uOwogICAgIHN0cnVjdCB7CiAgICAgICAgIEV3a19NZW51IG1lbnU7CiAgICAgICAg IFdlYkNvcmU6OlBvcHVwTWVudUNsaWVudCogbWVudUNsaWVudDsKQEAgLTg0OSw3ICs4NDksNyBA QCBzdGF0aWMgRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhKiBfZXdrX3ZpZXdfcHJpdl9uZXcoRXdrX1Zp ZXdfU21hcnRfRGF0YSogc21hcnREYXRhKQogCiAgICAgcHJpdi0+aGlzdG9yeSA9IGV3a19oaXN0 b3J5X25ldyhzdGF0aWNfY2FzdDxXZWJDb3JlOjpCYWNrRm9yd2FyZExpc3RJbXBsKj4ocHJpdi0+ cGFnZS0+YmFja0ZvcndhcmRMaXN0KCkpKTsKIAotICAgIHByaXYtPnN0b3JhZ2VTZXNzaW9uID0g V2ViQ29yZTo6TmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpjcmVhdGVEZWZhdWx0U2Vzc2lvbigpOwor ICAgIHByaXYtPnN0b3JhZ2VTZXNzaW9uID0gJldlYkNvcmU6Ok5ldHdvcmtTdG9yYWdlU2Vzc2lv bjo6ZGVmYXVsdFN0b3JhZ2VTZXNzaW9uKCk7CiAKICAgICBwcml2LT5wYWdlQ2xpZW50ID0gYWRv cHRQdHIobmV3IFBhZ2VDbGllbnRFZmwoc21hcnREYXRhLT5zZWxmKSk7CiAKQEAgLTQ3NzIsNyAr NDc3Miw3IEBAIFdlYkNvcmU6Ok5ldHdvcmtTdG9yYWdlU2Vzc2lvbiogc3RvcmFnZVNlc3Npb24o Y29uc3QgRXZhc19PYmplY3QqIGV3a1ZpZXcpCiB7CiAgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JF VFVSTihld2tWaWV3LCBzbWFydERhdGEsIDApOwogICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JF VFVSTihzbWFydERhdGEsIHByaXYsIDApOwotICAgIHJldHVybiBwcml2LT5zdG9yYWdlU2Vzc2lv bi5nZXQoKTsKKyAgICByZXR1cm4gcHJpdi0+c3RvcmFnZVNlc3Npb247CiB9CiAKIH0gLy8gbmFt ZXNwYWNlIEVXS1ByaXZhdGUK