118671 2013-07-15 05:49:46 -0700 webkitpy: replace urllib with urllib2 for downloading additional modules 2013-07-16 05:58:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 brian.holt webkit-unassigned cdumez cjerdonek commit-queue dpranke glenn mrobinson rniwa simon.fraser oldest_to_newest 908376 0 brian.holt 2013-07-15 05:49:46 -0700 Tarball releases for additional modules are downloaded using python’s urllib. However this fails when traffic is routed through a proxy: $Tools/Scripts/test-webkitpy fails with error 400. However the proxy is correctly setup and can download the file with wget. The solution (and this solves the problem for me) is to replace urllib with urllib2, which should cause no trouble because urllib2 should be available everywhere but has better proxy support. 908378 1 206658 brian.holt 2013-07-15 05:52:58 -0700 Created attachment 206658 Patch 908837 2 brian.holt 2013-07-16 05:32:09 -0700 It looks like urllib2 is used quite a lot around the codebase in case that was giving pause for thought $ find Tools/Scripts/webkitpy -name "*.py" | xargs grep urllib2 | wc -l 132 908844 3 206658 commit-queue 2013-07-16 05:57:57 -0700 Comment on attachment 206658 Patch Clearing flags on attachment: 206658 Committed r152717: <http://trac.webkit.org/changeset/152717> 908845 4 commit-queue 2013-07-16 05:58:00 -0700 All reviewed patches have been landed. Closing bug. 206658 2013-07-15 05:52:58 -0700 2013-07-16 05:57:57 -0700 Patch bug-118671-20130715135215.patch text/plain 1578 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNTcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTcwMzkxMTg3ZTQxOTg3M2I2ZWU1MjZlZjE3OTVlYWMw NmUyODQ0ZS4uY2JjZDcwNjdmZDliN2VjZDUwMGE4MDZiN2VkY2YzOTg2ZWVlNDAyZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTA3LTE1ICBCcmlhbiBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKwor ICAgICAgICB3ZWJraXRweTogcmVwbGFjZSB1cmxsaWIgd2l0aCB1cmxsaWIyIGZvciBkb3dubG9h ZGluZyBhZGRpdGlvbmFsIG1vZHVsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExODY3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVybGxpYjIgaXMgYXZhaWxhYmxlIHdoZXJlZXZlciB1cmxsaWIgaXMs IGJ1dCBoYXMgYmV0dGVyIHByb3h5IHN1cHBvcnQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9zeXN0ZW0vYXV0b2luc3RhbGwucHk6CisgICAgICAgIChBdXRvSW5zdGFsbGVy Ll9kb3dubG9hZF90b19zdHJlYW0pOgorCiAyMDEzLTA3LTEwICBTZXJnaW8gQ29ycmVpYSAgPHNl cmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgSGFuZGxlICJsb2FkLHByb3Zp c2lvbmFsLGZhaWxlZCIgd2l0aCB0aGUgb25fZXJyb3IgY2FsbGJhY2sgb24gRUZMIE1pbmlCcm93 c2VyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vYXV0 b2luc3RhbGwucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vYXV0b2lu c3RhbGwucHkKaW5kZXggZTVmMWI1NGEzN2U1MTIxMGYxNjc4NzhkMDJlZjU2YjE3ZDljMTY5NS4u MmUxNTg4N2JiNmViMGU4YmJjMTBlOTkzYzRiZjE3ZWRjZjVmMmFkNiAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2F1dG9pbnN0YWxsLnB5CisrKyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9hdXRvaW5zdGFsbC5weQpAQCAtMzks NyArMzksNyBAQCBpbXBvcnQgc3RhdAogaW1wb3J0IHN5cwogaW1wb3J0IHRhcmZpbGUKIGltcG9y dCB0ZW1wZmlsZQotaW1wb3J0IHVybGxpYgoraW1wb3J0IHVybGxpYjIKIGltcG9ydCB1cmxwYXJz ZQogaW1wb3J0IHppcGZpbGUKIApAQCAtMjg3LDcgKzI4Nyw3IEBAIGNsYXNzIEF1dG9JbnN0YWxs ZXIob2JqZWN0KToKICAgICAgICAgZmFpbHVyZXMgPSAwCiAgICAgICAgIHdoaWxlIFRydWU6CiAg ICAgICAgICAgICB0cnk6Ci0gICAgICAgICAgICAgICAgbmV0c3RyZWFtID0gdXJsbGliLnVybG9w ZW4odXJsKQorICAgICAgICAgICAgICAgIG5ldHN0cmVhbSA9IHVybGxpYjIudXJsb3Blbih1cmwp CiAgICAgICAgICAgICAgICAgYnJlYWsKICAgICAgICAgICAgIGV4Y2VwdCBJT0Vycm9yLCBlcnI6 CiAgICAgICAgICAgICAgICAgIyBUcnkgbXVsdGlwbGUgdGltZXMK