118650 2013-07-13 16:38:08 -0700 Set view to active in ViewClientEfl after WebProcess has relaunched 2013-10-09 13:14:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sergio sergio cdumez cmarcelo commit-queue gyuyoung.kim luiz noam rakuco tonikitoo zeno oldest_to_newest 908208 0 sergio 2013-07-13 16:38:08 -0700 CoordinatedGraphics: Set scene to active in WebView::paintToCurrentGLContext() 908209 1 206623 sergio 2013-07-13 16:39:49 -0700 Created attachment 206623 Patch 908210 2 sergio 2013-07-13 16:40:21 -0700 Previously, the scene was set to active in WebView::initialize(), but then if the Web Process crashed and we needed to recreate the drawing area, via WebPageProxy::initializeWebPage(), it would create a new scene which would never be set to active, and from that point on, we would only get a blank view. A simple way to verify this behavior on the EFL port would be to kill the Web Process: $ killall WebProcess After this, you will only get a blank view. 908247 3 206623 noam 2013-07-14 04:59:57 -0700 Comment on attachment 206623 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206623&action=review > Source/WebKit2/ChangeLog:12 > + Previously, the scene was set to active in WebView::initialize(), but then > + if the Web Process crashed and we needed to recreate the drawing area, via > + WebPageProxy::initializeWebPage(), it would create a new scene which would > + never be set to active, and from that point on, we would only get a blank > + view. don't we get some kind of event, like didInitialize? Setting the scene to active during paint doesn't seem like the right solution. > Source/WebKit2/ChangeLog:19 > + A simple way to verify this behavior on the EFL port would be to kill the > + Web Process: > + > + $ killall WebProcess > + > + After this, you will only get a blank view. This requires an API test. 908264 4 sergio 2013-07-14 08:07:23 -0700 Thanks for the feedback. (In reply to comment #3) > (From update of attachment 206623 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206623&action=review > > > Source/WebKit2/ChangeLog:12 > > + Previously, the scene was set to active in WebView::initialize(), but then > > + if the Web Process crashed and we needed to recreate the drawing area, via > > + WebPageProxy::initializeWebPage(), it would create a new scene which would > > + never be set to active, and from that point on, we would only get a blank > > + view. > > don't we get some kind of event, like didInitialize? Apparently not, but I will investigate it further. > Setting the scene to active during paint doesn't seem like the right solution. > I got the idea from QRawWebView::paint() (UIProcess/API/qt/raw/qrawwebview.cpp:~366), but I agree it feels a bit like a workaround, other than a proper solution. > > Source/WebKit2/ChangeLog:19 > > + A simple way to verify this behavior on the EFL port would be to kill the > > + Web Process: > > + > > + $ killall WebProcess > > + > > + After this, you will only get a blank view. > > This requires an API test. Okay, I will take a look at this as well. 912603 5 sergio 2013-07-29 15:01:17 -0700 @noam: Do you think it would be better to set the view to active in WebView::didRelaunchProcess() [UIProcess/CoordinatedGraphics/WebView.cpp], or should it be done by the clients, such as ViewClientEfl::webProcessDidRelaunch [UIProcess/efl/ViewClientEfl.cpp]? The latter seems to be more flexible to ports, since they would be able to choose the behavior they want without interfering with other ports. 914094 6 208004 sergio 2013-08-02 05:11:31 -0700 Created attachment 208004 Adding WKViewSetIsAtive to ViewClientEfl 914095 7 sergio 2013-08-02 05:12:31 -0700 (In reply to comment #6) > Created an attachment (id=208004) [details] > Adding WKViewSetIsAtive to ViewClientEfl If this patch is okay, I will update the title accordingly. 919987 8 208004 buildbot 2013-08-22 15:30:26 -0700 Comment on attachment 208004 Adding WKViewSetIsAtive to ViewClientEfl Attachment 208004 did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1526444 938035 9 208004 commit-queue 2013-10-09 13:14:06 -0700 Comment on attachment 208004 Adding WKViewSetIsAtive to ViewClientEfl Clearing flags on attachment: 208004 Committed r157178: <http://trac.webkit.org/changeset/157178> 938036 10 commit-queue 2013-10-09 13:14:09 -0700 All reviewed patches have been landed. Closing bug. 206623 2013-07-13 16:39:49 -0700 2013-08-02 05:11:24 -0700 Patch bug-118650-20130713193743.patch text/plain 2449 sergio U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTM2ZjMwYmExMDgyYTEy MTI3YWQ3OTcyYTFkZThiY2I0MjM5YjYxNS4uOTA4YjRiOWZlMGNiYTMwNTFjNGY4NGVkMDZhNjhl NDQ4NDIxNDA2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEzLTA3LTEzICBTZXJn aW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgQ29v cmRpbmF0ZWRHcmFwaGljczogU2V0IHNjZW5lIHRvIGFjdGl2ZSBpbiBXZWJWaWV3OjpwYWludFRv Q3VycmVudEdMQ29udGV4dCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTg2NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBQcmV2aW91c2x5LCB0aGUgc2NlbmUgd2FzIHNldCB0byBhY3RpdmUgaW4gV2Vi Vmlldzo6aW5pdGlhbGl6ZSgpLCBidXQgdGhlbgorICAgICAgICBpZiB0aGUgV2ViIFByb2Nlc3Mg Y3Jhc2hlZCBhbmQgd2UgbmVlZGVkIHRvIHJlY3JlYXRlIHRoZSBkcmF3aW5nIGFyZWEsIHZpYQor ICAgICAgICBXZWJQYWdlUHJveHk6OmluaXRpYWxpemVXZWJQYWdlKCksIGl0IHdvdWxkIGNyZWF0 ZSBhIG5ldyBzY2VuZSB3aGljaCB3b3VsZAorICAgICAgICBuZXZlciBiZSBzZXQgdG8gYWN0aXZl LCBhbmQgZnJvbSB0aGF0IHBvaW50IG9uLCB3ZSB3b3VsZCBvbmx5IGdldCBhIGJsYW5rCisgICAg ICAgIHZpZXcuCisKKyAgICAgICAgQSBzaW1wbGUgd2F5IHRvIHZlcmlmeSB0aGlzIGJlaGF2aW9y IG9uIHRoZSBFRkwgcG9ydCB3b3VsZCBiZSB0byBraWxsIHRoZQorICAgICAgICBXZWIgUHJvY2Vz czoKKworICAgICAgICAkIGtpbGxhbGwgV2ViUHJvY2VzcworCisgICAgICAgIEFmdGVyIHRoaXMs IHlvdSB3aWxsIG9ubHkgZ2V0IGEgYmxhbmsgdmlldy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9D b29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3 Ojppbml0aWFsaXplKTogRG8gbm90IHNldCBzY2VuZSB0byBhY3RpdmUgZHVyaW5nCisgICAgICAg IGluaXRpYWxpemF0aW9uLiBNb3ZlZCB0byBwYWludFRvQ3VycmVudEdMQ29udGV4dCgpLgorICAg ICAgICAoV2ViS2l0OjpXZWJWaWV3OjpwYWludFRvQ3VycmVudEdMQ29udGV4dCk6IFNldHRpbmcg dGhlIHNjZW5lIHRvCisgICAgICAgIGFjdGl2ZS4KKwogMjAxMy0wNy0xMCAgUm9nZXIgRm9uZyAg PHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFBsdWdpbnMgdGhhdCBkb24ndCBzdXBw b3J0IHNuYXBzaG90dGluZyBzaG91bGQgbm90IGFsbCBhdXRvc3RhcnQuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3Bw CmluZGV4IGUxYjQ0ZTBlNjRmMzc1MmY2YTA5YmYwZjEyMmUzOTc3NTE0Njc0ZGYuLmM3YjNjMDEw ZGM2YzAxODkxOWY0MGE5YzQ4MWQ5MTY1NjFkMzE2MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwCkBAIC03 Myw4ICs3Myw2IEBAIFdlYlZpZXc6On5XZWJWaWV3KCkKIHZvaWQgV2ViVmlldzo6aW5pdGlhbGl6 ZSgpCiB7CiAgICAgbV9wYWdlLT5pbml0aWFsaXplV2ViUGFnZSgpOwotICAgIGlmIChDb29yZGlu YXRlZEdyYXBoaWNzU2NlbmUqIHNjZW5lID0gY29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lKCkpCi0g ICAgICAgIHNjZW5lLT5zZXRBY3RpdmUodHJ1ZSk7CiB9CiAKIHZvaWQgV2ViVmlldzo6c2V0U2l6 ZShjb25zdCBXZWJDb3JlOjpJbnRTaXplJiBzaXplKQpAQCAtMTMxLDYgKzEyOSw4IEBAIHZvaWQg V2ViVmlldzo6cGFpbnRUb0N1cnJlbnRHTENvbnRleHQoKQogICAgIGlmICghc2NlbmUpCiAgICAg ICAgIHJldHVybjsKIAorICAgIHNjZW5lLT5zZXRBY3RpdmUodHJ1ZSk7CisKICAgICAvLyBGSVhN RTogV2UgbmVlZCB0byBjbGVhbiB1cCB0aGlzIGNvZGUgYXMgaXQgaXMgc3BsaXQgb3ZlciBDb29y ZEdmeCBhbmQgUGFnZS4KICAgICBzY2VuZS0+c2V0RHJhd3NCYWNrZ3JvdW5kKG1fcGFnZS0+ZHJh d3NCYWNrZ3JvdW5kKCkpOwogICAgIGNvbnN0IEZsb2F0UmVjdCYgdmlld3BvcnQgPSBtX3VzZXJW aWV3cG9ydFRyYW5zZm9ybS5tYXBSZWN0KEludFJlY3QoSW50UG9pbnQoKSwgbV9zaXplKSk7Cg== 208004 2013-08-02 05:11:31 -0700 2013-10-09 13:14:06 -0700 Adding WKViewSetIsAtive to ViewClientEfl bug-118650-20130802081127.patch text/plain 2173 sergio U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmFmOWZhZWJjMmYxYTE3 ZGJiYWNmMzJkMmFjYTE4Y2RhMjA5NzY1NS4uOGRkYTFjMDJlZDg4OGJmMTBmZWEwODRhMjc5MzVl MGRmNzYxNmFkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA4LTAyICBTZXJn aW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgU2V0 IHZpZXcgdG8gYWN0aXZlIGluIFZpZXdDbGllbnRFZmwgYWZ0ZXIgV2ViUHJvY2VzcyBoYXMgcmVs YXVuY2hlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE4NjUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg T25jZSBXZWJQcm9jZXNzIHJlbGF1bmNoZXMsIHRoZSB1bmRlcmx5aW5nIHNjZW5lIGZyb20gdGhl IHZpZXcgaXMgcmVjcmVhdGVkCisgICAgICAgIGFuZCBpcyBub3QgYWN0aXZlIGJ5IGRlZmF1bHQs IHdoaWNoIG1lYW5zIGl0IHdpbGwgYmUgaW4gYGJhY2tncm91bmQnLiBJbgorICAgICAgICBwcmFj dGljZSwgZnJvbSB0aGF0IHBvaW50IG9uIHdlIGFyZSBnb2luZyB0byBnZXQgYSBibGFuayBzY3Jl ZW4sIHVubGVzcyB3ZQorICAgICAgICBzZXQgaXQgdG8gYWN0aXZlLgorCisgICAgICAgIEluIHRo ZSBub3JtYWwgZmxvdywgdGhlIHZpZXcgaXMgc2V0IHRvIGFjdGl2ZSBkdXJpbmcgaXRzIGluaXRp YWxpemF0aW9uOyB0aGlzCisgICAgICAgIHBhdGNoIHNldHMgaXQgdG8gYWN0aXZlIGFsc28gaW4g Vmlld0NsaWVudEVmbCwgaW4gdGhlIHdlYlByb2Nlc3NEaWRSZWxhdW5jaAorICAgICAgICBjYWxs YmFjay4KKworICAgICAgICAqIFVJUHJvY2Vzcy9lZmwvVmlld0NsaWVudEVmbC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OlZpZXdDbGllbnRFZmw6OndlYlByb2Nlc3NEaWRSZWxhdW5jaCk6IEFkZGVk IFdLVmlld1NldElzQWN0aXZlIGNhbGwuCisKIDIwMTMtMDgtMDEgIFJ1dGggRm9uZyAgPHJ1dGhf Zm9uZ0BhcHBsZS5jb20+CiAKICAgICAgICAgW0Zvcm1zOiBjb2xvcl0gPGlucHV0IHR5cGU9J2Nv bG9yJz4gcG9wb3ZlciBjb2xvciB3ZWxsIGltcGxlbWVudGF0aW9uCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1ZpZXdDbGllbnRFZmwuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2VmbC9WaWV3Q2xpZW50RWZsLmNwcAppbmRleCBlMTQyMTRmYTQ5Y2MzY2Q3 Yjc4ZGQ0YzJlZTViYmEzZTQ0MTNjMWU2Li43ZWFiMTRiOTdmNjVlYmQ1Y2Q2OGFjNTFhZDZhZDYw YTE0MzA1ZjVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1ZpZXdD bGllbnRFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvVmlld0NsaWVu dEVmbC5jcHAKQEAgLTkwLDYgKzkwLDEwIEBAIHZvaWQgVmlld0NsaWVudEVmbDo6d2ViUHJvY2Vz c0NyYXNoZWQoV0tWaWV3UmVmLCBXS1VSTFJlZiB1cmwsIGNvbnN0IHZvaWQqIGNsaWVuCiAKIHZv aWQgVmlld0NsaWVudEVmbDo6d2ViUHJvY2Vzc0RpZFJlbGF1bmNoKFdLVmlld1JlZiB2aWV3UmVm LCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQogeworICAgIC8vIFdlYlByb2Nlc3MganVzdCByZWxh dW5jaGVkIGFuZCB0aGUgdW5kZXJseWluZyBzY2VuZSBmcm9tIHRoZSB2aWV3IGlzIG5vdCBzZXQg dG8gYWN0aXZlIGJ5IGRlZmF1bHQsIHdoaWNoCisgICAgLy8gbWVhbnMgZnJvbSB0aGF0IHBvaW50 IG9uIHdlIHdvdWxkIG9ubHkgZ2V0IGEgYmxhbmsgc2NyZWVuLCBoZW5jZSB3ZSBzZXQgaXQgdG8g YWN0aXZlIGhlcmUgdG8gYXZvaWQgdGhhdC4KKyAgICBXS1ZpZXdTZXRJc0FjdGl2ZSh2aWV3UmVm LCB0cnVlKTsKKwogICAgIGlmIChjb25zdCBjaGFyKiB0aGVtZVBhdGggPSB0b0V3a1ZpZXcoY2xp ZW50SW5mbyktPnRoZW1lUGF0aCgpKQogICAgICAgICBXS1ZpZXdTZXRUaGVtZVBhdGgodmlld1Jl ZiwgYWRvcHRXSyhXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyh0aGVtZVBhdGgpKS5nZXQo KSk7CiB9Cg==