<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>118639</bug_id>
          
          <creation_ts>2013-07-12 23:56:50 -0700</creation_ts>
          <short_desc>A (column) flexbox should take min-height into account for sizing</short_desc>
          <delta_ts>2022-08-26 01:28:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>CONFIGURATION CHANGED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>BlinkMergeCandidate</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ahmad.saleem792</cc>
    
    <cc>ap</cc>
    
    <cc>bdakin</cc>
    
    <cc>bfulgham</cc>
    
    <cc>dino</cc>
    
    <cc>hyatt</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>908139</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-07-12 23:56:50 -0700</bug_when>
    <thetext>Consider merging https://chromium.googlesource.com/chromium/blink/+/1a8ed26a737c8eb3544e5241d638c872f2a0058a

Per http://dev.w3.org/csswg/css-flexbox/#intrinsic-sizes

&quot;The max-content main size of a flex container is the sum of the flex
container&apos;s items&apos; max-content contributions. The min-content main size
of a single-line flex container is the sum of the flex container&apos;s
items&apos; min-content contributions&quot;

&quot;The main-size min-content/max-content contribution of a flex item is
its outer hypothetical main size when sized under a
min-content/max-content constraint (respectively).&quot;

plus 9.2:
&quot;The hypothetical main size is the item&apos;s flex base size clamped
according to its min and max main size properties.&quot;

Therefore, when we calculate containerMainInnerSize, we should use
sumHypotheticalMainSize instead of sumFlexBaseSize.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1893939</commentid>
    <comment_count>1</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-08-26 01:28:45 -0700</bug_when>
    <thetext>This patch is not required because Webkit GitHub Code already matches with this one:

https://github.com/WebKit/WebKit/blob/4ccdb2ac7f7c989dd9d92ec1c42dccc44ef21b6a/Source/WebCore/rendering/RenderFlexibleBox.cpp#

LayoutUnit containerMainInnerSize = mainAxisContentExtent(sumHypotheticalMainSize);

I am going to mark this as &quot;RESOLVED CONFIGURATION CHANGED&quot;. Thanks!</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>