<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>118638</bug_id>
          
          <creation_ts>2013-07-12 23:50:12 -0700</creation_ts>
          <short_desc>Flexbox: Rename various variables and arguments to match the naming from the spec</short_desc>
          <delta_ts>2024-01-02 11:02:45 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>168657</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>BlinkMergeCandidate</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ahmad.saleem792</cc>
    
    <cc>bdakin</cc>
    
    <cc>dino</cc>
    
    <cc>hyatt</cc>
    
    <cc>sgill26</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>908138</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-07-12 23:50:12 -0700</bug_when>
    <thetext>Consider merging https://chromium.googlesource.com/chromium/blink/+/4a723f1500205a05096946476bdc84b56a24f90f

This should make it easier to understand the code. I have also
simplified some calculations and gave some expressions their own
variables.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1985134</commentid>
    <comment_count>1</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2023-10-14 12:42:25 -0700</bug_when>
    <thetext>@Sam - is this applicable anymore?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1985719</commentid>
    <comment_count>2</comment_count>
    <who name="Sammy Gill">sgill26</who>
    <bug_when>2023-10-17 16:19:04 -0700</bug_when>
    <thetext>Looking at both the patch in question and the current code I don&apos;t think so. Looks like we merged in those changes and some others when we rebased the flex code off of Blink&apos;s ToT a while ago: https://bugs.webkit.org/show_bug.cgi?id=168657</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2002561</commentid>
    <comment_count>3</comment_count>
    <who name="Sammy Gill">sgill26</who>
    <bug_when>2024-01-02 11:02:45 -0800</bug_when>
    <thetext>Going to go ahead and resolve this since it was already taken care of by the rebase we did a while back

*** This bug has been marked as a duplicate of bug 168657 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>