118637 2013-07-12 23:35:27 -0700 Add a thread safety assertion when creating an AtomicString from a StringImpl 2013-07-17 16:36:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin cmarcelo commit-queue oldest_to_newest 908136 0 benjamin 2013-07-12 23:35:27 -0700 Add a thread safety assertion when creating an AtomicString from a StringImpl 908137 1 206594 benjamin 2013-07-12 23:46:43 -0700 Created attachment 206594 Patch 909513 2 206594 benjamin 2013-07-17 16:36:31 -0700 Comment on attachment 206594 Patch Clearing flags on attachment: 206594 Committed r152816: <http://trac.webkit.org/changeset/152816> 909514 3 benjamin 2013-07-17 16:36:33 -0700 All reviewed patches have been landed. Closing bug. 206594 2013-07-12 23:46:43 -0700 2013-07-17 16:36:31 -0700 Patch bug-118637-20130712234426.patch text/plain 3531 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDc4MTlkNGExZjExODI2ODM5OWJiMmY1 Mjk0NTlkNzk0ZjRkMGVlYzEuLmQwN2EyNDdlYTU2NDVkZmRmZmRjZjI3NzFmYjQxZjdkMDUxMzFm ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTMtMDctMTIgIEJlbmphbWluIFBvdWxhaW4gIDxi ZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBhIHRocmVhZCBzYWZldHkgYXNzZXJ0 aW9uIHdoZW4gY3JlYXRpbmcgYW4gQXRvbWljU3RyaW5nIGZyb20gYSBTdHJpbmdJbXBsCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg2MzcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZ29hbCBpcyB0 byBwcmV2ZW50IHRoaXMga2luZCBvZiB1c2U6CisgICAgICAgIC1Tb21lb25lIGNyZWF0ZSBhIFN0 cmluZyBmcm9tIGEgU3RyaW5nSW1wbC4KKyAgICAgICAgLUF0IHNvbWUgcG9pbnQsIHRoZSBzdHJp bmcgYmVjb21lcyBhdG9taWMuCisgICAgICAgIC1MYXRlciwgd2hlbiB0aGUgc3RyaW5nIG9ubHkg aGFzIG9uZSByZWYsIGl0cyBvd25lcnNoaXAgaXMgJ3Bhc3NlZCcgdG8gYW4gb3RoZXIgdGhyZWFk CisgICAgICAgICB3aXRob3V0IGNoZWNraW5nIFN0cmluZzo6aXNTYWZlVG9TZW5kVG9Bbm90aGVy VGhyZWFkKCkuCisgICAgICAgIC1JbiB0aGUgdGhyZWFkIEIsIGFuIEF0b21pY1N0cmluZyBpcyBj cmVhdGVkIGZyb20gdGhlIFN0cmluZy4KKyAgICAgICAgLT5UaGUgQXRvbWljU3RyaW5nJ3MgU3Ry aW5nSW1wbCByZXR1cm5lZCBpcyBub3QgaW4gdGhlIGN1cnJlbnQgdGhyZWFkIHN0cmluZyB0YWJs ZS4KKworICAgICAgICAqIHd0Zi90ZXh0L0F0b21pY1N0cmluZy5jcHA6CisgICAgICAgIChXVEY6 OkF0b21pY1N0cmluZzo6aXNJbkF0b21pY1N0cmluZ1RhYmxlKToKKyAgICAgICAgKiB3dGYvdGV4 dC9BdG9taWNTdHJpbmcuaDoKKyAgICAgICAgKFdURjo6QXRvbWljU3RyaW5nOjphZGQpOgorCiAy MDEzLTA3LTEyICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwu Y29tPgogCiAgICAgICAgIEltcHJvdmUgU3RyaW5nSW1wbDo6Y29uc3RydWN0SW50ZXJuYWwoKSBt ZXRob2QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcCBi L1NvdXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcAppbmRleCBlOTUyMjBiMTE5ZTk1 OThiNjRkNzNlYzQ1MmNlOWMxNDQ5MTFkYzAyLi4yYjE5MjQyMTljY2JmNjZiYmE3ZGFmYzcyZjEz MWMzNjk3ZWNkZjE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmlu Zy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwCkBAIC00NDcs NiArNDQ3LDE0IEBAIEF0b21pY1N0cmluZyBBdG9taWNTdHJpbmc6OmZyb21VVEY4SW50ZXJuYWwo Y29uc3QgY2hhciogY2hhcmFjdGVyc1N0YXJ0LCBjb25zdCBjCiAgICAgcmV0dXJuIGF0b21pY1N0 cmluZzsKIH0KIAorI2lmICFBU1NFUlRfRElTQUJMRUQKK2Jvb2wgQXRvbWljU3RyaW5nOjppc0lu QXRvbWljU3RyaW5nVGFibGUoU3RyaW5nSW1wbCogc3RyaW5nKQoreworICAgIEF0b21pY1N0cmlu Z1RhYmxlTG9ja2VyIGxvY2tlcjsKKyAgICByZXR1cm4gc3RyaW5nVGFibGUoKS5jb250YWlucyhz dHJpbmcpOworfQorI2VuZGlmCisKICNpZm5kZWYgTkRFQlVHCiB2b2lkIEF0b21pY1N0cmluZzo6 c2hvdygpIGNvbnN0CiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0 cmluZy5oIGIvU291cmNlL1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuaAppbmRleCAzZDdiNjU3 NmFjYWI5NDAxMDZiNTEyYWM2MTNhZGI0NzI3YmQ3MDk4Li5hNjNkNmMwOGQzYzg2M2IxNzJhZDc4 NjEzMmE1NjM3ODA5ZGZjZDczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21p Y1N0cmluZy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmgKQEAgLTE4 MiwxMSArMTgyLDEzIEBAIHByaXZhdGU6CiAgICAgV1RGX0VYUE9SVF9TVFJJTkdfQVBJIHN0YXRp YyBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IGFkZChjb25zdCBVQ2hhciosIHVuc2lnbmVkIGxlbmd0 aCwgdW5zaWduZWQgZXhpc3RpbmdIYXNoKTsKICAgICBXVEZfRVhQT1JUX1NUUklOR19BUEkgc3Rh dGljIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gYWRkKGNvbnN0IFVDaGFyKik7CiAgICAgV1RGX0VY UE9SVF9TVFJJTkdfQVBJIHN0YXRpYyBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IGFkZChTdHJpbmdJ bXBsKiwgdW5zaWduZWQgb2Zmc2V0LCB1bnNpZ25lZCBsZW5ndGgpOwotICAgIEFMV0FZU19JTkxJ TkUgc3RhdGljIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gYWRkKFN0cmluZ0ltcGwqIHIpCisgICAg QUxXQVlTX0lOTElORSBzdGF0aWMgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBhZGQoU3RyaW5nSW1w bCogc3RyaW5nKQogICAgIHsKLSAgICAgICAgaWYgKCFyIHx8IHItPmlzQXRvbWljKCkpCi0gICAg ICAgICAgICByZXR1cm4gcjsKLSAgICAgICAgcmV0dXJuIGFkZFNsb3dDYXNlKHIpOworICAgICAg ICBpZiAoIXN0cmluZyB8fCBzdHJpbmctPmlzQXRvbWljKCkpIHsKKyAgICAgICAgICAgIEFTU0VS VF9XSVRIX01FU1NBR0UoIXN0cmluZyB8fCBpc0luQXRvbWljU3RyaW5nVGFibGUoc3RyaW5nKSwg IlRoZSBhdG9taWMgc3RyaW5nIGNvbWVzIGZyb20gYW4gb3RoZXIgdGhyZWFkISIpOworICAgICAg ICAgICAgcmV0dXJuIHN0cmluZzsKKyAgICAgICAgfQorICAgICAgICByZXR1cm4gYWRkU2xvd0Nh c2Uoc3RyaW5nKTsKICAgICB9CiAgICAgV1RGX0VYUE9SVF9TVFJJTkdfQVBJIHN0YXRpYyBQYXNz UmVmUHRyPFN0cmluZ0ltcGw+IGFkZEZyb21MaXRlcmFsRGF0YShjb25zdCBjaGFyKiBjaGFyYWN0 ZXJzLCB1bnNpZ25lZCBsZW5ndGgpOwogICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQSSBzdGF0aWMg UGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBhZGRTbG93Q2FzZShTdHJpbmdJbXBsKik7CkBAIC0xOTUs NiArMTk3LDEwIEBAIHByaXZhdGU6CiAjZW5kaWYKIAogICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQ SSBzdGF0aWMgQXRvbWljU3RyaW5nIGZyb21VVEY4SW50ZXJuYWwoY29uc3QgY2hhciosIGNvbnN0 IGNoYXIqKTsKKworI2lmICFBU1NFUlRfRElTQUJMRUQKKyAgICBXVEZfRVhQT1JUX1NUUklOR19B UEkgc3RhdGljIGJvb2wgaXNJbkF0b21pY1N0cmluZ1RhYmxlKFN0cmluZ0ltcGwqKTsKKyNlbmRp ZgogfTsKIAogaW5saW5lIGJvb2wgb3BlcmF0b3I9PShjb25zdCBBdG9taWNTdHJpbmcmIGEsIGNv bnN0IEF0b21pY1N0cmluZyYgYikgeyByZXR1cm4gYS5pbXBsKCkgPT0gYi5pbXBsKCk7IH0K