118623 2013-07-12 16:13:26 -0700 [iOS] TextTrackRepresentation not cleared when captions are disabled 2013-07-12 16:51:16 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson commit-queue dino esprehn+autocc glenn jer.noble oldest_to_newest 908090 0 eric.carlson 2013-07-12 16:13:26 -0700 The early return from MediaControlTextTrackContainerElement::updateDisplay when captions are not visible prevents the TextTrackRepresentation from being cleared. 908092 1 206578 eric.carlson 2013-07-12 16:23:00 -0700 Created attachment 206578 Proposed patch 908097 2 eric.carlson 2013-07-12 16:37:00 -0700 committed r152607: http://trac.webkit.org/changeset/152607 206578 2013-07-12 16:23:00 -0700 2013-07-12 16:51:16 -0700 Proposed patch patch_1.txt text/plain 1488 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjYwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA3LTEyICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFRleHRUcmFj a1JlcHJlc2VudGF0aW9uIG5vdCBjbGVhcmVkIHdoZW4gY2FwdGlvbnMgYXJlIGRpc2FibGVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg2MjMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvc2hh ZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29u dHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQ6OnVwZGF0ZURpc3BsYXkpOiBEbyBub3QgcmV0 dXJuIGltbWVkaWF0ZWx5CisgICAgICAgICAgICB3aGVuIGNhcHRpb25zIGFyZSBkaXNhYmxlZCBz byB0aGUgbmVjZXNzYXJ5IGNsZWFudXAgaGFwcGVucy4KKwogMjAxMy0wNy0xMiAgQnJlbnQgRnVs Z2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luZG93c10gQXR0ZW1wdCB0 byBzYXRpc2Z5IHRoZSBPcGVuIFNvdXJjZSBXaW5kb3dzIGJvdHMuCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCShyZXZp c2lvbiAxNTI2MDYpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xF bGVtZW50cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMjcsMTAgKzEyMjcsOCBAQCBjb25zdCBB dG9taWNTdHJpbmcmIE1lZGlhQ29udHJvbFRleHRUcmFjCiAKIHZvaWQgTWVkaWFDb250cm9sVGV4 dFRyYWNrQ29udGFpbmVyRWxlbWVudDo6dXBkYXRlRGlzcGxheSgpCiB7Ci0gICAgaWYgKCFtZWRp YUNvbnRyb2xsZXIoKS0+Y2xvc2VkQ2FwdGlvbnNWaXNpYmxlKCkpIHsKKyAgICBpZiAoIW1lZGlh Q29udHJvbGxlcigpLT5jbG9zZWRDYXB0aW9uc1Zpc2libGUoKSkKICAgICAgICAgcmVtb3ZlQ2hp bGRyZW4oKTsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KIAogICAgIEhUTUxNZWRpYUVsZW1lbnQq IG1lZGlhRWxlbWVudCA9IHRvUGFyZW50TWVkaWFFbGVtZW50KHRoaXMpOwogICAgIC8vIDEuIElm IHRoZSBtZWRpYSBlbGVtZW50IGlzIGFuIGF1ZGlvIGVsZW1lbnQsIG9yIGlzIGFub3RoZXIgcGxh eWJhY2sK