118615 2013-07-12 14:36:02 -0700 Minor cleaning of AtomicString::addSlowCase 2013-07-15 01:08:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin cmarcelo commit-queue oldest_to_newest 908070 0 benjamin 2013-07-12 14:36:02 -0700 Minor cleaning of AtomicString::addSlowCase 908071 1 206573 benjamin 2013-07-12 14:36:53 -0700 Created attachment 206573 Patch 908074 2 206573 ggaren 2013-07-12 14:46:27 -0700 Comment on attachment 206573 Patch return statement is wrong. 908076 3 206574 benjamin 2013-07-12 14:51:17 -0700 Created attachment 206574 Patch 908078 4 206574 ggaren 2013-07-12 14:55:49 -0700 Comment on attachment 206574 Patch r=me 908326 5 benjamin 2013-07-15 01:08:45 -0700 Committed r152625: <http://trac.webkit.org/changeset/152625> 206573 2013-07-12 14:36:53 -0700 2013-07-12 14:51:15 -0700 Patch bug-118615-20130712143436.patch text/plain 2015 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDc4MTlkNGExZjExODI2ODM5OWJiMmY1 Mjk0NTlkNzk0ZjRkMGVlYzEuLjcyZTdiZDE3NTA3MzY1OGI1ZDc5MGJiM2MzMTQzNWVlNTAzOTQ4 MmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDctMTIgIEJlbmphbWluIFBvdWxhaW4gIDxi ZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIE1pbm9yIGNsZWFuaW5nIG9mIEF0b21pY1N0 cmluZzo6YWRkU2xvd0Nhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExODYxNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEdpdmUgdGhlIHZhcmlhYmxlIGEgcHJvcGVyIG5hbWUuCisgICAgICAgIEFkZCBh c3NlcnRpb25zIHRvIGNsYXJpZnkgdGhlIGluIGFuZCBvdXQgc3RhdGVzLgorCisgICAgICAgICog d3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcDoKKyAgICAgICAgKFdURjo6QXRvbWljU3RyaW5nOjph ZGRTbG93Q2FzZSk6CisKIDIwMTMtMDctMTIgIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwu cG96ZG55YWtvdkBpbnRlbC5jb20+CiAKICAgICAgICAgSW1wcm92ZSBTdHJpbmdJbXBsOjpjb25z dHJ1Y3RJbnRlcm5hbCgpIG1ldGhvZApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9B dG9taWNTdHJpbmcuY3BwIGIvU291cmNlL1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwCmlu ZGV4IGU5NTIyMGIxMTllOTU5OGI2NGQ3M2VjNDUyY2U5YzE0NDkxMWRjMDIuLjFhOWI4ZjViY2Ew MzJhMjE5ZWNhNzhhYTlkYjlhNTlhMjQzNjk4OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3Rm L3RleHQvQXRvbWljU3RyaW5nLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0 cmluZy5jcHAKQEAgLTM3NywxNiArMzc3LDIyIEBAIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gQXRv bWljU3RyaW5nOjphZGRGcm9tTGl0ZXJhbERhdGEoY29uc3QgY2hhciogY2hhcmFjdGVycywKICAg ICByZXR1cm4gYWRkVG9TdHJpbmdUYWJsZTxDaGFyQnVmZmVyLCBDaGFyQnVmZmVyRnJvbUxpdGVy YWxEYXRhVHJhbnNsYXRvcj4oYnVmZmVyKTsKIH0KIAotUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBB dG9taWNTdHJpbmc6OmFkZFNsb3dDYXNlKFN0cmluZ0ltcGwqIHIpCitQYXNzUmVmUHRyPFN0cmlu Z0ltcGw+IEF0b21pY1N0cmluZzo6YWRkU2xvd0Nhc2UoU3RyaW5nSW1wbCogc3RyaW5nKQogewot ICAgIGlmICghci0+bGVuZ3RoKCkpCisgICAgaWYgKCFzdHJpbmctPmxlbmd0aCgpKQogICAgICAg ICByZXR1cm4gU3RyaW5nSW1wbDo6ZW1wdHkoKTsKIAorICAgIEFTU0VSVF9XSVRIX01FU1NBR0Uo IXN0cmluZy0+aXNBdG9taWMoKSwgIkF0b21pY1N0cmluZyBzaG91bGQgbm90IGhpdCB0aGUgc2xv dyBjYXNlIGlmIHRoZSBzdHJpbmcgaXMgYWxyZWFkeSBhdG9taWMuIik7CisKICAgICBBdG9taWNT dHJpbmdUYWJsZUxvY2tlciBsb2NrZXI7Ci0gICAgU3RyaW5nSW1wbCogcmVzdWx0ID0gKnN0cmlu Z1RhYmxlKCkuYWRkKHIpLml0ZXJhdG9yOwotICAgIGlmIChyZXN1bHQgPT0gcikKLSAgICAgICAg ci0+c2V0SXNBdG9taWModHJ1ZSk7Ci0gICAgcmV0dXJuIHJlc3VsdDsKKyAgICBIYXNoU2V0PFN0 cmluZ0ltcGwqPjo6QWRkUmVzdWx0IGFkZFJlc3VsdCA9IHN0cmluZ1RhYmxlKCkuYWRkKHN0cmlu Zyk7CisKKyAgICBpZiAoYWRkUmVzdWx0LmlzTmV3RW50cnkpIHsKKyAgICAgICAgQVNTRVJUKCph ZGRSZXN1bHQuaXRlcmF0b3IgPT0gc3RyaW5nKTsKKyAgICAgICAgc3RyaW5nLT5zZXRJc0F0b21p Yyh0cnVlKTsKKyAgICB9CisKKyAgICByZXR1cm4gc3RyaW5nOwogfQogCiB0ZW1wbGF0ZTx0eXBl bmFtZSBDaGFyYWN0ZXJUeXBlPgo= 206574 2013-07-12 14:51:17 -0700 2013-07-12 14:55:49 -0700 Patch bug-118615-20130712144900.patch text/plain 2028 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDc4MTlkNGExZjExODI2ODM5OWJiMmY1 Mjk0NTlkNzk0ZjRkMGVlYzEuLjcyZTdiZDE3NTA3MzY1OGI1ZDc5MGJiM2MzMTQzNWVlNTAzOTQ4 MmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDctMTIgIEJlbmphbWluIFBvdWxhaW4gIDxi ZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIE1pbm9yIGNsZWFuaW5nIG9mIEF0b21pY1N0 cmluZzo6YWRkU2xvd0Nhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExODYxNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEdpdmUgdGhlIHZhcmlhYmxlIGEgcHJvcGVyIG5hbWUuCisgICAgICAgIEFkZCBh c3NlcnRpb25zIHRvIGNsYXJpZnkgdGhlIGluIGFuZCBvdXQgc3RhdGVzLgorCisgICAgICAgICog d3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcDoKKyAgICAgICAgKFdURjo6QXRvbWljU3RyaW5nOjph ZGRTbG93Q2FzZSk6CisKIDIwMTMtMDctMTIgIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwu cG96ZG55YWtvdkBpbnRlbC5jb20+CiAKICAgICAgICAgSW1wcm92ZSBTdHJpbmdJbXBsOjpjb25z dHJ1Y3RJbnRlcm5hbCgpIG1ldGhvZApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9B dG9taWNTdHJpbmcuY3BwIGIvU291cmNlL1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwCmlu ZGV4IGU5NTIyMGIxMTllOTU5OGI2NGQ3M2VjNDUyY2U5YzE0NDkxMWRjMDIuLjc5NWI0YjA0OWIz Nzc2YWJlODY4N2U1ZTc0NmU4NGRjNzNkODZmNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3Rm L3RleHQvQXRvbWljU3RyaW5nLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0 cmluZy5jcHAKQEAgLTM3NywxNiArMzc3LDIyIEBAIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gQXRv bWljU3RyaW5nOjphZGRGcm9tTGl0ZXJhbERhdGEoY29uc3QgY2hhciogY2hhcmFjdGVycywKICAg ICByZXR1cm4gYWRkVG9TdHJpbmdUYWJsZTxDaGFyQnVmZmVyLCBDaGFyQnVmZmVyRnJvbUxpdGVy YWxEYXRhVHJhbnNsYXRvcj4oYnVmZmVyKTsKIH0KIAotUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBB dG9taWNTdHJpbmc6OmFkZFNsb3dDYXNlKFN0cmluZ0ltcGwqIHIpCitQYXNzUmVmUHRyPFN0cmlu Z0ltcGw+IEF0b21pY1N0cmluZzo6YWRkU2xvd0Nhc2UoU3RyaW5nSW1wbCogc3RyaW5nKQogewot ICAgIGlmICghci0+bGVuZ3RoKCkpCisgICAgaWYgKCFzdHJpbmctPmxlbmd0aCgpKQogICAgICAg ICByZXR1cm4gU3RyaW5nSW1wbDo6ZW1wdHkoKTsKIAorICAgIEFTU0VSVF9XSVRIX01FU1NBR0Uo IXN0cmluZy0+aXNBdG9taWMoKSwgIkF0b21pY1N0cmluZyBzaG91bGQgbm90IGhpdCB0aGUgc2xv dyBjYXNlIGlmIHRoZSBzdHJpbmcgaXMgYWxyZWFkeSBhdG9taWMuIik7CisKICAgICBBdG9taWNT dHJpbmdUYWJsZUxvY2tlciBsb2NrZXI7Ci0gICAgU3RyaW5nSW1wbCogcmVzdWx0ID0gKnN0cmlu Z1RhYmxlKCkuYWRkKHIpLml0ZXJhdG9yOwotICAgIGlmIChyZXN1bHQgPT0gcikKLSAgICAgICAg ci0+c2V0SXNBdG9taWModHJ1ZSk7Ci0gICAgcmV0dXJuIHJlc3VsdDsKKyAgICBIYXNoU2V0PFN0 cmluZ0ltcGwqPjo6QWRkUmVzdWx0IGFkZFJlc3VsdCA9IHN0cmluZ1RhYmxlKCkuYWRkKHN0cmlu Zyk7CisKKyAgICBpZiAoYWRkUmVzdWx0LmlzTmV3RW50cnkpIHsKKyAgICAgICAgQVNTRVJUKCph ZGRSZXN1bHQuaXRlcmF0b3IgPT0gc3RyaW5nKTsKKyAgICAgICAgc3RyaW5nLT5zZXRJc0F0b21p Yyh0cnVlKTsKKyAgICB9CisKKyAgICByZXR1cm4gKmFkZFJlc3VsdC5pdGVyYXRvcjsKIH0KIAog dGVtcGxhdGU8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4K