118608 2013-07-12 09:29:15 -0700 Remove some dead stores pointed out by the clang static analyzer 2013-07-12 17:00:38 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jberlin jberlin andersca jberlin oldest_to_newest 907983 0 jberlin 2013-07-12 09:29:15 -0700 When I run the clang static analyzer on the WebKit project on ToT (152591), it points out a number of dead stores. We should remove them. 907988 1 206551 jberlin 2013-07-12 09:51:41 -0700 Created attachment 206551 Patch 908105 2 206551 jberlin 2013-07-12 17:00:33 -0700 Comment on attachment 206551 Patch Committed in http://trac.webkit.org/changeset/152608 206551 2013-07-12 09:51:41 -0700 2013-07-12 17:00:32 -0700 Patch patch.patch text/plain 5661 jberlin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCAwZjMzNTcyLi40NDFhYmU4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjkgQEAKKzIwMTMtMDctMTIgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxl LmNvbT4KKworICAgICAgICBSZW1vdmUgc29tZSBkZWFkIHN0b3JlcyBwb2ludGVkIG91dCBieSB0 aGUgY2xhbmcgc3RhdGljIGFuYWx5emVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NjA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBQbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdpbkhvc3RNYW5h Z2VyLm1tOgorICAgICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpbkhvc3RNYW5hZ2VyOjppbnN0 YW50aWF0ZVBsdWdpbik6CisgICAgICAgIGtyIGlzIG5ldmVyIHJlYWQgYWZ0ZXIgdGhpcyBwb2lu dCwgc28gdGhlcmUgaXMgbm8gcmVhc29uIHRvIGFzc2lnbiB0byBpdC4KKworICAgICAgICAqIFBs dWdpbnMvV2ViQmFzZVBsdWdpblBhY2thZ2UubW06CisgICAgICAgICgtW1dlYkJhc2VQbHVnaW5Q YWNrYWdlIGdldFBsdWdpbkluZm9Gcm9tUExpc3RzXSk6CisgICAgICAgIFRoZSBleHRlbnNpb25z IGFycmF5IGlzIG9ubHkgdXNlZCBpbiB0aGUgd2hpbGUgbG9vcC4gTW92ZSB0aGUgZGVjbGFyYXRp b24gdG8gdGhlIGZpcnN0IHBsYWNlCisgICAgICAgIGl0IGlzIHVzZWQgaW4gdGhlIHdoaWxlIGxv b3AuIFNpbmNlIGl0IGlzIGFsd2F5cyByZWFzc2lnbmVkIGF0IHRoYXQgbG9jYXRpb24sIGFuZCBz aW5jZSBpdAorICAgICAgICBpcyBuZXZlciByZWFkIGFmdGVyIHRoZSBzdWJzZXF1ZW50IGZvciBs b29wLCB0aGUgYXNzaWdubWVudCB0byBhbiBhcnJheSBjb250YWluaW5nIHRoZSBlbXB0eQorICAg ICAgICBzdHJpbmcgaXMgbmV2ZXIgdXNlZC4gUmVtb3ZlIGl0LgorICAgICAgICBTaW1pbGFybHks IHRoZSB2YWx1ZSBvZiB0aGUgZGVzY3JpcHRpb24gaXMgYWx3YXlzIG92ZXJ3cml0dGVuIGJlZm9y ZSB1c2VkIHRvIGFzc2lnbiB0bworICAgICAgICBtaW1lQ2xhc3NJbmZvLmRlc2Mgb3IgdG8gcGx1 Z2luSW5mby5kZXNjLCBzbyB0aGUgY29kZSB0byBhc3NpZ24gaXQgdG8gdGhlIGVtcHR5IHN0cmlu ZyBpcworICAgICAgICBuZXZlciB1c2VkLiBSZW1vdmUgaXQuCisKKyAgICAgICAgKiBXZWJWaWV3 L1dlYlRleHRDb21wbGV0aW9uQ29udHJvbGxlci5tbToKKyAgICAgICAgKC1bV2ViVGV4dENvbXBs ZXRpb25Db250cm9sbGVyIF9wbGFjZVBvcHVwV2luZG93Ol0pOgorICAgICAgICBtYXhXaWR0aCBp cyBuZXZlciByZWFkIChhbmQgbmV2ZXIgd2FzIHNpbmNlIGl0IHdhcyBhZGRlZCBpbiByNzMxMSkg YWZ0ZXIgaXQgaXMgdXNlZCBvbiB0aGUKKyAgICAgICAgbGluZSBhYm92ZSB0byBzZXQgd2luZG93 RnJhbWUuc2l6ZS53aWR0aC4KKwogMjAxMy0wNy0xMSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBw bGUuY29tPgogCiAgICAgICAgIFttYWNdIE5vIEFQSSBmb3IgZ2V0dGluZyB0aGUgcGFnZSB2aXNp YmlsaXR5IHN0YXRlIG9mIGEgV2ViVmlldwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMv UGx1Z2lucy9Ib3N0ZWQvTmV0c2NhcGVQbHVnaW5Ib3N0TWFuYWdlci5tbSBiL1NvdXJjZS9XZWJL aXQvbWFjL1BsdWdpbnMvSG9zdGVkL05ldHNjYXBlUGx1Z2luSG9zdE1hbmFnZXIubW0KaW5kZXgg ZWRmZWNiMS4uYjQ5NmU0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvUGx1Z2lucy9I b3N0ZWQvTmV0c2NhcGVQbHVnaW5Ib3N0TWFuYWdlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21h Yy9QbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdpbkhvc3RNYW5hZ2VyLm1tCkBAIC0yNjQsNyAr MjY0LDcgQEAgUGFzc1JlZlB0cjxOZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJveHk+IE5ldHNjYXBl UGx1Z2luSG9zdE1hbmFnZXI6Omluc3RhbnRpYXRlUGwKICAgICAgICAgLy8gQ3JlYXRlIGEgbmV3 IGluc3RhbmNlLgogICAgICAgICBpbnN0YW5jZSA9IE5ldHNjYXBlUGx1Z2luSW5zdGFuY2VQcm94 eTo6Y3JlYXRlKGhvc3RQcm94eSwgcGx1Z2luVmlldywgZnVsbEZyYW1lKTsKICAgICAgICAgcmVx dWVzdElEID0gaW5zdGFuY2UtPm5leHRSZXF1ZXN0SUQoKTsKLSAgICAgICAga3IgPSBfV0tQSElu c3RhbnRpYXRlUGx1Z2luKGhvc3RQcm94eS0+cG9ydCgpLCByZXF1ZXN0SUQsICh1aW50OF90Kilb ZGF0YSBieXRlc10sIFtkYXRhIGxlbmd0aF0sIGluc3RhbmNlLT5wbHVnaW5JRCgpKTsKKyAgICAg ICAgX1dLUEhJbnN0YW50aWF0ZVBsdWdpbihob3N0UHJveHktPnBvcnQoKSwgcmVxdWVzdElELCAo dWludDhfdCopW2RhdGEgYnl0ZXNdLCBbZGF0YSBsZW5ndGhdLCBpbnN0YW5jZS0+cGx1Z2luSUQo KSk7CiAgICAgfQogCiAgICAgc3RkOjphdXRvX3B0cjxOZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJv eHk6Okluc3RhbnRpYXRlUGx1Z2luUmVwbHk+IHJlcGx5ID0gaW5zdGFuY2UtPndhaXRGb3JSZXBs eTxOZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJveHk6Okluc3RhbnRpYXRlUGx1Z2luUmVwbHk+KHJl cXVlc3RJRCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9QbHVnaW5zL1dlYkJhc2VQ bHVnaW5QYWNrYWdlLm1tIGIvU291cmNlL1dlYktpdC9tYWMvUGx1Z2lucy9XZWJCYXNlUGx1Z2lu UGFja2FnZS5tbQppbmRleCBhN2IzOWU1Li5kNDUyYTRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L21hYy9QbHVnaW5zL1dlYkJhc2VQbHVnaW5QYWNrYWdlLm1tCisrKyBiL1NvdXJjZS9XZWJL aXQvbWFjL1BsdWdpbnMvV2ViQmFzZVBsdWdpblBhY2thZ2UubW0KQEAgLTIxMiw4ICsyMTIsNyBA QCAtIChCT09MKWdldFBsdWdpbkluZm9Gcm9tUExpc3RzCiAKICAgICBOU0VudW1lcmF0b3IgKmtl eUVudW1lcmF0b3IgPSBbTUlNRVR5cGVzIGtleUVudW1lcmF0b3JdOwogICAgIE5TRGljdGlvbmFy eSAqTUlNRURpY3Rpb25hcnk7Ci0gICAgTlNTdHJpbmcgKk1JTUUsICpkZXNjcmlwdGlvbjsKLSAg ICBOU0FycmF5ICpleHRlbnNpb25zOworICAgIE5TU3RyaW5nICpNSU1FOwogCiAgICAgd2hpbGUg KChNSU1FID0gW2tleUVudW1lcmF0b3IgbmV4dE9iamVjdF0pICE9IG5pbCkgewogICAgICAgICBN SU1FRGljdGlvbmFyeSA9IFtNSU1FVHlwZXMgb2JqZWN0Rm9yS2V5Ok1JTUVdOwpAQCAtMjI1LDcg KzIyNCw3IEBAIC0gKEJPT0wpZ2V0UGx1Z2luSW5mb0Zyb21QTGlzdHMKIAogICAgICAgICBNaW1l Q2xhc3NJbmZvIG1pbWVDbGFzc0luZm87CiAgICAgICAgIAotICAgICAgICBleHRlbnNpb25zID0g W1tNSU1FRGljdGlvbmFyeSBvYmplY3RGb3JLZXk6V2ViUGx1Z2luRXh0ZW5zaW9uc0tleV0gX3dl Yl9sb3dlcmNhc2VTdHJpbmdzXTsKKyAgICAgICAgTlNBcnJheSAqZXh0ZW5zaW9ucyA9IFtbTUlN RURpY3Rpb25hcnkgb2JqZWN0Rm9yS2V5OldlYlBsdWdpbkV4dGVuc2lvbnNLZXldIF93ZWJfbG93 ZXJjYXNlU3RyaW5nc107CiAgICAgICAgIGZvciAoTlNVSW50ZWdlciBpID0gMDsgaSA8IFtleHRl bnNpb25zIGNvdW50XTsgKytpKSB7CiAgICAgICAgICAgICAvLyBUaGUgRGl2WCBwbHVnLWluIGxp c3RzIG11bHRpcGxlIGV4dGVuc2lvbnMgaW4gYSBjb21tYSBzZXBhcmF0ZWQgc3RyaW5nIGluc3Rl YWQgb2YgdXNpbmcKICAgICAgICAgICAgIC8vIG11bHRpcGxlIGFycmF5IGVsZW1lbnRzIGluIHRo ZSBwcm9wZXJ0eSBsaXN0LiBXb3JrIGFyb3VuZCB0aGlzIGhlcmUgYnkgc3BsaXR0aW5nIHRoZQpA QCAtMjM2LDE3ICsyMzUsMTEgQEAgLSAoQk9PTClnZXRQbHVnaW5JbmZvRnJvbVBMaXN0cwogICAg ICAgICAgICAgICAgIG1pbWVDbGFzc0luZm8uZXh0ZW5zaW9ucy5hcHBlbmQoZXh0ZW5zaW9uKTsK ICAgICAgICAgfQogCi0gICAgICAgIGlmIChbZXh0ZW5zaW9ucyBjb3VudF0gPT0gMCkKLSAgICAg ICAgICAgIGV4dGVuc2lvbnMgPSBbTlNBcnJheSBhcnJheVdpdGhPYmplY3Q6QCIiXTsKLQogICAg ICAgICBtaW1lQ2xhc3NJbmZvLnR5cGUgPSBTdHJpbmcoTUlNRSkubG93ZXIoKTsKIAotICAgICAg ICBkZXNjcmlwdGlvbiA9IFtNSU1FRGljdGlvbmFyeSBvYmplY3RGb3JLZXk6V2ViUGx1Z2luVHlw ZURlc2NyaXB0aW9uS2V5XTsKLSAgICAgICAgbWltZUNsYXNzSW5mby5kZXNjID0gZGVzY3JpcHRp b247CisgICAgICAgIG1pbWVDbGFzc0luZm8uZGVzYyA9IFtNSU1FRGljdGlvbmFyeSBvYmplY3RG b3JLZXk6V2ViUGx1Z2luVHlwZURlc2NyaXB0aW9uS2V5XTsKIAogICAgICAgICBwbHVnaW5JbmZv Lm1pbWVzLmFwcGVuZChtaW1lQ2xhc3NJbmZvKTsKLSAgICAgICAgaWYgKCFkZXNjcmlwdGlvbikK LSAgICAgICAgICAgIGRlc2NyaXB0aW9uID0gQCIiOwogICAgIH0KIAogICAgIE5TU3RyaW5nICpm aWxlbmFtZSA9IFsoTlNTdHJpbmcgKilwYXRoIGxhc3RQYXRoQ29tcG9uZW50XTsKQEAgLTI1Nyw3 ICsyNTAsNyBAQCAtIChCT09MKWdldFBsdWdpbkluZm9Gcm9tUExpc3RzCiAgICAgICAgIHRoZU5h bWUgPSBmaWxlbmFtZTsKICAgICBwbHVnaW5JbmZvLm5hbWUgPSB0aGVOYW1lOwogCi0gICAgZGVz Y3JpcHRpb24gPSBbc2VsZiBfb2JqZWN0Rm9ySW5mb0RpY3Rpb25hcnlLZXk6V2ViUGx1Z2luRGVz Y3JpcHRpb25LZXldOworICAgIE5TU3RyaW5nICpkZXNjcmlwdGlvbiA9IFtzZWxmIF9vYmplY3RG b3JJbmZvRGljdGlvbmFyeUtleTpXZWJQbHVnaW5EZXNjcmlwdGlvbktleV07CiAgICAgaWYgKCFk ZXNjcmlwdGlvbikKICAgICAgICAgZGVzY3JpcHRpb24gPSBmaWxlbmFtZTsKICAgICBwbHVnaW5J bmZvLmRlc2MgPSBkZXNjcmlwdGlvbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dl YlZpZXcvV2ViVGV4dENvbXBsZXRpb25Db250cm9sbGVyLm1tIGIvU291cmNlL1dlYktpdC9tYWMv V2ViVmlldy9XZWJUZXh0Q29tcGxldGlvbkNvbnRyb2xsZXIubW0KaW5kZXggZGJmNDhhZS4uNGQ3 NmRiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJUZXh0Q29tcGxl dGlvbkNvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJUZXh0 Q29tcGxldGlvbkNvbnRyb2xsZXIubW0KQEAgLTE0OCw3ICsxNDgsNiBAQCAtICh2b2lkKV9wbGFj ZVBvcHVwV2luZG93OihOU1BvaW50KXRvcExlZnQKICAgICAgICAgbWF4V2lkdGggPSBjZWlsZihb TlNXaW5kb3cgZnJhbWVSZWN0Rm9yQ29udGVudFJlY3Q6TlNNYWtlUmVjdCgwLjBmLCAwLjBmLCBt YXhXaWR0aCwgMTAwLjBmKSBzdHlsZU1hc2s6TlNCb3JkZXJsZXNzV2luZG93TWFza10uc2l6ZS53 aWR0aCk7CiAgICAgICAgIG1heFdpZHRoICs9IDUuMGY7CiAgICAgICAgIHdpbmRvd0ZyYW1lLnNp emUud2lkdGggPSBzdGQ6Om1heChtYXhXaWR0aCwgd2luZG93RnJhbWUuc2l6ZS53aWR0aCk7Ci0g ICAgICAgIG1heFdpZHRoID0gc3RkOjptaW48Q0dGbG9hdD4oNDAwLCB3aW5kb3dGcmFtZS5zaXpl LndpZHRoKTsKICAgICB9CiAgICAgW19wb3B1cFdpbmRvdyBzZXRGcmFtZTp3aW5kb3dGcmFtZSBk aXNwbGF5Ok5PXTsKICAgICAK