<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>118606</bug_id>
          
          <creation_ts>2013-07-12 08:23:39 -0700</creation_ts>
          <short_desc>[Win] R152573 broke Windows build</short_desc>
          <delta_ts>2013-07-12 14:11:32 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>118610</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zoltan Arvai">zarvai</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abrhm</cc>
    
    <cc>allan.jensen</cc>
    
    <cc>ggaren</cc>
    
    <cc>jturcotte</cc>
    
    <cc>kadam</cc>
    
    <cc>oliver</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>907971</commentid>
    <comment_count>0</comment_count>
    <who name="Zoltan Arvai">zarvai</who>
    <bug_when>2013-07-12 08:23:39 -0700</bug_when>
    <thetext>After http://trac.webkit.org/changeset/152573 Windows build is broken. 
There was a fix in http://trac.webkit.org/changeset/152577, but some problem remained:

JITThunks.cpp
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(383) : error C2066: cast to function type is illegal
        C:\buildslave\qt-windows-32bit-release\build\Source\JavaScriptCore\jit\JITThunks.cpp(84) : see reference to function template instantiation &apos;std::pair&lt;_Ty1,_Ty2&gt; std::make_pair&lt;JSC::EncodedJSValue(__fastcall *&amp;)(JSC::ExecState *),JSC::EncodedJSValue(JSC::ExecState *)&gt;(__int64,_Ty2 (__fastcall &amp;))&apos; being compiled
        with
        [
            _Ty1=__int64 (__fastcall *)(JSC::ExecState *),
            _Ty2=__int64 (JSC::ExecState *)
        ]
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(254) : error C3867: &apos;std::_Pair_base&lt;_Ty1,_Ty2&gt;::second&apos;: function call missing argument list; use &apos;&amp;std::_Pair_base&lt;_Ty1,_Ty2&gt;::second&apos; to create a pointer to member
        with
        [
            _Ty1=__int64 (__fastcall *)(JSC::ExecState *),
            _Ty2=__int64 (JSC::ExecState *)
        ]
        C:\buildslave\qt-windows-32bit-release\build\Source\JavaScriptCore\jit\JITThunks.cpp(84) : see reference to function template instantiation &apos;std::pair&lt;_Ty1,_Ty2&gt;::pair&lt;__int64(__fastcall *)(JSC::ExecState *),__int64(JSC::ExecState *)&gt;(std::pair&lt;_Ty1,__int64 (JSC::ExecState *)&gt; &amp;&amp;)&apos; being compiled
        with
        [
            _Ty1=JSC::NativeFunction,
            _Ty2=JSC::NativeFunction
        ]

The following bots are affected:
Apple Win Debug (Build) http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/68295/steps/compile-webkit/logs/stdio
Apple Win Release (Build) http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/50133/steps/compile-webkit/logs/stdio
Qt Windows http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Release/builds/66798/steps/compile-webkit/logs/stdio

Could you check it, please?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>908063</commentid>
    <comment_count>1</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2013-07-12 14:11:32 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 118610 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>