118603 2013-07-12 07:42:21 -0700 [jhbuild] Avoid restarting from scratch failed initial checkouts 2013-07-12 13:06:10 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 emanuele.aina webkit-unassigned commit-queue gustavo mrobinson oldest_to_newest 907960 0 206546 emanuele.aina 2013-07-12 07:42:21 -0700 Created attachment 206546 Patch If the initial checkout is interrupted midway (eg. because the internet connection went down) config files do not get generated and that causes the next checkout to start from scratch (the missing files cause the script to delete the build root and the downloaded sources). By generating the files before invoking jhbuild, subsequent runs are able to start where the previous run left. 907963 1 commit-queue 2013-07-12 07:44:44 -0700 Attachment 206546 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/update-webkit-libs-jhbuild']" exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 907969 2 206546 mrobinson 2013-07-12 08:12:19 -0700 Comment on attachment 206546 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206546&action=review > Tools/ChangeLog:3 > + [jhbuild] Avoid restarting from scratch failed initial checkouts Looks good to me other than the missing bug URL here. 907974 3 emanuele.aina 2013-07-12 08:54:17 -0700 (In reply to comment #2) > Looks good to me other than the missing bug URL here. Yup, I used `webkit-patch create-bug` for the upload assuming that it was going to automagically take care somewhat of this as `git bz` does, but does not seems to be the case. Knowing this I wonder about the usefulness `webkit-patch create-bug`... However, I'll upload a fixed patch in a minute. Thanks for the review! 907975 4 206549 emanuele.aina 2013-07-12 08:54:59 -0700 Created attachment 206549 Patch 907977 5 206549 commit-queue 2013-07-12 09:03:55 -0700 Comment on attachment 206549 Patch Rejecting attachment 206549 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 206549, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/1064127 907986 6 emanuele.aina 2013-07-12 09:38:58 -0700 (In reply to comment #5) > /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Martin, sorry for the newbieness, should I have added you to the Changelog entry in the "Reviewed by" line? Should I reupload the patch after adding "Reviewed by Martin Robinson."? 907997 7 mrobinson 2013-07-12 10:36:10 -0700 (In reply to comment #6) > (In reply to comment #5) > > /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). > > Martin, sorry for the newbieness, should I have added you to the Changelog entry in the "Reviewed by" line? > Should I reupload the patch after adding "Reviewed by Martin Robinson."? No worries. You can either leave the "Reviewed by OOPS" line or add "Reviewed by Martin Robinson." The commit-queue knows how to fill out the reviewer field (but not other OOPS types). 908002 8 emanuele.aina 2013-07-12 10:50:41 -0700 (In reply to comment #7) > > Martin, sorry for the newbieness, should I have added you to the Changelog entry in the "Reviewed by" line? > > Should I reupload the patch after adding "Reviewed by Martin Robinson."? > > No worries. You can either leave the "Reviewed by OOPS" line or add "Reviewed by Martin Robinson." The commit-queue knows how to fill out the reviewer field (but not other OOPS types). Oh, I see, I removed the OOPS not knowing how the magic was supposed to work. :/ I'll upload the patch with "Reviewed by Martin Robinson." in a moment. Thanks! 908005 9 206555 emanuele.aina 2013-07-12 10:53:03 -0700 Created attachment 206555 Patch Added missing 'Reviewed by' line to the ChangeLog 908050 10 206555 commit-queue 2013-07-12 13:06:07 -0700 Comment on attachment 206555 Patch Clearing flags on attachment: 206555 Committed r152605: <http://trac.webkit.org/changeset/152605> 908051 11 commit-queue 2013-07-12 13:06:10 -0700 All reviewed patches have been landed. Closing bug. 206546 2013-07-12 07:42:21 -0700 2013-07-12 08:54:51 -0700 Patch 20130712144003.patch text/plain 1617 emanuele.aina U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNTg0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTcwMzkxMTg3ZTQxOTg3M2I2ZWU1MjZlZjE3OTVlYWMw NmUyODQ0ZS4uYjU4ZGM5ODRiNGRhMGY4MGMzNTBhYzZiMWUxYWZkZTNjMjJjMTM1NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEzLTA3LTEyICBFbWFudWVsZSBBaW5hICA8ZW1hbnVlbGUuYWluYUBjb2xsYWJvcmEu Y29tPgorCisgICAgICAgIFtqaGJ1aWxkXSBBdm9pZCByZXN0YXJ0aW5nIGZyb20gc2NyYXRjaCBm YWlsZWQgaW5pdGlhbCBjaGVja291dHMKKworICAgICAgICBJZiB0aGUgaW5pdGlhbCBjaGVja291 dCBpcyBpbnRlcnJ1cHRlZCBtaWR3YXkgKGVnLiBiZWNhdXNlIHRoZSBpbnRlcm5ldAorICAgICAg ICBjb25uZWN0aW9uIHdlbnQgZG93bikgY29uZmlnIGZpbGVzIGRvIG5vdCBnZXQgZ2VuZXJhdGVk IGFuZCB0aGF0IGNhdXNlcworICAgICAgICB0aGUgbmV4dCBjaGVja291dCB0byBzdGFydCBmcm9t IHNjcmF0Y2ggKHRoZSBtaXNzaW5nIGZpbGVzIGNhdXNlIHRoZQorICAgICAgICBzY3JpcHQgdG8g ZGVsZXRlIHRoZSBidWlsZCByb290IGFuZCB0aGUgZG93bmxvYWRlZCBzb3VyY2VzKS4KKworICAg ICAgICBCeSBnZW5lcmF0aW5nIHRoZSBmaWxlcyBiZWZvcmUgaW52b2tpbmcgamhidWlsZCwgc3Vi c2VxdWVudCBydW5zIGFyZSBhYmxlCisgICAgICAgIHRvIHN0YXJ0IHdoZXJlIHRoZSBwcmV2aW91 cyBydW4gbGVmdC4KKworICAgICAgICAqIFNjcmlwdHMvdXBkYXRlLXdlYmtpdC1saWJzLWpoYnVp bGQ6CisgICAgICAgIChzYXZlSmhidWlsZE1kNSk6IGludm9rZSBpdCBiZWZvcmUgcnVuSmhidWls ZCgpLgorCiAyMDEzLTA3LTEwICBTZXJnaW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5i b3NzYS5vcmc+CiAKICAgICAgICAgSGFuZGxlICJsb2FkLHByb3Zpc2lvbmFsLGZhaWxlZCIgd2l0 aCB0aGUgb25fZXJyb3IgY2FsbGJhY2sgb24gRUZMIE1pbmlCcm93c2VyCmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtbGlicy1qaGJ1aWxkIGIvVG9vbHMvU2NyaXB0cy91 cGRhdGUtd2Via2l0LWxpYnMtamhidWlsZAppbmRleCBhMTQ4ODg3NmE5NWFmYzBjODRkMGNlMjJm YTY0NjI0NWU0ZDk4ODUyLi43NGRkN2I2YzViMGY2OThhZDFiODc1YmZjMmJmOTk5MDhkMDU2NjEx IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtbGlicy1qaGJ1aWxkCisr KyBiL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1saWJzLWpoYnVpbGQKQEAgLTEyNCw3ICsx MjQsNyBAQCBpZiAoLWUgZ2V0SmhidWlsZFBhdGgoKSAmJiBqaGJ1aWxkQ29uZmlndXJhdGlvbkNo YW5nZWQoKSkgewogICAgIGNsZWFuSmhidWlsZCgpOwogfQogCitzYXZlSmhidWlsZE1kNSgpOwor CiBwcmludCAiVXBkYXRpbmcgIiAuICRwcmV0dHlQbGF0Zm9ybXskcGxhdGZvcm19IC4gIiBwb3J0 IGRlcGVuZGVuY2llcyB1c2luZyBqaGJ1aWxkLi4uXG4iOwogcnVuSmhidWlsZCgiYnVpbGQiKTsK LQotc2F2ZUpoYnVpbGRNZDUoKTsK 206549 2013-07-12 08:54:59 -0700 2013-07-12 10:52:54 -0700 Patch bug-118603-20130712155241.patch text/plain 1673 emanuele.aina U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNTg0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTcwMzkxMTg3ZTQxOTg3M2I2ZWU1MjZlZjE3OTVlYWMw NmUyODQ0ZS4uZDAxZDVmMTkwNmU2MDJhMjdjMGUyZThiOGI2YjQ1YTRkMWQ4NWNhOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEzLTA3LTEyICBFbWFudWVsZSBBaW5hICA8ZW1hbnVlbGUuYWluYUBjb2xsYWJvcmEu Y29tPgorCisgICAgICAgIFtqaGJ1aWxkXSBBdm9pZCByZXN0YXJ0aW5nIGZyb20gc2NyYXRjaCBm YWlsZWQgaW5pdGlhbCBjaGVja291dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExODYwMworCisgICAgICAgIElmIHRoZSBpbml0aWFsIGNoZWNrb3V0 IGlzIGludGVycnVwdGVkIG1pZHdheSAoZWcuIGJlY2F1c2UgdGhlIGludGVybmV0CisgICAgICAg IGNvbm5lY3Rpb24gd2VudCBkb3duKSBjb25maWcgZmlsZXMgZG8gbm90IGdldCBnZW5lcmF0ZWQg YW5kIHRoYXQgY2F1c2VzCisgICAgICAgIHRoZSBuZXh0IGNoZWNrb3V0IHRvIHN0YXJ0IGZyb20g c2NyYXRjaCAodGhlIG1pc3NpbmcgZmlsZXMgY2F1c2UgdGhlCisgICAgICAgIHNjcmlwdCB0byBk ZWxldGUgdGhlIGJ1aWxkIHJvb3QgYW5kIHRoZSBkb3dubG9hZGVkIHNvdXJjZXMpLgorCisgICAg ICAgIEJ5IGdlbmVyYXRpbmcgdGhlIGZpbGVzIGJlZm9yZSBpbnZva2luZyBqaGJ1aWxkLCBzdWJz ZXF1ZW50IHJ1bnMgYXJlIGFibGUKKyAgICAgICAgdG8gc3RhcnQgd2hlcmUgdGhlIHByZXZpb3Vz IHJ1biBsZWZ0LgorCisgICAgICAgICogU2NyaXB0cy91cGRhdGUtd2Via2l0LWxpYnMtamhidWls ZDoKKyAgICAgICAgKHNhdmVKaGJ1aWxkTWQ1KTogaW52b2tlIGl0IGJlZm9yZSBydW5KaGJ1aWxk KCkuCisKIDIwMTMtMDctMTAgIFNlcmdpbyBDb3JyZWlhICA8c2VyZ2lvLmNvcnJlaWFAb3BlbmJv c3NhLm9yZz4KIAogICAgICAgICBIYW5kbGUgImxvYWQscHJvdmlzaW9uYWwsZmFpbGVkIiB3aXRo IHRoZSBvbl9lcnJvciBjYWxsYmFjayBvbiBFRkwgTWluaUJyb3dzZXIKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1saWJzLWpoYnVpbGQgYi9Ub29scy9TY3JpcHRzL3Vw ZGF0ZS13ZWJraXQtbGlicy1qaGJ1aWxkCmluZGV4IGExNDg4ODc2YTk1YWZjMGM4NGQwY2UyMmZh NjQ2MjQ1ZTRkOTg4NTIuLjc0ZGQ3YjZjNWIwZjY5OGFkMWI4NzViZmMyYmY5OTkwOGQwNTY2MTEg MTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1saWJzLWpoYnVpbGQKKysr IGIvVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWxpYnMtamhidWlsZApAQCAtMTI0LDcgKzEy NCw3IEBAIGlmICgtZSBnZXRKaGJ1aWxkUGF0aCgpICYmIGpoYnVpbGRDb25maWd1cmF0aW9uQ2hh bmdlZCgpKSB7CiAgICAgY2xlYW5KaGJ1aWxkKCk7CiB9CiAKK3NhdmVKaGJ1aWxkTWQ1KCk7CisK IHByaW50ICJVcGRhdGluZyAiIC4gJHByZXR0eVBsYXRmb3JteyRwbGF0Zm9ybX0gLiAiIHBvcnQg ZGVwZW5kZW5jaWVzIHVzaW5nIGpoYnVpbGQuLi5cbiI7CiBydW5KaGJ1aWxkKCJidWlsZCIpOwot Ci1zYXZlSmhidWlsZE1kNSgpOwo= 206555 2013-07-12 10:53:03 -0700 2013-07-12 13:06:07 -0700 Patch bug-118603-20130712175046.patch text/plain 1713 emanuele.aina U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNTkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTcwMzkxMTg3ZTQxOTg3M2I2ZWU1MjZlZjE3OTVlYWMw NmUyODQ0ZS4uNDEwNjI4ZjU0YTVmYTFjMTYzMjg3OGE3OGJiMTMyM2Y4NjY4ZjlhMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEzLTA3LTEyICBFbWFudWVsZSBBaW5hICA8ZW1hbnVlbGUuYWluYUBjb2xsYWJvcmEu Y29tPgorCisgICAgICAgIFtqaGJ1aWxkXSBBdm9pZCByZXN0YXJ0aW5nIGZyb20gc2NyYXRjaCBm YWlsZWQgaW5pdGlhbCBjaGVja291dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExODYwMworCisgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2Jp bnNvbi4KKworICAgICAgICBJZiB0aGUgaW5pdGlhbCBjaGVja291dCBpcyBpbnRlcnJ1cHRlZCBt aWR3YXkgKGVnLiBiZWNhdXNlIHRoZSBpbnRlcm5ldAorICAgICAgICBjb25uZWN0aW9uIHdlbnQg ZG93bikgY29uZmlnIGZpbGVzIGRvIG5vdCBnZXQgZ2VuZXJhdGVkIGFuZCB0aGF0IGNhdXNlcwor ICAgICAgICB0aGUgbmV4dCBjaGVja291dCB0byBzdGFydCBmcm9tIHNjcmF0Y2ggKHRoZSBtaXNz aW5nIGZpbGVzIGNhdXNlIHRoZQorICAgICAgICBzY3JpcHQgdG8gZGVsZXRlIHRoZSBidWlsZCBy b290IGFuZCB0aGUgZG93bmxvYWRlZCBzb3VyY2VzKS4KKworICAgICAgICBCeSBnZW5lcmF0aW5n IHRoZSBmaWxlcyBiZWZvcmUgaW52b2tpbmcgamhidWlsZCwgc3Vic2VxdWVudCBydW5zIGFyZSBh YmxlCisgICAgICAgIHRvIHN0YXJ0IHdoZXJlIHRoZSBwcmV2aW91cyBydW4gbGVmdC4KKworICAg ICAgICAqIFNjcmlwdHMvdXBkYXRlLXdlYmtpdC1saWJzLWpoYnVpbGQ6CisgICAgICAgIChzYXZl SmhidWlsZE1kNSk6IGludm9rZSBpdCBiZWZvcmUgcnVuSmhidWlsZCgpLgorCiAyMDEzLTA3LTEw ICBTZXJnaW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAg ICAgSGFuZGxlICJsb2FkLHByb3Zpc2lvbmFsLGZhaWxlZCIgd2l0aCB0aGUgb25fZXJyb3IgY2Fs bGJhY2sgb24gRUZMIE1pbmlCcm93c2VyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3VwZGF0 ZS13ZWJraXQtbGlicy1qaGJ1aWxkIGIvVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWxpYnMt amhidWlsZAppbmRleCBhMTQ4ODg3NmE5NWFmYzBjODRkMGNlMjJmYTY0NjI0NWU0ZDk4ODUyLi43 NGRkN2I2YzViMGY2OThhZDFiODc1YmZjMmJmOTk5MDhkMDU2NjExIDEwMDc1NQotLS0gYS9Ub29s cy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtbGlicy1qaGJ1aWxkCisrKyBiL1Rvb2xzL1NjcmlwdHMv dXBkYXRlLXdlYmtpdC1saWJzLWpoYnVpbGQKQEAgLTEyNCw3ICsxMjQsNyBAQCBpZiAoLWUgZ2V0 SmhidWlsZFBhdGgoKSAmJiBqaGJ1aWxkQ29uZmlndXJhdGlvbkNoYW5nZWQoKSkgewogICAgIGNs ZWFuSmhidWlsZCgpOwogfQogCitzYXZlSmhidWlsZE1kNSgpOworCiBwcmludCAiVXBkYXRpbmcg IiAuICRwcmV0dHlQbGF0Zm9ybXskcGxhdGZvcm19IC4gIiBwb3J0IGRlcGVuZGVuY2llcyB1c2lu ZyBqaGJ1aWxkLi4uXG4iOwogcnVuSmhidWlsZCgiYnVpbGQiKTsKLQotc2F2ZUpoYnVpbGRNZDUo KTsK