118596 2013-07-12 04:56:36 -0700 [ATK] Leak: Leak in WebKitAccessibleTextGetText 2013-07-15 06:24:09 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 116317 0 brian.holt webkit-unassigned aboxhall apinheiro cfleizach cgarcia commit-queue dmazzoni jdiggs mario ocdude webkit-bug-importer oldest_to_newest 907907 0 brian.holt 2013-07-12 04:56:36 -0700 Many leaks found in tesktak using valgrind (this is one example): ==32735== 65 bytes in 1 blocks are definitely lost in loss record 8,278 of 12,167 ==32735== at 0x4C2B3F8: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==32735== by 0xA40AD10: g_malloc (gmem.c:159) ==32735== by 0xA42173B: g_strdup (gstrfuncs.c:364) ==32735== by 0x6713A39: _ZL27webkitAccessibleTextGetTextP8_AtkTextii (WebKitAccessibleInterfaceText.cpp:594) ==32735== by 0x6711EA5: _ZL21getGailTextUtilForAtkP8_AtkText (WebKitAccessibleInterfaceText.cpp:171) ==32735== by 0x6713CF6: _ZL36webkitAccessibleTextGetTextForOffsetP8_AtkTexti15AtkTextBoundary23GetTextRelativePositionPiS3_ (WebKitAccessibleInterfaceText.cpp:659) ==32735== by 0x6713DA3: _ZL35webkitAccessibleTextGetTextAtOffsetP8_AtkTexti15AtkTextBoundaryPiS2_ (WebKitAccessibleInterfaceText.cpp:673) ==32735== by 0x9F5FBD9: atk_text_get_text_at_offset (atktext.c:458) ==32735== by 0x402985: testGetTextFunction (testatk.c:102) ==32735== by 0x402E43: runGetTextTests (testatk.c:166) ==32735== by 0x408F03: testWebkitAtkGetTextAtOffset (testatk.c:776) ==32735== by 0xA427B1C: g_test_run_suite_internal (gtestutils.c:1714) ==32735== by 0xA427C95: g_test_run_suite_internal (gtestutils.c:1778) ==32735== by 0xA427C95: g_test_run_suite_internal (gtestutils.c:1778) ==32735== by 0xA427FF2: g_test_run_suite (gtestutils.c:1823) ==32735== by 0x4145AB: main (testatk.c:2115) ==32735== { <insert_a_suppression_name_here> Memcheck:Leak fun:malloc fun:g_malloc fun:g_strdup fun:_ZL27webkitAccessibleTextGetTextP8_AtkTextii fun:_ZL21getGailTextUtilForAtkP8_AtkText fun:_ZL36webkitAccessibleTextGetTextForOffsetP8_AtkTexti15AtkTextBoundary23GetTextRelativePositionPiS3_ fun:_ZL35webkitAccessibleTextGetTextAtOffsetP8_AtkTexti15AtkTextBoundaryPiS2_ fun:atk_text_get_text_at_offset fun:testGetTextFunction fun:runGetTextTests fun:testWebkitAtkGetTextAtOffset fun:g_test_run_suite_internal fun:g_test_run_suite_internal fun:g_test_run_suite_internal fun:g_test_run_suite fun:main } 907908 1 webkit-bug-importer 2013-07-12 04:57:01 -0700 <rdar://problem/14426403> 907938 2 206537 brian.holt 2013-07-12 06:38:28 -0700 Created attachment 206537 Patch 908341 3 206537 mario 2013-07-15 02:06:18 -0700 Comment on attachment 206537 Patch gail_util_text_setup() accepts a const gchar* and webkitAccessibleTextGetText() returns newly allocated memory, so this is a absolutely right. Thanks for the patch! 908377 4 206537 cgarcia 2013-07-15 05:52:23 -0700 Comment on attachment 206537 Patch Correct, it seems there's a similar leak in textExtents. 908381 5 brian.holt 2013-07-15 06:07:02 -0700 (In reply to comment #4) > (From update of attachment 206537 [details]) > Correct, it seems there's a similar leak in textExtents. It looks like that was fixed in https://bugs.webkit.org/show_bug.cgi?id=118248. Not sure why I missed the leak in addressed in this bug when I was working on that one! 908383 6 206537 commit-queue 2013-07-15 06:24:06 -0700 Comment on attachment 206537 Patch Clearing flags on attachment: 206537 Committed r152631: <http://trac.webkit.org/changeset/152631> 908384 7 commit-queue 2013-07-15 06:24:09 -0700 All reviewed patches have been landed. Closing bug. 206537 2013-07-12 06:38:28 -0700 2013-07-15 06:24:06 -0700 Patch bug-118596-20130712143626.patch text/plain 1645 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjllYTg5NjdhNDQ0Zjll Yzk1MzY2MmViOWM3ZDVlOWI2ZDdmYjIzZi4uNGI2YTYzYmZhNjVjY2IwNmEyYzRmOWVlYjNjYjBj YTcyODM3N2U4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA3LTEyICBCcmlh biBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKworICAgICAgICBbQVRLXSBMZWFrOiBM ZWFrIGluIFdlYktpdEFjY2Vzc2libGVUZXh0R2V0VGV4dAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgbWVtb3J5IGxlYWsuCisKKyAgICAgICAg KiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlSW50ZXJmYWNlVGV4dC5jcHA6Cisg ICAgICAgIChnZXRHYWlsVGV4dFV0aWxGb3JBdGspOgorCiAyMDEzLTA3LTExICBBbmRyZWkgQnVj dXIgIDxhYnVjdXJAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgUmVnaW9uc10gSW4gYSByZWdp b24gY2hhaW4gd2l0aCBhdXRvLWhlaWdodCByZWdpb25zLCBsaW5lcyBnZXQgdGhlaXIgbGVuZ3Ro IGJhc2VkIG9ubHkgb24gdGhlIGZpcnN0IHJlZ2lvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFjZVRleHQuY3BwIGIv U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFj ZVRleHQuY3BwCmluZGV4IDEyZTUxZTNjOTJlMzcwODM3MzJmNGJhOTdlZGIxOGFiZTgwMmM1NjIu LjU1Y2MxZjJjNDI1OWY1ZmVmYWMxMGJkYzhiMzNkNDBiOTY1ZDlhYmEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VU ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nl c3NpYmxlSW50ZXJmYWNlVGV4dC5jcHAKQEAgLTE2OCw3ICsxNjgsOCBAQCBzdGF0aWMgZ2NoYXIq IHdlYmtpdEFjY2Vzc2libGVUZXh0R2V0VGV4dChBdGtUZXh0KiwgZ2ludCBzdGFydE9mZnNldCwg Z2ludCBlbmRPZgogc3RhdGljIEdhaWxUZXh0VXRpbCogZ2V0R2FpbFRleHRVdGlsRm9yQXRrKEF0 a1RleHQqIHRleHRPYmplY3QpCiB7CiAgICAgR2FpbFRleHRVdGlsKiBnYWlsVGV4dFV0aWwgPSBn YWlsX3RleHRfdXRpbF9uZXcoKTsKLSAgICBnYWlsX3RleHRfdXRpbF90ZXh0X3NldHVwKGdhaWxU ZXh0VXRpbCwgd2Via2l0QWNjZXNzaWJsZVRleHRHZXRUZXh0KHRleHRPYmplY3QsIDAsIC0xKSk7 CisgICAgR093blB0cjxjaGFyPiB0ZXh0KHdlYmtpdEFjY2Vzc2libGVUZXh0R2V0VGV4dCh0ZXh0 T2JqZWN0LCAwLCAtMSkpOworICAgIGdhaWxfdGV4dF91dGlsX3RleHRfc2V0dXAoZ2FpbFRleHRV dGlsLCB0ZXh0LmdldCgpKTsKICAgICByZXR1cm4gZ2FpbFRleHRVdGlsOwogfQogCg==