118589 2013-07-12 02:07:14 -0700 Web Inspector: Pass null for sidebarPanels and role in WebInspector.Sidebar() 2013-07-12 05:46:37 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 0 seokju webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 907870 0 seokju 2013-07-12 02:07:14 -0700 sidebarPanels : It is necessary to get correct argument after r152141. Without this, error messages can be displayed. WebKit/WebKitBuild/Debug/share/ewebkit-0/WebInspectorUI/Sidebar.js:79: CONSOLEAPI ERROR: WebKit/WebKitBuild/Debug/share/ewebkit-0/WebInspectorUI/Sidebar.js:79: CONSOLEAPI ERROR: WebKit/WebKitBuild/Debug/share/ewebkit-0/WebInspectorUI/Sidebar.js:79: CONSOLEAPI ERROR: WebKit/WebKitBuild/Debug/share/ewebkit-0/WebInspectorUI/Sidebar.js:79: CONSOLEAPI ERROR: WebKit/WebKitBuild/Debug/share/ewebkit-0/WebInspectorUI/Sidebar.js:79: CONSOLEAPI ERROR: role : Could pass null for it since default value is "group". 907871 1 webkit-bug-importer 2013-07-12 02:07:48 -0700 <rdar://problem/14425513> 907872 2 206516 seokju 2013-07-12 02:11:08 -0700 Created attachment 206516 Patch 907916 3 206516 commit-queue 2013-07-12 05:46:35 -0700 Comment on attachment 206516 Patch Clearing flags on attachment: 206516 Committed r152588: <http://trac.webkit.org/changeset/152588> 907917 4 commit-queue 2013-07-12 05:46:37 -0700 All reviewed patches have been landed. Closing bug. 206516 2013-07-12 02:11:08 -0700 2013-07-12 05:46:35 -0700 Patch bug-118589-20130712180851.patch text/plain 2347 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 NjJiYmIxNzQ4OWE5NDgyYzU4ODQ5MDc2MzFmMGE1NDgyNDU4ZDk0Li41MzgwNjkzYzc4NjQ2OWQz NGVkNTljMmU4YzVhNDQ1NjdlYzRjNjQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMy0wNy0xMiAgU2Vva2p1IEt3b24gIDxzZW9ranUua3dvbkBnbWFpbC5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUGFzcyBudWxsIGZvciBzaWRlYmFyUGFuZWxz IGFuZCByb2xlIGluIFdlYkluc3BlY3Rvci5TaWRlYmFyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODU4OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHNpZGViYXJQYW5lbHMgOiBJdCBpcyBuZWNlc3Nh cnkgdG8gZ2V0IGNvcnJlY3QgYXJndW1lbnQgYWZ0ZXIgcjE1MjE0MS4KKyAgICAgICAgV2l0aG91 dCB0aGlzLCBlcnJvciBtZXNzYWdlcyBjYW4gYmUgZGlzcGxheWVkLgorICAgICAgICByb2xlIDog Q291bGQgcGFzcyBudWxsIGZvciBpdCBzaW5jZSBkZWZhdWx0IHZhbHVlIGlzICJncm91cCIuCisK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01haW4uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu Y29udGVudExvYWRlZCk6CisKIDIwMTMtMDctMDMgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlA YXBwbGUuY29tPgogCiAgICAgICAgIEd1YXJkIHJlbWFpbmluZyBjYWxscyB0byBkZWNvZGVVUklD b21wb25lbnQgd2l0aCBhIHRyeS9jYXRjaC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9NYWluLmpzCmluZGV4IGRmMGE4NTdhNjI2OGMzNGM0MGQyMmE4OTQ1YjRkMTg1NWYy Nzg0OWEuLjViNTg2ODAxNzVlN2IwOTMwZTc2ZDM3NmIwOTNmNjgwY2Y0NDI4ZDQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01haW4uanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTWFpbi5qcwpAQCAtMTY5LDcgKzE2OSw3 IEBAIFdlYkluc3BlY3Rvci5jb250ZW50TG9hZGVkID0gZnVuY3Rpb24oKQogICAgIHRoaXMubmF2 aWdhdGlvblNpZGViYXIuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuU2lkZWJhci5FdmVu dC5XaWR0aERpZENoYW5nZSwgdGhpcy5fc2lkZWJhcldpZHRoRGlkQ2hhbmdlLCB0aGlzKTsKICAg ICB0aGlzLm5hdmlnYXRpb25TaWRlYmFyLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlNp ZGViYXIuRXZlbnQuU2lkZWJhclBhbmVsU2VsZWN0ZWQsIHRoaXMuX25hdmlnYXRpb25TaWRlYmFy UGFuZWxTZWxlY3RlZCwgdGhpcyk7CiAKLSAgICB0aGlzLnJpZ2h0U2lkZWJhciA9IHRoaXMuZGV0 YWlsc1NpZGViYXIgPSBuZXcgV2ViSW5zcGVjdG9yLlNpZGViYXIoZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoImRldGFpbHMtc2lkZWJhciIpLCBXZWJJbnNwZWN0b3IuU2lkZWJhci5TaWRlcy5SaWdo dCwgImdyb3VwIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJEZXRhaWxzIikpOworICAgIHRoaXMu cmlnaHRTaWRlYmFyID0gdGhpcy5kZXRhaWxzU2lkZWJhciA9IG5ldyBXZWJJbnNwZWN0b3IuU2lk ZWJhcihkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZGV0YWlscy1zaWRlYmFyIiksIFdlYkluc3Bl Y3Rvci5TaWRlYmFyLlNpZGVzLlJpZ2h0LCBudWxsLCBudWxsLCBXZWJJbnNwZWN0b3IuVUlTdHJp bmcoIkRldGFpbHMiKSk7CiAgICAgdGhpcy5kZXRhaWxzU2lkZWJhci5hZGRFdmVudExpc3RlbmVy KFdlYkluc3BlY3Rvci5TaWRlYmFyLkV2ZW50LkNvbGxhcHNlZFN0YXRlRGlkQ2hhbmdlLCB0aGlz Ll9zaWRlYmFyQ29sbGFwc2VkU3RhdGVEaWRDaGFuZ2UsIHRoaXMpOwogICAgIHRoaXMuZGV0YWls c1NpZGViYXIuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuU2lkZWJhci5FdmVudC5XaWR0 aERpZENoYW5nZSwgdGhpcy5fc2lkZWJhcldpZHRoRGlkQ2hhbmdlLCB0aGlzKTsKICAgICB0aGlz LmRldGFpbHNTaWRlYmFyLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlNpZGViYXIuRXZl bnQuU2lkZWJhclBhbmVsU2VsZWN0ZWQsIHRoaXMuX2RldGFpbHNTaWRlYmFyUGFuZWxTZWxlY3Rl ZCwgdGhpcyk7Cg==