118575 2013-07-11 13:25:21 -0700 Web Inspector: Color picker sometimes produces incorrect styles 2013-07-15 11:53:00 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P1 Normal --- 1 timothy timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 907747 0 timothy 2013-07-11 13:25:21 -0700 When using the new color picker to change a color in the inspector, the styles are sometimes incorrectly set. This usually happens when you use the opacity slider. <rdar://problem/14406853> 907748 1 206485 timothy 2013-07-11 13:29:00 -0700 Created attachment 206485 Patch 908469 2 206485 joepeck 2013-07-15 11:30:33 -0700 Comment on attachment 206485 Patch r=me 908475 3 206485 commit-queue 2013-07-15 11:52:58 -0700 Comment on attachment 206485 Patch Clearing flags on attachment: 206485 Committed r152651: <http://trac.webkit.org/changeset/152651> 908476 4 commit-queue 2013-07-15 11:53:00 -0700 All reviewed patches have been landed. Closing bug. 206485 2013-07-11 13:29:00 -0700 2013-07-15 11:52:58 -0700 Patch bug-118575-20130711162644.patch text/plain 4071 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 NjJiYmIxNzQ4OWE5NDgyYzU4ODQ5MDc2MzFmMGE1NDgyNDU4ZDk0Li42MTVjYmZmZTg1MmZjMDdk MWY2MDQ2ZTZjN2UyYzU0NThiYzQ3NTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMy0wNy0xMSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgUHJvcGVybHkgaGFuZGxlIHN0eWxlIHRleHQgY2hhbmdlcyB3aGlsZSB0 aGUgY29sb3IgcG9wb3ZlciBpcyBvcGVuLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg1NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ1NTU3R5bGVEZWNsYXJhdGlvblRl eHRFZGl0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblRl eHRFZGl0b3IucHJvdG90eXBlLl9jb2xvclN3YXRjaENsaWNrZWQudXBkYXRlQ29kZU1pcnJvcik6 CisgICAgICAgIFRoZSBvcmlnaW5hbCB0ZXh0IG1hcmtlciBtaWdodCBoYXZlIGJlZW4gY2xlYXJl ZCBieSBhIHN0eWxlIHVwZGF0ZSwgaW4gdGhpcyBjYXNlIHdlIG5lZWQgdG8KKyAgICAgICAgZmlu ZCB0aGUgbmV3IGNvbG9yIHRleHQgbWFya2VyIHNvIHdlIGtub3cgdGhlIHJpZ2h0IHJhbmdlIGZv ciB0aGUgbmV3IHN0eWxlIGNvbG9yIHRleHQuCisKIDIwMTMtMDctMDMgIFRpbW90aHkgSGF0Y2hl ciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIEd1YXJkIHJlbWFpbmluZyBjYWxscyB0 byBkZWNvZGVVUklDb21wb25lbnQgd2l0aCBhIHRyeS9jYXRjaC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRp dG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ1NTU3R5bGVEZWNs YXJhdGlvblRleHRFZGl0b3IuanMKaW5kZXggYWU4YWNiZjIwMTdlN2YwZTQ1NzI1MDM4NzgxMTc4 ZWI3ZmMxODA5ZC4uMzU3NDAzYTFlNDM0NTA4OTZmYzI3NmNlNjcwOWI5OThhODc3MDE3MCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ1NTU3R5bGVEZWNs YXJhdGlvblRleHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IuanMKQEAgLTY3OCwyMiArNjc4LDUy IEBAIFdlYkluc3BlY3Rvci5DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5wcm90b3R5cGUg PSB7CiAKICAgICAgICAgZnVuY3Rpb24gdXBkYXRlQ29kZU1pcnJvcihuZXdDb2xvclRleHQpCiAg ICAgICAgIHsKLSAgICAgICAgICAgIHRoaXMuX2NvZGVNaXJyb3Iub3BlcmF0aW9uKGZ1bmN0aW9u KCkgCisgICAgICAgICAgICBmdW5jdGlvbiB1cGRhdGUoKQogICAgICAgICAgICAgeworICAgICAg ICAgICAgICAgIC8vIFRoZSBvcmlnaW5hbCB0ZXh0IG1hcmtlciBtaWdodCBoYXZlIGJlZW4gY2xl YXJlZCBieSBhIHN0eWxlIHVwZGF0ZSwKKyAgICAgICAgICAgICAgICAvLyBpbiB0aGlzIGNhc2Ug d2UgbmVlZCB0byBmaW5kIHRoZSBuZXcgY29sb3IgdGV4dCBtYXJrZXIgc28gd2Uga25vdworICAg ICAgICAgICAgICAgIC8vIHRoZSByaWdodCByYW5nZSBmb3IgdGhlIG5ldyBzdHlsZSBjb2xvciB0 ZXh0LgorICAgICAgICAgICAgICAgIGlmICghY29sb3JUZXh0TWFya2VyIHx8ICFjb2xvclRleHRN YXJrZXIuZmluZCgpKSB7CisgICAgICAgICAgICAgICAgICAgIGNvbG9yVGV4dE1hcmtlciA9IG51 bGw7CisKKyAgICAgICAgICAgICAgICAgICAgdmFyIG1hcmtzID0gdGhpcy5fY29kZU1pcnJvci5m aW5kTWFya3NBdChyYW5nZS5mcm9tKTsKKyAgICAgICAgICAgICAgICAgICAgaWYgKCFtYXJrcy5s ZW5ndGgpCisgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgICAgICAg ICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBtYXJrcy5sZW5ndGg7ICsraSkgeworICAgICAgICAg ICAgICAgICAgICAgICAgdmFyIG1hcmsgPSBtYXJrc1tpXTsKKyAgICAgICAgICAgICAgICAgICAg ICAgIGlmICghbWFyay5fX21hcmtlZENvbG9yKQorICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNvbnRpbnVlOworICAgICAgICAgICAgICAgICAgICAgICAgY29sb3JUZXh0TWFya2VyID0gbWFy azsKKyAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAgICAgICB9 CisgICAgICAgICAgICAgICAgfQorCisgICAgICAgICAgICAgICAgaWYgKCFjb2xvclRleHRNYXJr ZXIpCisgICAgICAgICAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICAgICAgICAgIC8vIFNv bWV0aW1lcyB3ZSBzdGlsbCBtaWdodCBmaW5kIGEgc3RhbGUgdGV4dCBtYXJrZXIgd2l0aCBmaW5k TWFya3NBdC4KKyAgICAgICAgICAgICAgICB2YXIgbmV3UmFuZ2UgPSBjb2xvclRleHRNYXJrZXIu ZmluZCgpOworICAgICAgICAgICAgICAgIGlmICghbmV3UmFuZ2UpCisgICAgICAgICAgICAgICAg ICAgIHJldHVybjsKKworICAgICAgICAgICAgICAgIHJhbmdlID0gbmV3UmFuZ2U7CisKICAgICAg ICAgICAgICAgICBjb2xvclRleHRNYXJrZXIuY2xlYXIoKTsKIAogICAgICAgICAgICAgICAgIHRo aXMuX2NvZGVNaXJyb3IucmVwbGFjZVJhbmdlKG5ld0NvbG9yVGV4dCwgcmFuZ2UuZnJvbSwgcmFu Z2UudG8pOwogCiAgICAgICAgICAgICAgICAgLy8gVGhlIGNvbG9yJ3MgdGV4dCBmb3JtYXQgY291 bGQgaGF2ZSBjaGFuZ2VkLCBzbyB3ZSBuZWVkIHRvIHVwZGF0ZSB0aGUgInJhbmdlIiAKICAgICAg ICAgICAgICAgICAvLyB2YXJpYWJsZSB0byBhbnRpY2lwYXRlIGEgZGlmZmVyZW50ICJyYW5nZS50 byIgcHJvcGVydHkuCi0gICAgICAgICAgICAgICAgdmFyIHRvID0ge2xpbmU6IHJhbmdlLmZyb20u bGluZSwgY2g6IHJhbmdlLmZyb20uY2ggKyBuZXdDb2xvclRleHQubGVuZ3RofTsKLSAgICAgICAg ICAgICAgICByYW5nZS50byA9IHRvOworICAgICAgICAgICAgICAgIHJhbmdlLnRvLmNoID0gcmFu Z2UuZnJvbS5jaCArIG5ld0NvbG9yVGV4dC5sZW5ndGg7CiAKLSAgICAgICAgICAgICAgICBjb2xv clRleHRNYXJrZXIgPSB0aGlzLl9jb2RlTWlycm9yLm1hcmtUZXh0KHJhbmdlLmZyb20sIHRvKTsK KyAgICAgICAgICAgICAgICBjb2xvclRleHRNYXJrZXIgPSB0aGlzLl9jb2RlTWlycm9yLm1hcmtU ZXh0KHJhbmdlLmZyb20sIHJhbmdlLnRvKTsKICAgICAgICAgICAgICAgICBjb2xvclRleHRNYXJr ZXIuX19tYXJrZWRDb2xvciA9IHRydWU7CiAKICAgICAgICAgICAgICAgICBzd2F0Y2guX19jb2xv clRleHRNYXJrZXIgPSBjb2xvclRleHRNYXJrZXI7Ci0gICAgICAgICAgICB9LmJpbmQodGhpcykp OworICAgICAgICAgICAgfQorCisgICAgICAgICAgICB0aGlzLl9jb2RlTWlycm9yLm9wZXJhdGlv bih1cGRhdGUuYmluZCh0aGlzKSk7CiAgICAgICAgIH0KIAogICAgICAgICBpZiAoZXZlbnQuc2hp ZnRLZXkpIHsKQEAgLTcxMCw3ICs3NDAsNiBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJh dGlvblRleHRFZGl0b3IucHJvdG90eXBlID0gewogICAgICAgICAgICAgdGhpcy5faWdub3JlQ29k ZU1pcnJvckNvbnRlbnREaWRDaGFuZ2VFdmVudCA9IHRydWU7CiAgICAgICAgICAgICB1cGRhdGVD b2RlTWlycm9yLmNhbGwodGhpcywgbmV3Q29sb3JUZXh0KTsKICAgICAgICAgICAgIGRlbGV0ZSB0 aGlzLl9pZ25vcmVDb2RlTWlycm9yQ29udGVudERpZENoYW5nZUV2ZW50OwotCiAgICAgICAgIH0g ZWxzZSB7CiAgICAgICAgICAgICB0aGlzLl9jb2xvclBpY2tlclBvcG92ZXIgPSBuZXcgV2ViSW5z cGVjdG9yLlBvcG92ZXIodGhpcyk7CiAK