118562 2013-07-11 05:42:05 -0700 Insufficient viewport repaints when FrameView::paintsEntireContents 2013-07-12 01:23:11 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen commit-queue esprehn+autocc glenn noam simon.fraser oldest_to_newest 907610 0 allan.jensen 2013-07-11 05:42:05 -0700 If FrameView::paintsEntireContents is true, and the frameView is resized, the repaints emitted by the render-tree are wrongly limited to the frameRect. It appears to be because the visualOverflow of a renderview is equal frameRect. Since paints to contents implies no clipping or only clipping to total contents, the visualOverflow of RenderView should match the layoutOverflow. 907617 1 206450 allan.jensen 2013-07-11 05:47:47 -0700 Created attachment 206450 Patch 907620 2 allan.jensen 2013-07-11 05:50:13 -0700 This solves a bug that happens on the Qt port if TiledBackingStore is enabled but ResizesToContent is not. To trigger the issue open a page with centered content, scroll down and resize the width. Typically only part of the viewport will be repainted, and if you scroll more tiles not repainted can be seen. 907853 3 206450 commit-queue 2013-07-12 01:23:09 -0700 Comment on attachment 206450 Patch Clearing flags on attachment: 206450 Committed r152584: <http://trac.webkit.org/changeset/152584> 907854 4 commit-queue 2013-07-12 01:23:11 -0700 All reviewed patches have been landed. Closing bug. 206450 2013-07-11 05:47:47 -0700 2013-07-12 01:23:08 -0700 Patch bug-118562-20130711144531.patch text/plain 2525 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjg3ZjYyYjFjOWEyNjM4 NDM2OTA3NTY5YWRkMzY4ZTk0ODQxNGUwNy4uOTVhNWEwZjQ5MzExYTNhMzAyMDNhYzYwZWZkNjk2 ZmI4OTc1Zjc4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEzLTA3LTExICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCisgICAgICAgIElu c3VmZmljaWVudCB2aWV3cG9ydCByZXBhaW50cyB3aGVuIEZyYW1lVmlldzo6cGFpbnRzRW50aXJl Q29udGVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExODU2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdoZW4gdGhlIGZyYW1ldmlldyBwYWludHMgZW50aXJlIGNvbnRlbnQsIHRoZSB2aXN1YWxPdmVy Zmxvd1JlY3Qgb2YgUmVuZGVyVmlldworICAgICAgICBzaG91bGQgYmUgdGhlIHNhbWUgYXMgdGhl IGxheW91dE92ZXJmbG93UmVjdC4KKworICAgICAgICBUaGlzIGFmZmVjdHMgdGhlIHJlcXVlc3Rl ZCByZXBhaW50cyBvbiByZXNpemUgb2YgdGhlIGZyYW1ldmlldy4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclZpZXc6OnZpc3Vh bE92ZXJmbG93UmVjdCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclZpZXcuaDoKKworMjAx My0wNy0xMSAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQGRpZ2lhLmNvbT4K KwogICAgICAgICBbUXRdW1dLMV0gVGlsZWQgYmFja2luZyBzdG9yZSBicmVha3Mgc2Nyb2xsYmFy cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NTU2 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcAppbmRleCA0Mzc0ZjQxNGEy YjU1ODAwYzE3MWJiNTA2ZDcyZTgyNzc0ZTIxNzNlLi45MDk3ZmEyMjdhODNmOWU2OGI4YWY0ZjNi M2MwZGMyYmQzYTE5ODUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3Bw CkBAIC01NjIsNiArNTYyLDE0IEBAIHZvaWQgUmVuZGVyVmlldzo6cmVwYWludFZpZXdBbmRDb21w b3NpdGVkTGF5ZXJzKCkKICNlbmRpZgogfQogCitMYXlvdXRSZWN0IFJlbmRlclZpZXc6OnZpc3Vh bE92ZXJmbG93UmVjdCgpIGNvbnN0Cit7CisgICAgaWYgKG1fZnJhbWVWaWV3LT5wYWludHNFbnRp cmVDb250ZW50cygpKQorICAgICAgICByZXR1cm4gbGF5b3V0T3ZlcmZsb3dSZWN0KCk7CisKKyAg ICByZXR1cm4gUmVuZGVyQmxvY2s6OnZpc3VhbE92ZXJmbG93UmVjdCgpOworfQorCiB2b2lkIFJl bmRlclZpZXc6OmNvbXB1dGVSZWN0Rm9yUmVwYWludChjb25zdCBSZW5kZXJMYXllck1vZGVsT2Jq ZWN0KiByZXBhaW50Q29udGFpbmVyLCBMYXlvdXRSZWN0JiByZWN0LCBib29sIGZpeGVkKSBjb25z dAogewogICAgIC8vIElmIGEgY29udGFpbmVyIHdhcyBzcGVjaWZpZWQsIGFuZCB3YXMgbm90IDAg b3IgdGhlIFJlbmRlclZpZXcsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVmlldy5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuaAppbmRl eCA4NGMyYWIxMDgxMWUwYzI0MWI5YzA5ZTBiMGYyYTJhZDUxMWQ2MGEwLi4zMTEyYzdlMGM0ZGI1 ZThkMmViZDFjMGY0NmY5ODE3MmQ3NGUwZjFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyVmlldy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJWaWV3LmgKQEAgLTc0LDYgKzc0LDcgQEAgcHVibGljOgogCiAgICAgRnJhbWVWaWV3KiBmcmFt ZVZpZXcoKSBjb25zdCB7IHJldHVybiBtX2ZyYW1lVmlldzsgfQogCisgICAgdmlydHVhbCBMYXlv dXRSZWN0IHZpc3VhbE92ZXJmbG93UmVjdCgpIGNvbnN0IE9WRVJSSURFOwogICAgIHZpcnR1YWwg dm9pZCBjb21wdXRlUmVjdEZvclJlcGFpbnQoY29uc3QgUmVuZGVyTGF5ZXJNb2RlbE9iamVjdCog cmVwYWludENvbnRhaW5lciwgTGF5b3V0UmVjdCYsIGJvb2wgZml4ZWQgPSBmYWxzZSkgY29uc3Qg T1ZFUlJJREU7CiAgICAgdm9pZCByZXBhaW50Vmlld1JlY3RhbmdsZShjb25zdCBMYXlvdXRSZWN0 JiwgYm9vbCBpbW1lZGlhdGUgPSBmYWxzZSkgY29uc3Q7CiAgICAgLy8gUmVwYWludCB0aGUgdmll dywgYW5kIGFsbCBjb21wb3NpdGVkIGxheWVycyB0aGF0IGludGVyc2VjdCB0aGUgZ2l2ZW4gYWJz b2x1dGUgcmVjdGFuZ2xlLgo=