118552 2013-07-11 01:51:25 -0700 [GTK] Layout Test accessibility/deleting-iframe-destroys-axcache.html, platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html are failing 2013-07-11 11:59:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 spena webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jdiggs mario oldest_to_newest 907566 0 spena 2013-07-11 01:51:25 -0700 The following layout test are failing on [GTK] after r152537 accessibility/deleting-iframe-destroys-axcache.html platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug%20WK1/r152560%20%283023%29/results.html 907598 1 206446 mario 2013-07-11 04:51:08 -0700 Created attachment 206446 Patch proposal It seems I just forgot to add this extra check when adding the OR condition in a previous patch. 907679 2 mario 2013-07-11 09:21:43 -0700 This is causing some interesting crashes in debug builds so, as much as I hate putting pressure, it would be great to have it reviewed soon. Fortunately, I believe it will be a no brainer :) 907735 3 mario 2013-07-11 11:59:05 -0700 Committed r152574: <http://trac.webkit.org/changeset/152574> 206446 2013-07-11 04:51:08 -0700 2013-07-11 10:13:11 -0700 Patch proposal 0001-2013-07-11-Mario-Sanchez-Prada-mario.prada-samsung.c.patch text/plain 5636 mario RnJvbSBmODhjMzg0ODZkZWIzYjNlZTg1ZmZlNWZiZTMwM2IxYjAxZWU1ZjI1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KRGF0ZTogVGh1LCAxMSBKdWwgMjAxMyAxMjo0NjowMSArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIDIwMTMtMDctMTEgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KCiAgICAgICAgW0dUS10gTGF5b3V0IFRlc3QgYWNjZXNzaWJpbGl0eS9kZWxldGlu Zy1pZnJhbWUtZGVzdHJveXMtYXhjYWNoZS5odG1sLCBwbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0 eS9yZXBsYWNlZC1vYmplY3RzLWluLWFub255bW91cy1ibG9ja3MuaHRtbCBhcmUgZmFpbGluZwog ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg1NTIKCiAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIERvIG5vdCBhc3N1bWUg YWx3YXlzIHRoYXQgd2UgaGF2ZSBhIFJlbmRlclRleHQgcmVuZGVyZXIgd2hlbgogICAgICAgIGNh bGxpbmcgdG8gdG9SZW5kZXJUZXh0KCksIHNpbmNlIHdlIG1pZ2h0IGJlIGV4ZWN1dGluZyB0aGF0 IHBhcnQKICAgICAgICBvZiB0aGUgY29kZSBkdWUgdG8gaGF2ZSByZXF1ZXN0ZWQgdG8gaW5jbHVk ZSBhbGwgdGhlIGNoaWxkcmVuLgoKICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0 eVJlbmRlck9iamVjdC5jcHA6CiAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlSZW5kZXJP YmplY3Q6OnRleHRVbmRlckVsZW1lbnQpOiBBZGQKICAgICAgICBtaXNzaW5nIGd1YXJkIGZvciBS ZW5kZXJUZXh0LCBuZWVkZWQgYWZ0ZXIgcjE1MjUzNy4KCjIwMTMtMDctMTEgIE1hcmlvIFNhbmNo ZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1zdW5nLmNvbT4KCiAgICAgICAgW0dUS10gTGF5b3V0 IFRlc3QgYWNjZXNzaWJpbGl0eS9kZWxldGluZy1pZnJhbWUtZGVzdHJveXMtYXhjYWNoZS5odG1s LCBwbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9yZXBsYWNlZC1vYmplY3RzLWluLWFub255bW91 cy1ibG9ja3MuaHRtbCBhcmUgZmFpbGluZwogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTg1NTIKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCgogICAgICAgIFJlbW92ZSB0ZXN0cyB0aGF0IGFyZSBubyBsb25nZXIgZXhwZWN0ZWQgdG8g Y3Jhc2guCgogICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6IFJlbW92ZWQg dGVzdHMuCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8ICAgMTEgKysrKysrKysrKysKIExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9U ZXN0RXhwZWN0YXRpb25zICAgICAgICAgICAgICAgfCAgICA0IC0tLS0KIFNvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrKysr KysrKysrKwogLi4uL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2Jq ZWN0LmNwcCB8ICAgMTAgKysrKysrLS0tLQogNCBmaWxlcyBjaGFuZ2VkLCAzMiBpbnNlcnRpb25z KCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxNzg1ZWY4Li5lOTljZGEyIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDUgKzEsMTYgQEAKIDIwMTMtMDctMTEgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFk YUBzYW1zdW5nLmNvbT4KIAorICAgICAgICBbR1RLXSBMYXlvdXQgVGVzdCBhY2Nlc3NpYmlsaXR5 L2RlbGV0aW5nLWlmcmFtZS1kZXN0cm95cy1heGNhY2hlLmh0bWwsIHBsYXRmb3JtL2d0ay9hY2Nl c3NpYmlsaXR5L3JlcGxhY2VkLW9iamVjdHMtaW4tYW5vbnltb3VzLWJsb2Nrcy5odG1sIGFyZSBm YWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTg1NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZW1vdmUgdGVzdHMgdGhhdCBhcmUgbm8gbG9uZ2VyIGV4cGVjdGVkIHRvIGNyYXNoLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6IFJlbW92ZWQgdGVzdHMuCisKKzIw MTMtMDctMTEgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1zdW5nLmNvbT4K KwogICAgICAgICBbR1RLXSBVbnJldmlld2VkIGdhcmRlbmluZy4gQWRkZWQgY3Jhc2ggZXhwZWN0 YXRpb25zIGluIGRlYnVnIGJ1aWxkcyBhZnRlciByMTUyNTM3CiAKICAgICAgICAgKiBwbGF0Zm9y bS9ndGsvVGVzdEV4cGVjdGF0aW9uczogQWRkZWQgdHdvIGNyYXNoaW5nIHRlc3RzLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBjZTk3M2ZjLi5hYWZkOWJl IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNDk2LDEw ICs0OTYsNiBAQCB3ZWJraXQub3JnL2IvMTE4NDIyIFsgRGVidWcgXSBodHRwL3Rlc3RzL3NlY3Vy aXR5L1hGcmFtZU9wdGlvbnMveC1mcmFtZS1vcHRpb25zLQogCiB3ZWJraXQub3JnL2IvMTE4NDIz IGh0dHAvdGVzdHMvbWlzYy9pZnJhbWUtcmVwYXJlbnRpbmctaWQtY29sbGlzaW9uLmh0bWwgWyBD cmFzaCBQYXNzIF0KIAotd2Via2l0Lm9yZy9iLzExODU1MiBbIERlYnVnIF0gYWNjZXNzaWJpbGl0 eS9kZWxldGluZy1pZnJhbWUtZGVzdHJveXMtYXhjYWNoZS5odG1sIFsgQ3Jhc2ggXQotCi13ZWJr aXQub3JnL2IvMTE4NTUyIFsgRGVidWcgXSBwbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9yZXBs YWNlZC1vYmplY3RzLWluLWFub255bW91cy1ibG9ja3MuaHRtbCBbIENyYXNoIF0KLQogIy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KICMgRW5kIG9mIENyYXNoaW5nIHRlc3RzCiAjLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDIxZDI2ZGQuLjYwMzcx NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMy0wNy0xMSAgTWFyaW8gU2FuY2hl eiBQcmFkYSAgPG1hcmlvLnByYWRhQHNhbXN1bmcuY29tPgogCisgICAgICAgIFtHVEtdIExheW91 dCBUZXN0IGFjY2Vzc2liaWxpdHkvZGVsZXRpbmctaWZyYW1lLWRlc3Ryb3lzLWF4Y2FjaGUuaHRt bCwgcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvcmVwbGFjZWQtb2JqZWN0cy1pbi1hbm9ueW1v dXMtYmxvY2tzLmh0bWwgYXJlIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExODU1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIERvIG5vdCBhc3N1bWUgYWx3YXlzIHRoYXQgd2UgaGF2ZSBhIFJl bmRlclRleHQgcmVuZGVyZXIgd2hlbgorICAgICAgICBjYWxsaW5nIHRvIHRvUmVuZGVyVGV4dCgp LCBzaW5jZSB3ZSBtaWdodCBiZSBleGVjdXRpbmcgdGhhdCBwYXJ0CisgICAgICAgIG9mIHRoZSBj b2RlIGR1ZSB0byBoYXZlIHJlcXVlc3RlZCB0byBpbmNsdWRlIGFsbCB0aGUgY2hpbGRyZW4uCisK KyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6dGV4dFVuZGVyRWxl bWVudCk6IEFkZAorICAgICAgICBtaXNzaW5nIGd1YXJkIGZvciBSZW5kZXJUZXh0LCBuZWVkZWQg YWZ0ZXIgcjE1MjUzNy4KKworMjAxMy0wNy0xMSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlv LnByYWRhQHNhbXN1bmcuY29tPgorCiAgICAgICAgIFtBVEtdIFJlZmFjdG9yIGNvZGUgZm9yIHRy YW5zbGF0aW5nIG9mZnNldHMgYmV0d2VlbiBXZWJDb3JlIGExMXkgYW5kIEFUSwogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MTc5CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVj dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJP YmplY3QuY3BwCmluZGV4IDMxNzEzOGYuLmViYmMxOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcApA QCAtNjYyLDExICs2NjIsMTMgQEAgU3RyaW5nIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnRl eHRVbmRlckVsZW1lbnQoQWNjZXNzaWJpbGl0eVRleHRVbmRlckVsZW1lbnQKICAgICAKICAgICAg ICAgLy8gU29tZXRpbWVzIHRleHQgZnJhZ21lbnRzIGRvbid0IGhhdmUgTm9kZXMgYXNzb2NpYXRl ZCB3aXRoIHRoZW0gKGxpa2Ugd2hlbgogICAgICAgICAvLyBDU1MgY29udGVudCBpcyB1c2VkIHRv IGluc2VydCB0ZXh0IG9yIHdoZW4gYSBSZW5kZXJDb3VudGVyIGlzIHVzZWQuKQotICAgICAgICBS ZW5kZXJUZXh0KiByZW5kZXJUZXh0T2JqZWN0ID0gdG9SZW5kZXJUZXh0KG1fcmVuZGVyZXIpOwot ICAgICAgICBpZiAocmVuZGVyVGV4dE9iamVjdC0+aXNUZXh0RnJhZ21lbnQoKSkKLSAgICAgICAg ICAgIHJldHVybiBTdHJpbmcoc3RhdGljX2Nhc3Q8UmVuZGVyVGV4dEZyYWdtZW50Kj4obV9yZW5k ZXJlciktPmNvbnRlbnRTdHJpbmcoKSk7Ci0gICAgICAgIGVsc2UKKyAgICAgICAgaWYgKG1fcmVu ZGVyZXItPmlzVGV4dCgpKSB7CisgICAgICAgICAgICBSZW5kZXJUZXh0KiByZW5kZXJUZXh0T2Jq ZWN0ID0gdG9SZW5kZXJUZXh0KG1fcmVuZGVyZXIpOworICAgICAgICAgICAgaWYgKHJlbmRlclRl eHRPYmplY3QtPmlzVGV4dEZyYWdtZW50KCkpCisgICAgICAgICAgICAgICAgcmV0dXJuIFN0cmlu ZyhzdGF0aWNfY2FzdDxSZW5kZXJUZXh0RnJhZ21lbnQqPihtX3JlbmRlcmVyKS0+Y29udGVudFN0 cmluZygpKTsKKwogICAgICAgICAgICAgcmV0dXJuIFN0cmluZyhyZW5kZXJUZXh0T2JqZWN0LT50 ZXh0KCkpOworICAgICAgICB9CiAgICAgfQogICAgIAogICAgIHJldHVybiBBY2Nlc3NpYmlsaXR5 Tm9kZU9iamVjdDo6dGV4dFVuZGVyRWxlbWVudChtb2RlKTsKLS0gCjEuNy4xMC40Cgo=