118549 2013-07-10 23:25:17 -0700 [EFL] --minimal build fails while linking libwebcore_efl.so 2013-07-12 07:43:09 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 oleg.beletski webkit-unassigned cdumez commit-queue gyuyoung.kim rakuco oldest_to_newest 907527 0 oleg.beletski 2013-07-10 23:25:17 -0700 ./Tools/Scripts/build-webkit --efl --cmakeargs="-DSHARED_CORE=ON" --minimal fails with this error: Linking CXX shared library ../../lib/libwebcore_efl.so CMakeFiles/WebCore.dir/plugins/PluginPackageNone.cpp.o: In function `WebCore::PluginPackage::determineQuirks(WTF::String const&)': PluginPackageNone.cpp:(.text._ZN7WebCore13PluginPackage15determineQuirksERKN3WTF6StringE+0x0): multiple definition of `WebCore::PluginPackage::determineQuirks(WTF::String const&)' CMakeFiles/WebCore.dir/plugins/PluginPackage.cpp.o:PluginPackage.cpp:(.text._ZN7WebCore13PluginPackage15determineQuirksERKN3WTF6StringE+0x0): first defined here collect2: ld returned 1 exit status make[2]: *** [lib/libwebcore_efl.so.0.1.0] Error 1 make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2 make: *** [all] Error 2 907754 1 206487 oleg.beletski 2013-07-11 14:16:21 -0700 Created attachment 206487 Patch 907891 2 206487 rakuco 2013-07-12 04:05:35 -0700 Comment on attachment 206487 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206487&action=review Looks OK to me, but please fix the style notes I added. > Source/WebCore/ChangeLog:8 > + This is fix for 11854. > + > + * CMakeLists.txt: The bug number is already mentioned above, so there's no need to say it again. Instead, it's helpful to describe what you did in the "* CMakeLists.txt" line, like "Move file foo to the block bar because of this and that". > Source/WebCore/CMakeLists.txt:2611 > plugins/npapi.cpp > + plugins/PluginPackage.cpp Please keep this list alphabetically (and case-sensitively) sorted. 907894 3 206487 cdumez 2013-07-12 04:11:16 -0700 Comment on attachment 206487 Patch r- until comments are addressed 907944 4 206539 oleg.beletski 2013-07-12 06:54:28 -0700 Created attachment 206539 Patch 907946 5 206539 oleg.beletski 2013-07-12 06:57:32 -0700 Comment on attachment 206539 Patch Thanks for you comments, new patch attached. Setting commit flag. 907948 6 206539 cdumez 2013-07-12 07:01:56 -0700 Comment on attachment 206539 Patch Ok, r=me. 907961 7 206539 commit-queue 2013-07-12 07:43:06 -0700 Comment on attachment 206539 Patch Clearing flags on attachment: 206539 Committed r152591: <http://trac.webkit.org/changeset/152591> 907962 8 commit-queue 2013-07-12 07:43:09 -0700 All reviewed patches have been landed. Closing bug. 206487 2013-07-11 14:16:21 -0700 2013-07-12 06:54:20 -0700 Patch bug-118549-20130712011404.patch text/plain 1327 oleg.beletski U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIyMmM4NDgzNzQ4MzM5 ZmNkYjNjODEwNWRmZGE3MWZjMzViMThlOC4uYmM0YTdmMmM3ZTdiYjVjZDE2MTVjM2M4MjQ2NzNh MWFlOTY4NTE3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA3LTExICBPbGVn IEJlbGV0c2tpICA8b2xlZy5iZWxldHNraUBnbWFpbC5jb20+CisKKyAgICAgICAgW0VGTF0gLS1t aW5pbWFsIGJ1aWxkIGZhaWxzIHdoaWxlIGxpbmtpbmcgbGlid2ViY29yZV9lZmwuc28KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODU0OQorCisgICAg ICAgIFRoaXMgaXMgZml4IGZvciAxMTg1NC4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OiAK KwogMjAxMy0wNy0wOSAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgog CiAgICAgICAgIFVzZSB0b1NWR0ZvbnRFbGVtZW50KCkgaW5zdGVhZCBvZiBzdGF0aWNfY2FzdDxT VkdGb250RWxlbWVudCo+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4 dCBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IGFhMjE4ODIxZDE2ZmM4NzY0 NzU0ZjIzMzY5MjNmOGRlMjg5MDVlMzcuLjg1NjZjZTRkYjQ5OWQ4NTBjMjU0YmNhMDUyMGUwMjNi NjJjZDQ0NzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBi L1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0yMTAyLDcgKzIxMDIsNiBAQCBzZXQo V2ViQ29yZV9TT1VSQ0VTCiAgICAgcGx1Z2lucy9QbHVnaW5EYXRhLmNwcAogICAgIHBsdWdpbnMv UGx1Z2luRGVidWcuY3BwCiAgICAgcGx1Z2lucy9QbHVnaW5NYWluVGhyZWFkU2NoZWR1bGVyLmNw cAotICAgIHBsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHAKICAgICBwbHVnaW5zL1BsdWdpblN0cmVh bS5jcHAKICAgICBwbHVnaW5zL1BsdWdpblZpZXcuY3BwCiAKQEAgLTI2MDksNiArMjYwOCw3IEBA IGVuZGlmICgpCiBpZiAoRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEkpCiAgICAgbGlzdChBUFBF TkQgV2ViQ29yZV9TT1VSQ0VTCiAgICAgICAgIHBsdWdpbnMvbnBhcGkuY3BwCisgICAgICAgIHBs dWdpbnMvUGx1Z2luUGFja2FnZS5jcHAKICAgICApCiBlbHNlICgpCiAgICAgbGlzdChBUFBFTkQg V2ViQ29yZV9TT1VSQ0VTCg== 206539 2013-07-12 06:54:28 -0700 2013-07-12 07:43:06 -0700 Patch bug-118549-20130712175210.patch text/plain 1384 oleg.beletski U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIyMmM4NDgzNzQ4MzM5 ZmNkYjNjODEwNWRmZGE3MWZjMzViMThlOC4uOTMwNDliMDA1MDk5ODVlYzIzMmZiN2VhNzYyYWUw YmM4YjUxZmVkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA3LTEyICBPbGVn IEJlbGV0c2tpICA8b2xlZy5iZWxldHNraUBnbWFpbC5jb20+CisKKyAgICAgICAgW0VGTF0gLS1t aW5pbWFsIGJ1aWxkIGZhaWxzIHdoaWxlIGxpbmtpbmcgbGlid2ViY29yZV9lZmwuc28KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODU0OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50 eHQ6CisgICAgICAgIE1vdmluZyBmaWxlIHBsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHAgdG8gRU5B QkxFX05FVFNDQVBFX1BMVUdJTl9BUEkgYmxvY2suCisKIDIwMTMtMDctMDkgIEd5dXlvdW5nIEtp bSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBVc2UgdG9TVkdGb250RWxl bWVudCgpIGluc3RlYWQgb2Ygc3RhdGljX2Nhc3Q8U1ZHRm9udEVsZW1lbnQqPgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxp c3RzLnR4dAppbmRleCBhYTIxODgyMWQxNmZjODc2NDc1NGYyMzM2OTIzZjhkZTI4OTA1ZTM3Li5k NjRlMGE0NjA1OTQ1YWJmYTAzNGRhYTE5NjlhOGE5ODkyNWU4NTIzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3Rz LnR4dApAQCAtMjEwMiw3ICsyMTAyLDYgQEAgc2V0KFdlYkNvcmVfU09VUkNFUwogICAgIHBsdWdp bnMvUGx1Z2luRGF0YS5jcHAKICAgICBwbHVnaW5zL1BsdWdpbkRlYnVnLmNwcAogICAgIHBsdWdp bnMvUGx1Z2luTWFpblRocmVhZFNjaGVkdWxlci5jcHAKLSAgICBwbHVnaW5zL1BsdWdpblBhY2th Z2UuY3BwCiAgICAgcGx1Z2lucy9QbHVnaW5TdHJlYW0uY3BwCiAgICAgcGx1Z2lucy9QbHVnaW5W aWV3LmNwcAogCkBAIC0yNjA4LDYgKzI2MDcsNyBAQCBlbmRpZiAoKQogCiBpZiAoRU5BQkxFX05F VFNDQVBFX1BMVUdJTl9BUEkpCiAgICAgbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCisgICAg ICAgIHBsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHAKICAgICAgICAgcGx1Z2lucy9ucGFwaS5jcHAK ICAgICApCiBlbHNlICgpCg==