118535 2013-07-10 11:07:07 -0700 Some Java plugin instances can deadlock with the WebProcess on NPP_Destroy 2013-07-10 11:35:18 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson andersca oldest_to_newest 907409 0 beidson 2013-07-10 11:07:07 -0700 Some Java plugin instances can deadlock with the WebProcess on NPP_Destroy The newest official Java plugin does some of its NPP_Destroy cleanup work on a background thread. This includes calling NP_Deallocate on an NPObject on that background thread. Doing that is unsupported, has undefined behavior, and as of http://trac.webkit.org/changeset/139514 will cause a deadlock. Since we can't fix the Java plugin and since this is during plugin teardown anyways, we can marshall the destruction back to the main thread. In radar as <rdar://problem/14286390> 907416 1 206400 beidson 2013-07-10 11:23:04 -0700 Created attachment 206400 Patch v1 907418 2 206400 ap 2013-07-10 11:25:22 -0700 Comment on attachment 206400 Patch v1 Perhaps add some pointers to why we have such a hack, and only in one place? 907419 3 beidson 2013-07-10 11:35:18 -0700 http://trac.webkit.org/changeset/152539 206400 2013-07-10 11:23:04 -0700 2013-07-10 11:25:22 -0700 Patch v1 patch text/plain 1831 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlMDg3OTgwLi5mZDE1YjRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTMtMDctMTAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIFNvbWUgSmF2YSBwbHVnaW4gaW5zdGFuY2VzIGNhbiBkZWFkbG9jayB3aXRoIHRoZSBXZWJQ cm9jZXNzIG9uIE5QUF9EZXN0cm95LgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTQyODYzOTA+ IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NTM1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvUGx1 Z2lucy9OUE9iamVjdFByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6TlBPYmplY3RQcm94eTo6 fk5QT2JqZWN0UHJveHkpOiBBU1NFUlQgdGhpcyBpcyB0aGUgbWFpbiB0aHJlYWQuCisgICAgICAg IChXZWJLaXQ6Ok5QT2JqZWN0UHJveHk6Ok5QX0RlYWxsb2NhdGUpOiBJZiB0aGlzIGlzbid0IHRo ZSBtYWluIHRocmVhZCwgY2FsbCBpdCBhZ2FpbiBvbiB0aGUgbWFpbiB0aHJlYWQuCisKIDIwMTMt MDctMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtHVEtdIFJ1bnRpbWUgY3JpdGljYWwgd2FybmluZyB3aGVuIHVubG9hZGluZyBhIG1vZHVs ZSB0aGF0IGZhaWxlZCB0byBsb2FkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv UGx1Z2lucy9OUE9iamVjdFByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9QbHVnaW5z L05QT2JqZWN0UHJveHkuY3BwCmluZGV4IDYxZGFhNmMuLjkwZDJiMjkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05QT2JqZWN0UHJveHkuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05QT2JqZWN0UHJveHkuY3BwCkBAIC0zNSw2ICszNSwx MCBAQAogI2luY2x1ZGUgIk5QUmVtb3RlT2JqZWN0TWFwLmgiCiAjaW5jbHVkZSAiTlBSdW50aW1l VXRpbGl0aWVzLmgiCiAjaW5jbHVkZSAiTlBWYXJpYW50RGF0YS5oIgorI2luY2x1ZGUgPFdlYkNv cmUvUnVuTG9vcC5oPgorI2luY2x1ZGUgPHd0Zi9NYWluVGhyZWFkLmg+CisKK3VzaW5nIG5hbWVz cGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIApAQCAtNTUsNiArNTksOCBAQCBO UE9iamVjdFByb3h5OjpOUE9iamVjdFByb3h5KCkKIAogTlBPYmplY3RQcm94eTo6fk5QT2JqZWN0 UHJveHkoKQogeworICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CisKICAgICBpZiAoIW1fbnBS ZW1vdGVPYmplY3RNYXApCiAgICAgICAgIHJldHVybjsKIApAQCAtMjkzLDYgKzI5OSwxMSBAQCBO UE9iamVjdCogTlBPYmplY3RQcm94eTo6TlBfQWxsb2NhdGUoTlBQIG5wcCwgTlBDbGFzcyopCiAK IHZvaWQgTlBPYmplY3RQcm94eTo6TlBfRGVhbGxvY2F0ZShOUE9iamVjdCogbnBPYmplY3QpCiB7 CisgICAgaWYgKCFpc01haW5UaHJlYWQoKSkgeworICAgICAgICBSdW5Mb29wOjptYWluKCktPmRp c3BhdGNoKGJpbmQoJk5QT2JqZWN0UHJveHk6Ok5QX0RlYWxsb2NhdGUsIG5wT2JqZWN0KSk7Cisg ICAgICAgIHJldHVybjsKKyAgICB9CisgICAgCiAgICAgTlBPYmplY3RQcm94eSogbnBPYmplY3RQ cm94eSA9IHRvTlBPYmplY3RQcm94eShucE9iamVjdCk7CiAgICAgZGVsZXRlIG5wT2JqZWN0UHJv eHk7CiB9Cg==