11853 2006-12-16 11:20:53 -0800 REGRESSION (r17352): Whitespace in <title> is rendered 2007-01-18 19:52:47 -0800 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 RESOLVED FIXED HasReduction, Regression P1 Normal --- 1 dev+webkit webkit-unassigned ggaren mitz oldest_to_newest 41717 0 dev+webkit 2006-12-16 11:20:53 -0800 Excessive whitespace in the <title> element is rendered on ToT but not Safari 2.0.4 (or any other browser). Probably due to the loader refactoring? 41718 1 11884 dev+webkit 2006-12-16 11:21:37 -0800 Created attachment 11884 reduction 41719 2 mitz 2006-12-16 11:42:50 -0800 I think this is a result of <http://trac.webkit.org/projects/webkit/changeset/17352>, which promised to "[replace] stringByCollapsingNonPrintingCharacters with a c++ equivalent". I couldn't find the equivalent, nor when it is applied to the title. 41720 3 dev+webkit 2006-12-16 11:59:29 -0800 Bug11692 seems to have been caused by that change too. 34569 4 12496 sam 2007-01-16 16:13:27 -0800 Created attachment 12496 patch Patch modifies the method canonicalizedTitle() to collapse the internal whitespace. This required removing an optimization in the function. I added a test to the manuel tests as the DRT does not dump the title. 34545 5 mjs 2007-01-16 22:02:57 -0800 r=me Might be worth enhancing layout tests to be able to dump title. 34251 6 mrowe 2007-01-18 19:52:47 -0800 Landed in r18972. 11884 2006-12-16 11:21:37 -0800 2006-12-16 11:21:37 -0800 reduction titletest.html text/html 238 dev+webkit PGh0bWw+Cgo8aGVhZD4KICAgIDx0aXRsZT4KICAgICAgICBMb3JlbQogICAgICAgIElwc3VtCiAg ICAgICAgRG9sb3IKICAgIDwvdGl0bGU+CjwvaGVhZD4KCjxib2R5PgogICAgVGl0bGUgc2hvdWxk IHJlbmRlciBhcyAiTG9yZW0gSXBzdW0gRG9sb3IiIG5vdCAiTG9yZW0mbmJzcDsmbmJzcDsmbmJz cDsmbmJzcDsmbmJzcDtJcHN1bSZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO0RvbG9yIi4KPC9ib2R5 PgoKPC9odG1sPg== 12496 2007-01-16 16:13:27 -0800 2007-01-16 22:03:30 -0800 patch titleWS.diff text/plain 4096 sam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxODg5MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDctMDEtMTYgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXRjaCBm b3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NTMKKyAgICAgICAg UkVHUkVTU0lPTiAocjE3MzUyKTogV2hpdGVzcGFjZSBpbiA8dGl0bGU+IGlzIHJlbmRlcmVkCisK KyAgICAgICAgKiBsb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Y2Fub25pY2FsaXplZFRpdGxlKTogQ2hhbmdlZCB0byBhbHNvIGNvbGxhcHNlIGludGVybmFsCisg ICAgICAgIHdoaXRlc3BhY2UuICBUaGlzIHJlcXVpcmVkIHJlbW92aW5nIGFuIG9wdGltaXphdGlv biB0aGF0IGlzIG5vCisgICAgICAgIGxvbmdlciBwb3NzaWJsZS4KKyAgICAgICAgKiBtYW51YWwt dGVzdHMvdGl0bGUtaW50ZXJuYWwtd2hpdGVzcGFjZS5odG1sOiBBZGRlZC4KKwogMjAwNy0wMS0x NiAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QWRhbS4KSW5kZXg6IFdlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAJKHJldmlzaW9uIDE4ODkyKQor KysgV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00 OCw0OCArNDgsNDYgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogLyoKLSAqIFBlcmZvcm1zIHRo cmVlIG9wZXJhdGlvbnM6CisgKiBQZXJmb3JtcyBmb3VyIG9wZXJhdGlvbnM6CiAgKiAgMS4gQ29u dmVydCBiYWNrc2xhc2hlcyB0byBjdXJyZW5jeSBzeW1ib2xzCiAgKiAgMi4gQ29udmVydCBjb250 cm9sIGNoYXJhY3RlcnMgdG8gc3BhY2VzCiAgKiAgMy4gVHJpbSBsZWFkaW5nIGFuZCB0cmFpbGlu ZyBzcGFjZXMKKyAqICA0LiBDb2xsYXBzZSBpbnRlcm5hbCB3aGl0ZXNwYWNlLgogICovCiBzdGF0 aWMgaW5saW5lIFN0cmluZyBjYW5vbmljYWxpemVkVGl0bGUoY29uc3QgU3RyaW5nJiB0aXRsZSwg RnJhbWUqIGZyYW1lKQogewogICAgIEFTU0VSVCghdGl0bGUuaXNFbXB0eSgpKTsKLSAgICAKKwog ICAgIGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzID0gdGl0bGUuY2hhcmFjdGVycygpOwogICAgIHVu c2lnbmVkIGxlbmd0aCA9IHRpdGxlLmxlbmd0aCgpOwogICAgIHVuc2lnbmVkIGk7Ci0gICAgCi0g ICAgLy8gRmluZCB0aGUgZmlyc3Qgbm9uLWNhbm9uaWNhbCBjaGFyYWN0ZXIKLSAgICBmb3IgKGkg PSAwOyBpIDwgbGVuZ3RoOyArK2kpIHsKLSAgICAgICAgVUNoYXIgYyA9IGNoYXJhY3RlcnNbaV07 Ci0gICAgICAgIGlmIChjIDwgMHgyMCB8fCBjID09IDB4N0YgfHwgYyA9PSAnXFwnKQotICAgICAg ICAgICAgYnJlYWs7Ci0gICAgfQotCi0gICAgLy8gT3B0aW1pemF0aW9uIGZvciB0aXRsZXMgdGhh dCBoYXZlIG5vIG5vbi1jYW5vbmljYWwgY2hhcmFjdGVycyBhbmQgbm8gbGVhZGluZyBvciB0cmFp bGluZyBzcGFjZXMKLSAgICBpZiAoaSA9PSBsZW5ndGggJiYgY2hhcmFjdGVyc1swXSAhPSAnICcg JiYgY2hhcmFjdGVyc1tsZW5ndGggLSAxXSAhPSAnICcpCi0gICAgICAgIHJldHVybiB0aXRsZTsK IAogICAgIFZlY3RvcjxVQ2hhcj4gc3RyaW5nQnVpbGRlcihsZW5ndGgpOwogICAgIHVuc2lnbmVk IGJ1aWxkZXJJbmRleCA9IDA7Ci0gICAgCisKICAgICAvLyBTa2lwIGxlYWRpbmcgc3BhY2VzIGFu ZCBsZWFkaW5nIGNoYXJhY3RlcnMgdGhhdCB3b3VsZCBjb252ZXJ0IHRvIHNwYWNlcwogICAgIGZv ciAoaSA9IDA7IGkgPCBsZW5ndGg7ICsraSkgewogICAgICAgICBVQ2hhciBjID0gY2hhcmFjdGVy c1tpXTsKICAgICAgICAgaWYgKCEoYyA8PSAweDIwIHx8IGMgPT0gMHg3RikpCiAgICAgICAgICAg ICBicmVhazsKICAgICB9Ci0gICAgCi0gICAgLy8gUmVwbGFjZSBjb250cm9sIGNoYXJhY3RlcnMg d2l0aCBzcGFjZXMsIGFuZCBiYWNrc2xhc2hlcyB3aXRoIGN1cnJlbmN5IHN5bWJvbHMKKworICAg IC8vIFJlcGxhY2UgY29udHJvbCBjaGFyYWN0ZXJzIHdpdGggc3BhY2VzLCBhbmQgYmFja3NsYXNo ZXMgd2l0aCBjdXJyZW5jeSBzeW1ib2xzLCBhbmQgY29sbGFwc2Ugd2hpdGVzcGFjZS4KKyAgICBi b29sIHByZXZpb3VzQ2hhcldhc1dTID0gZmFsc2U7CiAgICAgZm9yICg7IGkgPCBsZW5ndGg7ICsr aSkgewogICAgICAgICBVQ2hhciBjID0gY2hhcmFjdGVyc1tpXTsKLSAgICAgICAgaWYgKGMgPCAw eDIwIHx8IGMgPT0gMHg3RikKLSAgICAgICAgICAgIGMgPSAnICc7Ci0gICAgICAgIGVsc2UgaWYg KGMgPT0gJ1xcJykKLSAgICAgICAgICAgIGMgPSBmcmFtZS0+YmFja3NsYXNoQXNDdXJyZW5jeVN5 bWJvbCgpOwotICAgICAgICBzdHJpbmdCdWlsZGVyW2J1aWxkZXJJbmRleCsrXSA9IGM7CisgICAg ICAgIGlmIChjIDw9IDB4MjAgfHwgYyA9PSAweDdGKSB7CisgICAgICAgICAgICBpZiAocHJldmlv dXNDaGFyV2FzV1MpCisgICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICBzdHJp bmdCdWlsZGVyW2J1aWxkZXJJbmRleCsrXSA9ICcgJzsKKyAgICAgICAgICAgIHByZXZpb3VzQ2hh cldhc1dTID0gdHJ1ZTsKKyAgICAgICAgfSBlbHNlIGlmIChjID09ICdcXCcpIHsKKyAgICAgICAg ICAgIHN0cmluZ0J1aWxkZXJbYnVpbGRlckluZGV4KytdID0gZnJhbWUtPmJhY2tzbGFzaEFzQ3Vy cmVuY3lTeW1ib2woKTsKKyAgICAgICAgICAgIHByZXZpb3VzQ2hhcldhc1dTID0gZmFsc2U7Cisg ICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBzdHJpbmdCdWlsZGVyW2J1aWxkZXJJbmRleCsr XSA9IGM7CisgICAgICAgICAgICBwcmV2aW91c0NoYXJXYXNXUyA9IGZhbHNlOworICAgICAgICB9 CiAgICAgfQogCiAgICAgLy8gU3RyaXAgdHJhaWxpbmcgc3BhY2VzCkBAIC05OCwxMCArOTYsMTAg QEAgc3RhdGljIGlubGluZSBTdHJpbmcgY2Fub25pY2FsaXplZFRpdGxlKAogICAgICAgICBpZiAo c3RyaW5nQnVpbGRlcltidWlsZGVySW5kZXhdICE9ICcgJykKICAgICAgICAgICAgIGJyZWFrOwog ICAgIH0KLSAgICAKLSAgICBpZiAoYnVpbGRlckluZGV4ID09IDAgJiYgc3RyaW5nQnVpbGRlclti dWlsZGVySW5kZXhdID09ICcgJykKKworICAgIGlmICghYnVpbGRlckluZGV4ICYmIHN0cmluZ0J1 aWxkZXJbYnVpbGRlckluZGV4XSA9PSAnICcpCiAgICAgICAgIHJldHVybiAiIjsKLSAgICAKKwog ICAgIHN0cmluZ0J1aWxkZXIucmVzaXplKGJ1aWxkZXJJbmRleCArIDEpOwogICAgIHJldHVybiBT dHJpbmc6OmFkb3B0KHN0cmluZ0J1aWxkZXIpOwogfQpJbmRleDogV2ViQ29yZS9tYW51YWwtdGVz dHMvdGl0bGUtaW50ZXJuYWwtd2hpdGVzcGFjZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv bWFudWFsLXRlc3RzL3RpdGxlLWludGVybmFsLXdoaXRlc3BhY2UuaHRtbAkocmV2aXNpb24gMCkK KysrIFdlYkNvcmUvbWFudWFsLXRlc3RzL3RpdGxlLWludGVybmFsLXdoaXRlc3BhY2UuaHRtbAko cmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMiBAQAorPGh0bWw+Cis8aGVhZD4KKyAgICA8dGl0bGU+ CisgICAgICAgIExvcmVtCisgICAgICAgIElwc3VtCisgICAgICAgIERvbG9yCisgICAgPC90aXRs ZT4KKzwvaGVhZD4KKzxib2R5PgorICAgIFRpdGxlIHNob3VsZCByZW5kZXIgYXMgIkxvcmVtIElw c3VtIERvbG9yIiBub3QgIkxvcmVtJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7SXBzdW0m bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDtEb2xvciIuCis8L2JvZHk+Cis8L2h0bWw+Cg==