118519 2013-07-09 15:59:00 -0700 Remove some dead code from WebNSURLExtras _web_hostString 2013-07-10 08:54:27 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jberlin jberlin andersca jberlin oldest_to_newest 907231 0 jberlin 2013-07-09 15:59:00 -0700 - (NSString *)_web_hostString { NSData *data = [self _web_hostData]; if (!data) { data = [NSData data]; } return [[[NSString alloc] initWithData:[self _web_hostData] encoding:NSUTF8StringEncoding] autorelease]; } data isn’t ever used and initWithData:encoding does not throw an exception when data is nil, so we should just remove data. 907233 1 206356 jberlin 2013-07-09 16:04:22 -0700 Created attachment 206356 Patch 907380 2 206356 jberlin 2013-07-10 08:54:22 -0700 Comment on attachment 206356 Patch Committed in http://trac.webkit.org/changeset/152536 206356 2013-07-09 16:04:22 -0700 2013-07-10 08:54:22 -0700 Patch patch.patch text/plain 1262 jberlin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCAyZTNhY2Q0Li4zYzBmYTMyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTMtMDctMDkgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxl LmNvbT4KKworICAgICAgICBSZW1vdmUgc29tZSBkZWFkIGNvZGUgZnJvbSBXZWJOU1VSTEV4dHJh cyBfd2ViX2hvc3RTdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExODUxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogTWlzYy9XZWJOU1VSTEV4dHJhcy5tbToKKyAgICAgICAgKC1bTlNVUkwgX3dl Yl9ob3N0U3RyaW5nXSk6CisgICAgICAgIE5TU3RyaW5nIGluaXRXaXRoRGF0YTplbmNvZGluZzog ZG9lcyBub3QgdGhyb3cgYW4gZXhjZXB0aW9uIHdoZW4gcGFzc2luZyBuaWwgZm9yIHRoZSBkYXRh LCBzbworICAgICAgICBqdXN0IGRlbGV0ZSB0aGUgY29kZSB0aGF0IHdhc24ndCBiZWluZyBydW4u CisKIDIwMTMtMDctMDQgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4K IAogICAgICAgICBBZGQgYSBtZXRob2QgdG8gZ2V0IHVucmVhY2hhYmxlIFVSTCBmcm9tIFdlYkZy YW1lLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvTWlzYy9XZWJOU1VSTEV4dHJhcy5t bSBiL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViTlNVUkxFeHRyYXMubW0KaW5kZXggOTljMzVi YS4uYzJjMWM5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvTWlzYy9XZWJOU1VSTEV4 dHJhcy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dlYk5TVVJMRXh0cmFzLm1tCkBA IC0yNjQsMTAgKzI2NCw2IEBAIC0oTlNEYXRhICopX3dlYl9ob3N0RGF0YQogCiAtIChOU1N0cmlu ZyAqKV93ZWJfaG9zdFN0cmluZwogewotICAgIE5TRGF0YSAqZGF0YSA9IFtzZWxmIF93ZWJfaG9z dERhdGFdOwotICAgIGlmICghZGF0YSkgewotICAgICAgICBkYXRhID0gW05TRGF0YSBkYXRhXTsK LSAgICB9CiAgICAgcmV0dXJuIFtbW05TU3RyaW5nIGFsbG9jXSBpbml0V2l0aERhdGE6W3NlbGYg X3dlYl9ob3N0RGF0YV0gZW5jb2Rpbmc6TlNVVEY4U3RyaW5nRW5jb2RpbmddIGF1dG9yZWxlYXNl XTsKIH0KIAo=