118515 2013-07-09 10:56:50 -0700 8 bytes memory leaks in WebProcessMainQt.cpp when proxy is initialized 2013-09-25 23:32:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pmuarteo webkit-unassigned abecsi cdumez cmarcelo commit-queue gyuyoung.kim menard pmuarteo webkit.review.bot oldest_to_newest 907190 0 pmuarteo 2013-07-09 10:56:50 -0700 8 bytes memory leaks in WebProcessMainQt.cpp when proxy is initialized 907193 1 206344 pmuarteo 2013-07-09 11:06:46 -0700 Created attachment 206344 Patch 907194 2 commit-queue 2013-07-09 11:08:07 -0700 Attachment 206344 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp']" exit_code: 1 Source/WebKit2/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 907195 3 206345 pmuarteo 2013-07-09 11:13:02 -0700 Created attachment 206345 Patch 907197 4 206345 cdumez 2013-07-09 11:14:36 -0700 Comment on attachment 206345 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206345&action=review > Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp:140 > + delete proxyFactory; You might want to use OwnPtr and QNetworkProxyFactory::setApplicationProxyFactory(proxyFactory.leakPtr()); to avoid manual memory handling. 907202 5 206346 pmuarteo 2013-07-09 12:07:59 -0700 Created attachment 206346 Patch 907205 6 206346 cdumez 2013-07-09 12:36:44 -0700 Comment on attachment 206346 Patch Looks good, r=me. 907225 7 pmuarteo 2013-07-09 14:38:41 -0700 Thanks (In reply to comment #6) > (From update of attachment 206346 [details]) > Looks good, r=me. 933372 8 pmuarteo 2013-09-25 22:56:33 -0700 What else can I do to make it landing? Is there anyone to help me about it? 933373 9 206346 gyuyoung.kim 2013-09-25 23:05:33 -0700 Comment on attachment 206346 Patch Though I'm not a QT port developer, this patch looks good. 933374 10 gyuyoung.kim 2013-09-25 23:08:18 -0700 (In reply to comment #8) > What else can I do to make it landing? Is there anyone to help me about it? Do not change bug status with "Resolved Fixed" manually. commit bot will change the status after landing. See also https://bugs.webkit.org/page.cgi?id=fields.html#status 933377 11 206346 commit-queue 2013-09-25 23:32:04 -0700 Comment on attachment 206346 Patch Clearing flags on attachment: 206346 Committed r156449: <http://trac.webkit.org/changeset/156449> 933378 12 commit-queue 2013-09-25 23:32:07 -0700 All reviewed patches have been landed. Closing bug. 206344 2013-07-09 11:06:46 -0700 2013-07-09 11:13:00 -0700 Patch bug-118515-20130709110304.patch text/plain 1529 pmuarteo U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNDY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTA4Nzk4MDFmYjI5YTY1 MTZjN2QxNWZmODM5MWFjMGY1MDlkNGVhZC4uZmMzM2ZiNmYwZGY5OGJjNTQ5NWNiNTI0NDUzNTRj ODc3MmE4ZDg1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA3LTA5ICBNaW5q dSBLaW0gIDxwbXVhcnRlb0BnbWFpbC5jb20+CisKKyAgICAgICAgOCBieXRlcyBtZW1vcnkgbGVh a3MgaW4gV2ViUHJvY2Vzc01haW5RdC5jcHAgd2hlbiBwcm94eSBpcyBpbml0aWFsaXplZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NTE1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNz L3F0L1dlYlByb2Nlc3NNYWluUXQuY3BwOgorICAgICAgICAoV2ViS2l0Ojppbml0aWFsaXplUHJv eHkpOiBEZWxldGVkIEVudkh0dHBQcm94eUZhY3Rvcnkgd2hlbiB0aGUgb2JqZWN0CisJCWlzIG5v dCBpbml0aWFsaXplZCBmcm9tIGVudmlyb25tZW50IGFuZCB0aGVyZSBpcyBub3RoaW5nIHRvIGhh bmRsZSBpdC4KKwogMjAxMy0wNy0wNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUnVudGltZSBjcml0aWNhbCB3YXJuaW5nIHdoZW4g dW5sb2FkaW5nIGEgbW9kdWxlIHRoYXQgZmFpbGVkIHRvIGxvYWQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvV2ViUHJvY2Vzc01haW5RdC5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NNYWluUXQuY3BwCmluZGV4IGNjZDkzYTk3Zjc5 ZWEwOTg1MjlhOTFiOGE0NjMxMDU0NTNjZmFlNTQuLjJhMjRkYzA2Y2VkMzM1YzNjM2E1ZGI2NDhk NTAwMzVlNGQ4ZDVmZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQv V2ViUHJvY2Vzc01haW5RdC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9xdC9X ZWJQcm9jZXNzTWFpblF0LmNwcApAQCAtMTM2LDcgKzEzNiw4IEBAIHN0YXRpYyB2b2lkIGluaXRp YWxpemVQcm94eSgpCiAgICAgICAgICAgICBpZiAocHJveHlGYWN0b3J5LT5pbml0aWFsaXplRnJv bUVudmlyb25tZW50KCkpIHsKICAgICAgICAgICAgICAgICBRTmV0d29ya1Byb3h5RmFjdG9yeTo6 c2V0QXBwbGljYXRpb25Qcm94eUZhY3RvcnkocHJveHlGYWN0b3J5KTsKICAgICAgICAgICAgICAg ICByZXR1cm47Ci0gICAgICAgICAgICB9CisgICAgICAgICAgICB9IGVsc2UKKyAgICAgICAgICAg ICAgICBkZWxldGUgcHJveHlGYWN0b3J5OwogICAgICAgICB9CiAgICAgfQogICAgIFFOZXR3b3Jr UHJveHlGYWN0b3J5OjpzZXRVc2VTeXN0ZW1Db25maWd1cmF0aW9uKHRydWUpOwo= 206345 2013-07-09 11:13:02 -0700 2013-07-09 12:07:54 -0700 Patch bug-118515-20130709110921.patch text/plain 1535 pmuarteo U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNDY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTA4Nzk4MDFmYjI5YTY1 MTZjN2QxNWZmODM5MWFjMGY1MDlkNGVhZC4uNzJiYmUwNmQzMzg3MjBmODZiMTgyYmUwOWQ1MmIz MDQ4ZGUyNDUwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA3LTA5ICBNaW5q dSBLaW0gIDxwbXVhcnRlb0BnbWFpbC5jb20+CisKKyAgICAgICAgOCBieXRlcyBtZW1vcnkgbGVh a3MgaW4gV2ViUHJvY2Vzc01haW5RdC5jcHAgd2hlbiBwcm94eSBpcyBpbml0aWFsaXplZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NTE1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNz L3F0L1dlYlByb2Nlc3NNYWluUXQuY3BwOgorICAgICAgICAoV2ViS2l0Ojppbml0aWFsaXplUHJv eHkpOiBEZWxldGVkIEVudkh0dHBQcm94eUZhY3Rvcnkgd2hlbiB0aGUgb2JqZWN0CisgICAgICAg IGlzIG5vdCBpbml0aWFsaXplZCBmcm9tIGVudmlyb25tZW50IGFuZCB0aGVyZSBpcyBub3RoaW5n IHRvIGhhbmRsZSBpdC4KKwogMjAxMy0wNy0wNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2Fy Y2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUnVudGltZSBjcml0aWNhbCB3YXJuaW5n IHdoZW4gdW5sb2FkaW5nIGEgbW9kdWxlIHRoYXQgZmFpbGVkIHRvIGxvYWQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvV2ViUHJvY2Vzc01haW5RdC5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NNYWluUXQuY3BwCmluZGV4IGNjZDkz YTk3Zjc5ZWEwOTg1MjlhOTFiOGE0NjMxMDU0NTNjZmFlNTQuLjJhMjRkYzA2Y2VkMzM1YzNjM2E1 ZGI2NDhkNTAwMzVlNGQ4ZDVmZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvcXQvV2ViUHJvY2Vzc01haW5RdC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9xdC9XZWJQcm9jZXNzTWFpblF0LmNwcApAQCAtMTM2LDcgKzEzNiw4IEBAIHN0YXRpYyB2b2lk IGluaXRpYWxpemVQcm94eSgpCiAgICAgICAgICAgICBpZiAocHJveHlGYWN0b3J5LT5pbml0aWFs aXplRnJvbUVudmlyb25tZW50KCkpIHsKICAgICAgICAgICAgICAgICBRTmV0d29ya1Byb3h5RmFj dG9yeTo6c2V0QXBwbGljYXRpb25Qcm94eUZhY3RvcnkocHJveHlGYWN0b3J5KTsKICAgICAgICAg ICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICB9CisgICAgICAgICAgICB9IGVsc2UKKyAgICAg ICAgICAgICAgICBkZWxldGUgcHJveHlGYWN0b3J5OwogICAgICAgICB9CiAgICAgfQogICAgIFFO ZXR3b3JrUHJveHlGYWN0b3J5OjpzZXRVc2VTeXN0ZW1Db25maWd1cmF0aW9uKHRydWUpOwo= 206346 2013-07-09 12:07:59 -0700 2013-09-25 23:32:03 -0700 Patch bug-118515-20130709120417.patch text/plain 1838 pmuarteo U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNDY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTA4Nzk4MDFmYjI5YTY1 MTZjN2QxNWZmODM5MWFjMGY1MDlkNGVhZC4uYjExYWI4OTE1ZmVlMzUyNjAyODMyMWQzNGYwN2Qz Yjc3NjM5MzUxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA3LTA5ICBNaW5q dSBLaW0gIDxwbXVhcnRlb0BnbWFpbC5jb20+CisKKyAgICAgICAgOCBieXRlcyBtZW1vcnkgbGVh a3MgaW4gV2ViUHJvY2Vzc01haW5RdC5jcHAgd2hlbiBwcm94eSBpcyBpbml0aWFsaXplZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NTE1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNz L3F0L1dlYlByb2Nlc3NNYWluUXQuY3BwOgorICAgICAgICAoV2ViS2l0Ojppbml0aWFsaXplUHJv eHkpOiBIYW5kbGVkIEVudkh0dHBQcm94eUZhY3RvcnkgYnkgdXNpbmcgT3duUHRyCisgICAgICAg IHRvIGF2b2lkIG1lbW9yeSBsZWFrIHdoZW4gaXQgaXNuJ3QgaGFuZGxlZCBieSBOZXR3b3JrUHJv eHlGYWN0b3J5CisKIDIwMTMtMDctMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFJ1bnRpbWUgY3JpdGljYWwgd2FybmluZyB3aGVu IHVubG9hZGluZyBhIG1vZHVsZSB0aGF0IGZhaWxlZCB0byBsb2FkCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NNYWluUXQuY3BwIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzTWFpblF0LmNwcAppbmRleCBjY2Q5M2E5N2Y3 OWVhMDk4NTI5YTkxYjhhNDYzMTA1NDUzY2ZhZTU0Li40NzRiNmM2ZmU1N2ZkZWE0YjQyYTc3YTAw MWVlNDY0MDVhMTliMGY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0 L1dlYlByb2Nlc3NNYWluUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQv V2ViUHJvY2Vzc01haW5RdC5jcHAKQEAgLTEzMiw5ICsxMzIsOSBAQCBzdGF0aWMgdm9pZCBpbml0 aWFsaXplUHJveHkoKQogICAgIGlmIChwcm94eWxpc3QuY291bnQoKSA9PSAxKSB7CiAgICAgICAg IFFOZXR3b3JrUHJveHkgcHJveHkgPSBwcm94eWxpc3QuZmlyc3QoKTsKICAgICAgICAgaWYgKHBy b3h5ID09IFFOZXR3b3JrUHJveHk6Ok5vUHJveHkgfHwgcHJveHkgPT0gUU5ldHdvcmtQcm94eTo6 RGVmYXVsdFByb3h5KSB7Ci0gICAgICAgICAgICBFbnZIdHRwUHJveHlGYWN0b3J5KiBwcm94eUZh Y3RvcnkgPSBuZXcgRW52SHR0cFByb3h5RmFjdG9yeSgpOworICAgICAgICAgICAgT3duUHRyPEVu dkh0dHBQcm94eUZhY3Rvcnk+IHByb3h5RmFjdG9yeSA9IGFkb3B0UHRyKG5ldyBFbnZIdHRwUHJv eHlGYWN0b3J5KCkpOwogICAgICAgICAgICAgaWYgKHByb3h5RmFjdG9yeS0+aW5pdGlhbGl6ZUZy b21FbnZpcm9ubWVudCgpKSB7Ci0gICAgICAgICAgICAgICAgUU5ldHdvcmtQcm94eUZhY3Rvcnk6 OnNldEFwcGxpY2F0aW9uUHJveHlGYWN0b3J5KHByb3h5RmFjdG9yeSk7CisgICAgICAgICAgICAg ICAgUU5ldHdvcmtQcm94eUZhY3Rvcnk6OnNldEFwcGxpY2F0aW9uUHJveHlGYWN0b3J5KHByb3h5 RmFjdG9yeS5sZWFrUHRyKCkpOwogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAg IH0KICAgICAgICAgfQo=