118509 2013-07-09 09:08:57 -0700 [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents 2013-07-10 01:42:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 spena spena cgarcia commit-queue haraken kenneth mrobinson simon.fraser oldest_to_newest 907128 0 spena 2013-07-09 09:08:57 -0700 [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents 907132 1 206327 spena 2013-07-09 09:14:08 -0700 Created attachment 206327 Patch 907142 2 206327 mrobinson 2013-07-09 09:28:55 -0700 Comment on attachment 206327 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206327&action=review > Tools/ChangeLog:14 > + fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer > + crashes after this fix is added. This patch isn't removing it from the TestExpectations file though? 907145 3 spena 2013-07-09 09:36:47 -0700 (In reply to comment #2) > This patch isn't removing it from the TestExpectations file though? No, it isn't. The GTK-WK2 buildbot is a bit red these days, and this test has been failing probably forever (the flakiness dashboard doesn't have any records of it passing). I am (slowly) trying to improve the bots situation these days, maybe I should have started skipping them first, and then go on with fixes? 907146 4 spena 2013-07-09 09:37:36 -0700 (In reply to comment #3) > (In reply to comment #2) > > This patch isn't removing it from the TestExpectations file though? > > No, it isn't. The GTK-WK2 buildbot is a bit red these days, and this test has been failing probably forever (the flakiness dashboard doesn't have any records of it passing). (The test wasn't skipped on GTK-WK1, it worked fine there) 907147 5 206327 mrobinson 2013-07-09 09:37:36 -0700 Comment on attachment 206327 Patch It's fine to just fix it now. Thanks! 907313 6 206327 commit-queue 2013-07-10 01:42:08 -0700 Comment on attachment 206327 Patch Clearing flags on attachment: 206327 Committed r152530: <http://trac.webkit.org/changeset/152530> 907314 7 commit-queue 2013-07-10 01:42:11 -0700 All reviewed patches have been landed. Closing bug. 206327 2013-07-09 09:14:08 -0700 2013-07-10 01:42:08 -0700 Patch bug-118509-20130709171139.patch text/plain 2809 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNDkxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjRlMjFlNWRmNWQ0NzNmYTE1OTkyZjU2YmYwZDVhZjVk ZmE1ZmI4Yi4uMjgxNWQ4MDg1NGFhMWI3ZjNjNTE4MmJkZjFiMTRmNzU2MGM2NDhkOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDEzLTA3LTA5ICBTaW1vbiBQZW5hICA8c2ltb24ucGVuYUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbR1RLXSBXZWJLaXRUZXN0UnVubmVyIHRyaWVzIHRvIHJlbW92ZSBhbiBhbHJlYWR5 IGRlbGV0ZWQgZXZlbnQgaW4gRXZlbnRTZW5kZXJQcm94eTo6cmVwbGF5U2F2ZWRFdmVudHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODUwOQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIEV2ZW50U2Vu ZGVyUHJveHk6OnJlcGxheVNhdmVkRXZlbnRzIFdlYktpdFRlc3RSdW5uZXIgY2FuIGNyYXNoCisg ICAgICAgIHdoZW4gdHJ5aW5nIHRvIHJlbW92ZSBhbiBldmVudCBhbHJlYWR5IHJlbW92ZWQsIGlm IGFub3RoZXIgZXZlbnQgaXMKKyAgICAgICAgcHJvY2Vzc2VkIGluIHRoZSBtaWRkbGUuIEJ5IHVz aW5nIGEgRGVxdWUncyB0YWtlRmlyc3QsIHdlIGVuc3VyZSB0aGUKKyAgICAgICAgZWxlbWVudCBp cyByZW1vdmVkIGJlZm9yZSB3ZSBkaXNwYXRjaCBpdC4KKworICAgICAgICBmYXN0L2V2ZW50cy9t b3VzZWRvd24taW5zaWRlLWRyYWdzdGFydC1zaG91bGQtbm90LWNhdXNlLWNyYXNoLmh0bWwgbm8g bG9uZ2VyCisgICAgICAgIGNyYXNoZXMgYWZ0ZXIgdGhpcyBmaXggaXMgYWRkZWQuCisKKyAgICAg ICAgKiBXZWJLaXRUZXN0UnVubmVyL0V2ZW50U2VuZGVyUHJveHkuaDogVXNlIGEgRGVxdWUgaW5z dGVhZCBvZiBWZWN0b3IgaW4gR1RLCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9ndGsvRXZl bnRTZW5kZXJQcm94eUd0ay5jcHA6CisgICAgICAgIChXVFI6OkV2ZW50U2VuZGVyUHJveHk6OnJl cGxheVNhdmVkRXZlbnRzKTogVXNlIHRha2VGaXJzdCB0byByZXRyaWV2ZSB0aGUgZXZlbnQKKyAg ICAgICAgZnJvbSB0aGUgcXVldWUuCisKIDIwMTMtMDctMDggIFphbiBEb2JlcnNlayAgPHpkb2Jl cnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEtVUkwgdW5pdCB0ZXN0IGZpeHR1cmUgY2xhc3Mg c2hvdWxkIGhhdmUgYSBtZWFuaW5nZnVsIG5hbWUKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRl c3RSdW5uZXIvRXZlbnRTZW5kZXJQcm94eS5oIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9FdmVu dFNlbmRlclByb3h5LmgKaW5kZXggOTJmZTJkMDc3NGNmYjJkNjEyOWVkMGIwNGQ4ODVlYThiNDQ3 OGQ0OS4uYmI4MTRhOGZjZTRiYWEwZjYwMTY0Y2U2ZjRkYjllMWI2ZWYyYzZhOSAxMDA2NDQKLS0t IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9FdmVudFNlbmRlclByb3h5LmgKKysrIGIvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9FdmVudFNlbmRlclByb3h5LmgKQEAgLTMyLDcgKzMyLDcgQEAKICNp bmNsdWRlIDxRVG91Y2hFdmVudD4KICNlbGlmIFBMQVRGT1JNKEdUSykKICNpbmNsdWRlIDxnZGsv Z2RrLmg+Ci0jaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgorI2luY2x1ZGUgPHd0Zi9EZXF1ZS5oPgog I2VsaWYgUExBVEZPUk0oRUZMKQogI2luY2x1ZGUgPFdlYktpdDIvRVdlYktpdDIuaD4KICNpbmNs dWRlIDx3dGYvRGVxdWUuaD4KQEAgLTExNCw3ICsxMTQsNyBAQCBwcml2YXRlOgogI2lmIFBMQVRG T1JNKE1BQykKICAgICBpbnQgZXZlbnROdW1iZXI7CiAjZWxpZiBQTEFURk9STShHVEspCi0gICAg VmVjdG9yPFdUUkV2ZW50UXVldWVJdGVtPiBtX2V2ZW50UXVldWU7CisgICAgRGVxdWU8V1RSRXZl bnRRdWV1ZUl0ZW0+IG1fZXZlbnRRdWV1ZTsKICAgICB1bnNpZ25lZCBtX21vdXNlQnV0dG9uQ3Vy cmVudGx5RG93bjsKICNlbGlmIFBMQVRGT1JNKFFUKQogICAgIFF0OjpNb3VzZUJ1dHRvbnMgbV9t b3VzZUJ1dHRvbnM7CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2d0ay9FdmVu dFNlbmRlclByb3h5R3RrLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL0V2ZW50U2Vu ZGVyUHJveHlHdGsuY3BwCmluZGV4IDNkY2IwM2E4YWQzMmM0OTNhZDVmNzFhMzJmYzM3NTA5YWNk ZmM1MDYuLjI5NTUzMmU2YTNkYjYxZjMwNDU4N2U0ZjRlNzVmN2NiNmQzY2RjYTQgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL0V2ZW50U2VuZGVyUHJveHlHdGsuY3BwCisr KyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL0V2ZW50U2VuZGVyUHJveHlHdGsuY3BwCkBA IC0xNTUsMTIgKzE1NSwxMSBAQCBzdGF0aWMgdm9pZCBkaXNwYXRjaEV2ZW50KEdka0V2ZW50KiBl dmVudCkKIHZvaWQgRXZlbnRTZW5kZXJQcm94eTo6cmVwbGF5U2F2ZWRFdmVudHMoKQogewogICAg IHdoaWxlICghbV9ldmVudFF1ZXVlLmlzRW1wdHkoKSkgewotICAgICAgICBXVFJFdmVudFF1ZXVl SXRlbSBpdGVtID0gbV9ldmVudFF1ZXVlLmZpcnN0KCk7CisgICAgICAgIFdUUkV2ZW50UXVldWVJ dGVtIGl0ZW0gPSBtX2V2ZW50UXVldWUudGFrZUZpcnN0KCk7CiAgICAgICAgIGlmIChpdGVtLmRl bGF5KQogICAgICAgICAgICAgZ191c2xlZXAoaXRlbS5kZWxheSAqIDEwMDApOwogCiAgICAgICAg IGRpc3BhdGNoRXZlbnQoaXRlbS5ldmVudCk7Ci0gICAgICAgIG1fZXZlbnRRdWV1ZS5yZW1vdmUo MCk7CiAgICAgfQogfQogCg==