118505 2013-07-09 07:03:52 -0700 Leak: TextCodecICU::registerCodecs is leaking 2017-11-28 14:39:11 -0800 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=154737 https://bugs.webkit.org/show_bug.cgi?id=160931 InRadar P2 Normal --- 116317 106716 1 brian.holt ap ap cdumez commit-queue darin ews-watchlist glenn joepeck menard mrobinson psolanki simon.fraser oldest_to_newest 907104 0 brian.holt 2013-07-09 07:03:52 -0700 In Source/WebCore/platform/text/TextCodecICU.cpp:215 Leaks found using the "--leak" option in the Gtk port: Command: /home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Debug/Programs/DumpRenderTree - Leak_DefinitelyLost 70 bytes in 7 blocks are definitely lost in loss record 10,235 of 17,061 malloc (/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) WTF::fastMalloc(unsigned long) (/WebKitBuild/Debug/../../Source/WTF/wtf/FastMalloc.cpp:286) WTF::fastStrDup(char const*) (/WebKitBuild/Debug/../../Source/WTF/wtf/FastMalloc.cpp:219) WebCore::TextCodecICU::registerCodecs(void (*)(char const*, WTF::PassOwnPtr<WebCore::TextCodec> (*)(WebCore::TextEncoding const&, void const*), void const*)) (/WebKitBuild/Debug/../../Source/WebCore/platform/text/TextCodecICU.cpp:215) WebCore::extendTextCodecMaps() (/WebKitBuild/Debug/../../Source/WebCore/platform/text/TextEncodingRegistry.cpp:293) WebCore::atomicCanonicalTextEncodingName(char const*) (/WebKitBuild/Debug/../../Source/WebCore/platform/text/TextEncodingRegistry.cpp:338) char const* WebCore::atomicCanonicalTextEncodingName<unsigned char>(unsigned char const*, unsigned long) (/WebKitBuild/Debug/../../Source/WebCore/platform/text/TextEncodingRegistry.cpp:355) WebCore::atomicCanonicalTextEncodingName(WTF::String const&) (/WebKitBuild/Debug/../../Source/WebCore/platform/text/TextEncodingRegistry.cpp:364) WebCore::TextEncoding::TextEncoding(WTF::String const&) (/WebKitBuild/Debug/../../Source/WebCore/platform/text/TextEncoding.cpp:57) WebCore::XMLHttpRequest::didReceiveData(char const*, int) (/WebKitBuild/Debug/../../Source/WebCore/xml/XMLHttpRequest.cpp:1198) WebCore::DocumentThreadableLoader::didReceiveData(unsigned long, char const*, int) (/WebKitBuild/Debug/../../Source/WebCore/loader/DocumentThreadableLoader.cpp:299) WebCore::DocumentThreadableLoader::loadRequest(WebCore::ResourceRequest const&, WebCore::SecurityCheckPolicy) (/WebKitBuild/Debug/../../Source/WebCore/loader/DocumentThreadableLoader.cpp:426) WebCore::DocumentThreadableLoader::DocumentThreadableLoader(WebCore::Document*, WebCore::ThreadableLoaderClient*, WebCore::DocumentThreadableLoader::BlockingBehavior, WebCore::ResourceRequest const&, WebCore::ThreadableLoaderOptions const&) (/WebKitBuild/Debug/../../Source/WebCore/loader/DocumentThreadableLoader.cpp:87) WebCore::DocumentThreadableLoader::loadResourceSynchronously(WebCore::Document*, WebCore::ResourceRequest const&, WebCore::ThreadableLoaderClient&, WebCore::ThreadableLoaderOptions const&) (/WebKitBuild/Debug/../../Source/WebCore/loader/DocumentThreadableLoader.cpp:61) WebCore::ThreadableLoader::loadResourceSynchronously(WebCore::ScriptExecutionContext*, WebCore::ResourceRequest const&, WebCore::ThreadableLoaderClient&, WebCore::ThreadableLoaderOptions const&) (/WebKitBuild/Debug/../../Source/WebCore/loader/ThreadableLoader.cpp:78) WebCore::XMLHttpRequest::createRequest(int&) (/WebKitBuild/Debug/../../Source/WebCore/xml/XMLHttpRequest.cpp:818) WebCore::XMLHttpRequest::send(WTF::String const&, int&) (/WebKitBuild/Debug/../../Source/WebCore/xml/XMLHttpRequest.cpp:644) WebCore::JSXMLHttpRequest::send(JSC::ExecState*) (/WebKitBuild/Debug/../../Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp:133) WebCore::jsXMLHttpRequestPrototypeFunctionSend(JSC::ExecState*) (/WebKitBuild/Debug/DerivedSources/WebCore/JSXMLHttpRequest.cpp:643) 0x3959E0E4 () JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) (/WebKitBuild/Debug/../../Source/JavaScriptCore/jit/JITCode.h:135) JSC::Interpreter::execute(JSC::EvalExecutable*, JSC::ExecState*, JSC::JSValue, JSC::JSScope*) (/WebKitBuild/Debug/../../Source/JavaScriptCore/interpreter/Interpreter.cpp:1286) JSC::eval(JSC::ExecState*) (/WebKitBuild/Debug/../../Source/JavaScriptCore/interpreter/Interpreter.cpp:160) llint_slow_path_call_eval (/WebKitBuild/Debug/../../Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1489) 0x59927D4 (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Debug/.libs/libjavascriptcoregtk-3.0.so.0.14.1) JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) (/WebKitBuild/Debug/../../Source/JavaScriptCore/jit/JITCode.h:135) JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::JSObject*) (/WebKitBuild/Debug/../../Source/JavaScriptCore/interpreter/Interpreter.cpp:937) JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) (/WebKitBuild/Debug/../../Source/JavaScriptCore/runtime/Completion.cpp:83) WebCore::JSMainThreadExecState::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) (/WebKitBuild/Debug/../../Source/WebCore/bindings/js/JSMainThreadExecState.h:77) WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld*) (/WebKitBuild/Debug/../../Source/WebCore/bindings/js/ScriptController.cpp:142) WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) (/WebKitBuild/Debug/../../Source/WebCore/bindings/js/ScriptController.cpp:158) WebCore::ScriptElement::executeScript(WebCore::ScriptSourceCode const&) (/WebKitBuild/Debug/../../Source/WebCore/dom/ScriptElement.cpp:316) WebCore::ScriptElement::prepareScript(WTF::TextPosition const&, WebCore::ScriptElement::LegacyTypeSupport) (/WebKitBuild/Debug/../../Source/WebCore/dom/ScriptElement.cpp:245) WebCore::HTMLScriptRunner::runScript(WebCore::Element*, WTF::TextPosition const&) (/WebKitBuild/Debug/../../Source/WebCore/html/parser/HTMLScriptRunner.cpp:312) WebCore::HTMLScriptRunner::execute(WTF::PassRefPtr<WebCore::Element>, WTF::TextPosition const&) (/WebKitBuild/Debug/../../Source/WebCore/html/parser/HTMLScriptRunner.cpp:181) WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder() (/WebKitBuild/Debug/../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:271) WebCore::HTMLDocumentParser::canTakeNextToken(WebCore::HTMLDocumentParser::SynchronousMode, WebCore::PumpSession&) (/WebKitBuild/Debug/../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:290) WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) (/WebKitBuild/Debug/../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:535) WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode) (/WebKitBuild/Debug/../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:235) WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution() (/WebKitBuild/Debug/../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:896) Suppression (error hash=#81F7BC2F68C3BF33#): For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports { <insert_a_suppression_name_here> Memcheck:Leak fun:malloc fun:_ZN3WTF10fastMallocEm fun:_ZN3WTF10fastStrDupEPKc fun:_ZN7WebCore12TextCodecICU14registerCodecsEPFvPKcPFN3WTF10PassOwnPtrINS_9TextCodecEEERKNS_12TextEncodingEPKvESB_E fun:_ZN7WebCoreL19extendTextCodecMapsEv fun:_ZN7WebCore31atomicCanonicalTextEncodingNameEPKc fun:_ZN7WebCore31atomicCanonicalTextEncodingNameIhEEPKcPKT_m fun:_ZN7WebCore31atomicCanonicalTextEncodingNameERKN3WTF6StringE fun:_ZN7WebCore12TextEncodingC1ERKN3WTF6StringE fun:_ZN7WebCore14XMLHttpRequest14didReceiveDataEPKci fun:_ZN7WebCore24DocumentThreadableLoader14didReceiveDataEmPKci fun:_ZN7WebCore24DocumentThreadableLoader11loadRequestERKNS_15ResourceRequestENS_19SecurityCheckPolicyE fun:_ZN7WebCore24DocumentThreadableLoaderC1EPNS_8DocumentEPNS_22ThreadableLoaderClientENS0_16BlockingBehaviorERKNS_15ResourceRequestERKNS_23ThreadableLoaderOptionsE fun:_ZN7WebCore24DocumentThreadableLoader25loadResourceSynchronouslyEPNS_8DocumentERKNS_15ResourceRequestERNS_22ThreadableLoaderClientERKNS_23ThreadableLoaderOptionsE fun:_ZN7WebCore16ThreadableLoader25loadResourceSynchronouslyEPNS_22ScriptExecutionContextERKNS_15ResourceRequestERNS_22ThreadableLoaderClientERKNS_23ThreadableLoaderOptionsE fun:_ZN7WebCore14XMLHttpRequest13createRequestERi fun:_ZN7WebCore14XMLHttpRequest4sendERKN3WTF6StringERi fun:_ZN7WebCore16JSXMLHttpRequest4sendEPN3JSC9ExecStateE fun:_ZN7WebCore37jsXMLHttpRequestPrototypeFunctionSendEPN3JSC9ExecStateE obj:* fun:_ZN3JSC7JITCode7executeEPNS_7JSStackEPNS_9ExecStateEPNS_2VME fun:_ZN3JSC11Interpreter7executeEPNS_14EvalExecutableEPNS_9ExecStateENS_7JSValueEPNS_7JSScopeE } 907109 1 206319 brian.holt 2013-07-09 07:18:23 -0700 Created attachment 206319 Patch 907134 2 206319 ap 2013-07-09 09:15:40 -0700 Comment on attachment 206319 Patch I think that the leak may be real, but the fix is not right. Generally, these strings are permanently stored in textCodecMap, and not leaked. One case where a leak may occur is when the same webStandardName is registered multiple times - when this happens, map value is thrown away. However, I don't think that it's correct to remove fastStrDup. The result of ucnv_getCanonicalName is not documented to remain useful indefinitely - for example, they may be reusing a static buffer. So, we need our own copy of the string. 907148 3 brian.holt 2013-07-09 09:40:22 -0700 (In reply to comment #2) > (From update of attachment 206319 [details]) > I think that the leak may be real, but the fix is not right. > > Generally, these strings are permanently stored in textCodecMap, and not leaked. One case where a leak may occur is when the same webStandardName is registered multiple times - when this happens, map value is thrown away. > > However, I don't think that it's correct to remove fastStrDup. The result of ucnv_getCanonicalName is not documented to remain useful indefinitely - for example, they may be reusing a static buffer. So, we need our own copy of the string. Thanks for your comments. It seems that there might be some inconsistency in the way that the memory is handled. If we need our own copy of the string, should we also make a copy of canonicalConverterName on line 193? And if we're making copies then should the responsibility fall to TextCodecMap to free the additional data? But the additionalData is const implying (at least to me) that the TextCodecMap doesn't own that data. What would you suggest would be the best way to address the leak? 907158 4 ap 2013-07-09 09:58:15 -0700 > If we need our own copy of the string, should we also make a copy of canonicalConverterName on line 193? Indeed! > And if we're making copies then should the responsibility fall to TextCodecMap to free the additional data? But the additionalData is const implying (at least to me) that the TextCodecMap doesn't own that data. Generally speaking, constness is separate from ownership, it's perfectly fine to free a const pointer. The tricky part here is that additional data is not necessarily a string pointer - TextCodecMap passes a pointer to a number. So the function to delete additional data needs to be provided by caller. > What would you suggest would be the best way to address the leak? I think that we shouldn't enumerate ICU aliases at all, and have our own encoding name table that's suitable for the web instead (similarly to what TextCodecMac does for legacy Mac encodings). That would be a valuable architectural improvement, and it would sidestep this issue entirely. Given the complexity of fixing only this leak, we should consider just implementing the above idea. 951483 5 ap 2013-11-17 22:19:45 -0800 <rdar://problem/15486167> 1036278 6 ap 2014-09-19 19:35:49 -0700 *** Bug 136973 has been marked as a duplicate of this bug. *** 1086983 7 ap 2015-04-20 20:06:47 -0700 *** Bug 143975 has been marked as a duplicate of this bug. *** 1087052 8 darin 2015-04-21 08:45:21 -0700 It would be nice to fix this leak. But keep in mind that we leaked intentionally when originally creating this code, and it’s a little tricky to design this out. I like Alexey’s suggestion above. 1375498 9 ap 2017-11-28 13:26:49 -0800 This was fixed in r204605, just need to remove the special case from leaks parser. 1375501 10 327782 ap 2017-11-28 13:30:40 -0800 Created attachment 327782 stop silencing the leak 1375530 11 327782 joepeck 2017-11-28 14:19:30 -0800 Comment on attachment 327782 stop silencing the leak r=me 1375540 12 327782 commit-queue 2017-11-28 14:39:08 -0800 Comment on attachment 327782 stop silencing the leak Clearing flags on attachment: 327782 Committed r225240: <https://trac.webkit.org/changeset/225240> 1375541 13 commit-queue 2017-11-28 14:39:11 -0800 All reviewed patches have been landed. Closing bug. 206319 2013-07-09 07:18:23 -0700 2017-11-28 13:30:40 -0800 Patch bug-118505-20130709151623.patch text/plain 1497 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIyMmM4NDgzNzQ4MzM5 ZmNkYjNjODEwNWRmZGE3MWZjMzViMThlOC4uNzlhN2U4Mjc2ODFmMzUwZjM2ZGFiMjNkODg5ZDUw MzI3YTM4N2U3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA3LTA5ICBCcmlh biBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKworICAgICAgICBMZWFrOiBUZXh0Q29k ZWNJQ1U6OnJlZ2lzdGVyQ29kZWNzIGlzIGxlYWtpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODUwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIG1lbW9yeSBsZWFrIGJ5IHJlbW92aW5nIGNh bGwgdG8gZHVwbGljYXRlIHN0cmluZy4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvVGV4dENv ZGVjSUNVLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRDb2RlY0lDVTo6cmVnaXN0ZXJDb2Rl Y3MpOgorCiAyMDEzLTA3LTA5ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5j b20+CiAKICAgICAgICAgVXNlIHRvU1ZHRm9udEVsZW1lbnQoKSBpbnN0ZWFkIG9mIHN0YXRpY19j YXN0PFNWR0ZvbnRFbGVtZW50Kj4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3RleHQvVGV4dENvZGVjSUNVLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4 dENvZGVjSUNVLmNwcAppbmRleCA4NmQ0ZWExNzI2NTQyM2Q0M2NmM2ZjYTYwMzAzZGU0MjY0Mzk5 YmNhLi40NjE1YTI5YTU5ODdlMmVlZWQzZjQ3ZTViMDExN2RhNWRjNmJkZmJlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRDb2RlY0lDVS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9UZXh0Q29kZWNJQ1UuY3BwCkBAIC0yMTIsNyArMjEy LDcgQEAgdm9pZCBUZXh0Q29kZWNJQ1U6OnJlZ2lzdGVyQ29kZWNzKFRleHRDb2RlY1JlZ2lzdHJh ciByZWdpc3RyYXIpCiAgICAgICAgICAgICB8fCBzdHJjbXAod2ViU3RhbmRhcmROYW1lLCAiVElT LTYyMCIpID09IDApCiAgICAgICAgICAgICBjb250aW51ZTsKIAotICAgICAgICByZWdpc3RyYXIo d2ViU3RhbmRhcmROYW1lLCBjcmVhdGUsIGZhc3RTdHJEdXAoY2Fub25pY2FsQ29udmVydGVyTmFt ZSkpOworICAgICAgICByZWdpc3RyYXIod2ViU3RhbmRhcmROYW1lLCBjcmVhdGUsIGNhbm9uaWNh bENvbnZlcnRlck5hbWUpOwogICAgIH0KIAogICAgIC8vIFRoZXNlIGVuY29kaW5ncyBjdXJyZW50 bHkgZG9uJ3QgaGF2ZSBzdGFuZGFyZCBuYW1lcywgc28gd2UgbmVlZCB0byByZWdpc3RlciBlbmNv ZGVycyBtYW51YWxseS4K 327782 2017-11-28 13:30:40 -0800 2017-11-28 14:39:08 -0800 stop silencing the leak RegisterCodecsLeaks.txt text/plain 2145 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNTIzNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTExLTI4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFN0b3Agc2lsZW5jaW5nIGxlYWtzIGluIFRleHRDb2RlY0lDVTo6cmVnaXN0 ZXJDb2RlY3MsIGFzIHRoZSBwcm9ibGVtIHdhcyBmaXhlZCBhIHdoaWxlIGFnby4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODUwNQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy92YWxncmlu ZC9zdXBwcmVzc2lvbnMudHh0OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9sZWFr ZGV0ZWN0b3IucHk6CisgICAgICAgIChMZWFrRGV0ZWN0b3IuX2NhbGxzdGFja3NfdG9fZXhjbHVk ZV9mcm9tX2xlYWtzKToKKwogMjAxNy0xMS0yOCAgTXMyZ2VyICA8TXMyZ2VyQGlnYWxpYS5jb20+ CiAKICAgICAgICAgU3RvcCBtb2RpZnlpbmcgc2VsZi5leHBlY3RhdGlvbnMgaW4gVGVzdEV4cGVj dGF0aW9uTGluZS5leHBlY3RlZF9iZWhhdmlvci4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvdmFsZ3Jp bmQvc3VwcHJlc3Npb25zLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3ZhbGdyaW5k L3N1cHByZXNzaW9ucy50eHQJKHJldmlzaW9uIDIyNTIwMCkKKysrIFRvb2xzL1NjcmlwdHMvdmFs Z3JpbmQvc3VwcHJlc3Npb25zLnR4dAkod29ya2luZyBjb3B5KQpAQCAtNTk0LDggKzU5NCw2IEBA CiB9CiAKIHsKLSAgICMgVGV4dENvZGVjSUNVOjpyZWdpc3RlckNvZGVjcyBpcyBsZWFraW5nIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg1MDUKLSAgIFdlYkNvcmU6 OlRleHRDb2RlYzo6cmVnaXN0ZXJDb2RlY3MoKQogICAgTWVtY2hlY2s6TGVhawogICAgZnVuOm1h bGxvYwogICAgZnVuOl9aTjNXVEYxMGZhc3RNYWxsb2NFbQpJbmRleDogVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9wb3J0L2xlYWtkZXRlY3Rvci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3BvcnQvbGVha2RldGVjdG9yLnB5CShyZXZpc2lvbiAyMjUyMDApCisrKyBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbGVha2RldGVjdG9yLnB5CSh3b3JraW5nIGNvcHkpCkBA IC01NCwxMiArNTQsOSBAQCBjbGFzcyBMZWFrRGV0ZWN0b3Iob2JqZWN0KToKIAogICAgIGRlZiBf Y2FsbHN0YWNrc190b19leGNsdWRlX2Zyb21fbGVha3Moc2VsZik6CiAgICAgICAgIGNhbGxzdGFj a3MgPSBbCi0gICAgICAgICAgICAnVGV4dENvZGVjSUNVOjpyZWdpc3RlckNvZGVjcycsICAjIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg1MDUKKyAgICAgICAgICAg ICMgTGlzdCBzdWJzdHJpbmdzIGhlcmUsIGUuZy4KKyAgICAgICAgICAgICMgJ1RleHRDb2RlY0lD VTo6cmVnaXN0ZXJDb2RlY3MnLCAgIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTE4NTA1CiAgICAgICAgIF0KLSAgICAgICAgaWYgc2VsZi5fcG9ydC5vcGVyYXRpbmdf c3lzdGVtID09ICdtYWMnIGFuZCBzZWxmLl9wb3J0LmlzX21hdmVyaWNrcygpOgotICAgICAgICAg ICAgY2FsbHN0YWNrcyArPSBbCi0gICAgICAgICAgICAgICAgJ0FWQXNzZXRSZXNvdXJjZUxvYWRl ciBfcG9zZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlV2l0aEtleTpkYXRhOnJlcXVlc3REaWN0aW9u YXJ5OmZhbGxiYWNrSGFuZGxlcjonLCAgIyA8cmRhcjovL3Byb2JsZW0vMTk2OTk4ODc+IGxlYWsg aW4gQVZGb3VuZGF0aW9uCi0gICAgICAgICAgICBdCiAgICAgICAgIHJldHVybiBjYWxsc3RhY2tz CiAKICAgICBkZWYgX2xlYWtzX2FyZ3Moc2VsZiwgcGlkKToK