118496 2013-07-09 01:46:02 -0700 Use toSVGFontElement() instead of static_cast<SVGFontElement*> 2013-07-09 04:32:10 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue d-r fmalita pdr schenney zimmermann oldest_to_newest 907038 0 gyuyoung.kim 2013-07-09 01:46:02 -0700 As a step to change static_cast with toXXX, static_cast<SVGFontElement*> can be changed with toSVGFontElement(). Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153761 907039 1 206300 gyuyoung.kim 2013-07-09 01:51:10 -0700 Created attachment 206300 Patch 907070 2 206300 kling 2013-07-09 04:09:14 -0700 Comment on attachment 206300 Patch r=me. It would be nice to have an isSVGFontElement(const Node*) instead of checking hasTagName(). 907071 3 gyuyoung.kim 2013-07-09 04:10:36 -0700 (In reply to comment #2) > (From update of attachment 206300 [details]) > r=me. > > It would be nice to have an isSVGFontElement(const Node*) instead of checking hasTagName(). Ok, no problem. I will file a bug for it. 907076 4 206300 commit-queue 2013-07-09 04:32:07 -0700 Comment on attachment 206300 Patch Clearing flags on attachment: 206300 Committed r152491: <http://trac.webkit.org/changeset/152491> 907077 5 commit-queue 2013-07-09 04:32:10 -0700 All reviewed patches have been landed. Closing bug. 206300 2013-07-09 01:51:10 -0700 2013-07-09 04:32:07 -0700 Patch bug-118496-20130709174856.patch text/plain 6624 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNDQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjI5NTNkY2MyNmJkM2E2 YzQ1ZjkzMTg2MGZkYjRkYmQ4OGJhMjNhMy4uMGRjN2Y0MGM0YzgyYjM0ZTAyOTI0NjVjNjY5MmY4 MThjMjczYzhjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEzLTA3LTA5ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgVXNlIHRvU1ZH Rm9udEVsZW1lbnQoKSBpbnN0ZWFkIG9mIHN0YXRpY19jYXN0PFNWR0ZvbnRFbGVtZW50Kj4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODQ5NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzIGEgc3RlcCB0 byBjaGFuZ2Ugc3RhdGljX2Nhc3Qgd2l0aCB0b1hYWCwgc3RhdGljX2Nhc3Q8U1ZHRm9udEVsZW1l bnQqPiBjYW4KKyAgICAgICAgYmUgY2hhbmdlZCB3aXRoIHRvU1ZHRm9udEVsZW1lbnQoKS4KKwor ICAgICAgICBCbGluayBtZXJnZSBmcm9tIGh0dHBzOi8vc3JjLmNocm9taXVtLm9yZy92aWV3dmMv Ymxpbms/dmlldz1yZXYmcmV2aXNpb249MTUzNzYxCisKKyAgICAgICAgKiBzdmcvU1ZHRm9udEVs ZW1lbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OnRvU1ZHRm9udEVsZW1lbnQpOgorICAgICAgICAq IHN2Zy9TVkdGb250RmFjZUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHRm9udEZh Y2VFbGVtZW50OjpyZWJ1aWxkRm9udEZhY2UpOgorICAgICAgICAqIHN2Zy9TVkdHbHlwaEVsZW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHR2x5cGhFbGVtZW50OjppbnZhbGlkYXRlR2x5 cGhDYWNoZSk6CisgICAgICAgICogc3ZnL1NWR0hLZXJuRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTVkdIS2VybkVsZW1lbnQ6Omluc2VydGVkSW50byk6CisgICAgICAgIChXZWJDb3Jl OjpTVkdIS2VybkVsZW1lbnQ6OnJlbW92ZWRGcm9tKToKKyAgICAgICAgKiBzdmcvU1ZHVktlcm5F bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1ZLZXJuRWxlbWVudDo6aW5zZXJ0ZWRJ bnRvKToKKyAgICAgICAgKFdlYkNvcmU6OlNWR1ZLZXJuRWxlbWVudDo6cmVtb3ZlZEZyb20pOgor CiAyMDEzLTA3LTA4ICDDgWTDoW0gS2FsbGFpICA8a2FkYW1AaW5mLnUtc3plZ2VkLmh1PgogCiAg ICAgICAgIFtRdF0gSW5jcmVtZW50YWwgYnVpbGQgZml4IGFmdGVyIHIxNDU3MTIuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRm9udEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3Jl L3N2Zy9TVkdGb250RWxlbWVudC5oCmluZGV4IGVhODAyZWQzNDgzZTljZjU1MGY5YjhiOGQzNTk2 NTAwMjJjNzI1NDEuLjE1ODVmMjU1ZTI3ODZlMTUwMDJhZGFhZTY3OTIyNjI3Nzg2NGFhNGEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdGb250RWxlbWVudC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3N2Zy9TVkdGb250RWxlbWVudC5oCkBAIC0yNyw2ICsyNyw3IEBACiAjaW5jbHVk ZSAiU1ZHRXh0ZXJuYWxSZXNvdXJjZXNSZXF1aXJlZC5oIgogI2luY2x1ZGUgIlNWR0dseXBoRWxl bWVudC5oIgogI2luY2x1ZGUgIlNWR0dseXBoTWFwLmgiCisjaW5jbHVkZSAiU1ZHTmFtZXMuaCIK ICNpbmNsdWRlICJTVkdQYXJzZXJVdGlsaXRpZXMuaCIKICNpbmNsdWRlICJTVkdTdHlsZWRFbGVt ZW50LmgiCiAKQEAgLTg5LDYgKzkwLDEyIEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX2lzR2x5cGhD YWNoZVZhbGlkOwogfTsKIAoraW5saW5lIFNWR0ZvbnRFbGVtZW50KiB0b1NWR0ZvbnRFbGVtZW50 KE5vZGUqIG5vZGUpCit7CisgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oIW5v ZGUgfHwgbm9kZS0+aGFzVGFnTmFtZShTVkdOYW1lczo6Zm9udFRhZykpOworICAgIHJldHVybiBz dGF0aWNfY2FzdDxTVkdGb250RWxlbWVudCo+KG5vZGUpOworfQorCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCiAKICNlbmRpZiAvLyBFTkFCTEUoU1ZHX0ZPTlRTKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvc3ZnL1NWR0ZvbnRGYWNlRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcv U1ZHRm9udEZhY2VFbGVtZW50LmNwcAppbmRleCA4MjgwOTJlMGNmOTg3MmJkZTNkNTJjMmZjYWMx YjY3NTUzMjhjMTI2Li5lOGIyZmQyOGYyZGFmOGNlMGVjZjZhM2U0YTVmYjBiYzk1ZTVkMWJhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRm9udEZhY2VFbGVtZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRm9udEZhY2VFbGVtZW50LmNwcApAQCAtMjg4LDcgKzI4 OCw3IEBAIHZvaWQgU1ZHRm9udEZhY2VFbGVtZW50OjpyZWJ1aWxkRm9udEZhY2UoKQogICAgIFJl ZlB0cjxDU1NWYWx1ZUxpc3Q+IGxpc3Q7CiAKICAgICBpZiAoZGVzY3JpYmVzUGFyZW50Rm9udCkg ewotICAgICAgICBtX2ZvbnRFbGVtZW50ID0gc3RhdGljX2Nhc3Q8U1ZHRm9udEVsZW1lbnQqPihw YXJlbnROb2RlKCkpOworICAgICAgICBtX2ZvbnRFbGVtZW50ID0gdG9TVkdGb250RWxlbWVudChw YXJlbnROb2RlKCkpOwogCiAgICAgICAgIGxpc3QgPSBDU1NWYWx1ZUxpc3Q6OmNyZWF0ZUNvbW1h U2VwYXJhdGVkKCk7CiAgICAgICAgIGxpc3QtPmFwcGVuZChDU1NGb250RmFjZVNyY1ZhbHVlOjpj cmVhdGVMb2NhbChmb250RmFtaWx5KCkpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2 Zy9TVkdHbHlwaEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0dseXBoRWxlbWVu dC5jcHAKaW5kZXggNmRjMjg2OTBhMDViYjNmNDlkOWVjYjQ2ZGU1MTExNDE5NTE5ZGI0MC4uMmIx MTBhOTcyZmFlM2RhNDM2NjU2ZGY0MGI5NzI4NmNjZmU4ZDc5NiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvc3ZnL1NWR0dseXBoRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3Zn L1NWR0dseXBoRWxlbWVudC5jcHAKQEAgLTQ3LDEwICs0Nyw4IEBAIFBhc3NSZWZQdHI8U1ZHR2x5 cGhFbGVtZW50PiBTVkdHbHlwaEVsZW1lbnQ6OmNyZWF0ZShjb25zdCBRdWFsaWZpZWROYW1lJiB0 YWdOYW1lCiB2b2lkIFNWR0dseXBoRWxlbWVudDo6aW52YWxpZGF0ZUdseXBoQ2FjaGUoKQogewog ICAgIENvbnRhaW5lck5vZGUqIGZvbnROb2RlID0gcGFyZW50Tm9kZSgpOwotICAgIGlmIChmb250 Tm9kZSAmJiBmb250Tm9kZS0+aGFzVGFnTmFtZShTVkdOYW1lczo6Zm9udFRhZykpIHsKLSAgICAg ICAgaWYgKFNWR0ZvbnRFbGVtZW50KiBlbGVtZW50ID0gc3RhdGljX2Nhc3Q8U1ZHRm9udEVsZW1l bnQqPihmb250Tm9kZSkpCi0gICAgICAgICAgICBlbGVtZW50LT5pbnZhbGlkYXRlR2x5cGhDYWNo ZSgpOwotICAgIH0KKyAgICBpZiAoZm9udE5vZGUgJiYgZm9udE5vZGUtPmhhc1RhZ05hbWUoU1ZH TmFtZXM6OmZvbnRUYWcpKQorICAgICAgICB0b1NWR0ZvbnRFbGVtZW50KGZvbnROb2RlKS0+aW52 YWxpZGF0ZUdseXBoQ2FjaGUoKTsKIH0KIAogdm9pZCBTVkdHbHlwaEVsZW1lbnQ6OnBhcnNlQXR0 cmlidXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmIG5hbWUsIGNvbnN0IEF0b21pY1N0cmluZyYgdmFs dWUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHSEtlcm5FbGVtZW50LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdIS2VybkVsZW1lbnQuY3BwCmluZGV4IDA2YjY2ODUzODg4 YmZlOGFiNjQyMTIxNjI2MTRiNDNkNTE3OTY5ZDUuLjM5ODY3M2QzMTE2NzllZmMwODg3ZWMxNzc2 MDM2YmM0NDBiZWY5OTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdIS2VybkVs ZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdIS2VybkVsZW1lbnQuY3BwCkBA IC00NCwxMCArNDQsOCBAQCBQYXNzUmVmUHRyPFNWR0hLZXJuRWxlbWVudD4gU1ZHSEtlcm5FbGVt ZW50OjpjcmVhdGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgdGFnTmFtZQogTm9kZTo6SW5zZXJ0aW9u Tm90aWZpY2F0aW9uUmVxdWVzdCBTVkdIS2VybkVsZW1lbnQ6Omluc2VydGVkSW50byhDb250YWlu ZXJOb2RlKiByb290UGFyZW50KQogewogICAgIENvbnRhaW5lck5vZGUqIGZvbnROb2RlID0gcGFy ZW50Tm9kZSgpOwotICAgIGlmIChmb250Tm9kZSAmJiBmb250Tm9kZS0+aGFzVGFnTmFtZShTVkdO YW1lczo6Zm9udFRhZykpIHsKLSAgICAgICAgaWYgKFNWR0ZvbnRFbGVtZW50KiBlbGVtZW50ID0g c3RhdGljX2Nhc3Q8U1ZHRm9udEVsZW1lbnQqPihmb250Tm9kZSkpCi0gICAgICAgICAgICBlbGVt ZW50LT5pbnZhbGlkYXRlR2x5cGhDYWNoZSgpOwotICAgIH0KKyAgICBpZiAoZm9udE5vZGUgJiYg Zm9udE5vZGUtPmhhc1RhZ05hbWUoU1ZHTmFtZXM6OmZvbnRUYWcpKQorICAgICAgICB0b1NWR0Zv bnRFbGVtZW50KGZvbnROb2RlKS0+aW52YWxpZGF0ZUdseXBoQ2FjaGUoKTsKIAogICAgIHJldHVy biBTVkdFbGVtZW50OjppbnNlcnRlZEludG8ocm9vdFBhcmVudCk7CiB9CkBAIC01NSwxMCArNTMs OCBAQCBOb2RlOjpJbnNlcnRpb25Ob3RpZmljYXRpb25SZXF1ZXN0IFNWR0hLZXJuRWxlbWVudDo6 aW5zZXJ0ZWRJbnRvKENvbnRhaW5lck5vZGUqCiB2b2lkIFNWR0hLZXJuRWxlbWVudDo6cmVtb3Zl ZEZyb20oQ29udGFpbmVyTm9kZSogcm9vdFBhcmVudCkKIHsKICAgICBDb250YWluZXJOb2RlKiBm b250Tm9kZSA9IHBhcmVudE5vZGUoKTsKLSAgICBpZiAoZm9udE5vZGUgJiYgZm9udE5vZGUtPmhh c1RhZ05hbWUoU1ZHTmFtZXM6OmZvbnRUYWcpKSB7Ci0gICAgICAgIGlmIChTVkdGb250RWxlbWVu dCogZWxlbWVudCA9IHN0YXRpY19jYXN0PFNWR0ZvbnRFbGVtZW50Kj4oZm9udE5vZGUpKQotICAg ICAgICAgICAgZWxlbWVudC0+aW52YWxpZGF0ZUdseXBoQ2FjaGUoKTsKLSAgICB9CisgICAgaWYg KGZvbnROb2RlICYmIGZvbnROb2RlLT5oYXNUYWdOYW1lKFNWR05hbWVzOjpmb250VGFnKSkKKyAg ICAgICAgdG9TVkdGb250RWxlbWVudChmb250Tm9kZSktPmludmFsaWRhdGVHbHlwaENhY2hlKCk7 CiAKICAgICBTVkdFbGVtZW50OjpyZW1vdmVkRnJvbShyb290UGFyZW50KTsKIH0KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdWS2VybkVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNv cmUvc3ZnL1NWR1ZLZXJuRWxlbWVudC5jcHAKaW5kZXggY2I1NDFiNzIzZjM5MWFmOWNmNWYxMWVl Y2JhZDUzOTE1MDcxMWU2MC4uNzg1YTIyNGU2ODRjOTUxZjAyNzc0YTlhNzBhZWNhYmY5ZWZkMWNi MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1ZLZXJuRWxlbWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1ZLZXJuRWxlbWVudC5jcHAKQEAgLTQzLDEwICs0Myw4 IEBAIE5vZGU6Okluc2VydGlvbk5vdGlmaWNhdGlvblJlcXVlc3QgU1ZHVktlcm5FbGVtZW50Ojpp bnNlcnRlZEludG8oQ29udGFpbmVyTm9kZSoKIHsKICAgICBpZiAocm9vdFBhcmVudC0+aW5Eb2N1 bWVudCgpKSB7CiAgICAgICAgIENvbnRhaW5lck5vZGUqIGZvbnROb2RlID0gcGFyZW50Tm9kZSgp OwotICAgICAgICBpZiAoZm9udE5vZGUgJiYgZm9udE5vZGUtPmhhc1RhZ05hbWUoU1ZHTmFtZXM6 OmZvbnRUYWcpKSB7Ci0gICAgICAgICAgICBpZiAoU1ZHRm9udEVsZW1lbnQqIGVsZW1lbnQgPSBz dGF0aWNfY2FzdDxTVkdGb250RWxlbWVudCo+KGZvbnROb2RlKSkKLSAgICAgICAgICAgICAgICBl bGVtZW50LT5pbnZhbGlkYXRlR2x5cGhDYWNoZSgpOwotICAgICAgICB9CisgICAgICAgIGlmIChm b250Tm9kZSAmJiBmb250Tm9kZS0+aGFzVGFnTmFtZShTVkdOYW1lczo6Zm9udFRhZykpCisgICAg ICAgICAgICB0b1NWR0ZvbnRFbGVtZW50KGZvbnROb2RlKS0+aW52YWxpZGF0ZUdseXBoQ2FjaGUo KTsKICAgICB9CiAKICAgICByZXR1cm4gU1ZHRWxlbWVudDo6aW5zZXJ0ZWRJbnRvKHJvb3RQYXJl bnQpOwpAQCAtNTUsMTAgKzUzLDkgQEAgTm9kZTo6SW5zZXJ0aW9uTm90aWZpY2F0aW9uUmVxdWVz dCBTVkdWS2VybkVsZW1lbnQ6Omluc2VydGVkSW50byhDb250YWluZXJOb2RlKgogdm9pZCBTVkdW S2VybkVsZW1lbnQ6OnJlbW92ZWRGcm9tKENvbnRhaW5lck5vZGUqIHJvb3RQYXJlbnQpCiB7CiAg ICAgQ29udGFpbmVyTm9kZSogZm9udE5vZGUgPSBwYXJlbnROb2RlKCk7Ci0gICAgaWYgKGZvbnRO b2RlICYmIGZvbnROb2RlLT5oYXNUYWdOYW1lKFNWR05hbWVzOjpmb250VGFnKSkgewotICAgICAg ICBpZiAoU1ZHRm9udEVsZW1lbnQqIGVsZW1lbnQgPSBzdGF0aWNfY2FzdDxTVkdGb250RWxlbWVu dCo+KGZvbnROb2RlKSkKLSAgICAgICAgICAgIGVsZW1lbnQtPmludmFsaWRhdGVHbHlwaENhY2hl KCk7Ci0gICAgfQorICAgIGlmIChmb250Tm9kZSAmJiBmb250Tm9kZS0+aGFzVGFnTmFtZShTVkdO YW1lczo6Zm9udFRhZykpCisgICAgICAgIHRvU1ZHRm9udEVsZW1lbnQoZm9udE5vZGUpLT5pbnZh bGlkYXRlR2x5cGhDYWNoZSgpOworCiAgICAgU1ZHRWxlbWVudDo6cmVtb3ZlZEZyb20ocm9vdFBh cmVudCk7CiB9CiAK