118486 2013-07-08 15:10:28 -0700 NaturalLoops + Profiler = Crash 2013-07-08 22:09:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 118338 1 mhahnenberg fpizlo fpizlo oldest_to_newest 906927 0 mhahnenberg 2013-07-08 15:10:28 -0700 NaturalLoops::compute uses i instead of j in one of its internal loops. Should be a simple fix. 906989 1 mhahnenberg 2013-07-08 21:44:57 -0700 Looks like it's more complicated than I thought. Still crashes with this fix. 906990 2 fpizlo 2013-07-08 21:45:13 -0700 Added https://bugs.webkit.org/show_bug.cgi?id=118338 to the blocks list since SSA conversion needs Dominators and this bug looks like it might be Dominators-related. 906991 3 fpizlo 2013-07-08 21:58:24 -0700 Yeah I borked dominators. Lol. Patch on the way. 906992 4 fpizlo 2013-07-08 22:00:18 -0700 (In reply to comment #3) > Yeah I borked dominators. Lol. Patch on the way. See: http://trac.webkit.org/changeset/152431/branches/dfgFourthTier/Source/JavaScriptCore/dfg/DFGDominators.h Notice how I reversed "to" and "from". 906993 5 206289 fpizlo 2013-07-08 22:03:22 -0700 Created attachment 206289 the patch 906994 6 206289 ggaren 2013-07-08 22:06:01 -0700 Comment on attachment 206289 the patch r=me 906995 7 fpizlo 2013-07-08 22:09:43 -0700 Landed in http://trac.webkit.org/changeset/152481 206289 2013-07-08 22:03:22 -0700 2013-07-08 22:06:00 -0700 the patch blah.patch text/plain 4480 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUyNDgwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDEzLTA3LTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg TmF0dXJhbExvb3BzICsgUHJvZmlsZXIgPSBDcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NDg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBJIGJvcmtlZCBkb21pbmF0b3JzIGluOgor ICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xNTI0MzEvYnJhbmNoZXMv ZGZnRm91cnRoVGllci9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0RvbWluYXRvcnMuaAor ICAgICAgICAKKyAgICAgICAgVGhpcyBwYXRjaCBhbHNvIGFkZHMgc29tZSBkZWJ1ZyBzdXBwb3J0 LCBhbmQgZml4ZXMgdGhlIGxvb3AgdGhhdCBhZGRzIGEgYmxvY2sgdG8KKyAgICAgICAgYW4gYWxy ZWFkeS1leGlzdGluZyBuYXR1cmFsIGxvb3AuIE5vdGUgdGhhdCB3ZSBjdXJyZW50bHkgZG9uJ3Qg dGFrZSB0aGF0IHBhdGggaW4KKyAgICAgICAgbW9zdCBwcm9ncmFtcywgYnV0IGl0IHdpbGwgYXJp c2UsIGZvciBleGFtcGxlIGlmIHlvdSB1c2UgJ2NvbnRpbnVlJyAtIHRob3VnaCB5b3UnZAorICAg ICAgICBoYXZlIHRvIHVzZSBpdCByYXRoZXIgY2xldmVybHkgc2luY2UgdGhlIGJ5dGVjb2RlIHdp bGwgbm90IGp1bXAgdG8gdGhlIGxvb3AgaGVhZGVyCisgICAgICAgIGluIG1vc3QgdXNlcyBvZiAn Y29udGludWUnLgorCisgICAgICAgICogZGZnL0RGR0RvbWluYXRvcnMuY3BwOgorICAgICAgICAo SlNDOjpERkc6OkRvbWluYXRvcnM6OmR1bXApOgorICAgICAgICAoREZHKToKKyAgICAgICAgKiBk ZmcvREZHRG9taW5hdG9ycy5oOgorICAgICAgICAoSlNDOjpERkc6OkRvbWluYXRvcnM6OmRvbWlu YXRlcyk6CisgICAgICAgIChEb21pbmF0b3JzKToKKyAgICAgICAgKiBkZmcvREZHTmF0dXJhbExv b3BzLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpOYXR1cmFsTG9vcHM6OmNvbXB1dGUpOgorCiAy MDEzLTA3LTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgZm91 cnRoVGllcjogREZHOjpBYnN0cmFjdFN0YXRlOjpiZWdpbkJhc2ljQmxvY2soKSBzaG91bGQgc2V0 IG1faGF2ZVN0cnVjdHVyZXMgaWYgYW55IG9mIHRoZSB2YWx1ZXNBdEhlYWQgaGF2ZSBlaXRoZXIg YSBjdXJyZW50IGtub3duIHN0cnVjdHVyZSBvciBhIG5vbi10b3Avbm9uLWJvdHRvbSBhcnJheSBt b2RlcwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdEb21pbmF0b3JzLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0RvbWluYXRvcnMuY3Bw CShyZXZpc2lvbiAxNTI0ODApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0RvbWlu YXRvcnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDAsNiArMTAwLDIyIEBAIGJvb2wgRG9taW5h dG9yczo6aXRlcmF0ZUZvckJsb2NrKEdyYXBoJiAKICAgICByZXR1cm4gbV9yZXN1bHRzW2ldLnNl dEFuZENoZWNrKG1fc2NyYXRjaCk7CiB9CiAKK3ZvaWQgRG9taW5hdG9yczo6ZHVtcChHcmFwaCYg Z3JhcGgsIFByaW50U3RyZWFtJiBvdXQpIGNvbnN0Cit7CisgICAgZm9yIChCbG9ja0luZGV4IGJs b2NrSW5kZXggPSAwOyBibG9ja0luZGV4IDwgZ3JhcGgubnVtQmxvY2tzKCk7ICsrYmxvY2tJbmRl eCkgeworICAgICAgICBCYXNpY0Jsb2NrKiBibG9jayA9IGdyYXBoLmJsb2NrKGJsb2NrSW5kZXgp OworICAgICAgICBpZiAoIWJsb2NrKQorICAgICAgICAgICAgY29udGludWU7CisgICAgICAgIG91 dC5wcmludCgiICAgIEJsb2NrICIsICpibG9jaywgIjoiKTsKKyAgICAgICAgZm9yIChCbG9ja0lu ZGV4IG90aGVySW5kZXggPSAwOyBvdGhlckluZGV4IDwgZ3JhcGgubnVtQmxvY2tzKCk7ICsrb3Ro ZXJJbmRleCkgeworICAgICAgICAgICAgaWYgKCFkb21pbmF0ZXMoYmxvY2stPmluZGV4LCBvdGhl ckluZGV4KSkKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgIG91dC5wcmlu dCgiICMiLCBvdGhlckluZGV4KTsKKyAgICAgICAgfQorICAgICAgICBvdXQucHJpbnQoIlxuIik7 CisgICAgfQorfQorCiB9IH0gLy8gbmFtZXNwYWNlIEpTQzo6REZHCiAKICNlbmRpZiAvLyBFTkFC TEUoREZHX0pJVCkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRG9taW5hdG9y cy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRG9taW5hdG9y cy5oCShyZXZpc2lvbiAxNTI0ODApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Rv bWluYXRvcnMuaAkod29ya2luZyBjb3B5KQpAQCAtNDksNyArNDksNyBAQCBwdWJsaWM6CiAgICAg Ym9vbCBkb21pbmF0ZXMoQmxvY2tJbmRleCBmcm9tLCBCbG9ja0luZGV4IHRvKSBjb25zdAogICAg IHsKICAgICAgICAgQVNTRVJUKGlzVmFsaWQoKSk7Ci0gICAgICAgIHJldHVybiBtX3Jlc3VsdHNb ZnJvbV0uZ2V0KHRvKTsKKyAgICAgICAgcmV0dXJuIG1fcmVzdWx0c1t0b10uZ2V0KGZyb20pOwog ICAgIH0KICAgICAKICAgICBib29sIGRvbWluYXRlcyhCYXNpY0Jsb2NrKiBmcm9tLCBCYXNpY0Js b2NrKiB0bykgY29uc3QKQEAgLTU3LDEwICs1NywxMiBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVy biBkb21pbmF0ZXMoZnJvbS0+aW5kZXgsIHRvLT5pbmRleCk7CiAgICAgfQogICAgIAorICAgIHZv aWQgZHVtcChHcmFwaCYgZ3JhcGgsIFByaW50U3RyZWFtJikgY29uc3Q7CisgICAgCiBwcml2YXRl OgogICAgIGJvb2wgaXRlcmF0ZUZvckJsb2NrKEdyYXBoJiBncmFwaCwgQmxvY2tJbmRleCk7CiAg ICAgCi0gICAgVmVjdG9yPEZhc3RCaXRWZWN0b3I+IG1fcmVzdWx0czsKKyAgICBWZWN0b3I8RmFz dEJpdFZlY3Rvcj4gbV9yZXN1bHRzOyAvLyBGb3IgZWFjaCBibG9jaywgdGhlIGJpdHZlY3RvciBv ZiBibG9ja3MgdGhhdCBkb21pbmF0ZSBpdC4KICAgICBGYXN0Qml0VmVjdG9yIG1fc2NyYXRjaDsK IH07CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTmF0dXJhbExvb3BzLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05hdHVyYWxMb29w cy5jcHAJKHJldmlzaW9uIDE1MjQ4MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH TmF0dXJhbExvb3BzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTgsNiArNTgsMTEgQEAgdm9pZCBO YXR1cmFsTG9vcHM6OmNvbXB1dGUoR3JhcGgmIGdyYXBoKQogICAgIAogICAgIGdyYXBoLm1fZG9t aW5hdG9ycy5jb21wdXRlSWZOZWNlc3NhcnkoZ3JhcGgpOwogICAgIAorICAgIGlmICh2ZXJib3Nl KSB7CisgICAgICAgIGRhdGFMb2coIkRvbWluYXRvcnM6XG4iKTsKKyAgICAgICAgZ3JhcGgubV9k b21pbmF0b3JzLmR1bXAoZ3JhcGgsIFdURjo6ZGF0YUZpbGUoKSk7CisgICAgfQorICAgIAogICAg IG1fbG9vcHMucmVzaXplKDApOwogICAgIAogICAgIGZvciAoQmxvY2tJbmRleCBibG9ja0luZGV4 ID0gZ3JhcGgubnVtQmxvY2tzKCk7IGJsb2NrSW5kZXgtLTspIHsKQEAgLTcxLDkgKzc2LDEwIEBA IHZvaWQgTmF0dXJhbExvb3BzOjpjb21wdXRlKEdyYXBoJiBncmFwaCkKICAgICAgICAgICAgICAg ICBjb250aW51ZTsKICAgICAgICAgICAgIGJvb2wgZm91bmQgPSBmYWxzZTsKICAgICAgICAgICAg IGZvciAodW5zaWduZWQgaiA9IG1fbG9vcHMuc2l6ZSgpOyBqLS07KSB7Ci0gICAgICAgICAgICAg ICAgaWYgKG1fbG9vcHNbaV0uaGVhZGVyKCkgPT0gc3VjY2Vzc29yKSB7Ci0gICAgICAgICAgICAg ICAgICAgIG1fbG9vcHNbaV0uYWRkQmxvY2soYmxvY2spOworICAgICAgICAgICAgICAgIGlmICht X2xvb3BzW2pdLmhlYWRlcigpID09IHN1Y2Nlc3NvcikgeworICAgICAgICAgICAgICAgICAgICBt X2xvb3BzW2pdLmFkZEJsb2NrKGJsb2NrKTsKICAgICAgICAgICAgICAgICAgICAgZm91bmQgPSB0 cnVlOworICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICB9CiAgICAg ICAgICAgICB9CiAgICAgICAgICAgICBpZiAoZm91bmQpCg==