118483 2013-07-08 14:16:58 -0700 WebVTTParser's identifier buffering can ignore subsequent lines 2013-07-24 08:43:36 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 b.long webkit-unassigned commit-queue eric.carlson eric esprehn+autocc jer.noble oldest_to_newest 906909 0 b.long 2013-07-08 14:16:58 -0700 In WebVTTParser::parseBytes, we do this: String line = collectNextLine(data, length, &position); switch (m_state) { case Initial: // Buffer up at least 9 bytes before proceeding with checking for the file identifier. m_identifierData.append(data, length); if (m_identifierData.size() < bomLength + fileIdentifierLength) return; But it doesn't work in this situation: parser->parseBytes("WEBVTT\n\n", 8); parser->parseBytes("00:00:00.000 --> 00:00:10.000\nCue text\n\n", strlen("00:00:00.000 --> 00:00:10.000\nCue text\n\n"); The first parseBytes call has less than 9 bytes, so it does nothing. The second parseBytes call collects the current line ("00:00:00.000 --> 00:00:10.000"), but since the state is `Initial`, it just checks the identifier and throws away the current line. Now it collects the next line ("Cue text"), and because we're in state `Header`, it treats it as a comment and throws it away too. 906911 1 206267 b.long 2013-07-08 14:21:09 -0700 Created attachment 206267 Patch 906913 2 b.long 2013-07-08 14:27:28 -0700 I guess I should explain the patch: If `position == line.sizeInBytes()`, then we haven't parsed a line ending yet, so it's safe to continue buffering. If `position > line.sizeInBytes()`, then we parsed the entire line and should check it now. 908908 3 206267 commit-queue 2013-07-16 09:06:53 -0700 Comment on attachment 206267 Patch Rejecting attachment 206267 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 206267, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/1090259 908915 4 206788 b.long 2013-07-16 09:20:18 -0700 Created attachment 206788 Fix changelog to have reviewer section 911070 5 b.long 2013-07-23 10:12:07 -0700 Eric, can you review this again? All I changed was adding the "Reviewed by nobody (Oops)" line back so the commit queue would like it. 911315 6 206788 commit-queue 2013-07-24 08:43:34 -0700 Comment on attachment 206788 Fix changelog to have reviewer section Clearing flags on attachment: 206788 Committed r153086: <http://trac.webkit.org/changeset/153086> 911316 7 commit-queue 2013-07-24 08:43:36 -0700 All reviewed patches have been landed. Closing bug. 206267 2013-07-08 14:21:09 -0700 2013-07-16 09:20:15 -0700 Patch bug-118483-20130708151916.patch text/plain 1803 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTY0ODNiNmZiOTM1Njcz NGViZGNhYWJiNzRmZTJlMDYyODEwZjg3OS4uYjdlNTJmOTYxNjk4NjgzMzgwNDZjOTI5OWYyZjY2 MTAyODBkYWQyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA3LTA4ICBCcmVu ZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKworICAgICAgICBXZWJWVFRQYXJzZXIn cyBpZGVudGlmaWVyIGJ1ZmZlcmluZyBjYW4gaWdub3JlIHN1YnNlcXVlbnQgbGluZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODQ4MworCisgICAg ICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSB0aGlzIGJ1ZyBjYW4ndCBiZSByZXByb2R1Y2VkIGluIGxh eW91dCB0ZXN0cy4KKworICAgICAgICAqIGh0bWwvdHJhY2svV2ViVlRUUGFyc2VyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OldlYlZUVFBhcnNlcjo6cGFyc2VCeXRlcyk6IE9ubHkgYnVmZmVyIHRo ZSBpZGVudGlmaWVyIGlmIHdlIGhhdmVuJ3QgcmVhZCBhbiBlbnRpcmUgbGluZS4KKwogMjAxMy0w Ny0wOCAgUnV0aCBGb25nICA8cnV0aF9mb25nQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggVGV4 dFRyYWNrQ3VlOjpjdWVJbmRleCgpIHRvIGhhbmRsZSB0aGUgbnVsbCBjYXNlIG9mIFRleHRUcmFj azo6Y3VlcygoKSBwcm9wZXJseQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC90cmFj ay9XZWJWVFRQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9XZWJWVFRQYXJz ZXIuY3BwCmluZGV4IDljMzVkMjFhNWUxOTk2YzE3MjY1N2NhNzRkZGJhNjI4MDJhNzgwMzQuLjNm MTA4OTIyYWU1ZjdkZmIxM2NkZmFhYmYwZmRiYzc3N2Q0MzQ1YjEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvdHJhY2svV2ViVlRUUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL3RyYWNrL1dlYlZUVFBhcnNlci5jcHAKQEAgLTE1MSw5ICsxNTEsOSBAQCB2b2lkIFdl YlZUVFBhcnNlcjo6cGFyc2VCeXRlcyhjb25zdCBjaGFyKiBkYXRhLCB1bnNpZ25lZCBsZW5ndGgp CiAKICAgICAgICAgc3dpdGNoIChtX3N0YXRlKSB7CiAgICAgICAgIGNhc2UgSW5pdGlhbDoKLSAg ICAgICAgICAgIC8vIEJ1ZmZlciB1cCBhdCBsZWFzdCA5IGJ5dGVzIGJlZm9yZSBwcm9jZWVkaW5n IHdpdGggY2hlY2tpbmcgZm9yIHRoZSBmaWxlIGlkZW50aWZpZXIuCisgICAgICAgICAgICAvLyBC dWZmZXIgdXAgYXQgbGVhc3QgOSBieXRlcyBvciBhIGZ1bGwgbGluZSBiZWZvcmUgcHJvY2VlZGlu ZyB3aXRoIGNoZWNraW5nIGZvciB0aGUgZmlsZSBpZGVudGlmaWVyLgogICAgICAgICAgICAgbV9p ZGVudGlmaWVyRGF0YS5hcHBlbmQoZGF0YSwgbGVuZ3RoKTsKLSAgICAgICAgICAgIGlmIChtX2lk ZW50aWZpZXJEYXRhLnNpemUoKSA8IGJvbUxlbmd0aCArIGZpbGVJZGVudGlmaWVyTGVuZ3RoKQor ICAgICAgICAgICAgaWYgKHBvc2l0aW9uID09IGxpbmUuc2l6ZUluQnl0ZXMoKSAmJiBtX2lkZW50 aWZpZXJEYXRhLnNpemUoKSA8IGJvbUxlbmd0aCArIGZpbGVJZGVudGlmaWVyTGVuZ3RoKQogICAg ICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICAgICAgLy8gNC0xMiAtIENvbGxlY3QgdGhl IGZpcnN0IGxpbmUgYW5kIGNoZWNrIGZvciAiV0VCVlRUIi4K 206788 2013-07-16 09:20:18 -0700 2013-07-24 08:43:34 -0700 Fix changelog to have reviewer section bug-118483-20130716102014.patch text/plain 1826 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWRlNzY0OGI5ZTU5OGNk MGQzOTAyODJiZWJkMDA5NTc4NjFjYzg5ZS4uYTZiMWJlODU5MGZkNjU1ZGJmMmNkYTUyYTMxMWU3 ZDM1OTA5MzJmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA3LTE2ICBCcmVu ZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKworICAgICAgICBXZWJWVFRQYXJzZXIn cyBpZGVudGlmaWVyIGJ1ZmZlcmluZyBjYW4gaWdub3JlIHN1YnNlcXVlbnQgbGluZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODQ4MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBz aW5jZSB0aGlzIGJ1ZyBjYW4ndCBiZSByZXByb2R1Y2VkIGluIGxheW91dCB0ZXN0cy4KKworICAg ICAgICAqIGh0bWwvdHJhY2svV2ViVlRUUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Oldl YlZUVFBhcnNlcjo6cGFyc2VCeXRlcyk6IE9ubHkgYnVmZmVyIHRoZSBpZGVudGlmaWVyIGlmIHdl IGhhdmVuJ3QgcmVhZCBhbiBlbnRpcmUgbGluZS4KKwogMjAxMy0wNy0xNiAgRXJpYyBDYXJsc29u ICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBIVE1MTWVkaWFFbGVtZW50IHNo b3VsZCBub3QgYWRkIGN1ZXMgZm9yIGRpc2FibGVkIHRleHQgdHJhY2tzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1dlYlZUVFBhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL3RyYWNrL1dlYlZUVFBhcnNlci5jcHAKaW5kZXggOWMzNWQyMWE1ZTE5OTZjMTcyNjU3 Y2E3NGRkYmE2MjgwMmE3ODAzNC4uM2YxMDg5MjJhZTVmN2RmYjEzY2RmYWFiZjBmZGJjNzc3ZDQz NDViMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9XZWJWVFRQYXJzZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svV2ViVlRUUGFyc2VyLmNwcApAQCAt MTUxLDkgKzE1MSw5IEBAIHZvaWQgV2ViVlRUUGFyc2VyOjpwYXJzZUJ5dGVzKGNvbnN0IGNoYXIq IGRhdGEsIHVuc2lnbmVkIGxlbmd0aCkKIAogICAgICAgICBzd2l0Y2ggKG1fc3RhdGUpIHsKICAg ICAgICAgY2FzZSBJbml0aWFsOgotICAgICAgICAgICAgLy8gQnVmZmVyIHVwIGF0IGxlYXN0IDkg Ynl0ZXMgYmVmb3JlIHByb2NlZWRpbmcgd2l0aCBjaGVja2luZyBmb3IgdGhlIGZpbGUgaWRlbnRp Zmllci4KKyAgICAgICAgICAgIC8vIEJ1ZmZlciB1cCBhdCBsZWFzdCA5IGJ5dGVzIG9yIGEgZnVs bCBsaW5lIGJlZm9yZSBwcm9jZWVkaW5nIHdpdGggY2hlY2tpbmcgZm9yIHRoZSBmaWxlIGlkZW50 aWZpZXIuCiAgICAgICAgICAgICBtX2lkZW50aWZpZXJEYXRhLmFwcGVuZChkYXRhLCBsZW5ndGgp OwotICAgICAgICAgICAgaWYgKG1faWRlbnRpZmllckRhdGEuc2l6ZSgpIDwgYm9tTGVuZ3RoICsg ZmlsZUlkZW50aWZpZXJMZW5ndGgpCisgICAgICAgICAgICBpZiAocG9zaXRpb24gPT0gbGluZS5z aXplSW5CeXRlcygpICYmIG1faWRlbnRpZmllckRhdGEuc2l6ZSgpIDwgYm9tTGVuZ3RoICsgZmls ZUlkZW50aWZpZXJMZW5ndGgpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgICAg ICAvLyA0LTEyIC0gQ29sbGVjdCB0aGUgZmlyc3QgbGluZSBhbmQgY2hlY2sgZm9yICJXRUJWVFQi Lgo=