118466 2013-07-08 05:22:07 -0700 Add Deque::removeLast 2013-07-08 06:23:48 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned benjamin cmarcelo commit-queue oldest_to_newest 906740 0 koivisto 2013-07-08 05:22:07 -0700 Deque can remove both the first and the last element efficiently. 906741 1 206231 koivisto 2013-07-08 05:25:12 -0700 Created attachment 206231 patch 906743 2 206231 koivisto 2013-07-08 05:27:35 -0700 Comment on attachment 206231 patch wrong patch 906744 3 206233 koivisto 2013-07-08 05:28:09 -0700 Created attachment 206233 patch 906746 4 206233 kling 2013-07-08 05:36:03 -0700 Comment on attachment 206233 patch r=me, though we should also improve remove() some day.. Also, this could use an API test. 906762 5 koivisto 2013-07-08 06:23:48 -0700 http://trac.webkit.org/changeset/152449 (with API test) 206231 2013-07-08 05:25:12 -0700 2013-07-08 05:27:35 -0700 patch deque-remove-last.patch text/plain 2411 koivisto SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNTI0NDcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA3LTA4ICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgRGVxdWU6OnJlbW92ZUxhc3QKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODQ2NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgRGVxdWUgY2Fu IHJlbW92ZSBib3RoIHRoZSBmaXJzdCBhbmQgdGhlIGxhc3QgZWxlbWVudCBlZmZpY2llbnRseS4K KworICAgICAgICAqIHd0Zi9EZXF1ZS5oOgorICAgICAgICAoV1RGOjo6OnRha2VMYXN0KToKKyAg ICAgICAgKFdURjo6OjpyZW1vdmVMYXN0KToKKwogMjAxMy0wNy0wOCAgWm9sdGFuIEFydmFpICA8 emFydmFpQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBbUXRdW1dpbmRvd3NdIEJ1aWxkZml4 IGFmdGVyIHIxNTI0MjYuCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9EZXF1ZS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XVEYvd3RmL0RlcXVlLmgJKHJldmlzaW9uIDE1MjQwMCkKKysrIFNvdXJjZS9X VEYvd3RmL0RlcXVlLmgJKHdvcmtpbmcgY29weSkKQEAgLTc5LDEwICs3OSwxMiBAQCBuYW1lc3Bh Y2UgV1RGIHsKIAogICAgICAgICBUJiBsYXN0KCkgeyBBU1NFUlQobV9zdGFydCAhPSBtX2VuZCk7 IHJldHVybiAqKC0tZW5kKCkpOyB9CiAgICAgICAgIGNvbnN0IFQmIGxhc3QoKSBjb25zdCB7IEFT U0VSVChtX3N0YXJ0ICE9IG1fZW5kKTsgcmV0dXJuICooLS1lbmQoKSk7IH0KKyAgICAgICAgUGFz c1R5cGUgdGFrZUxhc3QoKTsKIAogICAgICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiB2b2lkIGFw cGVuZChjb25zdCBVJik7CiAgICAgICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+IHZvaWQgcHJlcGVu ZChjb25zdCBVJik7CiAgICAgICAgIHZvaWQgcmVtb3ZlRmlyc3QoKTsKKyAgICAgICAgdm9pZCBy ZW1vdmVMYXN0KCk7CiAgICAgICAgIHZvaWQgcmVtb3ZlKGl0ZXJhdG9yJik7CiAgICAgICAgIHZv aWQgcmVtb3ZlKGNvbnN0X2l0ZXJhdG9yJik7CiAKQEAgLTQwNiw2ICs0MDgsMTQgQEAgbmFtZXNw YWNlIFdURiB7CiAgICAgICAgIHJldHVybiBQYXNzOjp0cmFuc2ZlcihvbGRGaXJzdCk7CiAgICAg fQogCisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5PgorICAg IGlubGluZSB0eXBlbmFtZSBEZXF1ZTxULCBpbmxpbmVDYXBhY2l0eT46OlBhc3NUeXBlIERlcXVl PFQsIGlubGluZUNhcGFjaXR5Pjo6dGFrZUxhc3QoKQorICAgIHsKKyAgICAgICAgVCBvbGRMYXN0 ID0gUGFzczo6dHJhbnNmZXIobGFzdCgpKTsKKyAgICAgICAgcmVtb3ZlTGFzdCgpOworICAgICAg ICByZXR1cm4gUGFzczo6dHJhbnNmZXIob2xkTGFzdCk7CisgICAgfQorCiAgICAgdGVtcGxhdGU8 dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5PiB0ZW1wbGF0ZTx0eXBlbmFtZSBVPgog ICAgIGlubGluZSB2b2lkIERlcXVlPFQsIGlubGluZUNhcGFjaXR5Pjo6YXBwZW5kKGNvbnN0IFUm IHZhbHVlKQogICAgIHsKQEAgLTQ0Nyw2ICs0NTcsMjAgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAg fQogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5PgorICAg IGlubGluZSB2b2lkIERlcXVlPFQsIGlubGluZUNhcGFjaXR5Pjo6cmVtb3ZlTGFzdCgpCisgICAg eworICAgICAgICBjaGVja1ZhbGlkaXR5KCk7CisgICAgICAgIGludmFsaWRhdGVJdGVyYXRvcnMo KTsKKyAgICAgICAgQVNTRVJUKCFpc0VtcHR5KCkpOworICAgICAgICBpZiAoIW1fZW5kKQorICAg ICAgICAgICAgbV9lbmQgPSBtX2J1ZmZlci5jYXBhY2l0eSgpIC0gMTsKKyAgICAgICAgZWxzZQor ICAgICAgICAgICAgLS1tX2VuZDsKKyAgICAgICAgVHlwZU9wZXJhdGlvbnM6OmRlc3RydWN0KCZt X2J1ZmZlci5idWZmZXIoKVttX2VuZCArIDFdLCAmbV9idWZmZXIuYnVmZmVyKClbbV9lbmQgKyAy XSk7CisgICAgICAgIGNoZWNrVmFsaWRpdHkoKTsKKyAgICB9CisKKyAgICB0ZW1wbGF0ZTx0eXBl bmFtZSBULCBzaXplX3QgaW5saW5lQ2FwYWNpdHk+CiAgICAgaW5saW5lIHZvaWQgRGVxdWU8VCwg aW5saW5lQ2FwYWNpdHk+OjpyZW1vdmUoaXRlcmF0b3ImIGl0KQogICAgIHsKICAgICAgICAgaXQu Y2hlY2tWYWxpZGl0eSgpOwo= 206233 2013-07-08 05:28:09 -0700 2013-07-08 05:36:02 -0700 patch deque-remove-last-2.patch text/plain 2407 koivisto SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNTI0NDcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA3LTA4ICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgRGVxdWU6OnJlbW92ZUxhc3QKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODQ2NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgRGVxdWUgY2Fu IHJlbW92ZSBib3RoIHRoZSBmaXJzdCBhbmQgdGhlIGxhc3QgZWxlbWVudCBlZmZpY2llbnRseS4K KworICAgICAgICAqIHd0Zi9EZXF1ZS5oOgorICAgICAgICAoV1RGOjo6OnRha2VMYXN0KToKKyAg ICAgICAgKFdURjo6OjpyZW1vdmVMYXN0KToKKwogMjAxMy0wNy0wOCAgWm9sdGFuIEFydmFpICA8 emFydmFpQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBbUXRdW1dpbmRvd3NdIEJ1aWxkZml4 IGFmdGVyIHIxNTI0MjYuCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9EZXF1ZS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XVEYvd3RmL0RlcXVlLmgJKHJldmlzaW9uIDE1MjQwMCkKKysrIFNvdXJjZS9X VEYvd3RmL0RlcXVlLmgJKHdvcmtpbmcgY29weSkKQEAgLTc5LDEwICs3OSwxMiBAQCBuYW1lc3Bh Y2UgV1RGIHsKIAogICAgICAgICBUJiBsYXN0KCkgeyBBU1NFUlQobV9zdGFydCAhPSBtX2VuZCk7 IHJldHVybiAqKC0tZW5kKCkpOyB9CiAgICAgICAgIGNvbnN0IFQmIGxhc3QoKSBjb25zdCB7IEFT U0VSVChtX3N0YXJ0ICE9IG1fZW5kKTsgcmV0dXJuICooLS1lbmQoKSk7IH0KKyAgICAgICAgUGFz c1R5cGUgdGFrZUxhc3QoKTsKIAogICAgICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiB2b2lkIGFw cGVuZChjb25zdCBVJik7CiAgICAgICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+IHZvaWQgcHJlcGVu ZChjb25zdCBVJik7CiAgICAgICAgIHZvaWQgcmVtb3ZlRmlyc3QoKTsKKyAgICAgICAgdm9pZCBy ZW1vdmVMYXN0KCk7CiAgICAgICAgIHZvaWQgcmVtb3ZlKGl0ZXJhdG9yJik7CiAgICAgICAgIHZv aWQgcmVtb3ZlKGNvbnN0X2l0ZXJhdG9yJik7CiAKQEAgLTQwNiw2ICs0MDgsMTQgQEAgbmFtZXNw YWNlIFdURiB7CiAgICAgICAgIHJldHVybiBQYXNzOjp0cmFuc2ZlcihvbGRGaXJzdCk7CiAgICAg fQogCisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5PgorICAg IGlubGluZSB0eXBlbmFtZSBEZXF1ZTxULCBpbmxpbmVDYXBhY2l0eT46OlBhc3NUeXBlIERlcXVl PFQsIGlubGluZUNhcGFjaXR5Pjo6dGFrZUxhc3QoKQorICAgIHsKKyAgICAgICAgVCBvbGRMYXN0 ID0gUGFzczo6dHJhbnNmZXIobGFzdCgpKTsKKyAgICAgICAgcmVtb3ZlTGFzdCgpOworICAgICAg ICByZXR1cm4gUGFzczo6dHJhbnNmZXIob2xkTGFzdCk7CisgICAgfQorCiAgICAgdGVtcGxhdGU8 dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5PiB0ZW1wbGF0ZTx0eXBlbmFtZSBVPgog ICAgIGlubGluZSB2b2lkIERlcXVlPFQsIGlubGluZUNhcGFjaXR5Pjo6YXBwZW5kKGNvbnN0IFUm IHZhbHVlKQogICAgIHsKQEAgLTQ0Nyw2ICs0NTcsMjAgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAg fQogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5PgorICAg IGlubGluZSB2b2lkIERlcXVlPFQsIGlubGluZUNhcGFjaXR5Pjo6cmVtb3ZlTGFzdCgpCisgICAg eworICAgICAgICBjaGVja1ZhbGlkaXR5KCk7CisgICAgICAgIGludmFsaWRhdGVJdGVyYXRvcnMo KTsKKyAgICAgICAgQVNTRVJUKCFpc0VtcHR5KCkpOworICAgICAgICBpZiAoIW1fZW5kKQorICAg ICAgICAgICAgbV9lbmQgPSBtX2J1ZmZlci5jYXBhY2l0eSgpIC0gMTsKKyAgICAgICAgZWxzZQor ICAgICAgICAgICAgLS1tX2VuZDsKKyAgICAgICAgVHlwZU9wZXJhdGlvbnM6OmRlc3RydWN0KCZt X2J1ZmZlci5idWZmZXIoKVttX2VuZF0sICZtX2J1ZmZlci5idWZmZXIoKVttX2VuZCArIDFdKTsK KyAgICAgICAgY2hlY2tWYWxpZGl0eSgpOworICAgIH0KKworICAgIHRlbXBsYXRlPHR5cGVuYW1l IFQsIHNpemVfdCBpbmxpbmVDYXBhY2l0eT4KICAgICBpbmxpbmUgdm9pZCBEZXF1ZTxULCBpbmxp bmVDYXBhY2l0eT46OnJlbW92ZShpdGVyYXRvciYgaXQpCiAgICAgewogICAgICAgICBpdC5jaGVj a1ZhbGlkaXR5KCk7Cg==