118464 2013-07-08 04:46:02 -0700 REGRESSION(r151957): WebGL textures do not show 2013-07-10 01:47:18 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Critical --- 116041 1 t.morawski ossy allan.jensen cdumez cgarcia commit-queue dino d-r gustavo kalyan.kondapally laszlo.gombos mrobinson noam ossy pkasting oldest_to_newest 906735 0 t.morawski 2013-07-08 04:46:02 -0700 Currently, WebGL textures do not show at all. It seems that the patch: Checking if frame is complete and access duration doesn't need a decode https://bugs.webkit.org/show_bug.cgi?id=116041 is responsible for the regression. Moreover, one of Kronos conformance don't pass now. https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/gl-teximage.html Please also check any webgl sample that uses textures like this one: http://webglsamples.googlecode.com/hg/aquarium/aquarium.html Tested on EFL port only. 906812 1 ossy 2013-07-08 08:47:25 -0700 Thanks for reporting. I can confirm, http://trac.webkit.org/changeset/151957 is responsible for this bug on EFL and Nix too. Reverting this patch locally solved the bug for me. (aquarius example and the khronos test too) Additionally I checked it on Qt too and it works fine with and without this patch. I have an idea, maybe it is related to Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp somehow. Let me try to debug it. 906813 2 ossy 2013-07-08 08:50:53 -0700 I got the following errors on the khronos test with Nix: $ WebKitBuild/Release/bin/MiniBrowser https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/gl-teximage.html MiniBrowser: Use Alt + Left and Alt + Right to navigate back and forward. Use F5 to reload. Touch Emulation Mode enabled. Hold Control key to build and emit a multi-touch event: each mouse button should be a different touch point. Release Control Key to clear all tracking pressed touches. Use Control + mouse wheel to zoom in and out. [js:2099] requestAnimationFrame [js:2099] cancelAnimationFrame [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data [js:0] WebGL: INVALID_VALUE: texImage2D: bad image data X Error of failed request: GLXBadPixmap Major opcode of failed request: 135 (GLX) Minor opcode of failed request: 16 (X_GLXVendorPrivate) Serial number of failed request: 0 Current serial number in output stream: 28 906819 3 ossy 2013-07-08 08:57:55 -0700 (In reply to comment #1) > I have an idea, maybe it is related to Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp somehow. Let me try to debug it. Or BitmapImageCairo.cpp. 907075 4 206306 k.swiniarsk2 2013-07-09 04:28:39 -0700 Created attachment 206306 Texture loading test case I prepared test case showing where problem can be: At first it creates texture (no problem) Than loads data to texture from array buffer (no problem) Than attempts to load texture from separate *.png image (problem) It passes on older version of webkit and in other browsers. 907130 5 ossy 2013-07-09 09:12:55 -0700 I got the bug. ;) The problem is that GraphicsContext3D::ImageExtractor::extractImage(...) in Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp returns with false if !decoder.frameIsCompleteAtIndex(0). Before r151957 frameIsCompleteAtIndex(...) called m_decoder->frameBufferAtIndex(...) which ensured that the image will be decoded: - ImageFrame* buffer = m_decoder->frameBufferAtIndex(index); - return buffer && buffer->status() == ImageFrame::FrameComplete; + return m_decoder && m_decoder->frameIsCompleteAtIndex(index); But after r151957 frameIsCompleteAtIndex(...) doesn't trigger decoding, Fix is coming soon. 907150 6 206331 ossy 2013-07-09 09:44:44 -0700 Created attachment 206331 Patch 907153 7 ossy 2013-07-09 09:48:41 -0700 (In reply to comment #6) > Created an attachment (id=206331) [details] > Patch Tested on EFL and Nix too. And it fixed the bug, of course. :) 907167 8 206331 pkasting 2013-07-09 10:15:23 -0700 Comment on attachment 206331 Patch I can confirm that this is what Chromium does. 907303 9 ossy 2013-07-10 00:55:10 -0700 ping for review :) 907307 10 kalyan.kondapally 2013-07-10 01:33:42 -0700 (In reply to comment #9) > ping for review :) Thanks for the fix. LGTM 907308 11 206331 cdumez 2013-07-10 01:35:31 -0700 Comment on attachment 206331 Patch R=me. 907316 12 206331 commit-queue 2013-07-10 01:47:14 -0700 Comment on attachment 206331 Patch Clearing flags on attachment: 206331 Committed r152531: <http://trac.webkit.org/changeset/152531> 907317 13 commit-queue 2013-07-10 01:47:18 -0700 All reviewed patches have been landed. Closing bug. 206306 2013-07-09 04:28:39 -0700 2013-07-09 04:28:39 -0700 Texture loading test case texture_test.zip application/octet-stream 3380 k.swiniarsk2 UEsDBBQAAAAIABln6ULaB4h3nwMAAPMIAAAfABwAdGV4dHVyZV90ZXN0L3RleHR1cmVfdGVzdC5o dG1sflVUCQADcuzbUTnu21F1eAsAAQQ9UsBQBD1SwFC1VmFv4jgQ/Ux+hTf3YYOWAu3trlZLEolC lkWitKKpeqvVCZnECdYFO3JMW7Tiv9+Mk0BaHXu9Ox1Cij1v5tnzZuzEfTO+HoXfbgKy1pvMt9z6 wWgMjw3TlERrqgqmPXurk7NPNpg11xnzH9kqzYhmT3qrGDwL7fZKxHJ7FcFKxjt4RFQ80ILw2LPZ E93kGTsrTTZ55LFee/b5R5usGU/XuhwXepcxzzboZ3L+MX8aVHg1s323V3IAf8wfDHnMikjxXHMp EAdzA4ykKGTGjkDp61tWshURxpCYrbapsynStvXDIvB7oIoUORXEI7GMthsmdDdSjGoWZAxnjo2w 3R4Y94NPynTlcLmbxs5h7XaX5jkT8WjNs9jB0CoSh10uBFNfw6sZLAebIO/IW3elSM9/O7D2jW0C +2QWKCXVsLjViovUSbMOYUq1yQ+rxRPiwJh4nkfSrDu/XgaLxfWibbUAbCkG9RLErs32wGrtrVYi FXEwXUE3jHBYJKsCkC7NvqP9d8OJ64AdsZoNQeBBIvhXRvDralltEPLcDxo5RGsW/WFycFDsFi7N cErMplHAEhxgQk4F/VVCZdFsN5FCk0hmUnm/9PuU9vu+kKTsUhNeuD308bFauE2WFew0RZL04efX e3JXvg0FOS29BPHfEdvtrfzn60DlMLnqDHinm+TF0YBoS6sdigMZeBUBRo2AHY4dRuRMcWSg2ZnJ 1KwJGj1w9phLpe/xAB2DzXl67vHVnKqjS3nKsOEiqqO1w7A8e6vsAlOqSi0uuOY04wWLUeXJDNfe W0bVo9dIbrOYCKnJ0Z/co3uHFFKpHfl85pAy1KpizAkDaevLBVGUEKZld5RHMCxRbJFmNw0OPHBr NWlIThX0qWbKiAs8Ky7imgWmYfBbeLcIlhfjDsaUPjC4qeP4S6/G9H4xvFneGtNoNry6WYbQpuNJ 8C9Ywv/KcjWdL79MZ2GwMOZ5MFwEt+E/5BhOTnL8RDexzbKTBckkjZsFiSm8XxIlN4QqRXdktU0S pupy5/wJmgkqLtgjueNCfxqil/Me8BL73ocbiVx8+HAwnKOhf5hePJ/+enB/ffGnG5qyi/FLl75R ZTG5HHbIufk3LTC4m99OJ/NgvLz8FgadKpn/Sz6Om0TdAOqaSSWb2b3TBLpSIA/g9V1cXsCvUaT1 akl+osRhJxXh36vRei7HvpFMoSLIxK4U6eYihfcZfH/U73a4jstPkF75ZWNZfwJQSwMEFAAAAAgA GmfpQtoHiHefAwAA8wgAAB4AHAB0ZXh0dXJlX3Rlc3QvdGV4dHVyZV90ZXN0Lmh0bWxVVAkAA3Ps 21F07NtRdXgLAAEEPVLAUAQ9UsBQtVZhb+I4EP1MfoU392GDlgLt7a5WSxKJQpZForSiqXqr1QmZ xAnWBTtyTFu04r/fjJNAWh17vTsdQoo9b+bZ82bsxH0zvh6F324CstabzLfc+sFoDI8N05REa6oK pj17q5OzTzaYNdcZ8x/ZKs2IZk96qxg8C+32SsRyexXBSsY7eERUPNCC8Niz2RPd5Bk7K002eeSx Xnv2+UebrBlP17ocF3qXMc826Gdy/jF/GlR4NbN9t1dyAH/MHwx5zIpI8VxzKRAHcwOMpChkxo5A 6etbVrIVEcaQmK22qbMp0rb1wyLwe6CKFDkVxCOxjLYbJnQ3UoxqFmQMZ46NsN0eGPeDT8p05XC5 m8bOYe12l+Y5E/FozbPYwdAqEoddLgRTX8OrGSwHmyDvyFt3pUjPfzuw9o1tAvtkFigl1bC41YqL 1EmzDmFKtckPq8UT4sCYeJ5H0qw7v14Gi8X1om21AGwpBvUSxK7N9sBq7a1WIhVxMF1BN4xwWCSr ApAuzb6j/XfDieuAHbGaDUHgQSL4V0bw62pZbRDy3A8aOURrFv1hcnBQ7BYuzXBKzKZRwBIcYEJO Bf1VQmXRbDeRQpNIZlJ5v/T7lPb7vpCk7FITXrg99PGxWrhNlhXsNEWS9OHn13tyV74NBTktvQTx 3xHb7a385+tA5TC56gx4p5vkxdGAaEurHYoDGXgVAUaNgB2OHUbkTHFkoNmZydSsCRo9cPaYS6Xv 8QAdg815eu7x1Zyqo0t5yrDhIqqjtcOwPHur7AJTqkotLrjmNOMFi1HlyQzX3ltG1aPXSG6zmAip ydGf3KN7hxRSqR35fOaQMtSqYswJA2nrywVRlBCmZXeURzAsUWyRZjcNDjxwazVpSE4V9KlmyogL PCsu4poFpmHwW3i3CJYX4w7GlD4wuKnj+EuvxvR+MbxZ3hrTaDa8ulmG0KbjSfAvWML/ynI1nS+/ TGdhsDDmeTBcBLfhP+QYTk5y/EQ3sc2ykwXJJI2bBYkpvF8SJTeEKkV3ZLVNEqbqcuf8CZoJKi7Y I7njQn8aopfzHvAS+96HG4lcfPhwMJyjoX+YXjyf/npwf33xpxuasovxS5e+UWUxuRx2yLn5Ny0w uJvfTifzYLy8/BYGnSqZ/0s+jptE3QDqmkklm9m90wS6UiAP4PVdXF7Ar1Gk9WpJfqLEYScV4d+r 0Xoux76RTKEiyMSuFOnmIoX3GXx/1O92uI7LT5Be+WVjWX8CUEsDBAoAAAAAAMRg6UI+hSNuHAMA ABwDAAAYABwAdGV4dHVyZV90ZXN0L3RleHR1cmUucG5nVVQJAAOQ4NtR0uDbUXV4CwABBD1SwFAE PVLAUIlQTkcNChoKAAAADUlIRFIAAAEAAAAAEAgGAAAA+dOhSQAAAuNJREFUeJzt2kVz3EoUQGFp yMzMzMxs/2Wzt2ZmZmZm9pwsk4UUR4kmct67i28zNTV1N32mq7sVRVFQVRWbzYbdbsfhcOB0OnG5 XHh5eeHt7Y2Pjw++vr74+fnh7+9PQEAAgYGBBAUFERwcTEhICKGhoYSFhREeHk5ERASRkZFERUUR HR1NTEwMsbGxxMXFER8fT0JCAomJiSQlJZGcnExKSgqpqamkpaWRnp5ORkYGmZmZZGVlkZ2dTU5O Drm5ueTl5ZGfn09BQQGFhYUUFRVRXFxMSUkJpaWllJWVUV5eTkVFBZWVlVRVVVFdXU1NTQ21tbXU 1dVRX19PQ0MDjY2NNDU1oXijz8sY1aVNcWpTHdoUu0E2baqqTVHcmvS+b5Te79tUTGFXvvvxc6ei zfUT3d3d9PT00NvbS19fH/39/QwMDDA4OMjQ0BDDw8OMjIwwOjrK2NgY4+PjTExMMDk5ydTUFNPT 08zMzDA7O8vc3Bzz8/MsLCywuLjI0tISy8vLrKyssLq6ytraGuvr62xsbLC5ucnW1hbb29vs7Oyw u7vL3t4e+/v7HBwccHh4yNHREcfHx5ycnHB6esrZ2Rnn5+dcXFxweXnJ1dUV19fX3NzccHt7y93d Hff39zw8PPD4+MjT0xPPz8+8vLzw+vrK29sb7+/vfHx84Ha7AVAkANYFQJfdrcOzAfC0P1nov0IC IAH4vQAYXOim7QA8HAwzAqD+hGkBUNyaJAASgC+5AzBt4RrdAej80xv2H90B6JEAfBIAIcT/luUD CCGsY/kAQgjrWD6AEMI6cgho1iGg568BjR0OmnULYOUh4GeHg83NzbS0tNDa2kpbWxvt7e10dHTQ 2dlJV1fXp7cDcggoAZAAfOFbAAmABOCfCYDidOswaaEbfSGow9Nh0HsrYFUAHKo2CYAE4K/sAHTp PgU2GIAvtgMwMwCfkQDIOwAhxO+zfAAhhHUsH0AIYR3LBxBCWOQbuNAXXd184vYAAAAASUVORK5C YIJQSwMECgAAAAAAGmfpQgAAAAAAAAAAAAAAAA0AHAB0ZXh0dXJlX3Rlc3QvVVQJAANz7NtR/O3b UXV4CwABBD1SwFAEPVLAUFBLAQIeAxQAAAAIABln6ULaB4h3nwMAAPMIAAAfABgAAAAAAAEAAAC0 gQAAAAB0ZXh0dXJlX3Rlc3QvdGV4dHVyZV90ZXN0Lmh0bWx+VVQFAANy7NtRdXgLAAEEPVLAUAQ9 UsBQUEsBAh4DFAAAAAgAGmfpQtoHiHefAwAA8wgAAB4AGAAAAAAAAQAAALSB+AMAAHRleHR1cmVf dGVzdC90ZXh0dXJlX3Rlc3QuaHRtbFVUBQADc+zbUXV4CwABBD1SwFAEPVLAUFBLAQIeAwoAAAAA AMRg6UI+hSNuHAMAABwDAAAYABgAAAAAAAAAAAC0ge8HAAB0ZXh0dXJlX3Rlc3QvdGV4dHVyZS5w bmdVVAUAA5Dg21F1eAsAAQQ9UsBQBD1SwFBQSwECHgMKAAAAAAAaZ+lCAAAAAAAAAAAAAAAADQAY AAAAAAAAABAA/UFdCwAAdGV4dHVyZV90ZXN0L1VUBQADc+zbUXV4CwABBD1SwFAEPVLAUFBLBQYA AAAABAAEAHoBAACkCwAAAAA= 206331 2013-07-09 09:44:44 -0700 2013-07-10 01:47:14 -0700 Patch bug-118464-20130709184230.patch text/plain 3235 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmM0NmFhNWZmODhlMzc3 YmFlNmFmYWMzOTU2NmU3Mjc0YzdhYTQ3NS4uOGNiOTFiN2U0ZTE2NmQyOTllNjBlOTE1MmM0NTYw MjAzZDBmN2U3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA3LTA5ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MTUxOTU3KTogV2ViR0wgdGV4dHVyZXMgZG8gbm90IHNob3cKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODQ2NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIHIxNTE5NTcgZGVjb2Rlci5mcmFtZUlz Q29tcGxldGVBdEluZGV4KDApIGRvZXNuJ3QgdHJpZ2dlciBpbWFnZSBkZWNvZGluZywKKyAgICAg ICAgd2UgaGF2ZSB0byBjYWxsIGRlY29kZXIuY3JlYXRlRnJhbWVBdEluZGV4KDApIGV4cGxpY2l0 bHkgdG8gZW5zdXJlIGl0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3Jh cGhpY3NDb250ZXh0M0RDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRl eHQzRDo6SW1hZ2VFeHRyYWN0b3I6OmV4dHJhY3RJbWFnZSk6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvZWZsL0dyYXBoaWNzQ29udGV4dDNERWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkdyYXBoaWNzQ29udGV4dDNEOjpJbWFnZUV4dHJhY3Rvcjo6ZXh0cmFjdEltYWdlKToKKwogMjAx My0wNy0wOCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0NTUyBHcmlkIExheW91dF0gUmVuYW1lIGdyaWQte3Jvd3N8Y29sdW1uc30gdG8gZ3JpZC1k ZWZpbml0aW9uLXtyb3dzfGNvbHVtbnN9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dDNEQ2Fpcm8uY3Bw CmluZGV4IDg1NjE4Y2Q5YWI3MDRlZjg2ZWE2OGI2ZjlhYzIxNmFhMThiZDBhYTMuLmQzMWFkZjMy NjJlYTMxOTBiNDc2ODg3OTVhZGE0MzNhMDExOGQxNTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dDNEQ2Fpcm8uY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4 dDNEQ2Fpcm8uY3BwCkBAIC0xOTAsOSArMTkwLDEyIEBAIGJvb2wgR3JhcGhpY3NDb250ZXh0M0Q6 OkltYWdlRXh0cmFjdG9yOjpleHRyYWN0SW1hZ2UoYm9vbCBwcmVtdWx0aXBseUFscGhhLCBib29s CiAgICAgbV9hbHBoYU9wID0gQWxwaGFEb05vdGhpbmc7CiAgICAgaWYgKG1faW1hZ2UtPmRhdGEo KSkgewogICAgICAgICBkZWNvZGVyLnNldERhdGEobV9pbWFnZS0+ZGF0YSgpLCB0cnVlKTsKLSAg ICAgICAgaWYgKCFkZWNvZGVyLmZyYW1lQ291bnQoKSB8fCAhZGVjb2Rlci5mcmFtZUlzQ29tcGxl dGVBdEluZGV4KDApKQorICAgICAgICBpZiAoIWRlY29kZXIuZnJhbWVDb3VudCgpKQogICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgICAgIG1faW1hZ2VTdXJmYWNlID0gZGVjb2Rlci5j cmVhdGVGcmFtZUF0SW5kZXgoMCk7CisgICAgICAgIGlmICghbV9pbWFnZVN1cmZhY2UgfHwgIWRl Y29kZXIuZnJhbWVJc0NvbXBsZXRlQXRJbmRleCgwKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxz ZTsKICAgICB9IGVsc2UgewogICAgICAgICBtX2ltYWdlU3VyZmFjZSA9IG1faW1hZ2UtPm5hdGl2 ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7CiAgICAgICAgIC8vIDEuIEZvciB0ZXhJbWFnZTJEIHdp dGggSFRNTFZpZGVvRWxtZW50IGlucHV0LCBhc3N1bWUgbm8gUHJlbXVsdGlwbHlBbHBoYSBoYWQg YmVlbiBhcHBsaWVkIGFuZCB0aGUgYWxwaGEgdmFsdWUgaXMgMHhGRiBmb3IgZWFjaCBwaXhlbCwK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VmbC9HcmFwaGlj c0NvbnRleHQzREVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZmwv R3JhcGhpY3NDb250ZXh0M0RFZmwuY3BwCmluZGV4IDEyY2E3MjY2NGMzMjkwZmVhMjc0Yzk2MzE4 MWIxZmYxMjMzZjI4OGYuLmVhMjVlNDM1NWJmZjY2NWJhOWQ4YzUxYWRkMWYxNDUxZTNmYmJhMmEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VmbC9HcmFwaGlj c0NvbnRleHQzREVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv ZWZsL0dyYXBoaWNzQ29udGV4dDNERWZsLmNwcApAQCAtMjY1LDEwICsyNjUsMTIgQEAgYm9vbCBH cmFwaGljc0NvbnRleHQzRDo6SW1hZ2VFeHRyYWN0b3I6OmV4dHJhY3RJbWFnZShib29sIHByZW11 bHRpcGx5QWxwaGEsIGJvb2wKICAgICBpZiAobV9pbWFnZS0+ZGF0YSgpKSB7CiAgICAgICAgIGRl Y29kZXIuc2V0RGF0YShtX2ltYWdlLT5kYXRhKCksIHRydWUpOwogCi0gICAgICAgIGlmICghZGVj b2Rlci5mcmFtZUNvdW50KCkgfHwgIWRlY29kZXIuZnJhbWVJc0NvbXBsZXRlQXRJbmRleCgwKSkK KyAgICAgICAgaWYgKCFkZWNvZGVyLmZyYW1lQ291bnQoKSkKICAgICAgICAgICAgIHJldHVybiBm YWxzZTsKIAogICAgICAgICBtX2ltYWdlU3VyZmFjZSA9IGRlY29kZXIuY3JlYXRlRnJhbWVBdElu ZGV4KDApOworICAgICAgICBpZiAoIW1faW1hZ2VTdXJmYWNlIHx8ICFkZWNvZGVyLmZyYW1lSXND b21wbGV0ZUF0SW5kZXgoMCkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfSBlbHNl IHsKICAgICAgICAgbV9pbWFnZVN1cmZhY2UgPSBtX2ltYWdlLT5uYXRpdmVJbWFnZUZvckN1cnJl bnRGcmFtZSgpOwogICAgICAgICAvLyAxLiBGb3IgdGV4SW1hZ2UyRCB3aXRoIEhUTUxWaWRlb0Vs bWVudCBpbnB1dCwgYXNzdW1lIG5vIFByZW11bHRpcGx5QWxwaGEgaGFkIGJlZW4gYXBwbGllZCBh bmQgdGhlIGFscGhhIHZhbHVlIGlzIDB4RkYgZm9yIGVhY2ggcGl4ZWwsCg==