118457 2013-07-07 23:49:35 -0700 DeleteSelectionCommand does not handle correctly deletion with two consecutive BR element. 2013-07-08 19:49:37 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica rniwa sam oldest_to_newest 906676 0 206220 enrica 2013-07-07 23:49:35 -0700 Created attachment 206220 Test case Repro steps: Open the attached test case (test2br.html). Click on the empty line below the empty image box Press backspace. Expected: the empty line is removed and the caret moves after the image. Actual: Nothing happens. The line is not removed and the caret remains in the same position. <rdar://problem/14160912> 906704 1 206224 enrica 2013-07-08 02:01:51 -0700 Created attachment 206224 Patch 906977 2 206224 simon.fraser 2013-07-08 19:25:03 -0700 Comment on attachment 206224 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206224&action=review > Source/WebCore/editing/DeleteSelectionCommand.cpp:312 > + // when the two elements are sibling and should be false in a case like <div><br></div><br>. …are siblings... > LayoutTests/editing/deleting/delete-image-followed-by-two-br-expected.txt:1 > +CONSOLE MESSAGE: line 16: TypeError: 'undefined' is not a function (evaluating 'document.getElementsById("test")') Should this be here? 906981 3 enrica 2013-07-08 19:32:23 -0700 (In reply to comment #2) > (From update of attachment 206224 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206224&action=review > > > Source/WebCore/editing/DeleteSelectionCommand.cpp:312 > > + // when the two elements are sibling and should be false in a case like <div><br></div><br>. > > …are siblings... Fixed. > > > LayoutTests/editing/deleting/delete-image-followed-by-two-br-expected.txt:1 > > +CONSOLE MESSAGE: line 16: TypeError: 'undefined' is not a function (evaluating 'document.getElementsById("test")') > > Should this be here? No, it is a syntax error. Extra s in getElementById. thanks for catching it. 906984 4 enrica 2013-07-08 19:49:37 -0700 Committed revision 152478. 206220 2013-07-07 23:49:35 -0700 2013-07-07 23:49:35 -0700 Test case test2br.html text/html 147 enrica PGJvZHkgY29udGVudGVkaXRhYmxlPSJ0cnVlIj4KCTxkaXY+CgkJPGltZyB3aWR0aD0iMTQwIiBo ZWlnaHQ9IjE0MCI+PGJyPjxicj5QbGFjZSB0aGUgY2FyZXQgb24gdGhlIGxpbmUgYWJvdmUgYW5k IHByZXNzIGJhY2tzcGFjZS4KCTwvZGl2Pgo8L2JvZHk+ 206224 2013-07-08 02:01:51 -0700 2013-07-08 19:25:02 -0700 Patch cannot-delete-image.txt text/plain 6598 enrica SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjQ0MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA3LTA4ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgRGVsZXRlU2VsZWN0aW9uQ29t bWFuZCBkb2VzIG5vdCBoYW5kbGUgY29ycmVjdGx5IGRlbGV0aW9uIHdpdGggdHdvIGNvbnNlY3V0 aXZlIEJSIGVsZW1lbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTg0NTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE0MTYwOTEyPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIERlbGV0ZVNlbGVj dGlvbkNvbW1hbmQ6OmhhbmRsZVNwZWNpYWxDYXJlQlJEZWxldGUgd2UgZGlkIG5vdAorICAgICAg ICBoYW5kbGUgY29ycmVjdGx5IHRoZSBjYXNlIHdoZXJlIHdlIGhhZCA8YnI+PGJyPiBpbiB0aGUg bWFya3VwIGFuZAorICAgICAgICBub3RoaW5nIHdhcyBiZWluZyBkZWxldGVkLiBXZSBzaG91bGQg Y29uc2lkZXIgdGhpcyBsaWtlCisgICAgICAgIHRoZSBjYXNlIHdoZXJlIHRoZSA8YnI+IGlzIG9u IHRoZSBsaW5lIGJ5IGl0c2VsZiBhbmQgcmVtb3ZlIGl0LgorCisgICAgICAgIFRlc3Q6IGVkaXRp bmcvZGVsZXRpbmcvZGVsZXRlLWltYWdlLWZvbGxvd2VkLWJ5LXR3by1ici5odG1sCisKKyAgICAg ICAgKiBlZGl0aW5nL0RlbGV0ZVNlbGVjdGlvbkNvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RGVsZXRlU2VsZWN0aW9uQ29tbWFuZDo6aGFuZGxlU3BlY2lhbENhc2VCUkRlbGV0ZSk6CisK IDIwMTMtMDctMDggIEtpaG9uZyBLd29uICA8a2lob25nLmt3b25Ac2Ftc3VuZy5jb20+CiAKICAg ICAgICAgdmlicmF0ZSBmdW5jdGlvbiBoYXZlIHRvIHJldHVybiBib29sZWFuIHZhbHVlLgpJbmRl eDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxldGVTZWxlY3Rpb25Db21tYW5kLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0RlbGV0ZVNlbGVjdGlvbkNvbW1hbmQu Y3BwCShyZXZpc2lvbiAxNTI0MzgpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0RlbGV0ZVNl bGVjdGlvbkNvbW1hbmQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDgsNyArMzA4LDEwIEBAIGJv b2wgRGVsZXRlU2VsZWN0aW9uQ29tbWFuZDo6aGFuZGxlU3BlY2kKICAgICAvLyBDaGVjayBmb3Ig c3BlY2lhbC1jYXNlIHdoZXJlIHRoZSBzZWxlY3Rpb24gY29udGFpbnMgb25seSBhIEJSIG9uIGEg bGluZSBieSBpdHNlbGYgYWZ0ZXIgYW5vdGhlciBCUi4KICAgICBib29sIHVwc3RyZWFtU3RhcnRJ c0JSID0gbm9kZUFmdGVyVXBzdHJlYW1TdGFydC0+aGFzVGFnTmFtZShiclRhZyk7CiAgICAgYm9v bCBkb3duc3RyZWFtU3RhcnRJc0JSID0gbm9kZUFmdGVyRG93bnN0cmVhbVN0YXJ0LT5oYXNUYWdO YW1lKGJyVGFnKTsKLSAgICBib29sIGlzQlJPbkxpbmVCeUl0c2VsZiA9IHVwc3RyZWFtU3RhcnRJ c0JSICYmIGRvd25zdHJlYW1TdGFydElzQlIgJiYgbm9kZUFmdGVyRG93bnN0cmVhbVN0YXJ0ID09 IG5vZGVBZnRlclVwc3RyZWFtRW5kOworICAgIC8vIFdlIHNob3VsZCBjb25zaWRlciB0aGF0IHRo ZSBCUiBpcyBvbiBhIGxpbmUgYnkgaXRzZWxmIGFsc28gd2hlbiB3ZSBoYXZlIDxicj48YnI+LiBU aGlzIHRlc3Qgc2hvdWxkIGJlIHRydWUgb25seQorICAgIC8vIHdoZW4gdGhlIHR3byBlbGVtZW50 cyBhcmUgc2libGluZyBhbmQgc2hvdWxkIGJlIGZhbHNlIGluIGEgY2FzZSBsaWtlIDxkaXY+PGJy PjwvZGl2Pjxicj4uCisgICAgYm9vbCBpc0JST25MaW5lQnlJdHNlbGYgPSB1cHN0cmVhbVN0YXJ0 SXNCUiAmJiBkb3duc3RyZWFtU3RhcnRJc0JSICYmICgobm9kZUFmdGVyRG93bnN0cmVhbVN0YXJ0 ID09IG5vZGVBZnRlclVwc3RyZWFtRW5kKSB8fCAobm9kZUFmdGVyVXBzdHJlYW1FbmQgJiYgbm9k ZUFmdGVyVXBzdHJlYW1FbmQtPmhhc1RhZ05hbWUoYnJUYWcpICYmIG5vZGVBZnRlclVwc3RyZWFt U3RhcnQtPm5leHRTaWJsaW5nKCkgPT0gbm9kZUFmdGVyVXBzdHJlYW1FbmQpKTsKKwogICAgIGlm IChpc0JST25MaW5lQnlJdHNlbGYpIHsKICAgICAgICAgcmVtb3ZlTm9kZShub2RlQWZ0ZXJEb3du c3RyZWFtU3RhcnQpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKSW5kZXg6IExheW91dFRlc3RzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1 MjQ0MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE1IEBACisyMDEzLTA3LTA4ICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisK KyAgICAgICAgRGVsZXRlU2VsZWN0aW9uQ29tbWFuZCBkb2VzIG5vdCBoYW5kbGUgY29ycmVjdGx5 IGRlbGV0aW9uIHdpdGggdHdvIGNvbnNlY3V0aXZlIEJSIGVsZW1lbnQuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg0NTcKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzE0MTYwOTEyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogZWRpdGluZy9kZWxldGluZy9kZWxldGUtaW1hZ2UtZm9sbG93ZWQtYnkt dHdvLWJyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9kZWxldGluZy9k ZWxldGUtaW1hZ2UtZm9sbG93ZWQtYnktdHdvLWJyLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBs YXRmb3JtL21hYy9lZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1ici0wMDItZXhwZWN0ZWQudHh0OiBS ZWJhc2VkLgorCiAyMDEzLTA3LTA4ICBLcnp5c3p0b2YgQ3plY2ggIDxrLmN6ZWNoQHltYWlsLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkIEVGTCBnYXJkZW5pbmcuCkluZGV4OiBMYXlvdXRUZXN0 cy9lZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1pbWFnZS1mb2xsb3dlZC1ieS10d28tYnItZXhwZWN0 ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvZGVsZXRpbmcvZGVsZXRl LWltYWdlLWZvbGxvd2VkLWJ5LXR3by1ici1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9lZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1pbWFnZS1mb2xsb3dlZC1ieS10d28t YnItZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNDMgQEAKK0NPTlNPTEUg TUVTU0FHRTogbGluZSAxNjogVHlwZUVycm9yOiAndW5kZWZpbmVkJyBpcyBub3QgYSBmdW5jdGlv biAoZXZhbHVhdGluZyAnZG9jdW1lbnQuZ2V0RWxlbWVudHNCeUlkKCJ0ZXN0IiknKQorV2Ugc2hv dWxkIGJlIGFibGUgdG8gZGVsZXRlIHRoZSBiciBhbmQgdGhlbiB0aGUgaW1hZ2UuCit8IDxodG1s PgorfCAgIDxoZWFkPgorfCAgICAgPHNjcmlwdD4KK3wgICAgICAgc3JjPSIuLi8uLi9yZXNvdXJj ZXMvZHVtcC1hcy1tYXJrdXAuanMiCit8ICAgICAiCisiCit8ICAgICA8c2NyaXB0PgorfCAgICAg ICBsYW5ndWFnZT0iSmF2YVNjcmlwdCIKK3wgICAgICAgc3JjPSIuLi9lZGl0aW5nLmpzIgorfCAg ICAgICB0eXBlPSJ0ZXh0L0phdmFTY3JpcHQiCit8ICAgICAiCisiCit8ICAgICA8c2NyaXB0Pgor fCAgICAgICAiCisgICAgZnVuY3Rpb24gZWRpdGluZ1Rlc3QoKSB7CisgICAgICAgIG1vdmVTZWxl Y3Rpb25Gb3J3YXJkQnlMaW5lQ29tbWFuZCgpOworICAgICAgICBkZWxldGVDb21tYW5kKCk7Cisg ICAgICAgIGRlbGV0ZUNvbW1hbmQoKTsKKyAgICB9CisiCit8ICAgICAiCisiCit8ICAgPGJvZHk+ Cit8ICAgICA8ZGl2PgorfCAgICAgICBjb250ZW50ZWRpdGFibGU9InRydWUiCit8ICAgICAgIGlk PSJ0ZXN0IgorfCAgICAgICA8I3NlbGVjdGlvbi1jYXJldD4KK3wgICAgICAgPGJyPgorfCAgICAg ICAiVGhpcyBpcyBhIGxpbmUgb2YgdGV4dC4KKyIKK3wgICAgICIKKyIKK3wgICAgIDxzY3JpcHQ+ Cit8ICAgICAgICIKKyAgICBydW5EdW1wQXNUZXh0RWRpdGluZ1Rlc3QoZmFsc2UpOworICAgIE1h cmt1cC5kZXNjcmlwdGlvbigiV2Ugc2hvdWxkIGJlIGFibGUgdG8gZGVsZXRlIHRoZSBiciBhbmQg dGhlbiB0aGUgaW1hZ2UuIik7CisgICAgTWFya3VwLmR1bXAoZG9jdW1lbnQuZ2V0RWxlbWVudHNC eUlkKCJ0ZXN0IikpOworIgorfCAgICAgPG9sPgorfCAgICAgIgorIgpJbmRleDogTGF5b3V0VGVz dHMvZWRpdGluZy9kZWxldGluZy9kZWxldGUtaW1hZ2UtZm9sbG93ZWQtYnktdHdvLWJyLmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy9kZWxldGUtaW1hZ2Ut Zm9sbG93ZWQtYnktdHdvLWJyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0 aW5nL2RlbGV0aW5nL2RlbGV0ZS1pbWFnZS1mb2xsb3dlZC1ieS10d28tYnIuaHRtbAkod29ya2lu ZyBjb3B5KQpAQCAtMCwwICsxLDE3IEBACis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2R1 bXAtYXMtbWFya3VwLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPS4uL2VkaXRpbmcuanMgbGFu Z3VhZ2U9IkphdmFTY3JpcHQiIHR5cGU9InRleHQvSmF2YVNjcmlwdCIgPjwvc2NyaXB0PgorPHNj cmlwdD4KKyAgICBmdW5jdGlvbiBlZGl0aW5nVGVzdCgpIHsKKyAgICAgICAgbW92ZVNlbGVjdGlv bkZvcndhcmRCeUxpbmVDb21tYW5kKCk7CisgICAgICAgIGRlbGV0ZUNvbW1hbmQoKTsKKyAgICAg ICAgZGVsZXRlQ29tbWFuZCgpOworICAgIH0KKzwvc2NyaXB0PgorPGRpdiBjb250ZW50ZWRpdGFi bGU9InRydWUiIGlkPSJ0ZXN0Ij4KKyAgICA8aW1nIHdpZHRoPSIxNDAiIGhlaWdodD0iMTQwIj48 YnI+PGJyPlRoaXMgaXMgYSBsaW5lIG9mIHRleHQuCis8L2Rpdj4KKzxzY3JpcHQ+CisgICAgcnVu RHVtcEFzVGV4dEVkaXRpbmdUZXN0KGZhbHNlKTsKKyAgICBNYXJrdXAuZGVzY3JpcHRpb24oIldl IHNob3VsZCBiZSBhYmxlIHRvIGRlbGV0ZSB0aGUgYnIgYW5kIHRoZW4gdGhlIGltYWdlLiIpOwor ICAgIE1hcmt1cC5kdW1wKGRvY3VtZW50LmdldEVsZW1lbnRzQnlJZCgidGVzdCIpKTsKKzwvc2Ny aXB0PgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRpbmcvZGVsZXRpbmcvZGVs ZXRlLWJyLTAwMi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL2VkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLWJyLTAwMi1leHBlY3RlZC50eHQJKHJldmlz aW9uIDE1MjQzOCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9lZGl0aW5nL2RlbGV0aW5n L2RlbGV0ZS1ici0wMDItZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0yNCw3ICsyNCw2 IEBAIEVESVRJTkcgREVMRUdBVEU6IHdlYlZpZXdEaWRDaGFuZ2VTZWxlY3QKIEVESVRJTkcgREVM RUdBVEU6IHdlYlZpZXdEaWRDaGFuZ2VTZWxlY3Rpb246V2ViVmlld0RpZENoYW5nZVNlbGVjdGlv bk5vdGlmaWNhdGlvbgogRURJVElORyBERUxFR0FURTogd2ViVmlld0RpZENoYW5nZVNlbGVjdGlv bjpXZWJWaWV3RGlkQ2hhbmdlU2VsZWN0aW9uTm90aWZpY2F0aW9uCiBFRElUSU5HIERFTEVHQVRF OiBzaG91bGREZWxldGVET01SYW5nZTpyYW5nZSBmcm9tIDIgb2YgU1BBTiA+IERJViA+IEJPRFkg PiBIVE1MID4gI2RvY3VtZW50IHRvIDMgb2YgU1BBTiA+IERJViA+IEJPRFkgPiBIVE1MID4gI2Rv Y3VtZW50Ci1FRElUSU5HIERFTEVHQVRFOiBzaG91bGRDaGFuZ2VTZWxlY3RlZERPTVJhbmdlOnJh bmdlIGZyb20gMyBvZiBTUEFOID4gRElWID4gQk9EWSA+IEhUTUwgPiAjZG9jdW1lbnQgdG8gMyBv ZiBTUEFOID4gRElWID4gQk9EWSA+IEhUTUwgPiAjZG9jdW1lbnQgdG9ET01SYW5nZTpyYW5nZSBm cm9tIDIgb2YgU1BBTiA+IERJViA+IEJPRFkgPiBIVE1MID4gI2RvY3VtZW50IHRvIDIgb2YgU1BB TiA+IERJViA+IEJPRFkgPiBIVE1MID4gI2RvY3VtZW50IGFmZmluaXR5Ok5TU2VsZWN0aW9uQWZm aW5pdHlEb3duc3RyZWFtIHN0aWxsU2VsZWN0aW5nOkZBTFNFCiBFRElUSU5HIERFTEVHQVRFOiB3 ZWJWaWV3RGlkQ2hhbmdlU2VsZWN0aW9uOldlYlZpZXdEaWRDaGFuZ2VTZWxlY3Rpb25Ob3RpZmlj YXRpb24KIEVESVRJTkcgREVMRUdBVEU6IHdlYlZpZXdEaWRDaGFuZ2U6V2ViVmlld0RpZENoYW5n ZU5vdGlmaWNhdGlvbgogbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCg==