118447 2013-07-06 20:50:56 -0700 Range.getClientRects() not working correctly for partially contained vertically styled text nodes 2013-07-10 17:42:34 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 sam sam commit-queue dbates enrica esprehn+autocc glenn hyatt simon.fraser oldest_to_newest 906597 0 206197 sam 2013-07-06 20:50:56 -0700 Created attachment 206197 Test Case Range.getClientRects() is not working correctly for partially contained vertically styled text nodes. (See attached test case). 907402 1 206397 sam 2013-07-10 10:44:21 -0700 Created attachment 206397 Potential fix from Mac Murrett 907414 2 206397 hyatt 2013-07-10 11:15:30 -0700 Comment on attachment 206397 Potential fix from Mac Murrett View in context: https://bugs.webkit.org/attachment.cgi?id=206397&action=review > Source/WebCore/rendering/RenderText.cpp:338 > r.setHeight(box->logicalHeight()); > r.setY(box->y()); > } else { > - r.setWidth(box->logicalWidth()); > + r.setWidth(box->logicalHeight()); > r.setX(box->x()); Shouldn't this just be using box->width() and box->height()? Seems silly to call logical when you seem to want physical? 907415 3 sam 2013-07-10 11:16:30 -0700 (In reply to comment #2) > (From update of attachment 206397 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206397&action=review > > > Source/WebCore/rendering/RenderText.cpp:338 > > r.setHeight(box->logicalHeight()); > > r.setY(box->y()); > > } else { > > - r.setWidth(box->logicalWidth()); > > + r.setWidth(box->logicalHeight()); > > r.setX(box->x()); > > Shouldn't this just be using box->width() and box->height()? Seems silly to call logical when you seem to want physical? Agreed, I'll try that out. 907427 4 206404 sam 2013-07-10 11:59:42 -0700 Created attachment 206404 Patch 907428 5 206404 hyatt 2013-07-10 12:00:56 -0700 Comment on attachment 206404 Patch r=me 907486 6 sam 2013-07-10 16:57:36 -0700 Committed r152554: <http://trac.webkit.org/changeset/152554> 907494 7 dbates 2013-07-10 17:42:34 -0700 <rdar://problem/14305675> 206197 2013-07-06 20:50:56 -0700 2013-07-06 20:50:56 -0700 Test Case test.html text/html 1355 sam PGh0bWw+CiAgPGhlYWQ+CiAgICA8c3R5bGU+CiAgICAgICAgLnRlc3QgeyAtd2Via2l0LXdyaXRp bmctbW9kZTogdmVydGljYWwtbHI7IH0KICAgIDwvc3R5bGU+CiAgICA8c2NyaXB0PgoKICAgIHdp bmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpCiAgICB7CiAgICAgICAgLy8gRG9lcyB3b3JrCiAgICAg ICAgdmFyIHJhbmdlMSA9IGRvY3VtZW50LmNyZWF0ZVJhbmdlKCk7CiAgICAgICAgcmFuZ2UxLnNl bGVjdE5vZGVDb250ZW50cyhkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGVzdDEiKS5maXJzdENo aWxkKTsKICAgICAgICAKICAgICAgICBoaWdobGlnaHQocmFuZ2UxKTsKICAgICAgICAKICAgICAg ICAKICAgICAgICAvLyBEb2Vzbid0IHdvcmsKICAgICAgICB2YXIgcmFuZ2UyID0gZG9jdW1lbnQu Y3JlYXRlUmFuZ2UoKTsKICAgICAgICByYW5nZTIuc2VsZWN0Tm9kZUNvbnRlbnRzKGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJ0ZXN0MiIpLmZpcnN0Q2hpbGQpOwogICAgICAgIHJhbmdlMi5zZXRF bmQocmFuZ2UyLmVuZENvbnRhaW5lciwgcmFuZ2UyLmVuZE9mZnNldCAtIDEpOwoKICAgICAgICBo aWdobGlnaHQocmFuZ2UyKTsKICAgIH0KCiAgICBmdW5jdGlvbiBoaWdobGlnaHQocmFuZ2UpCiAg ICB7CiAgICAgICAgdmFyIHJlY3QgPSByYW5nZS5nZXRDbGllbnRSZWN0cygpWzBdOwoKICAgICAg ICB2YXIgZGl2ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7CiAgICAgICAgZGl2LnN0 eWxlLmJhY2tncm91bmRDb2xvciA9ICdyZWQnOwogICAgICAgIGRpdi5zdHlsZS5wb3NpdGlvbiA9 ICdhYnNvbHV0ZSc7CiAgICAgICAgZGl2LnN0eWxlLm9wYWNpdHkgPSAwLjM7CgogICAgICAgIGRp di5zdHlsZS50b3AgPSByZWN0LnRvcCArICJweCI7CiAgICAgICAgZGl2LnN0eWxlLmxlZnQgPSBy ZWN0LmxlZnQgKyAicHgiOwogICAgICAgIGRpdi5zdHlsZS5oZWlnaHQgPSByZWN0LmhlaWdodCAr ICJweCI7CiAgICAgICAgZGl2LnN0eWxlLndpZHRoID0gcmVjdC53aWR0aCArICJweCI7CgogICAg ICAgIGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCdib2R5JylbMF0uYXBwZW5kQ2hpbGQo ZGl2KTsKICAgIH0KICAgICAgICAKICAgIDwvc2NyaXB0PgogIDwvaGVhZD4KICA8Ym9keT4KICAg ICAgPHA+CiAgICAgICAgICBEb2VzIHdvcms6CiAgICAgICAgICA8ZGl2IGNsYXNzPSJ0ZXN0IiBp ZD0idGVzdDEiPkhlbGxvPC9kaXY+CiAgICAgIDwvcD4KICAgICAgPGJyPgogICAgICA8cD4KICAg ICAgICAgIERvZXNuJ3Qgd29yazoKICAgICAgICAgIDxkaXYgY2xhc3M9InRlc3QiIGlkPSJ0ZXN0 MiI+SGVsbG88L2Rpdj4KICAgICAgPC9wPgogIDwvYm9keT4KPC9odG1sPgo= 206397 2013-07-10 10:44:21 -0700 2013-07-10 11:59:38 -0700 Potential fix from Mac Murrett client-rects.diff text/plain 527 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAJKHJldmlzaW9uIDE1 MjQzMykKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMzM0LDcgKzMzNCw3IEBACiAgICAgICAgICAgICAgICAgci5zZXRIZWlnaHQo Ym94LT5sb2dpY2FsSGVpZ2h0KCkpOwogICAgICAgICAgICAgICAgIHIuc2V0WShib3gtPnkoKSk7 CiAgICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgICAgIHIuc2V0V2lkdGgoYm94LT5s b2dpY2FsV2lkdGgoKSk7CisgICAgICAgICAgICAgICAgci5zZXRXaWR0aChib3gtPmxvZ2ljYWxI ZWlnaHQoKSk7CiAgICAgICAgICAgICAgICAgci5zZXRYKGJveC0+eCgpKTsKICAgICAgICAgICAg IH0KICAgICAgICAgfQo= 206404 2013-07-10 11:59:42 -0700 2013-07-10 16:36:14 -0700 Patch bug-118447-20130710115728.patch text/plain 4870 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjU0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA3LTEwICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmFuZ2UuZ2V0Q2xpZW50UmVjdHMoKSBu b3Qgd29ya2luZyBjb3JyZWN0bHkgZm9yIHBhcnRpYWxseSBjb250YWluZWQgdmVydGljYWxseSBz dHlsZWQgdGV4dCBub2RlcworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTQzMDU2NzU+CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg0NDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPcmlnaW5hbCBwYXRj aCBieSBNYWMgTXVycmV0dCwgdHdlYWtlZCBieSBtZS4KKworICAgICAgICBUZXN0OiBmYXN0L2Rv bS9SYW5nZS9nZXRDbGllbnRSZWN0cy12ZXJ0aWNhbC5odG1sCisKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyVGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpsb2NhbFF1YWRGb3JUZXh0Qm94 KToKKyAgICAgICAgVXNlIHRoZSBwaHlzaWNhbCBhY2Nlc3NvcnMgcmF0aGVyIHRoYW4gdGhlIGxv Z2ljYWwgb25lcyB0byBnZXQgdGhlIGNvcnJlY3QgbWV0cmljcy4KKwogMjAxMy0wNy0xMCAgTmlj ayBEaWVnbyBZYW1hbmUgIDxuaWNrLnlhbWFuZUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIEZp eCBhIGJ1ZyBpbiBNZWRpYVN0cmVhbURlc2NyaXB0b3I6OnJlbW92ZVZpZGVvQ29tcG9uZW50Cklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQuY3BwCShyZXZpc2lvbiAxNTI0 MTcpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTMzMSwxMCArMzMxLDEwIEBAIHN0YXRpYyBGbG9hdFJlY3QgbG9jYWxRdWFkRm9y VGV4dEJveChJbmwKICAgICAgICAgICAgIC8vIENoYW5nZSB0aGUgaGVpZ2h0IGFuZCB5IHBvc2l0 aW9uIChvciB3aWR0aCBhbmQgeCBmb3IgdmVydGljYWwgdGV4dCkKICAgICAgICAgICAgIC8vIGJl Y2F1c2Ugc2VsZWN0aW9uUmVjdCB1c2VzIHNlbGVjdGlvbi1zcGVjaWZpYyB2YWx1ZXMuCiAgICAg ICAgICAgICBpZiAoYm94LT5pc0hvcml6b250YWwoKSkgewotICAgICAgICAgICAgICAgIHIuc2V0 SGVpZ2h0KGJveC0+bG9naWNhbEhlaWdodCgpKTsKKyAgICAgICAgICAgICAgICByLnNldEhlaWdo dChib3gtPmhlaWdodCgpKTsKICAgICAgICAgICAgICAgICByLnNldFkoYm94LT55KCkpOwogICAg ICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICByLnNldFdpZHRoKGJveC0+bG9naWNh bFdpZHRoKCkpOworICAgICAgICAgICAgICAgIHIuc2V0V2lkdGgoYm94LT53aWR0aCgpKTsKICAg ICAgICAgICAgICAgICByLnNldFgoYm94LT54KCkpOwogICAgICAgICAgICAgfQogICAgICAgICB9 CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCShyZXZpc2lvbiAxNTI1NDApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0wNy0xMCAgU2FtIFdlaW5pZyAgPHNh bUB3ZWJraXQub3JnPgorCisgICAgICAgIFJhbmdlLmdldENsaWVudFJlY3RzKCkgbm90IHdvcmtp bmcgY29ycmVjdGx5IGZvciBwYXJ0aWFsbHkgY29udGFpbmVkIHZlcnRpY2FsbHkgc3R5bGVkIHRl eHQgbm9kZXMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE0MzA1Njc1PgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NDQ3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2RvbS9SYW5nZS9nZXRD bGllbnRSZWN0cy12ZXJ0aWNhbC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv ZG9tL1JhbmdlL2dldENsaWVudFJlY3RzLXZlcnRpY2FsLmh0bWw6IEFkZGVkLgorCiAyMDEzLTA3 LTEwICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CiAKICAg ICAgICAgQVg6IEFsbG93IHJlcXVlc3RpbmcgdGhlIGZ1bGwgcGxhaW4gdGV4dCBmb3IgYW4gb2Jq ZWN0IHdpdGggdGV4dFVuZGVyRWxlbWVudCgpCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9S YW5nZS9nZXRDbGllbnRSZWN0cy12ZXJ0aWNhbC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvZmFzdC9kb20vUmFuZ2UvZ2V0Q2xpZW50UmVjdHMtdmVydGljYWwtZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vUmFuZ2UvZ2V0Q2xp ZW50UmVjdHMtdmVydGljYWwtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs MTAgQEAKK1RoaXMgdGVzdHMgdGhhdCBSYW5nZS5nZXRDbGllbnRSZWN0cygpIHdvcmsgY29ycmVj dGx5IGZvciBwYXJ0aWFsbHkgc2VsZWN0ZWQgdmVydGljYWwgdGV4dC4KKworT24gc3VjY2Vzcywg eW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRF U1QgQ09NUExFVEUiLgorCisKK1BBU1MgcmFuZ2UxLmdldENsaWVudFJlY3RzKClbMF0ud2lkdGgg aXMgcmFuZ2UyLmdldENsaWVudFJlY3RzKClbMF0ud2lkdGgKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFy c2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9SYW5nZS9nZXRDbGllbnRSZWN0cy12ZXJ0aWNhbC5odG1sCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2Zhc3QvZG9tL1JhbmdlL2dldENsaWVudFJlY3RzLXZlcnRpY2FsLmh0bWwJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9SYW5nZS9nZXRDbGllbnRSZWN0cy12ZXJ0 aWNhbC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNDEgQEAKKzxodG1sPgorICA8aGVh ZD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48 L3NjcmlwdD4KKyAgICA8c3R5bGU+CisgICAgICAgIC50ZXN0IHsgLXdlYmtpdC13cml0aW5nLW1v ZGU6IHZlcnRpY2FsLWxyOyB9CisgICAgPC9zdHlsZT4KKyAgICA8L3NjcmlwdD4KKyAgICA8L2hl YWQ+CisgICAgPGJvZHk+CisgICAgICAgIDxkaXYgaWQ9InRlc3RhcmVhIj4KKyAgICAgICAgICAg IDxwPgorICAgICAgICAgICAgICAgIDxkaXYgY2xhc3M9InRlc3QiIGlkPSJ0ZXN0MSI+SGVsbG88 L2Rpdj4KKyAgICAgICAgICAgIDwvcD4KKyAgICAgICAgICAgIDxwPgorICAgICAgICAgICAgICAg IDxkaXYgY2xhc3M9InRlc3QiIGlkPSJ0ZXN0MiI+SGVsbG88L2Rpdj4KKyAgICAgICAgICAgIDwv cD4KKyAgICAgICAgPC9kaXY+CisgICAgICAgIDxzY3JpcHQ+IAorICAgICAgICAgICAgZGVzY3Jp cHRpb24oIlRoaXMgdGVzdHMgdGhhdCBSYW5nZS5nZXRDbGllbnRSZWN0cygpIHdvcmsgY29ycmVj dGx5IGZvciBwYXJ0aWFsbHkgc2VsZWN0ZWQgdmVydGljYWwgdGV4dC4iKQorICAgICAgICAgICAg CisgICAgICAgICAgICAvLyBTZWxlY3QgYSB3aG9sZSBlbGVtZW50J3Mgd29ydGggb2YgdGV4dC4K KyAgICAgICAgICAgIHZhciByYW5nZTEgPSBkb2N1bWVudC5jcmVhdGVSYW5nZSgpOworICAgICAg ICAgICAgcmFuZ2UxLnNlbGVjdE5vZGVDb250ZW50cyhkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi dGVzdDEiKS5maXJzdENoaWxkKTsKKworCisgICAgICAgICAgICAvLyBTZWxlY3Qgc2xpZ2h0bHkg bGVzcyB0aGFuIGEgd2hvbGUgZWxlbWVudHMgd29ydGggb2YgdGV4dC4KKyAgICAgICAgICAgIHZh ciByYW5nZTIgPSBkb2N1bWVudC5jcmVhdGVSYW5nZSgpOworICAgICAgICAgICAgcmFuZ2UyLnNl bGVjdE5vZGVDb250ZW50cyhkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGVzdDIiKS5maXJzdENo aWxkKTsKKyAgICAgICAgICAgIHJhbmdlMi5zZXRFbmQocmFuZ2UyLmVuZENvbnRhaW5lciwgcmFu Z2UyLmVuZE9mZnNldCAtIDEpOworCisgICAgICAgICAgICAvLyBUaGV5IHNob3VsZCBoYXZlIHRo ZSBzYW1lIHdpZHRoLgorICAgICAgICAgICAgc2hvdWxkQmUoInJhbmdlMS5nZXRDbGllbnRSZWN0 cygpWzBdLndpZHRoIiwgInJhbmdlMi5nZXRDbGllbnRSZWN0cygpWzBdLndpZHRoIik7CisKKwor ICAgICAgICAgICAgLy8gQ2xlYW51cAorICAgICAgICAgICAgdmFyIHRlc3RhcmVhID0gZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RhcmVhIik7CisgICAgICAgICAgICB0ZXN0YXJlYS5wYXJl bnROb2RlLnJlbW92ZUNoaWxkKHRlc3RhcmVhKTsKKyAgICAgICAgPC9zY3JpcHQ+CisgICAgICAg IDxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Njcmlw dD4KKyAgICA8L2JvZHk+Cis8L2h0bWw+Cg==