118440 2013-07-05 21:31:35 -0700 Tons of crashes on bots after r152425 2013-07-05 22:03:35 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca bdakin sam simon.fraser webkit-bug-importer oldest_to_newest 906544 0 thorton 2013-07-05 21:31:35 -0700 In FrameView::max/minScrollPosition, m_frame->page() can be null (by design). 906545 1 webkit-bug-importer 2013-07-05 21:32:53 -0700 <rdar://problem/14366772> 906546 2 206184 thorton 2013-07-05 21:36:02 -0700 Created attachment 206184 patch 906548 3 206185 thorton 2013-07-05 21:50:17 -0700 Created attachment 206185 patch 906549 4 206185 sam 2013-07-05 21:53:32 -0700 Comment on attachment 206185 patch View in context: https://bugs.webkit.org/attachment.cgi?id=206185&action=review > Source/WebCore/page/FrameView.cpp:1646 > + if (Page* page = m_frame->page()) { I would do an early return. > Source/WebCore/page/FrameView.cpp:1658 > + Page* page = m_frame->page(); I would early return here. 906552 5 thorton 2013-07-05 22:03:29 -0700 http://trac.webkit.org/changeset/152434 206184 2013-07-05 21:36:02 -0700 2013-07-05 21:50:17 -0700 patch fix-crash.diff text/plain 2396 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5OTQ0NDdjLi5kYjRlMjVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTMtMDctMDUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK KyAgICAgICAgVG9ucyBvZiBjcmFzaGVzIG9uIGJvdHMgYWZ0ZXIgcjE1MjQyNQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NDQwCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8xNDM2Njc3Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBOdWxsLWNoZWNrIHRoZSBmcmFtZSdzIHBhZ2Ugc28gd2UgZG9uJ3Qg Y3Jhc2guIEl0J3MgT0sgdG8gbm90CisgICAgICAgIHBpbiBpZiB3ZSBkb24ndCBoYXZlIGEgcGFn ZSBiZWNhdXNlIHdlJ3JlIGJlaW5nIHRvcm4gZG93bi4KKworICAgICAgICAqIHBhZ2UvRnJhbWVW aWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6bWluaW11bVNjcm9sbFBvc2l0 aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6bWF4aW11bVNjcm9sbFBvc2l0aW9u KToKKworMjAxMy0wNy0wNSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4K KwogICAgICAgICBGaXggcjE1MjI2NTogRnJhbWVWaWV3J3MgcGFnaW5hdGlvbiBtb2RlIGlzIG9u bHkgb25lIG9mIHR3bywgYW5kIHRoZSBsb2dpYyB3YXMgdG90YWxseSB3cm9uZwogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NDM5CiAgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8xNDM2NjEyMD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCBj MzYwYmY3Li4zZGQxYTI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmll dy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0xNjQyLDkg KzE2NDIsMTEgQEAgSW50U2l6ZSBGcmFtZVZpZXc6OnNjcm9sbE9mZnNldEZvckZpeGVkUG9zaXRp b24oKSBjb25zdAogSW50UG9pbnQgRnJhbWVWaWV3OjptaW5pbXVtU2Nyb2xsUG9zaXRpb24oKSBj b25zdAogewogICAgIEludFBvaW50IG1pbmltdW1Qb3NpdGlvbihTY3JvbGxWaWV3OjptaW5pbXVt U2Nyb2xsUG9zaXRpb24oKSk7Ci0gICAgCi0gICAgaWYgKG1fZnJhbWUgPT0gbV9mcmFtZS0+cGFn ZSgpLT5tYWluRnJhbWUoKSAmJiBtX3Njcm9sbFBpbm5pbmdCZWhhdmlvciA9PSBQaW5Ub0JvdHRv bSkKLSAgICAgICAgbWluaW11bVBvc2l0aW9uLnNldFkobWF4aW11bVNjcm9sbFBvc2l0aW9uKCku eSgpKTsKKworICAgIGlmIChQYWdlKiBwYWdlID0gbV9mcmFtZS0+cGFnZSgpKSB7CisgICAgICAg IGlmIChtX2ZyYW1lID09IHBhZ2UtPm1haW5GcmFtZSgpICYmIG1fc2Nyb2xsUGlubmluZ0JlaGF2 aW9yID09IFBpblRvQm90dG9tKQorICAgICAgICAgICAgbWluaW11bVBvc2l0aW9uLnNldFkobWF4 aW11bVNjcm9sbFBvc2l0aW9uKCkueSgpKTsKKyAgICB9CiAgICAgCiAgICAgcmV0dXJuIG1pbmlt dW1Qb3NpdGlvbjsKIH0KQEAgLTE2NTcsOSArMTY1OSwxMSBAQCBJbnRQb2ludCBGcmFtZVZpZXc6 Om1heGltdW1TY3JvbGxQb3NpdGlvbigpIGNvbnN0CiAgICAgaWYgKChtX2ZyYW1lLT5wYWdlKCkt PnBhZ2luYXRpb24oKS5tb2RlID09IFBhZ2luYXRpb246OlVucGFnaW5hdGVkICYmIG1fcGFnaW5h dGlvbi5tb2RlID09IFBhZ2luYXRpb246OlVucGFnaW5hdGVkKQogICAgICAgICB8fCBzY3JvbGxP cmlnaW4oKSA9PSBJbnRQb2ludDo6emVybygpKQogICAgICAgICBtYXhpbXVtT2Zmc2V0LmNsYW1w TmVnYXRpdmVUb1plcm8oKTsKLSAgICAKLSAgICBpZiAobV9mcmFtZSA9PSBtX2ZyYW1lLT5wYWdl KCktPm1haW5GcmFtZSgpICYmIG1fc2Nyb2xsUGlubmluZ0JlaGF2aW9yID09IFBpblRvVG9wKQot ICAgICAgICBtYXhpbXVtT2Zmc2V0LnNldFkobWluaW11bVNjcm9sbFBvc2l0aW9uKCkueSgpKTsK KworICAgIGlmIChQYWdlKiBwYWdlID0gbV9mcmFtZS0+cGFnZSgpKSB7CisgICAgICAgIGlmICht X2ZyYW1lID09IHBhZ2UtPm1haW5GcmFtZSgpICYmIG1fc2Nyb2xsUGlubmluZ0JlaGF2aW9yID09 IFBpblRvVG9wKQorICAgICAgICAgICAgbWF4aW11bU9mZnNldC5zZXRZKG1pbmltdW1TY3JvbGxQ b3NpdGlvbigpLnkoKSk7CisgICAgfQogICAgIAogICAgIHJldHVybiBtYXhpbXVtT2Zmc2V0Owog fQo= 206185 2013-07-05 21:50:17 -0700 2013-07-05 21:53:32 -0700 patch fix-crash.diff text/plain 2822 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5OTQ0NDdjLi41ODI2MmRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIg QEAKIDIwMTMtMDctMDUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK KyAgICAgICAgVG9ucyBvZiBjcmFzaGVzIG9uIGJvdHMgYWZ0ZXIgcjE1MjQyNQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NDQwCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8xNDM2Njc3Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBOdWxsLWNoZWNrIHRoZSBmcmFtZSdzIHBhZ2Ugc28gd2UgZG9uJ3Qg Y3Jhc2guIEl0J3MgT0sgdG8gbm90CisgICAgICAgIHBpbiBpZiB3ZSBkb24ndCBoYXZlIGEgcGFn ZSBiZWNhdXNlIHdlJ3JlIGJlaW5nIHRvcm4gZG93bi4KKyAgICAgICAgQWxzbyBvbmx5IHRlc3Qg dGhlIFBhZ2UncyBwYWdpbmF0aW9uIG1vZGUgaWYgd2UgaGF2ZSBhIFBhZ2UsIG90aGVyd2lzZQor ICAgICAgICBhc3N1bWUgaXQncyB1bnBhZ2luYXRlZCAodG8gbWFpbnRhaW4gYmVoYXZpb3IpLgor CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVW aWV3OjptaW5pbXVtU2Nyb2xsUG9zaXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3 OjptYXhpbXVtU2Nyb2xsUG9zaXRpb24pOgorCisyMDEzLTA3LTA1ICBUaW0gSG9ydG9uICA8dGlt b3RoeV9ob3J0b25AYXBwbGUuY29tPgorCiAgICAgICAgIEZpeCByMTUyMjY1OiBGcmFtZVZpZXcn cyBwYWdpbmF0aW9uIG1vZGUgaXMgb25seSBvbmUgb2YgdHdvLCBhbmQgdGhlIGxvZ2ljIHdhcyB0 b3RhbGx5IHdyb25nCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTg0MzkKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE0MzY2MTIwPgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9GcmFtZVZpZXcuY3BwCmluZGV4IGMzNjBiZjcuLjg0MzQ0MzcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Zy YW1lVmlldy5jcHAKQEAgLTE2NDIsOSArMTY0MiwxMSBAQCBJbnRTaXplIEZyYW1lVmlldzo6c2Ny b2xsT2Zmc2V0Rm9yRml4ZWRQb3NpdGlvbigpIGNvbnN0CiBJbnRQb2ludCBGcmFtZVZpZXc6Om1p bmltdW1TY3JvbGxQb3NpdGlvbigpIGNvbnN0CiB7CiAgICAgSW50UG9pbnQgbWluaW11bVBvc2l0 aW9uKFNjcm9sbFZpZXc6Om1pbmltdW1TY3JvbGxQb3NpdGlvbigpKTsKLSAgICAKLSAgICBpZiAo bV9mcmFtZSA9PSBtX2ZyYW1lLT5wYWdlKCktPm1haW5GcmFtZSgpICYmIG1fc2Nyb2xsUGlubmlu Z0JlaGF2aW9yID09IFBpblRvQm90dG9tKQotICAgICAgICBtaW5pbXVtUG9zaXRpb24uc2V0WSht YXhpbXVtU2Nyb2xsUG9zaXRpb24oKS55KCkpOworCisgICAgaWYgKFBhZ2UqIHBhZ2UgPSBtX2Zy YW1lLT5wYWdlKCkpIHsKKyAgICAgICAgaWYgKG1fZnJhbWUgPT0gcGFnZS0+bWFpbkZyYW1lKCkg JiYgbV9zY3JvbGxQaW5uaW5nQmVoYXZpb3IgPT0gUGluVG9Cb3R0b20pCisgICAgICAgICAgICBt aW5pbXVtUG9zaXRpb24uc2V0WShtYXhpbXVtU2Nyb2xsUG9zaXRpb24oKS55KCkpOworICAgIH0K ICAgICAKICAgICByZXR1cm4gbWluaW11bVBvc2l0aW9uOwogfQpAQCAtMTY1MywxMiArMTY1NSwx NCBAQCBJbnRQb2ludCBGcmFtZVZpZXc6Om1heGltdW1TY3JvbGxQb3NpdGlvbigpIGNvbnN0CiB7 CiAgICAgSW50UG9pbnQgbWF4aW11bU9mZnNldChjb250ZW50c1dpZHRoKCkgLSB2aXNpYmxlV2lk dGgoKSAtIHNjcm9sbE9yaWdpbigpLngoKSwgdG90YWxDb250ZW50c1NpemUoKS5oZWlnaHQoKSAt IHZpc2libGVIZWlnaHQoKSAtIHNjcm9sbE9yaWdpbigpLnkoKSk7CiAKKyAgICBQYWdlKiBwYWdl ID0gbV9mcmFtZS0+cGFnZSgpOworCiAgICAgLy8gV2l0aCBwYWdpbmF0aW9uIGVuYWJsZWQsIHdl IGNhbiBoYXZlIGEgbmVnYXRpdmUgbWF4aW11bSBzY3JvbGwgcG9zaXRpb24uCi0gICAgaWYgKCht X2ZyYW1lLT5wYWdlKCktPnBhZ2luYXRpb24oKS5tb2RlID09IFBhZ2luYXRpb246OlVucGFnaW5h dGVkICYmIG1fcGFnaW5hdGlvbi5tb2RlID09IFBhZ2luYXRpb246OlVucGFnaW5hdGVkKQorICAg IGlmICgoKCFwYWdlIHx8IHBhZ2UtPnBhZ2luYXRpb24oKS5tb2RlID09IFBhZ2luYXRpb246OlVu cGFnaW5hdGVkKSAmJiBtX3BhZ2luYXRpb24ubW9kZSA9PSBQYWdpbmF0aW9uOjpVbnBhZ2luYXRl ZCkKICAgICAgICAgfHwgc2Nyb2xsT3JpZ2luKCkgPT0gSW50UG9pbnQ6Onplcm8oKSkKICAgICAg ICAgbWF4aW11bU9mZnNldC5jbGFtcE5lZ2F0aXZlVG9aZXJvKCk7Ci0gICAgCi0gICAgaWYgKG1f ZnJhbWUgPT0gbV9mcmFtZS0+cGFnZSgpLT5tYWluRnJhbWUoKSAmJiBtX3Njcm9sbFBpbm5pbmdC ZWhhdmlvciA9PSBQaW5Ub1RvcCkKKworICAgIGlmIChwYWdlICYmIG1fZnJhbWUgPT0gcGFnZS0+ bWFpbkZyYW1lKCkgJiYgbV9zY3JvbGxQaW5uaW5nQmVoYXZpb3IgPT0gUGluVG9Ub3ApCiAgICAg ICAgIG1heGltdW1PZmZzZXQuc2V0WShtaW5pbXVtU2Nyb2xsUG9zaXRpb24oKS55KCkpOwogICAg IAogICAgIHJldHVybiBtYXhpbXVtT2Zmc2V0Owo=