118438 2013-07-05 17:30:19 -0700 Fix the performance regressions introduced by r152418 2013-07-06 23:47:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 118415 1 benjamin benjamin andersca cmarcelo commit-queue oldest_to_newest 906512 0 benjamin 2013-07-05 17:30:19 -0700 Fix the performance regressions introduced by r152418 906515 1 206178 benjamin 2013-07-05 17:36:09 -0700 Created attachment 206178 Patch 906532 2 206178 mikhail.pozdnyakov 2013-07-05 20:45:15 -0700 Comment on attachment 206178 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206178&action=review Looks great, thanks for fixing it. > Source/WTF/wtf/text/StringImpl.h:1093 > +ALWAYS_INLINE bool equal(const UChar* a, const LChar* b, unsigned length) maybe it's worth saving couple of lines of code putting the function body to the same line? 906533 3 benjamin 2013-07-05 20:48:17 -0700 > maybe it's worth saving couple of lines of code putting the function body to the same line? Sure, I'll change that before landing. 906613 4 benjamin 2013-07-06 23:47:34 -0700 Committed r152438: <http://trac.webkit.org/changeset/152438> 206178 2013-07-05 17:36:09 -0700 2013-07-05 21:15:00 -0700 Patch bug-118438-20130705173400.patch text/plain 2405 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNDMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDlmZTYzN2RmZDRhOWI0MTk5ZjM1Yjdk YjAzNGE4Yzk5ODFkZGM0MTcuLjNmYTU5NjJmNzJkYjgyY2EzNTg4NjUzMmExMGVkNjQ3OGExZDY2 NWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDctMDUgIEJlbmphbWluIFBvdWxhaW4gIDxi ZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIEZpeCB0aGUgcGVyZm9ybWFuY2UgcmVncmVz c2lvbnMgaW50cm9kdWNlZCBieSByMTUyNDE4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg0MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHd0Zi90ZXh0L1N0cmluZ0ltcGwuaDoKKyAgICAgICAgKFdU Rjo6ZXF1YWwpOgorICAgICAgICBMb29waW5nIGJldHdlZW4gdHdvIGFyYml0cmFyeSBwb2ludGVy cyBwcmV2ZW50cyBpbXBvcnRhbnQgbG9vcAorICAgICAgICBvcHRpbWl6YXRpb25zLgorCiAyMDEz LTA3LTA1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtX aW5kb3dzXSBVbnJldmlld2VkIGJ1aWxkIGNvcnJlY3Rpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1w bC5oCmluZGV4IDcwNGRiYTI5M2E5OTM2NjY1ZmVmNjk4NGQ0MDYxMGY2YjMwMTk4ZDcuLjkyNGE0 YzVjYjY4MDFkYzBlNjBhOGEzMWNlZGUyNDEyOWJmOTc4MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X VEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5n SW1wbC5oCkBAIC0xMDc3LDEyICsxMDc3LDI0IEBAIEFMV0FZU19JTkxJTkUgYm9vbCBlcXVhbChj b25zdCBVQ2hhciogYSwgY29uc3QgVUNoYXIqIGIsIHVuc2lnbmVkIGxlbmd0aCkKICAgICByZXR1 cm4gaXNFcXVhbDsKIH0KICNlbHNlCi1BTFdBWVNfSU5MSU5FIGJvb2wgZXF1YWwoY29uc3QgTENo YXIqIGEsIGNvbnN0IExDaGFyKiBiLCB1bnNpZ25lZCBsZW5ndGgpIHsgcmV0dXJuIHN0ZDo6ZXF1 YWwoYSwgYSArIGxlbmd0aCwgYik7IH0KLUFMV0FZU19JTkxJTkUgYm9vbCBlcXVhbChjb25zdCBV Q2hhciogYSwgY29uc3QgVUNoYXIqIGIsIHVuc2lnbmVkIGxlbmd0aCkgeyByZXR1cm4gc3RkOjpl cXVhbChhLCBhICsgbGVuZ3RoLCBiKTsgfQorQUxXQVlTX0lOTElORSBib29sIGVxdWFsKGNvbnN0 IExDaGFyKiBhLCBjb25zdCBMQ2hhciogYiwgdW5zaWduZWQgbGVuZ3RoKSB7IHJldHVybiAhbWVt Y21wKGEsIGIsIGxlbmd0aCk7IH0KK0FMV0FZU19JTkxJTkUgYm9vbCBlcXVhbChjb25zdCBVQ2hh ciogYSwgY29uc3QgVUNoYXIqIGIsIHVuc2lnbmVkIGxlbmd0aCkgeyByZXR1cm4gIW1lbWNtcChh LCBiLCBsZW5ndGggKiBzaXplb2YoVUNoYXIpKTsgfQogI2VuZGlmCiAKLUFMV0FZU19JTkxJTkUg Ym9vbCBlcXVhbChjb25zdCBMQ2hhciogYSwgY29uc3QgVUNoYXIqIGIsIHVuc2lnbmVkIGxlbmd0 aCkgeyByZXR1cm4gc3RkOjplcXVhbChhLCBhICsgbGVuZ3RoLCBiKTsgfQotQUxXQVlTX0lOTElO RSBib29sIGVxdWFsKGNvbnN0IFVDaGFyKiBhLCBjb25zdCBMQ2hhciogYiwgdW5zaWduZWQgbGVu Z3RoKSB7IHJldHVybiBzdGQ6OmVxdWFsKGEsIGEgKyBsZW5ndGgsIGIpOyB9CitBTFdBWVNfSU5M SU5FIGJvb2wgZXF1YWwoY29uc3QgTENoYXIqIGEsIGNvbnN0IFVDaGFyKiBiLCB1bnNpZ25lZCBs ZW5ndGgpCit7CisgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGxlbmd0aDsgKytpKSB7Cisg ICAgICAgIGlmIChhW2ldICE9IGJbaV0pCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAg fQorICAgIHJldHVybiB0cnVlOworfQorCitBTFdBWVNfSU5MSU5FIGJvb2wgZXF1YWwoY29uc3Qg VUNoYXIqIGEsIGNvbnN0IExDaGFyKiBiLCB1bnNpZ25lZCBsZW5ndGgpCit7CisgICAgcmV0dXJu IGVxdWFsKGIsIGEsIGxlbmd0aCk7Cit9CisKIFdURl9FWFBPUlRfU1RSSU5HX0FQSSBib29sIGVx dWFsSWdub3JpbmdDYXNlKGNvbnN0IFN0cmluZ0ltcGwqLCBjb25zdCBTdHJpbmdJbXBsKik7CiBX VEZfRVhQT1JUX1NUUklOR19BUEkgYm9vbCBlcXVhbElnbm9yaW5nQ2FzZShjb25zdCBTdHJpbmdJ bXBsKiwgY29uc3QgTENoYXIqKTsKIGlubGluZSBib29sIGVxdWFsSWdub3JpbmdDYXNlKGNvbnN0 IExDaGFyKiBhLCBjb25zdCBTdHJpbmdJbXBsKiBiKSB7IHJldHVybiBlcXVhbElnbm9yaW5nQ2Fz ZShiLCBhKTsgfQo=