118414 2013-07-05 07:21:43 -0700 Stop hardcoding interfaces that have indexed getters returning strings 2013-07-06 00:25:33 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue darin haraken laszlo.gombos rniwa oldest_to_newest 906393 0 cdumez 2013-07-05 07:21:43 -0700 Interfaces that have indexed getters returning strings are currently hardcoded in the JSC bindings generator's IndexGetterReturnsStrings() subroutine. Now that we support the latest Web IDL indexed getter format, the generator can be smarter and detect if the returned type is a DOMString on its own (since it is specified in the Web IDL). 906394 1 206148 cdumez 2013-07-05 07:22:30 -0700 Created attachment 206148 WIP patch 906399 2 206151 cdumez 2013-07-05 07:52:57 -0700 Created attachment 206151 Patch 906510 3 206151 haraken 2013-07-05 17:11:16 -0700 Comment on attachment 206151 Patch ok 906559 4 206151 commit-queue 2013-07-06 00:25:31 -0700 Comment on attachment 206151 Patch Clearing flags on attachment: 206151 Committed r152435: <http://trac.webkit.org/changeset/152435> 906560 5 commit-queue 2013-07-06 00:25:33 -0700 All reviewed patches have been landed. Closing bug. 206148 2013-07-05 07:22:30 -0700 2013-07-05 07:52:57 -0700 WIP patch 118414_WIP.patch text/plain 2305 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv ckpTLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMu cG0KaW5kZXggMTgwMDUzZC4uZjUzZGI3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTE3OCwxNCArMTc4LDYgQEAgc3Vi IEdldENhbGxiYWNrQ2xhc3NOYW1lCiAgICAgcmV0dXJuICJKUyRjbGFzc05hbWUiOwogfQogCi1z dWIgSW5kZXhHZXR0ZXJSZXR1cm5zU3RyaW5ncwotewotICAgIG15ICR0eXBlID0gc2hpZnQ7Ci0K LSAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiQ1NTU3R5bGVEZWNsYXJhdGlvbiIgb3IgJHR5cGUg ZXEgIk1lZGlhTGlzdCIgb3IgJHR5cGUgZXEgIkRPTVN0cmluZ0xpc3QiIG9yICR0eXBlIGVxICJE T01Ub2tlbkxpc3QiIG9yICR0eXBlIGVxICJET01TZXR0YWJsZVRva2VuTGlzdCI7Ci0gICAgcmV0 dXJuIDA7Ci19Ci0KIHN1YiBBZGRJbmNsdWRlc0ZvclR5cGVJbkltcGwKIHsKICAgICBteSAkdHlw ZSA9IHNoaWZ0OwpAQCAtMzkwLDcgKzM4Miw3IEBAIHN1YiBHZW5lcmF0ZUdldE93blByb3BlcnR5 U2xvdEJvZHkKIAogICAgICAgICAjIElmIHRoZSBpdGVtIGZ1bmN0aW9uIHJldHVybnMgYSBzdHJp bmcgdGhlbiB3ZSBsZXQgdGhlIFRyZWF0UmV0dXJuZWROdWxsU3RyaW5nQXMgaGFuZGxlIHRoZSBj YXNlcwogICAgICAgICAjIHdoZXJlIHRoZSBpbmRleCBpcyBvdXQgb2YgcmFuZ2UuCi0gICAgICAg IGlmIChJbmRleEdldHRlclJldHVybnNTdHJpbmdzKCRpbnRlcmZhY2VOYW1lKSkgeworICAgICAg ICBpZiAoJGluZGV4ZWRHZXR0ZXJGdW5jdGlvbi0+c2lnbmF0dXJlLT50eXBlIGVxICJET01TdHJp bmciKSB7CiAgICAgICAgICAgICBwdXNoKEBnZXRPd25Qcm9wZXJ0eVNsb3RJbXBsLCAiICAgIGlm IChpbmRleCAhPSBQcm9wZXJ0eU5hbWU6Ok5vdEFuSW5kZXgpIHtcbiIpOwogICAgICAgICB9IGVs c2UgewogICAgICAgICAgICAgcHVzaChAZ2V0T3duUHJvcGVydHlTbG90SW1wbCwgIiAgICBpZiAo aW5kZXggIT0gUHJvcGVydHlOYW1lOjpOb3RBbkluZGV4ICYmIGluZGV4IDwgc3RhdGljX2Nhc3Q8 JGludGVyZmFjZU5hbWUqPih0aGlzT2JqZWN0LT5pbXBsKCkpLT5sZW5ndGgoKSkge1xuIik7CkBA IC0xOTc5LDcgKzE5NzEsNyBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbgogICAgICAgICAg ICAgfTsKIAogICAgICAgICAgICAgaWYgKCRpbmRleGVkR2V0dGVyRnVuY3Rpb24pIHsKLSAgICAg ICAgICAgICAgICBpZiAoSW5kZXhHZXR0ZXJSZXR1cm5zU3RyaW5ncygkaW50ZXJmYWNlTmFtZSkp IHsKKyAgICAgICAgICAgICAgICBpZiAoJGluZGV4ZWRHZXR0ZXJGdW5jdGlvbi0+c2lnbmF0dXJl LT50eXBlIGVxICJET01TdHJpbmciKSB7CiAgICAgICAgICAgICAgICAgICAgIHB1c2goQGltcGxD b250ZW50LCAiICAgIGlmIChpbmRleCA8PSBNQVhfQVJSQVlfSU5ERVgpIHtcbiIpOwogICAgICAg ICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50 LCAiICAgIGlmIChpbmRleCA8IHN0YXRpY19jYXN0PCRpbnRlcmZhY2VOYW1lKj4odGhpc09iamVj dC0+aW1wbCgpKS0+bGVuZ3RoKCkpIHtcbiIpOwpAQCAtMjY1Nyw3ICsyNjQ5LDcgQEAgc3ViIEdl bmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJ7XG4iKTsK ICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgJHtjbGFzc05hbWV9KiB0aGlzT2JqID0g anNDYXN0PCRjbGFzc05hbWUqPihhc09iamVjdChzbG90QmFzZSkpO1xuIik7CiAgICAgICAgIHB1 c2goQGltcGxDb250ZW50LCAiICAgIEFTU0VSVF9HQ19PQkpFQ1RfSU5IRVJJVFModGhpc09iaiwg JnNfaW5mbyk7XG4iKTsKLSAgICAgICAgaWYgKEluZGV4R2V0dGVyUmV0dXJuc1N0cmluZ3MoJGlu dGVyZmFjZU5hbWUpKSB7CisgICAgICAgIGlmICgkaW5kZXhlZEdldHRlckZ1bmN0aW9uLT5zaWdu YXR1cmUtPnR5cGUgZXEgIkRPTVN0cmluZyIpIHsKICAgICAgICAgICAgICRpbXBsSW5jbHVkZXN7 IktVUkwuaCJ9ID0gMTsKICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIHJldHVy biBqc1N0cmluZ09yVW5kZWZpbmVkKGV4ZWMsIHRoaXNPYmotPmltcGwoKS0+aXRlbShpbmRleCkp O1xuIik7CiAgICAgICAgIH0gZWxzZSB7Cg== 206151 2013-07-05 07:52:57 -0700 2013-07-06 00:25:30 -0700 Patch 118414_indexedGetterString.patch text/plain 3340 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNWU2NmExLi5mNGE4ZjM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTMtMDctMDUgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIFN0b3AgaGFyZGNvZGluZyBpbnRlcmZhY2VzIHRoYXQgaGF2ZSBpbmRl eGVkIGdldHRlcnMgcmV0dXJuaW5nIHN0cmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExODQxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFN0b3AgaGFyZGNvZGluZyB0aGUgbmFtZXMgb2YgaW50ZXJm YWNlcyB0aGF0IGhhdmUgaW5kZXhlZCBnZXR0ZXJzIHJldHVybmluZworICAgICAgICBzdHJpbmdz IGluIHRoZSBiaW5kaW5ncyBnZW5lcmF0b3IuIE5vdyB0aGF0IHdlIHVzZSB0aGUgbGF0ZXN0IFdl YiBJREwgaW5kZXhlZAorICAgICAgICBnZXR0ZXIsIG1vcmUgaW5mb3JtYXRpb24gaXMgcHJvdmlk ZWQgaW4gdGhlIElETCBmaWxlcyBhbmQgdGhlIGdlbmVyYXRvciBpcworICAgICAgICBhYmxlIHRv IGZpZ3VyZSBvdXQgaWYgdGhlIGluZGV4ZWQgZ2V0dGVyIGlzIHJldHVybmluZyBhIERPTVN0cmlu ZyBvbiBpdHMgb3duLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdl LgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAg ICAgIChHZW5lcmF0ZUdldE93blByb3BlcnR5U2xvdEJvZHkpOgorICAgICAgICAoR2VuZXJhdGVJ bXBsZW1lbnRhdGlvbik6CisKIDIwMTMtMDctMDUgIERlbmlzIE5vbWl5YW1hICA8ZC5ub21peWFt YUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbR1RLXSBmYXN0L3RleHQvZm9udC1rZXJuaW5nLmh0 bWwgZmFpbHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9ySlMucG0KaW5kZXggMTgwMDUzZC4uZjUzZGI3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTE3OCwxNCArMTc4 LDYgQEAgc3ViIEdldENhbGxiYWNrQ2xhc3NOYW1lCiAgICAgcmV0dXJuICJKUyRjbGFzc05hbWUi OwogfQogCi1zdWIgSW5kZXhHZXR0ZXJSZXR1cm5zU3RyaW5ncwotewotICAgIG15ICR0eXBlID0g c2hpZnQ7Ci0KLSAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiQ1NTU3R5bGVEZWNsYXJhdGlvbiIg b3IgJHR5cGUgZXEgIk1lZGlhTGlzdCIgb3IgJHR5cGUgZXEgIkRPTVN0cmluZ0xpc3QiIG9yICR0 eXBlIGVxICJET01Ub2tlbkxpc3QiIG9yICR0eXBlIGVxICJET01TZXR0YWJsZVRva2VuTGlzdCI7 Ci0gICAgcmV0dXJuIDA7Ci19Ci0KIHN1YiBBZGRJbmNsdWRlc0ZvclR5cGVJbkltcGwKIHsKICAg ICBteSAkdHlwZSA9IHNoaWZ0OwpAQCAtMzkwLDcgKzM4Miw3IEBAIHN1YiBHZW5lcmF0ZUdldE93 blByb3BlcnR5U2xvdEJvZHkKIAogICAgICAgICAjIElmIHRoZSBpdGVtIGZ1bmN0aW9uIHJldHVy bnMgYSBzdHJpbmcgdGhlbiB3ZSBsZXQgdGhlIFRyZWF0UmV0dXJuZWROdWxsU3RyaW5nQXMgaGFu ZGxlIHRoZSBjYXNlcwogICAgICAgICAjIHdoZXJlIHRoZSBpbmRleCBpcyBvdXQgb2YgcmFuZ2Uu Ci0gICAgICAgIGlmIChJbmRleEdldHRlclJldHVybnNTdHJpbmdzKCRpbnRlcmZhY2VOYW1lKSkg eworICAgICAgICBpZiAoJGluZGV4ZWRHZXR0ZXJGdW5jdGlvbi0+c2lnbmF0dXJlLT50eXBlIGVx ICJET01TdHJpbmciKSB7CiAgICAgICAgICAgICBwdXNoKEBnZXRPd25Qcm9wZXJ0eVNsb3RJbXBs LCAiICAgIGlmIChpbmRleCAhPSBQcm9wZXJ0eU5hbWU6Ok5vdEFuSW5kZXgpIHtcbiIpOwogICAg ICAgICB9IGVsc2UgewogICAgICAgICAgICAgcHVzaChAZ2V0T3duUHJvcGVydHlTbG90SW1wbCwg IiAgICBpZiAoaW5kZXggIT0gUHJvcGVydHlOYW1lOjpOb3RBbkluZGV4ICYmIGluZGV4IDwgc3Rh dGljX2Nhc3Q8JGludGVyZmFjZU5hbWUqPih0aGlzT2JqZWN0LT5pbXBsKCkpLT5sZW5ndGgoKSkg e1xuIik7CkBAIC0xOTc5LDcgKzE5NzEsNyBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbgog ICAgICAgICAgICAgfTsKIAogICAgICAgICAgICAgaWYgKCRpbmRleGVkR2V0dGVyRnVuY3Rpb24p IHsKLSAgICAgICAgICAgICAgICBpZiAoSW5kZXhHZXR0ZXJSZXR1cm5zU3RyaW5ncygkaW50ZXJm YWNlTmFtZSkpIHsKKyAgICAgICAgICAgICAgICBpZiAoJGluZGV4ZWRHZXR0ZXJGdW5jdGlvbi0+ c2lnbmF0dXJlLT50eXBlIGVxICJET01TdHJpbmciKSB7CiAgICAgICAgICAgICAgICAgICAgIHB1 c2goQGltcGxDb250ZW50LCAiICAgIGlmIChpbmRleCA8PSBNQVhfQVJSQVlfSU5ERVgpIHtcbiIp OwogICAgICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICAgICAgIHB1c2goQGlt cGxDb250ZW50LCAiICAgIGlmIChpbmRleCA8IHN0YXRpY19jYXN0PCRpbnRlcmZhY2VOYW1lKj4o dGhpc09iamVjdC0+aW1wbCgpKS0+bGVuZ3RoKCkpIHtcbiIpOwpAQCAtMjY1Nyw3ICsyNjQ5LDcg QEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQs ICJ7XG4iKTsKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgJHtjbGFzc05hbWV9KiB0 aGlzT2JqID0ganNDYXN0PCRjbGFzc05hbWUqPihhc09iamVjdChzbG90QmFzZSkpO1xuIik7CiAg ICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIEFTU0VSVF9HQ19PQkpFQ1RfSU5IRVJJVFMo dGhpc09iaiwgJnNfaW5mbyk7XG4iKTsKLSAgICAgICAgaWYgKEluZGV4R2V0dGVyUmV0dXJuc1N0 cmluZ3MoJGludGVyZmFjZU5hbWUpKSB7CisgICAgICAgIGlmICgkaW5kZXhlZEdldHRlckZ1bmN0 aW9uLT5zaWduYXR1cmUtPnR5cGUgZXEgIkRPTVN0cmluZyIpIHsKICAgICAgICAgICAgICRpbXBs SW5jbHVkZXN7IktVUkwuaCJ9ID0gMTsKICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAi ICAgIHJldHVybiBqc1N0cmluZ09yVW5kZWZpbmVkKGV4ZWMsIHRoaXNPYmotPmltcGwoKS0+aXRl bShpbmRleCkpO1xuIik7CiAgICAgICAgIH0gZWxzZSB7Cg==