118412 2013-07-05 05:55:44 -0700 [GTK] Leak: GFile* leaking in beginDragWithFilesCallback 2013-07-08 02:01:27 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116317 0 brian.holt webkit-unassigned cgarcia commit-queue kling menard mrobinson pnormand oldest_to_newest 906379 0 brian.holt 2013-07-05 05:55:44 -0700 In Tools/DumpRenderTree/gtk/EventSender.cpp: Leaks found using the "--leak" option in the Gtk port: Command: /home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/Programs/DumpRenderTree - Leak_DefinitelyLost 601 (128 direct, 473 indirect) bytes in 4 blocks are definitely lost in loss record 624 of 821 malloc (/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) g_malloc (/WebKitBuild/Dependencies/Source/glib-2.36.0/glib/gmem.c:159) g_slice_alloc (/WebKitBuild/Dependencies/Source/glib-2.36.0/glib/gslice.c:1003) g_slice_alloc0 (/WebKitBuild/Dependencies/Source/glib-2.36.0/glib/gslice.c:1029) g_type_create_instance (/WebKitBuild/Dependencies/Source/glib-2.36.0/gobject/gtype.c:1892) g_object_constructor (/WebKitBuild/Dependencies/Source/glib-2.36.0/gobject/gobject.c:1855) g_object_newv (/WebKitBuild/Dependencies/Source/glib-2.36.0/gobject/gobject.c:1638) g_object_new (/WebKitBuild/Dependencies/Source/glib-2.36.0/gobject/gobject.c:1548) _g_local_file_new (/WebKitBuild/Dependencies/Source/glib-2.36.0/gio/glocalfile.c:295) g_local_file_get_parent (/WebKitBuild/Dependencies/Source/glib-2.36.0/gio/glocalfile.c:474) beginDragWithFilesCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/Programs/DumpRenderTree) JSC::JSCallbackFunction::call(JSC::ExecState*) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0.14.1) JSC::LLInt::handleHostCall(JSC::ExecState*, JSC::Instruction*, JSC::JSValue, JSC::CodeSpecializationKind) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0.14.1) llint_slow_path_call (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0.14.1) 0x51278A4 (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0.14.1) JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::JSObject*) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0.14.1) JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0.14.1) WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld*) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::ScriptElement::executeScript(WebCore::ScriptSourceCode const&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::ScriptElement::prepareScript(WTF::TextPosition const&, WebCore::ScriptElement::LegacyTypeSupport) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::HTMLScriptRunner::runScript(WebCore::Element*, WTF::TextPosition const&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::HTMLScriptRunner::execute(WTF::PassRefPtr<WebCore::Element>, WTF::TextPosition const&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder() (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::HTMLDocumentParser::canTakeNextToken(WebCore::HTMLDocumentParser::SynchronousMode, WebCore::PumpSession&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution() (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::HTMLDocumentParser::notifyFinished(WebCore::CachedResource*) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::CachedResource::checkNotify() (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::SubresourceLoader::didFinishLoading(double) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) Suppression (error hash=#0E4208AA58CD97C8#): For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports { <insert_a_suppression_name_here> Memcheck:Leak fun:malloc fun:g_malloc fun:g_slice_alloc fun:g_slice_alloc0 fun:g_type_create_instance fun:g_object_constructor fun:g_object_newv fun:g_object_new fun:_g_local_file_new fun:g_local_file_get_parent fun:_ZL26beginDragWithFilesCallbackPK15OpaqueJSContextP13OpaqueJSValueS3_mPKPKS2_PS5_ fun:_ZN3JSC18JSCallbackFunction4callEPNS_9ExecStateE fun:_ZN3JSC5LLIntL14handleHostCallEPNS_9ExecStateEPNS_11InstructionENS_7JSValueENS_22CodeSpecializationKindE fun:llint_slow_path_call obj:/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0.14.1 fun:_ZN3JSC11Interpreter7executeEPNS_17ProgramExecutableEPNS_9ExecStateEPNS_8JSObjectE fun:_ZN3JSC8evaluateEPNS_9ExecStateERKNS_10SourceCodeENS_7JSValueEPS5_ fun:_ZN7WebCore16ScriptController15evaluateInWorldERKNS_16ScriptSourceCodeEPNS_15DOMWrapperWorldE fun:_ZN7WebCore16ScriptController8evaluateERKNS_16ScriptSourceCodeE fun:_ZN7WebCore13ScriptElement13executeScriptERKNS_16ScriptSourceCodeE fun:_ZN7WebCore13ScriptElement13prepareScriptERKN3WTF12TextPositionENS0_17LegacyTypeSupportE fun:_ZN7WebCore16HTMLScriptRunner9runScriptEPNS_7ElementERKN3WTF12TextPositionE } 906380 1 206142 brian.holt 2013-07-05 06:01:51 -0700 Created attachment 206142 Patch 906692 2 206142 brian.holt 2013-07-08 01:31:39 -0700 Comment on attachment 206142 Patch mrobinson: Would you mind setting cq+? 906702 3 206142 commit-queue 2013-07-08 02:01:23 -0700 Comment on attachment 206142 Patch Clearing flags on attachment: 206142 Committed r152444: <http://trac.webkit.org/changeset/152444> 906703 4 commit-queue 2013-07-08 02:01:27 -0700 All reviewed patches have been landed. Closing bug. 206142 2013-07-05 06:01:51 -0700 2013-07-08 02:01:23 -0700 Patch bug-118412-20130705135953.patch text/plain 1593 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNDE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjE1YjQ5M2ZmMzQ2NGE0NGM5ZmNlOTE3ZDQwNmM4MWVj Y2NiMWI2MC4uMDhkYWU2ZjgzNTU4NmQ2Nzg2Mjc0YWIwOTE5OTVkOGU3YzQyOTA4OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTA3LTA1ICBCcmlhbiBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbR1RLXSBMZWFrOiBHRmlsZSogbGVha2luZyBpbiBiZWdpbkRyYWdXaXRoRmlsZXND YWxsYmFjaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE4NDEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QW4gYWRvcHRSZWYgaXMgcmVxdWlyZWQgdG8gYmFsYW5jZSByZWYgYW5kIGRlcmVmIGNhbGxzLgor CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcDoKKyAgICAgICAg KGJlZ2luRHJhZ1dpdGhGaWxlc0NhbGxiYWNrKToKKwogMjAxMy0wNy0wNSAgWGFiaWVyIFJvZHJp Z3VleiBDYWx2YXIgIDxjYWx2YXJpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFdlYktp dDIgdGVzdCBUZXN0V2ViS2l0RmF2aWNvbkRhdGFiYXNlIHRpbWVzIG91dCB3aXRoIHJlY2VudCBn bGliCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3Bw IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcAppbmRleCBkY2EyYzBi MWFmYWY5MjQxNTA2NTdjOGY2ZTQxMDRhZTU4MTE2YmQ1Li42YjRmNzZkNTAzNjNkYTQ5MzkwNDk2 ZWY1YzJmNmExYmFjMzBiMDljIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsv RXZlbnRTZW5kZXIuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRl ci5jcHAKQEAgLTU0MSw3ICs1NDEsNyBAQCBzdGF0aWMgSlNWYWx1ZVJlZiBiZWdpbkRyYWdXaXRo RmlsZXNDYWxsYmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNPYmplY3RSZWYgZgogICAgIEdP d25QdHI8Z2NoYXI+IHNjaGVtZShnX2ZpbGVfZ2V0X3VyaV9zY2hlbWUocGFyZW50RGlyZWN0b3J5 LmdldCgpKSk7CiAgICAgaWYgKGdfc3RyX2VxdWFsKHNjaGVtZS5nZXQoKSwgImh0dHAiKSB8fCBn X3N0cl9lcXVhbChzY2hlbWUuZ2V0KCksICJodHRwcyIpKSB7CiAgICAgICAgIEdPd25QdHI8Z2No YXI+IGN1cnJlbnREaXJlY3RvcnkoZ19nZXRfY3VycmVudF9kaXIoKSk7Ci0gICAgICAgIHBhcmVu dERpcmVjdG9yeSA9IGdfZmlsZV9uZXdfZm9yX3BhdGgoY3VycmVudERpcmVjdG9yeS5nZXQoKSk7 CisgICAgICAgIHBhcmVudERpcmVjdG9yeSA9IGFkb3B0R1JlZihnX2ZpbGVfbmV3X2Zvcl9wYXRo KGN1cnJlbnREaXJlY3RvcnkuZ2V0KCkpKTsKICAgICB9CiAKICAgICBKU1N0cmluZ1JlZiBsZW5n dGhQcm9wZXJ0eSA9IEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJsZW5ndGgiKTsK