118404 2013-07-04 19:58:52 -0700 TestWebKitFaviconDatabase/clear-database is not testing things properly 2013-07-05 01:42:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 calvaris calvaris cgarcia commit-queue gustavo mrobinson oldest_to_newest 906292 0 calvaris 2013-07-04 19:58:52 -0700 TestWebKitFaviconDatabase/clean-database is not testing things properly 906293 1 206121 calvaris 2013-07-04 20:01:20 -0700 Created attachment 206121 Patch FiTest checks now for an existing icon and if clean database fails, it should exist and the test should fail. This was not happening so far. 906294 2 commit-queue 2013-07-04 20:03:28 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 906298 3 206121 cgarcia 2013-07-04 22:46:58 -0700 Comment on attachment 206121 Patch Good catch, thanks! :-) 906331 4 206121 commit-queue 2013-07-05 01:42:20 -0700 Comment on attachment 206121 Patch Clearing flags on attachment: 206121 Committed r152410: <http://trac.webkit.org/changeset/152410> 906332 5 commit-queue 2013-07-05 01:42:22 -0700 All reviewed patches have been landed. Closing bug. 206121 2013-07-04 20:01:20 -0700 2013-07-05 01:42:20 -0700 Patch bug-118404-20130705045912.patch text/plain 1741 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTkwOTVjZjEzMDExNDE3 ODNjNWE2MDE3OGFkNGI4MjA0Yjc5NjA4OC4uNGI5MWI4ZmZhYjM4ODdiNzYxNzMxMTY1OWFlM2Y0 ZmZjYzkzNDc0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA3LTA0ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgVGVz dFdlYktpdEZhdmljb25EYXRhYmFzZS9jbGVhci1kYXRhYmFzZSBpcyBub3QgdGVzdGluZyB0aGlu Z3MgcHJvcGVybHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExODQwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFdlYktpdEZhdmljb25EYXRhYmFzZS5j cHA6CisgICAgICAgICh0ZXN0Q2xlYXJEYXRhYmFzZSk6IENoZWNrIGZvciBhbiBleGlzdGluZyBp Y29uIHRoYXQgY2FuIG1ha2UgdGhlCisgICAgICAgIHRlc3QgZmFpbCBpZiBjbGVhciBkYXRhYmFz ZSBpcyBub3Qgd29ya2luZy4KKwogMjAxMy0wNy0wMyAgR29yZG9uIFNoZXJpZGFuICA8Z29yZG9u X3NoZXJpZGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgbWVjaGFuaXNtIHRvIGRl dGVjdCAocGFydGlhbGx5KSBoaWRkZW4gYmxvY2tlZCBwbHVnaW5zLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFdlYktpdEZhdmljb25EYXRh YmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0V2Vi S2l0RmF2aWNvbkRhdGFiYXNlLmNwcAppbmRleCBkNWYzMDc2OGM4MzhhNDNhYmU0ZjU2MjY3MTFh ZmRkY2Q5OTcyYzE5Li42Nzk3Y2I4MjY2MTlhYjI4NWJkYjllMTRhMDEzMTc3ZmI0ODNhNzZlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0V2Vi S2l0RmF2aWNvbkRhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay90ZXN0cy9UZXN0V2ViS2l0RmF2aWNvbkRhdGFiYXNlLmNwcApAQCAtMTUzLDcgKzE1Myw3 IEBAIHN0YXRpYyB2b2lkIHRlc3RDbGVhckRhdGFiYXNlKEZhdmljb25EYXRhYmFzZVRlc3QqIHRl c3QsIGdjb25zdHBvaW50ZXIpCiAgICAgV2ViS2l0RmF2aWNvbkRhdGFiYXNlKiBkYXRhYmFzZSA9 IHdlYmtpdF93ZWJfY29udGV4dF9nZXRfZmF2aWNvbl9kYXRhYmFzZSh0ZXN0LT5tX3dlYkNvbnRl eHQpOwogICAgIHdlYmtpdF9mYXZpY29uX2RhdGFiYXNlX2NsZWFyKGRhdGFiYXNlKTsKIAotICAg IEdPd25QdHI8Y2hhcj4gaWNvblVSSSh3ZWJraXRfZmF2aWNvbl9kYXRhYmFzZV9nZXRfZmF2aWNv bl91cmkoZGF0YWJhc2UsIGtTZXJ2ZXItPmdldFVSSUZvclBhdGgoIi8iKS5kYXRhKCkpKTsKKyAg ICBHT3duUHRyPGNoYXI+IGljb25VUkkod2Via2l0X2Zhdmljb25fZGF0YWJhc2VfZ2V0X2Zhdmlj b25fdXJpKGRhdGFiYXNlLCBrU2VydmVyLT5nZXRVUklGb3JQYXRoKCIvZm9vIikuZGF0YSgpKSk7 CiAgICAgZ19hc3NlcnQoIWljb25VUkkpOwogfQogCg==