118401 2013-07-04 12:12:30 -0700 fourthTier: FTL should better report its compile-times and it should be able to run in a mode where it doesn't spend time generating OSR exits 2013-07-08 09:55:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 118400 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 906240 0 fpizlo 2013-07-04 12:12:30 -0700 My current suspicion is that most of the time is spent in OSR exit computation. We know we can do better there, so it would be useful to be able to confirm this hypothesis on a variety of benchmarks. 906241 1 206109 fpizlo 2013-07-04 12:13:46 -0700 Created attachment 206109 the patch 906518 2 fpizlo 2013-07-05 18:10:56 -0700 Landed in http://trac.webkit.org/changeset/152432 906829 3 ggaren 2013-07-08 09:24:16 -0700 > My current suspicion is that most of the time is spent in OSR exit computation. Did this turn out to be true? 906849 4 fpizlo 2013-07-08 09:55:38 -0700 (In reply to comment #3) > > My current suspicion is that most of the time is spent in OSR exit computation. > > Did this turn out to be true? Currently LLVM compile times reduce by 30% if it doesn't have to deal with OSR exit marshaling. So, no, it's not "most" of the time, right now. But if you consider that we're also spending some significant fraction of time setting up pass managers, contexts, modules, execution engines, etc., I suspect that it'll be more than 30% if those other issues are fixed. 206109 2013-07-04 12:13:46 -0700 2013-07-05 13:17:02 -0700 the patch blah.patch text/plain 7705 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUyNDA0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBA CisyMDEzLTA3LTA0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Zm91cnRoVGllcjogRlRMIHNob3VsZCBiZXR0ZXIgcmVwb3J0IGl0cyBjb21waWxlLXRpbWVzIGFu ZCBpdCBzaG91bGQgYmUgYWJsZSB0byBydW4gaW4gYSBtb2RlIHdoZXJlIGl0IGRvZXNuJ3Qgc3Bl bmQgdGltZSBnZW5lcmF0aW5nIE9TUiBleGl0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4NDAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisgICAgICAgIAorICAgICAgICBBZGQgdHdvIG5ldyBPU1IgZXhpdCBtb2Rlcywg d2hpY2ggYXJlIHVzZWZ1bCBvbmx5IGZvciBwbGF5aW5nIHdpdGggY29tcGlsZSB0aW1lczoKKyAg ICAgICAgCisgICAgICAgIC0gQWxsIE9TUiBleGl0cyBhcmUgbGx2bS50cmFwKCkuCisgICAgICAg IAorICAgICAgICAtIE9TUiBleGl0cyBkb24ndCB0YWtlIGFyZ3VtZW50cyBhbmQgaGF2ZSBubyBl eGl0IHZhbHVlIG1hcnNoYWxpbmcuCisKKyAgICAgICAgKiBkZmcvREZHUGxhbi5jcHA6CisgICAg ICAgIChKU0M6OkRGRzo6UGxhbjo6Y29tcGlsZUluVGhyZWFkKToKKyAgICAgICAgKEpTQzo6REZH OjpQbGFuOjpjb21waWxlSW5UaHJlYWRJbXBsKToKKyAgICAgICAgKiBkZmcvREZHUGxhbi5oOgor ICAgICAgICAoUGxhbik6CisgICAgICAgICogZnRsL0ZUTEludHJpbnNpY1JlcG9zaXRvcnkuaDoK KyAgICAgICAgKEZUTCk6CisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcDoKKyAg ICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExWTTo6YXBwZW5kT1NSRXhpdCk6CisgICAgICAg IChMb3dlckRGR1RvTExWTSk6CisgICAgICAgIChKU0M6OkZUTDo6TG93ZXJERkdUb0xMVk06OmVt aXRPU1JFeGl0Q2FsbCk6CisgICAgICAgICogZnRsL0ZUTE91dHB1dC5oOgorICAgICAgICAoSlND OjpGVEw6Ok91dHB1dDo6dHJhcCk6CisgICAgICAgICogcnVudGltZS9PcHRpb25zLmg6CisgICAg ICAgIChKU0MpOgorCiAyMDEzLTA3LTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+ CiAKICAgICAgICAgZm91cnRoVGllcjogREZHOjpOb2RlOjptX29wSW5mbzIgc2hvdWxkIGFsc28g YmUgYSB1aW50cHRyX3QKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUGxhbi5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQbGFuLmNwcAko cmV2aXNpb24gMTUyNDAxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQbGFuLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTE2LDcgKzExNiwxMSBAQCB2b2lkIFBsYW46OmNvbXBpbGVJ blRocmVhZChMb25nTGl2ZWRTdGF0CiAgICAgICAgICAgICBwYXRoTmFtZSA9ICJGVEwiOwogICAg ICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KLSAgICAgICAgZGF0YUxvZygiT3B0aW1pemVkICIs ICpjb2RlQmxvY2stPmFsdGVybmF0aXZlKCksICIgd2l0aCAiLCBwYXRoTmFtZSwgIiBpbiAiLCBj dXJyZW50VGltZU1TKCkgLSBiZWZvcmUsICIgbXMuXG4iKTsKKyAgICAgICAgZG91YmxlIG5vdyA9 IGN1cnJlbnRUaW1lTVMoKTsKKyAgICAgICAgZGF0YUxvZygiT3B0aW1pemVkICIsICpjb2RlQmxv Y2stPmFsdGVybmF0aXZlKCksICIgd2l0aCAiLCBwYXRoTmFtZSwgIiBpbiAiLCBub3cgLSBiZWZv cmUsICIgbXMiKTsKKyAgICAgICAgaWYgKHBhdGggPT0gRlRMUGF0aCkKKyAgICAgICAgICAgIGRh dGFMb2coIiAoREZHOiAiLCBiZWZvcmVGVEwgLSBiZWZvcmUsICIsIExMVk06ICIsIG5vdyAtIGJl Zm9yZUZUTCwgIikiKTsKKyAgICAgICAgZGF0YUxvZygiLlxuIik7CiAgICAgfQogfQogCkBAIC0x OTMsNiArMTk3LDEwIEBAIFBsYW46OkNvbXBpbGF0aW9uUGF0aCBQbGFuOjpjb21waWxlSW5UaHIK ICAgICAgICAgCiAgICAgICAgIEZUTDo6U3RhdGUgc3RhdGUoZGZnKTsKICAgICAgICAgRlRMOjps b3dlckRGR1RvTExWTShzdGF0ZSk7CisgICAgICAgIAorICAgICAgICBpZiAoT3B0aW9uczo6cmVw b3J0Q29tcGlsZVRpbWVzKCkpCisgICAgICAgICAgICBiZWZvcmVGVEwgPSBjdXJyZW50VGltZU1T KCk7CisgICAgICAgIAogICAgICAgICBGVEw6OmNvbXBpbGUoc3RhdGUpOwogICAgICAgICBGVEw6 Omxpbmsoc3RhdGUpOwogICAgICAgICByZXR1cm4gRlRMUGF0aDsKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHUGxhbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHUGxhbi5oCShyZXZpc2lvbiAxNTI0MDEpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR1BsYW4uaAkod29ya2luZyBjb3B5KQpAQCAtNzYsNiArNzYsOCBAQCBzdHJ1 Y3QgUGxhbiA6IHB1YmxpYyBUaHJlYWRTYWZlUmVmQ291bnRlCiAgICAgRGVzaXJlZElkZW50aWZp ZXJzIGlkZW50aWZpZXJzOwogICAgIERlc2lyZWRTdHJ1Y3R1cmVDaGFpbnMgY2hhaW5zOwogICAg IAorICAgIGRvdWJsZSBiZWZvcmVGVEw7CisgICAgCiAgICAgYm9vbCBpc0NvbXBpbGVkOwogCiBw cml2YXRlOgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExJbnRyaW5zaWNSZXBv c2l0b3J5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExJbnRy aW5zaWNSZXBvc2l0b3J5LmgJKHJldmlzaW9uIDE1MjQwMSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9mdGwvRlRMSW50cmluc2ljUmVwb3NpdG9yeS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOCw5 ICszOCwxMCBAQCBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIEZUTCB7CiAKICNkZWZpbmUgRk9S X0VBQ0hfRlRMX0lOVFJJTlNJQyhtYWNybykgXAogICAgIG1hY3JvKGFkZFdpdGhPdmVyZmxvdzMy LCAibGx2bS5zYWRkLndpdGgub3ZlcmZsb3cuaTMyIiwgZnVuY3Rpb25UeXBlKHN0cnVjdFR5cGUo bV9jb250ZXh0LCBpbnQzMiwgYm9vbGVhbiksIGludDMyLCBpbnQzMikpIFwKLSAgICBtYWNybyhz dWJXaXRoT3ZlcmZsb3czMiwgImxsdm0uc3N1Yi53aXRoLm92ZXJmbG93LmkzMiIsIGZ1bmN0aW9u VHlwZShzdHJ1Y3RUeXBlKG1fY29udGV4dCwgaW50MzIsIGJvb2xlYW4pLCBpbnQzMiwgaW50MzIp KSBcCisgICAgbWFjcm8oZG91YmxlQWJzLCAibGx2bS5mYWJzLmY2NCIsIGZ1bmN0aW9uVHlwZShk b3VibGVUeXBlLCBkb3VibGVUeXBlKSkgXAogICAgIG1hY3JvKG11bFdpdGhPdmVyZmxvdzMyLCAi bGx2bS5zbXVsLndpdGgub3ZlcmZsb3cuaTMyIiwgZnVuY3Rpb25UeXBlKHN0cnVjdFR5cGUobV9j b250ZXh0LCBpbnQzMiwgYm9vbGVhbiksIGludDMyLCBpbnQzMikpIFwKLSAgICBtYWNybyhkb3Vi bGVBYnMsICJsbHZtLmZhYnMuZjY0IiwgZnVuY3Rpb25UeXBlKGRvdWJsZVR5cGUsIGRvdWJsZVR5 cGUpKQorICAgIG1hY3JvKHN1YldpdGhPdmVyZmxvdzMyLCAibGx2bS5zc3ViLndpdGgub3ZlcmZs b3cuaTMyIiwgZnVuY3Rpb25UeXBlKHN0cnVjdFR5cGUobV9jb250ZXh0LCBpbnQzMiwgYm9vbGVh biksIGludDMyLCBpbnQzMikpIFwKKyAgICBtYWNybyh0cmFwLCAibGx2bS50cmFwIiwgZnVuY3Rp b25UeXBlKHZvaWRUeXBlKSkKIAogI2RlZmluZSBGT1JfRUFDSF9GVU5DVElPTl9UWVBFKG1hY3Jv KSBcCiAgICAgbWFjcm8oSV9ERkdPcGVyYXRpb25fRUpzcywgZnVuY3Rpb25UeXBlKGludFB0ciwg aW50UHRyLCBpbnRQdHIpKSBcCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExv d2VyREZHVG9MTFZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRs L0ZUTExvd2VyREZHVG9MTFZNLmNwcAkocmV2aXNpb24gMTUyNDAxKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1 MjYsNiArMjUyNiwyMCBAQCBwcml2YXRlOgogICAgICAgICBFeGl0S2luZCBraW5kLCBGb3JtYXR0 ZWRWYWx1ZSBsb3dWYWx1ZSwgTm9kZSogaGlnaFZhbHVlLCBMVmFsdWUgZmFpbENvbmRpdGlvbiwK ICAgICAgICAgU3BlY3VsYXRpb25EaXJlY3Rpb24gZGlyZWN0aW9uLCBGb3JtYXR0ZWRWYWx1ZSBy ZWNvdmVyeSkKICAgICB7CisgICAgICAgIGlmIChPcHRpb25zOjpmdGxUcmFwc09uT1NSRXhpdCgp KSB7CisgICAgICAgICAgICBMQmFzaWNCbG9jayBmYWlsQ2FzZSA9IEZUTF9ORVdfQkxPQ0sobV9v dXQsICgiT1NSIGV4aXQgZmFpbENhc2UiKSk7CisgICAgICAgICAgICBMQmFzaWNCbG9jayBjb250 aW51YXRpb24gPSBGVExfTkVXX0JMT0NLKG1fb3V0LCAoIk9TUiBleGl0IGNvbnRpbnVhdGlvbiIp KTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgbV9vdXQuYnJhbmNoKGZhaWxDb25kaXRpb24s IGZhaWxDYXNlLCBjb250aW51YXRpb24pOworICAgICAgICAgICAgCisgICAgICAgICAgICBMQmFz aWNCbG9jayBsYXN0TmV4dCA9IG1fb3V0LmFwcGVuZFRvKGZhaWxDYXNlLCBjb250aW51YXRpb24p OworICAgICAgICAgICAgbV9vdXQudHJhcCgpOworICAgICAgICAgICAgbV9vdXQudW5yZWFjaGFi bGUoKTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgbV9vdXQuYXBwZW5kVG8oY29udGludWF0 aW9uLCBsYXN0TmV4dCk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAgICAgICAg CiAgICAgICAgIGlmICh2ZXJib3NlQ29tcGlsYXRpb25FbmFibGVkKCkpCiAgICAgICAgICAgICBk YXRhTG9nKCIgICAgT1NSIGV4aXQgd2l0aCB2YWx1ZSBzb3VyY2VzOiAiLCBtX3ZhbHVlU291cmNl cywgIlxuIik7CiAgICAgICAgIApAQCAtMjU1MSw3ICsyNTY1LDI1IEBAIHByaXZhdGU6CiAgICAg ICAgIGluZm8ubV90aHVua0FkZHJlc3MgPSBidWlsZEFsbG9jYShtX291dC5tX2J1aWxkZXIsIG1f b3V0LmludFB0cik7CiAgICAgICAgIAogICAgICAgICBMQmFzaWNCbG9jayBsYXN0TmV4dCA9IG1f b3V0LmFwcGVuZFRvKGZhaWxDYXNlLCBjb250aW51YXRpb24pOworCisgICAgICAgIGlmIChPcHRp b25zOjpmdGxPU1JFeGl0T21pdHNNYXJzaGFsbGluZygpKSB7CisgICAgICAgICAgICBtX291dC5j YWxsKAorICAgICAgICAgICAgICAgIG1fb3V0LmludFRvUHRyKAorICAgICAgICAgICAgICAgICAg ICBtX291dC5nZXQoaW5mby5tX3RodW5rQWRkcmVzcyksCisgICAgICAgICAgICAgICAgICAgIHBv aW50ZXJUeXBlKGZ1bmN0aW9uVHlwZShtX291dC52b2lkVHlwZSkpKSk7CisgICAgICAgIH0gZWxz ZQorICAgICAgICAgICAgZW1pdE9TUkV4aXRDYWxsKGV4aXQsIGluZm8sIGxvd1ZhbHVlLCBkaXJl Y3Rpb24sIHJlY292ZXJ5KTsKKyAgICAgICAgbV9vdXQudW5yZWFjaGFibGUoKTsKKyAgICAgICAg CisgICAgICAgIG1fb3V0LmFwcGVuZFRvKGNvbnRpbnVhdGlvbiwgbGFzdE5leHQpOwogICAgICAg ICAKKyAgICAgICAgbV9leGl0VGh1bmtHZW5lcmF0b3IuZW1pdFRodW5rKGluZGV4KTsKKyAgICB9 CisgICAgCisgICAgdm9pZCBlbWl0T1NSRXhpdENhbGwoCisgICAgICAgIE9TUkV4aXQmIGV4aXQs IE9TUkV4aXRDb21waWxhdGlvbkluZm8mIGluZm8sIEZvcm1hdHRlZFZhbHVlIGxvd1ZhbHVlLAor ICAgICAgICBTcGVjdWxhdGlvbkRpcmVjdGlvbiBkaXJlY3Rpb24sIEZvcm1hdHRlZFZhbHVlIHJl Y292ZXJ5KQorICAgIHsKICAgICAgICAgRXhpdEFyZ3VtZW50TGlzdCBhcmd1bWVudHM7CiAgICAg ICAgIGFyZ3VtZW50cy5hcHBlbmQobV9jYWxsRnJhbWUpOwogICAgICAgICBpZiAoISFsb3dWYWx1 ZSkKQEAgLTI2MjIsMTEgKzI2NTQsNiBAQCBwcml2YXRlOgogICAgICAgICAgICAgICAgIG1fb3V0 LmdldChpbmZvLm1fdGh1bmtBZGRyZXNzKSwKICAgICAgICAgICAgICAgICBwb2ludGVyVHlwZShm dW5jdGlvblR5cGUobV9vdXQudm9pZFR5cGUsIGFyZ3VtZW50VHlwZXMpKSksCiAgICAgICAgICAg ICBhcmd1bWVudHMpOwotICAgICAgICBtX291dC51bnJlYWNoYWJsZSgpOwotICAgICAgICAKLSAg ICAgICAgbV9vdXQuYXBwZW5kVG8oY29udGludWF0aW9uLCBsYXN0TmV4dCk7Ci0gICAgICAgIAot ICAgICAgICBtX2V4aXRUaHVua0dlbmVyYXRvci5lbWl0VGh1bmsoaW5kZXgpOwogICAgIH0KICAg ICAKICAgICB2b2lkIGFkZEV4aXRBcmd1bWVudEZvck5vZGUoCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZnRsL0ZUTE91dHB1dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9mdGwvRlRMT3V0cHV0LmgJKHJldmlzaW9uIDE1MjQwMSkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9mdGwvRlRMT3V0cHV0LmgJKHdvcmtpbmcgY29weSkKQEAgLTM0Nyw2ICszNDcsMTAg QEAgcHVibGljOgogICAgIAogICAgIHZvaWQgdW5yZWFjaGFibGUoKSB7IGJ1aWxkVW5yZWFjaGFi bGUobV9idWlsZGVyKTsgfQogICAgIAorICAgIHZvaWQgdHJhcCgpCisgICAgeworICAgICAgICBj YWxsKHRyYXBJbnRyaW5zaWMoKSk7CisgICAgfQogICAgIHZvaWQgY3Jhc2goKQogICAgIHsKICAg ICAgICAgY2FsbChpbnRUb1B0cihjb25zdEludFB0cihhYm9ydCksIHBvaW50ZXJUeXBlKGZ1bmN0 aW9uVHlwZSh2b2lkVHlwZSkpKSk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9PcHRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv T3B0aW9ucy5oCShyZXZpc2lvbiAxNTI0MDEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9PcHRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTkyLDYgKzkyLDggQEAgbmFtZXNwYWNl IEpTQyB7CiAgICAgdihib29sLCB1c2VGVExUQkFBLCB0cnVlKSBcCiAgICAgdihib29sLCBlbmFi bGVMTFZNRmFzdElTZWwsIGZhbHNlKSBcCiAgICAgdihib29sLCB1c2VMTFZNU21hbGxDb2RlTW9k ZWwsIGZhbHNlKSBcCisgICAgdihib29sLCBmdGxUcmFwc09uT1NSRXhpdCwgZmFsc2UpIFwKKyAg ICB2KGJvb2wsIGZ0bE9TUkV4aXRPbWl0c01hcnNoYWxsaW5nLCBmYWxzZSkgXAogICAgIHYodW5z aWduZWQsIGxsdm1CYWNrZW5kT3B0aW1pemF0aW9uTGV2ZWwsIDIpIFwKICAgICB2KHVuc2lnbmVk LCBsbHZtT3B0aW1pemF0aW9uTGV2ZWwsIDIpIFwKICAgICB2KHVuc2lnbmVkLCBsbHZtU2l6ZUxl dmVsLCAwKSBcCg==