118399 2013-07-04 11:53:40 -0700 Add a method to get unreachable URL from WebFrame. 2013-07-04 12:54:07 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.8 RESOLVED FIXED P2 Normal --- 1 yongjun_zhang webkit-unassigned commit-queue ddkilzer mitz yongjun_zhang oldest_to_newest 906234 0 yongjun_zhang 2013-07-04 11:53:40 -0700 Normally we could use [[WebFrame dataSource] unreachableURL] to get the failed URL. However, if the frame has not loaded (FrameLoader::frameHasLoaded() is false), we will get a nil dataSource and we won't be able to get unreachableURL. We need to add a method to always return the unreachableURL regardless if the frame has loaded or not. 906236 1 206107 yongjun_zhang 2013-07-04 12:00:27 -0700 Created attachment 206107 add a method to expose unreachableURL for WebFrame. 906246 2 yongjun_zhang 2013-07-04 12:17:58 -0700 thanks mitz! 906249 3 206107 commit-queue 2013-07-04 12:54:05 -0700 Comment on attachment 206107 add a method to expose unreachableURL for WebFrame. Clearing flags on attachment: 206107 Committed r152405: <http://trac.webkit.org/changeset/152405> 906250 4 commit-queue 2013-07-04 12:54:07 -0700 All reviewed patches have been landed. Closing bug. 206107 2013-07-04 12:00:27 -0700 2013-07-04 12:54:05 -0700 add a method to expose unreachableURL for WebFrame. oss_unreachable.patch text/plain 2088 yongjun_zhang SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjQwNCkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA3LTA0 ICBZb25nanVuIFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQWRk IGEgbWV0aG9kIHRvIGdldCB1bnJlYWNoYWJsZSBVUkwgZnJvbSBXZWJGcmFtZS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODM5OQorCisgICAgICAg IE5vcm1hbGx5IHdlIGNvdWxkIHVzZSBbW1dlYkZyYW1lIGRhdGFTb3VyY2VdIHVucmVhY2hhYmxl VVJMXSB0byBnZXQgdGhlIGZhaWxlZCBVUkwuICBIb3dldmVyLCBpZiB0aGUgZnJhbWUgaGFzIG5v dAorICAgICAgICBsb2FkZWQgKEZyYW1lTG9hZGVyOjpmcmFtZUhhc0xvYWRlZCgpIGlzIGZhbHNl KSwgd2Ugd2lsbCBnZXQgYSBuaWwgZGF0YVNvdXJjZSBhbmQgd2Ugd29uJ3QgYmUgYWJsZSB0byBn ZXQgdW5yZWFjaGFibGVVUkwuCisgICAgICAgIFdlIGNhbiBhZGQgYSBtZXRob2QgdG8gYWx3YXlz IHJldHVybiB0aGUgdW5yZWFjaGFibGVVUkwgcmVnYXJkbGVzcyBpZiB0aGUgZnJhbWUgaGFzIGxv YWRlZCBvciBub3QuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBXZWJWaWV3L1dlYkZyYW1lLm1tOgorICAgICAgICAoLVtXZWJGcmFtZSBfdW5yZWFj aGFibGVVUkxdKToKKyAgICAgICAgKiBXZWJWaWV3L1dlYkZyYW1lUHJpdmF0ZS5oOgorCiAyMDEz LTA3LTAzICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgSCZSIEJs b2NrIDIwMTAgSGVscCB3aW5kb3cgY2FuIG5vdCBiZSByZW9wZW5lZC4KSW5kZXg6IFNvdXJjZS9X ZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnJhbWUubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9tYWMvV2ViVmlldy9XZWJGcmFtZS5tbQkocmV2aXNpb24gMTUyNDAzKQorKysgU291cmNlL1dl YktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZS5tbQkod29ya2luZyBjb3B5KQpAQCAtMTI0MSw2ICsx MjQxLDExIEBAIC0gKE5TRGljdGlvbmFyeSAqKWVsZW1lbnRBdFBvaW50OihOU1BvaW4KICAgICBy ZXR1cm4gW1tbV2ViRWxlbWVudERpY3Rpb25hcnkgYWxsb2NdIGluaXRXaXRoSGl0VGVzdFJlc3Vs dDpjb3JlRnJhbWUtPmV2ZW50SGFuZGxlcigpLT5oaXRUZXN0UmVzdWx0QXRQb2ludChJbnRQb2lu dChwb2ludCksIEhpdFRlc3RSZXF1ZXN0OjpSZWFkT25seSB8IEhpdFRlc3RSZXF1ZXN0OjpBY3Rp dmUgfCBIaXRUZXN0UmVxdWVzdDo6SWdub3JlQ2xpcHBpbmcgfCBIaXRUZXN0UmVxdWVzdDo6RGlz YWxsb3dTaGFkb3dDb250ZW50KV0gYXV0b3JlbGVhc2VdOwogfQogCistIChOU1VSTCAqKV91bnJl YWNoYWJsZVVSTAoreworICAgIHJldHVybiBbW3NlbGYgX2RhdGFTb3VyY2VdIHVucmVhY2hhYmxl VVJMXTsKK30KKwogQGVuZAogCiBAaW1wbGVtZW50YXRpb24gV2ViRnJhbWUKSW5kZXg6IFNvdXJj ZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnJhbWVQcml2YXRlLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZVByaXZhdGUuaAkocmV2aXNpb24gMTUyNDAz KQorKysgU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZVByaXZhdGUuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTM3LDQgKzEzNyw1IEBAIEBpbnRlcmZhY2UgV2ViRnJhbWUgKFdlYlByaXZh dGUpCiAKIC0gKE5TRGljdGlvbmFyeSAqKWVsZW1lbnRBdFBvaW50OihOU1BvaW50KXBvaW50Owog CistIChOU1VSTCAqKV91bnJlYWNoYWJsZVVSTDsKIEBlbmQK